Commit Graph

309 Commits

Author SHA1 Message Date
Tom Schuster
b5139c60f2 Bug 1127443 - Remove JS_NewObject proto argument. 2015-01-31 16:18:51 +01:00
Nicholas Nethercote
3efc7a6cc3 Bug 1124973 (part 4) - Remove erroneous uses of PL_DHASH_ENTRY_IS_{BUSY,FREE} in nsJSNPRuntime.cpp. r=froydnj.
The BUSY check is merely useless, because BUSY is always true for a non-null
entry returned by PL_DHashTableAdd.

The FREE check is downright dangerous because it dereferences |entry| and
PL_DHashTableAdd() returns nullptr on OOM. A null check makes more sense here.
2015-01-26 14:05:06 -08:00
Nicholas Nethercote
c38455902a Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.

For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.

I'll do the trickier ones in subsequent patches.
2015-01-22 21:06:55 -08:00
Tom Schuster
01891781b2 Bug 1122619 - Remove getPropertyAttributes object ops. r=jorendorff 2015-01-24 16:38:08 +01:00
Tom Schuster
598e20943c Bug 1122552 - Introduce [[GetOwnProperty]] object op. r=jorendorff,bz 2015-01-22 17:17:26 +01:00
Nicholas Nethercote
16fcb0d8bb Bug 1123151 (part 3) - Make PLDHashTable::ops private. r=froydnj.
This required adding a getter and a setter, but they're used sparingly.
2015-01-19 16:34:44 -08:00
Nicholas Nethercote
4604f714c6 Bug 1123151 (part 2) - Add PLDHashTable::IsInitialized(). r=froydnj.
This encapsulates most of the uses of PLDHashTable::ops.
2015-01-19 16:11:34 -08:00
Nicholas Nethercote
009293c72a Bug 1123151 (part 1) - Set PLDHashTable::ops consistently. r=froydnj.
Currently the setting of PLDHashTable::ops is very haphazard.

- PLDHashTable has no constructor, so it's not auto-nulled, so lots of places
  null it themselves.

- In the fallible PLDHashTable::Init() function, if the entry storage
  allocation fails we'll be left with a table that has |ops| set -- indicating
  it's been initialized -- but has null entry storage. I'm not certain this can
  cause problems but it feels unsafe, and some (but not all) callers of Init()
  null it on failure.

- PLDHashTable does not null |ops| in Finish(), so some (but not all) callers
  do this themselves.

This patch makes things simpler.

- It adds a constructor that zeroes |ops|.

- It modifies Init() so that it only sets |ops| once success is ensured.

- It zeroes |ops| in Finish().

- Finally, it removes all the now-unnecessary |ops| nulling done by the users
  of PLDHashTable.
2015-01-19 16:01:24 -08:00
Michael Pruett
ad782194ca Bug 1121202 - Remove unused PL_DHashTableOperate function. r=njn 2015-01-15 18:01:07 -06:00
Nicholas Nethercote
eda870fe92 Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj. 2015-01-13 16:42:13 -08:00
Ms2ger
2c36b38c93 Bug 914067 - Remove JSVAL_VOID from dom/; r=jst 2015-01-14 08:59:06 +01:00
Michael Pruett
cbe37abc44 Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd 2015-01-05 20:27:28 -06:00
Aaron Klotz
06c94e3302 Bug 998863: Asynchronous Plugin Initialization, Part 1: nsJSNPRuntime changes; r=josh 2014-12-29 16:12:25 -07:00
Phil Ringnalda
4227fff1a3 Backed out 15 changesets (bug 1070755, bug 998863) for e10s bustage
CLOSED TREE

Backed out changeset 076d1d47d601 (bug 1070755)
Backed out changeset 43819af59ca5 (bug 998863)
Backed out changeset 5f587697ae63 (bug 998863)
Backed out changeset e2cf239e8572 (bug 998863)
Backed out changeset fe21b6b789ce (bug 998863)
Backed out changeset 404f59f86edc (bug 998863)
Backed out changeset 5dd57abaf2b0 (bug 998863)
Backed out changeset 6c1f006a03bc (bug 998863)
Backed out changeset 9e69875e3667 (bug 998863)
Backed out changeset c6b68f8f72ba (bug 998863)
Backed out changeset 713799a7afe4 (bug 998863)
Backed out changeset 4244d662787c (bug 998863)
Backed out changeset ba058cc7a1b2 (bug 998863)
Backed out changeset dabc69b0b09a (bug 998863)
Backed out changeset 18dad6d2e7cc (bug 998863)
2014-12-24 18:28:45 -08:00
Aaron Klotz
4e004889e7 Bug 998863: Asynchronous Plugin Initialization, Part 1: nsJSNPRuntime changes; r=josh 2014-12-24 17:55:48 -07:00
Tom Schuster
ffeb361ca3 Bug 1097267 - Use new enumerate hook for plugins. r=josh 2014-12-11 19:31:10 +01:00
Jason Orendorff
ddde8586c6 Bug 1103368, part 5 - Make Class::getProperty and setProperty nullable instead of needing stub functions. Never store stub functions in JSPropertyDescriptors. r=bhackett. 2014-11-22 12:23:39 -06:00
Jason Orendorff
6c66fe3b7e Bug 1103152 - Remove JS_DeletePropertyStub, JS_EnumerateStub, JS_ResolveStub, and JS_ConvertStub. Make five mandatory JSClass hooks optional (nullable). r=bhackett. 2014-12-02 16:56:35 -06:00
Julian Seward
a93f545433 Bug 1096054 - Uninitialised value use in Interpret(JSContext*, js::RunState&). r=jwalden. 2014-11-14 21:55:03 +01:00
Tom Schuster
c913a24c50 Bug 993026 - Rename NewResolve to Resolve in browser. r=bz 2014-11-08 01:07:12 +01:00
Tom Schuster
28c663f4ae Bug 993026 - Change resolve hook in browser/XPC. r=bholley 2014-11-08 01:07:12 +01:00
Tom Schuster
19ecd5993a Bug 1091900 - Remove iteratorObject hook. r=jorendorff
* * *
Bug 1091900 - Fix build on CLOSED TREE
2014-11-05 20:36:49 +01:00
Carsten "Tomcat" Book
6e4debec97 Backed out changeset 50b67052e480 (bug 1091900) 2014-11-06 09:11:12 +01:00
Tom Schuster
089a835ae0 Bug 1091900 - Fix build on CLOSED TREE 2014-11-05 21:19:04 +01:00
Jon Coppeard
4d760ea62c Bug 650161 - Update plugin wrapper tracing to work with compacting GC r=terrence r=johns 2014-11-05 16:37:16 +00:00
Jon Coppeard
2b4ab257cb Backed out changeset 2acbf923b6a8 (bug 650161) for causing hazards 2014-11-05 10:57:33 +00:00
Jon Coppeard
c108b054cc Bug 650161 - Update plugin tracing to work with compacting GC r=terrence r=johns 2014-11-05 08:44:27 +00:00
Bobby Holley
f204dd3faa Bug 1065811 - Expose isCallable()/isConstructor() in JS_PUBLIC_API. r=billm 2014-09-25 13:13:28 +02:00
Ehsan Akhgari
99fed18e00 Bug 1061023 - Fix more bad implicit constructors in DOM; r=baku 2014-09-01 18:26:43 -04:00
Nicholas Nethercote
c9cbbdc34d Bug 1057912 - Privatize most of PLDHashTable's fields. r=roc. 2014-08-25 16:56:33 -07:00
Bobby Holley
b2b763cb29 Bug 1052052 - Hoist Auto*JSContext into nsContentUtils and kill nsCxPusher.{cpp,h}. r=gabor 2014-08-14 18:47:15 -07:00
Ryan VanderMeulen
df43fcf12d Backed out changesets 5b1a3161f614, 17a9673ed782, and a9b8c346d295 (bug 1052052) for B2G non-unified bustage. 2014-08-14 17:23:10 -04:00
Bobby Holley
10dec58cfc Bug 1052052 - Hoist Auto*JSContext into nsContentUtils and kill nsCxPusher.{cpp,h}. r=gabor 2014-08-14 12:54:34 -07:00
Jon Coppeard
04b6fb5783 Bug 1052388 - Rename JS_CallHeapFooTracer() functions to JS_CallFooTracer() r=terrence r=smaug 2014-08-13 10:05:22 +01:00
Jason Orendorff
97a948f6eb Bug 1041261, part 2 - Changes to dom/plugins for symbol jsids. r=jst. 2014-08-06 12:33:53 -05:00
Bob Owen
4922b779dc Bug 1047509 - Part 3: Replace nsCxPusher in nsJSNPRuntime.cpp nsJSObjWrapper::NP_SetProperty. r=bholley 2014-08-08 13:22:53 +01:00
Bob Owen
f89b557cb5 Bug 1047509 - Part 2: Replace nsCxPusher in nsJSNPRuntime.cpp nsJSObjWrapper::NP_GetProperty. r=bholley 2014-08-08 13:21:07 +01:00
Bob Owen
af470fb97a Bug 1047509 - Part 1: Replace nsCxPusher in nsJSNPRuntime.cpp doInvoke. r=bholley 2014-08-08 09:01:45 +01:00
Nicholas Nethercote
663b82ea3b Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
* * *
imported patch rm-dummy-params
2014-08-06 06:31:21 -07:00
Bob Owen
9a68e64a20 Bug 1037904 Part 6: Replace nsCxPusher in nsJSObjWrapper::NP_Enumerate. r=bholley 2014-07-16 12:25:02 +01:00
Bob Owen
bd6d38f247 Bug 1037904 Part 5: Replace nsCxPusher in nsJSObjWrapper::NP_RemoveProperty. r=bholley 2014-07-16 12:24:49 +01:00
Bob Owen
c091f1ded0 Bug 1037904 Part 2: Replace nsCxPusher in nsJSObjWrapper::NP_HasProperties. r=bholley 2014-07-16 12:24:36 +01:00
Bob Owen
817e492937 Bug 1037904 Part 1: Replace nsCxPusher in nsJSObjWrapper::NP_HasMethod. r=bholley 2014-07-16 13:49:02 +01:00
Jan de Mooij
1fd3719a70 Bug 1034689 part 3 - Fix remaining places in Gecko to handle Latin1 strings. r=bz 2014-07-12 09:43:08 +02:00
Jon Coppeard
cef511feaa Bug 1013972 - Take account of reentrancy when removing entries from sJSObjWrappers r=bsmedberg 2014-05-27 10:35:13 +01:00
Jon Coppeard
d67f0ed243 Bug 959787 - Handlify remaining JS APIs r=terrence r=bz r=bholley 2014-04-30 10:10:33 +01:00
Nicholas Nethercote
121cf9ba60 Bug 952650 (part 16) - Remove JSVAL_TO_PRIVATE. r=till. 2014-04-28 16:01:31 -07:00
Nicholas Nethercote
22241fec6d Bug 952650 (part 13) - Remove JSVAL_IS_PRIMITIVE. r=till. 2014-04-27 20:27:54 -07:00
Nicholas Nethercote
2aae5772c2 Bug 952650 (part 12) - Remove JSVAL_TO_OBJECT. r=till. 2014-04-27 19:58:52 -07:00
Rodrigo Rodriguez Jr.
76724a5e28 Bug 952650 (part 11) - Remove JSVAL_TO_INT. r=njn. 2014-04-27 19:55:08 -07:00