Jonathan Kingston
9b880fdc20
Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
...
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Florian Quèze
f6add2cafd
Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop.
2018-02-28 18:51:33 +01:00
Kris Maglione
0bb74efdf1
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d
Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
...
Backed out changeset a1eca62826a1 (bug 1431533 )
Backed out changeset 34c999fa006b (bug 1431533 )
Backed out changeset e2674287e57f (bug 1431533 )
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb
Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
...
Backed out changeset 6e56f4c8843e (bug 1431533 )
Backed out changeset 12fc4dee861c (bug 1431533 )
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dan Banner
5af4450327
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Drew Willcoxon
062e2f296c
Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
...
MozReview-Commit-ID: 1wANxaD3QaV
2017-08-16 10:13:15 -07:00
Jared Wein
a080e2809f
Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
...
MozReview-Commit-ID: 5pJ96un8W5t
2017-08-08 11:56:49 -04:00
Wes Kocher
d497d08bc6
Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout
...
MozReview-Commit-ID: kEMoucDCJY
2017-08-10 15:46:38 -07:00
Jared Wein
bb3b0a581d
Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
...
MozReview-Commit-ID: 5pJ96un8W5t
2017-08-08 11:56:49 -04:00
Drew Willcoxon
1840617556
Bug 1367927 - Add a "save to pocket" item to the page action menu. r=mixedpuppy
...
MozReview-Commit-ID: APmutOUh2Q6
2017-08-01 10:17:00 -07:00
Jared Wein
098efc3f24
Bug 1383886 - Remove redundant element.closest() call since one call to closest() can do the work that was previously done by two calls to closest() and a property check. r=Gijs
...
MozReview-Commit-ID: L6weawO4qB0
2017-07-24 16:27:10 -04:00
Jared Wein
a1fe16741b
Bug 1383882 - Don't show the Pocket library animation if the Pocket page was removed. r=Gijs
...
MozReview-Commit-ID: D6xsPEUIC96
2017-07-24 16:16:56 -04:00
Jared Wein
7feb3f7139
Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
...
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.
MozReview-Commit-ID: Lq20GuocMkg
2017-07-21 18:00:01 -04:00
Wes Kocher
05e579c0fb
Backed out changeset d4b7fc921b88 (bug 1355922) for assertions in test_display_mode.html a=backout
...
MozReview-Commit-ID: GQh4DRTEUJI
2017-07-21 00:36:41 -07:00
Jared Wein
a13c276668
Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
...
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.
MozReview-Commit-ID: Lq20GuocMkg
2017-07-20 09:59:22 -04:00
Gijs Kruitbosch
1c0b6f626b
Bug 1354155 - fix pocket button's checks for whether it is the mainview in a panelmultiview, r=mikedeboer
...
MozReview-Commit-ID: 6kLNAtOmCjn
2017-05-30 16:29:45 +01:00
Jared Wein
5a181760cc
Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
...
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.
MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Zibi Braniecki
e1617486a8
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a
Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout
2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Mark Banner
358fce1e31
Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
...
MozReview-Commit-ID: FTDV8BcMGeF
2017-03-01 21:29:52 +00:00
Mark Banner
ba10e01046
Bug 1336070 - Enable eslint no-undef for browser/, apart from components/ and base/content/. r=mossop
...
MozReview-Commit-ID: CJtpm8zlLxa
2017-02-02 09:08:42 +00:00
Florian Quèze
c32c931bc9
Bug 1334831 - script-generated patch to use .remove() instead of .parentNode.removeChild, r=jaws.
2017-01-30 08:10:22 +01:00
Jared Wein
0ec522d5b6
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
242ab87626
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Gijs Kruitbosch
41dd46ed97
Bug 1320039, r=kmag,wladimir
...
MozReview-Commit-ID: Fsj4bG5e2gT
2016-11-24 11:21:05 +00:00
Jared Wein
ef8b1e86ca
Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop
2016-11-15 22:58:30 -05:00
Dave Townsend
12596ced47
Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
...
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Mark Banner
f1870b61b8
Bug 1315615 - Fix no-unused-vars issues in the Pocket extension. r=jaws
...
MozReview-Commit-ID: 4L8XCRo1PWe
2016-11-07 08:57:40 +00:00
Shane Caraveo
b2aa7c2779
Bug 1304151 add finished locales and a couple minor bug fixes, r=flod,Gijs
...
MozReview-Commit-ID: eyeDj5nxXE
2016-09-28 23:29:52 -07:00
Shane Caraveo
48d05d6f98
Bug 1304142 pocket a/b test updates, r=Gijs
...
MozReview-Commit-ID: ChBRc81QQ7Y
2016-09-20 16:06:37 -07:00
Jared Wein
4518d81cb5
Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Michael Kaply
b72a94415a
Bug 1287476 - Clear panel handlers to avoid double page. r=Gijs
2016-07-18 12:12:01 -05:00
Michael Kaply
b086b3340a
Bug 1276054 - Uplift pocket changes from partner. r=gijs
2016-07-05 09:34:30 -05:00
Ryan VanderMeulen
cfd8d773ca
Backed out changeset 0b20196061d7 (bug 1276054) for browser_UITour_pocket.js failures.
2016-06-24 15:41:09 -04:00
Michael Kaply
2502648f23
Bug 1276054 - Uplift pocket changes from partner. r=gijs
2016-06-23 10:48:39 -05:00
Dave Townsend
aebdf4481b
Bug 1245649: Turn on no-irregular-whitespace and no-mixed-spaces-and-tabs. r=jaws
2016-02-03 18:09:49 -08:00
Dave Townsend
a215a4a95a
Bug 1245649: Turn on no-extra-semi. r=markh
2016-02-03 17:27:36 -08:00
Shane Caraveo
73d9d8fb9d
Bug 1235873 fix pocket panel size when in menu panel, r=Gijs
2016-01-22 17:39:59 -08:00
Shane Caraveo
ee64a8946a
Bug 1236755 use about urls for panel iframes, r=Gijs
2016-01-12 09:27:33 -08:00
Dave Townsend
a37b82025e
Bug 1237340: Fix browser and toolkit eslint failures. r=Felipe
2016-01-06 10:10:35 -08:00
Shane Caraveo
3d87f487dc
Bug 1215694 move pocket to a system addon, r=Gijs, r=glandium
...
part 1: reorganize file locations, r=Gijs
part 2: remove built-in pocket code, r=Gijs
part 3: l10n support, r=glandium
part 4: move code/functionality from part 2 into the addon, r=Gijs
part 5: remove dead code, r=Gijs
part 6: create a simple api for addons to add to reader mode, r=Gijs
part 7: various test fixes related to cui behaviour and pocket, r=me
2015-12-29 15:40:52 -08:00