Commit Graph

662 Commits

Author SHA1 Message Date
Matthew Noorenberghe
5935ff8bf3 Bug 1432952 - Add a billing address picker to the credit card add/edit form. r=jaws
MozReview-Commit-ID: 9tquQ0C7D96
2018-04-10 18:31:05 -07:00
Matthew Noorenberghe
bab80ab776 Bug 1432952 - Use the testDialog helper in browser_editCreditCardDialog.js. r=jaws
MozReview-Commit-ID: 9tquQ0C7D93
2018-04-10 17:39:25 -07:00
Matthew Noorenberghe
6eb0502ee1 Bug 1432952 - Add a billingAddressGUID property to saved credit cards. r=jaws,kitcambridge
test_reconcile.js already provides great test coverage for a new field (like billingAddressGUID) being added either locally or remotely.

MozReview-Commit-ID: 5IGoH3zB1rz
2018-04-10 15:55:20 -07:00
Zibi Braniecki
ef4ccfd0e0 Bug 1449505 - Migrate FormAutofill to use mozIntl.getLocaleDisplayNames. r=MattN
MozReview-Commit-ID: FuQnIB2Tp5I
2018-04-01 15:18:25 +02:00
Andreea Pavel
77554651f5 Backed out 9 changesets (bug 1449505) for failing xpcshell at browser/extensions/formautofill/test/unit/test_addressRecords.js on a CLOSED TREE
Backed out changeset e96c92f80c09 (bug 1449505)
Backed out changeset 760e4d29af7e (bug 1449505)
Backed out changeset e82c5152cc17 (bug 1449505)
Backed out changeset 07143ec143ae (bug 1449505)
Backed out changeset 75a7dee8e060 (bug 1449505)
Backed out changeset a58126ed4b3f (bug 1449505)
Backed out changeset f0b4429eedff (bug 1449505)
Backed out changeset 4bf3befa991d (bug 1449505)
Backed out changeset 398d8addfbd8 (bug 1449505)
2018-04-11 10:07:42 +03:00
Phil Ringnalda
96d0e7b9fb Bug 1449505 followup, placate eslint on a CLOSED TREE 2018-04-10 23:10:46 -07:00
Zibi Braniecki
db5667f35c Bug 1449505 - Migrate FormAutofill to use mozIntl.getLocaleDisplayNames. r=MattN
MozReview-Commit-ID: FuQnIB2Tp5I
2018-04-01 15:18:25 +02:00
Matthew Noorenberghe
613b490bec Bug 1428414 - Support saving credit card changes in the Payment Request dialog. r=jaws
MozReview-Commit-ID: J2rRUy1lHiZ
2018-04-03 14:06:21 -04:00
Matthew Noorenberghe
80db3e4717 Bug 1428414 - Support re-using autofill edit forms for different records. r=jaws
MozReview-Commit-ID: LnpaX9oAo1A
2018-03-22 20:31:52 -07:00
Narcis Beleuzu
f9c4632e9b Bug 1425884 - Syntax fix for the browser_creditCard_doorhanger.js test skipping. r=jmaher 2018-03-20 19:43:00 -04:00
Kris Maglione
3e28bf5cba Bug 1446585: Remove support for resource entries in bootstrapped chrome.manifest files. r=aswan,MattN,k88hudson
MozReview-Commit-ID: EjymzU6koYX
2018-03-16 20:18:46 -07:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Matthew Noorenberghe
578163b125 Bug 1427954 - Pass FormAutofillUtils.isCCNumber to EditCreditCard. r=sfoster
The point of this is to remove dependencies on privileged code from autofillEditForms.js so it can
be used in the unprivileged PaymentRequest dialog. The PaymentRequest dialog will be able to inject
the privileged APIs in a different way.

MozReview-Commit-ID: 34PvRxzWcSr
2018-03-14 18:11:03 -07:00
Matthew Noorenberghe
1326bbbdf4 Bug 1427954 - Pass getFormFormat to EditAddress. r=sfoster
The point of this is to remove dependencies on privileged code from autofillEditForms.js so it can
be used in the unprivileged PaymentRequest dialog. The PaymentRequest dialog will be able to inject
the privileged APIs in a different way.

MozReview-Commit-ID: 6Kzq94m5hnZ
2018-03-14 18:11:22 -07:00
Matthew Noorenberghe
c4094215a1 Bug 1427954 - Pass supported and default countries to EditAutofillForm and move loadInitialValues. r=sfoster
The point of this is to remove dependencies on privileged code from autofillEditForms.js so it can
be used in the unprivileged PaymentRequest dialog. The PaymentRequest dialog will be able to inject
the privileged APIs in a different way.

MozReview-Commit-ID: 4KITOMz7Uxh
2018-03-14 18:11:36 -07:00
Matthew Noorenberghe
1597ac3676 Bug 1427954 - Move autofill edit dialog l10n to mutation observers. r=sfoster
MozReview-Commit-ID: 5jSj0xPBTQj
2018-03-14 18:12:00 -07:00
Matthew Noorenberghe
28196f5a82 Bug 1427954 - Remove string bundle references from autofillEditForms.js. r=sfoster
This is a step on the path to making it unpriveleged.

MozReview-Commit-ID: 3DSYvM2Pje9
2018-03-14 18:12:15 -07:00
Matthew Noorenberghe
79e4b011ea Bug 1427954 - Remove unused uninit code from editDialog.js and autofillEditForms.js. r=sfoster
MozReview-Commit-ID: 9GP1gsycgJo
2018-03-14 17:31:56 -07:00
Matthew Noorenberghe
447c316378 Bug 1427954 - Split autofill dialog logic from field logic. r=sfoster
We want to re-use the field/form logic but not the dialog-specific logic so this separates them out.

Custom Elements aren't enabled by default yet so we can't use them yet.

MozReview-Commit-ID: 60hMpgSOmpp
2018-03-14 18:12:38 -07:00
Matthew Noorenberghe
85cea5f35d Bug 1427954 - Don't pass child elements into the constructor. r=sfoster
MozReview-Commit-ID: 2iqHks0yD0v
2018-03-14 18:12:58 -07:00
Matthew Noorenberghe
6983623bf5 Bug 1427954 - Remove unused Services and XPCOMUtils imports in editDialog.js. r=sfoster
MozReview-Commit-ID: F4ryqNOYMn6
2018-03-14 17:06:42 -07:00
Kit Cambridge
f17824d71b Bug 1199077 - Autofill changes for async lastSync and syncID accessors. r=eoger
MozReview-Commit-ID: CgSqRevONRX
2018-03-02 14:53:23 -08:00
Arthur Iakab
de784be9f6 Bug 1425884 disabled browser_creditCard_doorhanger.js on Linux, Windows, OSX debug platforms r=jmaher 2018-03-11 22:14:00 +02:00
James Teh
df6143d305 Bug 1444283: Label the "Autofill addresses" and "autofill credit cards" check boxes for accessibility. r=MattN
MozReview-Commit-ID: EZ5ML1MQfOU
2018-03-09 13:50:01 +10:00
Daniel Marshall
7724f2e32c Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I
2018-02-10 21:23:19 +00:00
Mark Banner
29e56bce9b Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
MozReview-Commit-ID: IVMeZHGdVBk
2018-03-06 12:01:59 +00:00
Narcis Beleuzu
439cc34017 Backed out changeset a8130e46c530 (bug 1434483) for ESlint failures on browser_change_shipping.js. CLOSED TREE 2018-03-05 23:50:02 +02:00
Daniel Marshall
49ad18cee3 Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I
2018-02-10 21:23:19 +00:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
910da570a0 Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r=florian
MozReview-Commit-ID: HmliR8iNRDq
2018-02-22 16:55:36 +00:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Masayuki Nakano
efaea0aaa7 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T
2018-02-15 04:15:39 +09:00
Matthew Noorenberghe
0ace8f9ecb Bug 1438306 - Disable CA & DE country support and RTL support for Form Autofill in Beta 59+. r=Dolske
MozReview-Commit-ID: IBtrvEsIWtH
2018-02-14 13:41:27 -08:00
Masayuki Nakano
53a40055b6 Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK
2018-02-09 19:17:26 +09:00
Tom Ritter
5918a1f53d Bug 1435296 Address xpcshell test failures from increasing timer precision r=baku
See the comment on "Address test failures caused by bumping timer precision to 2 ms"
for more details.

MozReview-Commit-ID: LrsucEPdZIo
2018-02-12 11:41:38 -06:00
Tom Ritter
b414702f22 Bug 1435296 Address test failures caused by bumping timer precision to 2 ms r=baku
There are a few different reasons why tests needed updating (not an exhaustive list):

- Tests assume that successive operations take place at different times.
- Tests assume that an operation took a minimum amount of time.
- Tests hardcodes a specific delay.

In most cases we hardcode the preference off. In some cases this is the best approach,
in others, we would like to improve. The bug for tracking those improvements is Bug 1429648

An improvement that is present in some tests is to hardcode a specific precision reduction
that is acceptable based on the confides of the test. (Obviously this needs to be a fix for
the test framework and not a requirement on the feature being tested.)

In a few places, the test itself can be fixed, for example to no longer require the end
time of an operation to be strictly greater than the start time, and allows it to be equal
to it.

MozReview-Commit-ID: J59c7xQtZZJ
2018-02-12 11:39:41 -06:00
Boris Zbarsky
4fd6e65c55 Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00
Mark Banner
31b1fb7d6d Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop
MozReview-Commit-ID: 1LlfamNvBEM
2018-02-07 16:16:09 +00:00
Ian Moody
a54a2601c7 Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields. r=MattN,scottwu
The context menu shown is the standard web page one, and so inappropriate for
inside preferences.  Keep it on text fields so text editing commands are still
available, though unfortunately so are "This Frame", "Inspect Element", and
"Add a Keyword for this Search".

MozReview-Commit-ID: 7L012CZ4BhR
2018-01-21 22:50:07 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Matthew Noorenberghe
d75aa46e45 Bug 1435274 - Stop form autofilling if the master password prompt is cancelled. r=johannh
MozReview-Commit-ID: HnFbcWYX6QL
2018-02-02 21:42:31 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Edouard Oger
fda53ac528 Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc
MozReview-Commit-ID: IvwyleXBcNH
2018-01-04 18:07:10 -05:00
Noemi Erli
bd4af5546a Backed out 8 changesets (bug 633062) as requested by eoger on a CLOSED TREE
Backed out changeset 590656f7b5c5 (bug 633062)
Backed out changeset 0888aa122056 (bug 633062)
Backed out changeset 0780cf391c52 (bug 633062)
Backed out changeset 9798cbd03027 (bug 633062)
Backed out changeset 4b31c73a585f (bug 633062)
Backed out changeset 0a8866062136 (bug 633062)
Backed out changeset 20ff83289564 (bug 633062)
Backed out changeset 5e52125316e1 (bug 633062)
2018-01-31 22:09:30 +02:00
Edouard Oger
a67ec36cbd Bug 633062 p8 - Add Async observers. r=kitcambridge,markh,tcsc
MozReview-Commit-ID: IvwyleXBcNH
2018-01-04 18:07:10 -05:00
Masayuki Nakano
65ecb061b4 Bug 1134540 - Make all tests stop using nsIDOMWindowUtils.sendKeyEvent() r=smaug
nsIDOMWindowUtils.sendKeyEvent() can dispatch any keyboard events, i.e.,
may dispatch different key events from actual Gecko's behavior.  Instead,
they should use nsITextInputProcessor directly or synthesizeKey() of
EventUtils which wraps nsITextInputProcessor.

MozReview-Commit-ID: EDWqXy1OxJp
2018-01-30 22:05:44 +09:00
Sam Reading-Thompson, Robin Hodda, Joseph Fergusson
96a684c72d Bug 1429017 - Added spotlight upon clicking view in preferences in address autofill doorhanger r=MattN 2018-01-22 16:02:55 -08:00
George Dan, Ryan Neilsen, Dylan Turner
61369dbaa9 Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN 2018-01-30 14:44:59 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00