Commit Graph

40 Commits

Author SHA1 Message Date
Kris Maglione
1d4e106467 Bug 1444338: Make sure weak progress listener is not collected too early. r=mconley
MozReview-Commit-ID: GAwko5pkcc8
2018-03-09 08:44:37 -08:00
Kris Maglione
be99d41034 Bug 1443983: Part 1 - Remove shim usage in browser_google_behavior.js. r=mconley
MozReview-Commit-ID: 3pOOkRMxXsL
2018-03-08 13:37:28 -08:00
Florian Quèze
c0468168f5 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Zibi Braniecki
8c433fc56a Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
2017-03-11 18:43:11 -08:00
Sebastian Hengst
017c2ee2bf Backed out changeset 60d72c2dd49d (bug 1346616) for eslint failure in DirectoryLinksProvider.jsm. r=backout on a CLOSED TREE 2017-04-18 00:48:16 +02:00
Zibi Braniecki
64bae2dccf Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
2017-03-11 18:43:11 -08:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Mark Banner
3015c6f257 Bug 1188692 - Attempt to reduce intermittent failures in browser_ContentSearch.js by initialising listeners earlier. r=adw
MozReview-Commit-ID: 89Ew3Kr0viC
2016-12-21 11:50:25 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Gijs Kruitbosch
f073d29eb1 Bug 1314812 - followup nit: remove obsolete comments, rs=trivial,me,firebot, DONTBUILD
MozReview-Commit-ID: 8ElUTOUxEX8
2016-11-08 16:02:15 +00:00
Wes Kocher
c92af64732 Merge m-c to inbound, a=merge CLOSED TREE 2016-11-04 15:19:49 -07:00
Dave Townsend
dc3810c548 Bug 1314343: Turn on no-unreachable in eslint. r=standard8
Unreachable code can be a sign of a mistake so we should turn this rule on.

MozReview-Commit-ID: LQphsNL7HBX
2016-11-01 10:58:35 -07:00
Blake Kaplan
8ee33b31ec Bug 1314812 - Remove code that manually times out loads in favor of relying on the test harness. r=Gijs
MozReview-Commit-ID: FZB9ys9lvIN
2016-11-02 16:03:11 -07:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Drew Willcoxon
a11453a5f4 Bug 1180944 - Implement one-off searches from Awesomebar. r=mak,florian
MozReview-Commit-ID: A9YXB32L7MN
2016-08-02 18:00:26 -07:00
Florian Quèze
a3e244ebc6 Bug 1203168 - ask the user for confirmation when searching with a default search engine of unknown origin, data-review=bsmedberg, r=adw. 2016-05-27 13:41:29 +02:00
Carsten "Tomcat" Book
8905295433 Backed out changeset 08053d1e2cc1 (bug 1203168) for ESlint failure in browser_aboutSearchReset.js 2016-05-27 14:35:31 +02:00
Florian Quèze
01db1a04c5 Bug 1203168 - ask the user for confirmation when searching with a default search engine of unknown origin, data-review=bsmedberg, r=adw. 2016-05-27 13:41:29 +02:00
Neil Deakin
ce6558842f Bug 1235372, remove Promise.jsm usage from search tests, r=florian 2016-01-20 08:42:15 -05:00
Neil Deakin
bb9ce661dd Bug 1235372, re-enable browser_contextmenu.js in e10s, r=florian 2016-01-20 08:42:15 -05:00
Neil Deakin
433c637069 Bug 1235372, re-enable browser_searchbar_openpopup.js in e10s, r=florian 2016-01-20 08:42:15 -05:00
Neil Deakin
1276423eb7 Bug 1235372, re-enable browser_private_search_perwindowpb.js in e10s, r=florian 2016-01-20 08:42:15 -05:00
Ehsan Akhgari
ab5274776a Bug 1202621 - Correctly wait for both focus and the delayed startup to finish when opening a new window in private browsing tests; r=mconley 2015-10-03 11:27:07 -04:00
Florian Quèze
2074069a60 Bug 862148 - remove the DATA_* and TYPE_* constants from nsISearchEngine, r=adw. 2015-09-23 12:05:37 +02:00
Chris
ded2deea45 Bug 1121417: Change hiddenOneOffs search pref to use unichar type. r=gavin 2015-03-02 14:00:45 -08:00
Florian Quèze
64a421d5b1 Bug 1124900 - add tests for keyboard navigation in the search panel, r=Mossop. 2015-02-05 00:08:19 +01:00
Dave Townsend
a27b48b067 Bug 1103455: Change the events used to popup the search suggestions to avoid showing them when opening context menus. r=florian 2014-12-22 11:54:15 -08:00
Tim Taubert
abade39157 Bug 1077652 - Fix search tests to ignore loads from browsers without tabs r=jaws 2014-11-20 19:36:21 +01:00
Jared Wein
51c4215a6d Bug 947574 - Switch browser_426329.js to use tasks to avoid intermittent failure. r=Gijs 2014-08-20 13:22:14 -04:00
Gavin Sharp
0ccd1cc3bf Bug 896711: remove BrowserChromeTests.runWhenReady because it's being abused, r=dao/ttaubert/vporof 2013-07-27 17:32:40 -07:00
Drew Willcoxon
ae3f2923b3 Bug 975528 - Add search component tests for Bing searches. r=MattN,gavin 2014-03-12 16:56:00 -07:00
Olli Pettay
b734d7bc01 bug 789919, (snow-white) make addref/release of CCable objects faster by removing indirect refcnt increase/decrease, r=mccr8, test changes r=ehsan 2013-07-09 13:30:58 -04:00
Matthew Noorenberghe
23c6bb5231 Bug 851040 - Try to fix intermittent browser/components/search/test/browser_contextmenu.js. a=test-only 2013-03-14 23:59:06 -07:00
Matthew Noorenberghe
e9d2ffdbaf Bug 850349 - Cleanup browser search tests while debugging intermittent failure in browser_contextmenu.js. r=gavin
* browser_426329.js - Fix exception in popupshowing event listener causing search history dropdown to remain open on subsequent tests.
* browser_contextmenu.js - Add some debug messages.
                         - Move |doOnloadOnce(checkSearchURL);| just before the search tab opens so there is less interference with later tests.
                         - Add nsISelectionListener to know when selection has finished.
* head.js - Consolidate duplicated doOnloadOnce function.
* test.html - Fix character set warning.
2013-03-13 19:23:03 -07:00
Matthew Noorenberghe
ef17408128 Bug 848943 - Wait for popupshown to know when the context menu is ready. r=gavin 2013-03-12 08:38:42 -04:00
Matthew Noorenberghe
c3f63985f6 Bug 587780 - Part 5 - Test Google search params with @purpose. r=gavin 2012-05-03 23:42:29 -07:00