cookies.xul is unused and mostly unmaintained and should be removed.
Equivalent functionality in a well-maintained interface can be found
in the storage manager or the devtools storage inspector.
MozReview-Commit-ID: ILSt83hwN34
This commit adds a helper module for doing common tasks
related to site data, such as adding dummy data and getting usage.
There are many places that would potentially need to be cleaned
up to use this module instead, but I consider that work (and the
likely try failure fallout) out of scope for this bug.
MozReview-Commit-ID: 5eMDgHhClsO
Reorder the construction of Preference objects so network.proxy.autoconfig_url gets constructed before network.proxy.type, which will ensure that networkProxyAutoconfigURL is set to the value of network.proxy.autoconfig_url before network.proxy.type construction triggers the call to updateReloadButton.
MozReview-Commit-ID: BQL0RlvnCOo
We recently updated the cookie settings in about:preferences to live outside
of the history mode settings, but did not change the way that changes to history
mode (toggling the privatebrowsing.autostart pref) reflected in the cookies section.
This patch takes care of that by moving the cookie related pieces out of the code
that sets history settings and makes sure that the respective functions get called
in all appropriate cases.
I also moved some site data settings code to be closer to the cookies code.
MozReview-Commit-ID: 6ly079uDz4C
It seems `doCommand` runs through a different codepath than just clicking the checkbox,
and as a result the outcome of the command handler is different that way.
This aligns the automated test closer to what happens when you 'manually'
click the checkbox, and fixes the bug in the command handler.
MozReview-Commit-ID: ACxRUxB35px
This is a regression from bug 1429593. The code that was added to enable/disable controls on the page
depending on whether an extension is in control was being run when the page opened, which overrode
the code which disables specific controls based on the current proxy setting. All that is needed is
to call that code (which is in gConnectionsDialog.proxyTypeChanged()) if an extension is not in control
after the new code that was added. This patch fixes that issue, and includes a test verifying that
the manual controls are not enabled when the screen first opens.
MozReview-Commit-ID: 7jpp1wewZ2k
After including cookies in the site data manager in bug 1421737, we would
like to move the cookies settings to the site data section to give them
more visibility and to unify site data and cookies.
Our UR has shown that our differentiation between site data and cookies
is not helpful to users and that they struggle with discovering the
cookie settings that are hidden in the "custom history" menu.
Since the cookie settings are quite powerful/potentially breaking,
we changed the top level preference from a checkbox to a radiogroup,
to be able to highlight the potential breakage associated with "deny".
This grouping is also recommended by the webstorage spec:
https://www.w3.org/TR/webstorage/#privacy
The cookies dialog is not removed yet, because it is still accessible from
Page Info, but bug 1348223 will likely remove it entirely.
MozReview-Commit-ID: Adisn70Ks2Q
