Commit Graph

797 Commits

Author SHA1 Message Date
Jim Porter
8c24212591 Bug 1346671 - Enable the no-useless-concat eslint rule in toolkit/ r=jaws
MozReview-Commit-ID: 1a422BiLEhK
2017-03-13 17:34:24 -05:00
Gijs Kruitbosch
da2191fab2 Bug 1344759 - batch-insert bookmarks when importing from Edge, IE, Safari or Chrome, r=dao
MozReview-Commit-ID: Dhvw0Y0fm5x
2017-03-13 23:46:16 +00:00
Gijs Kruitbosch
2ca6d5b660 Bug 1344759 - add a unit test for Chrome bookmark imports, r=dao
MozReview-Commit-ID: 8w1GnbDmOc5
2017-03-13 23:25:46 +00:00
Gijs Kruitbosch
1c923f4717 Bug 1344644 - stop supporting outdated Edge bookmarks format to avoid hangs trying to open bookmarks database when Edge is open, r=dao
MozReview-Commit-ID: 2KihobvE8nV
2017-03-07 14:09:34 +00:00
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Gijs Kruitbosch
d9c7b8ddde Bug 1341097 - part 4: misc. small optimizations, r=mak
The MigrationUtils change is because 99% of the time we will only have
1 visit per URI, and so we spend silly amounts of time doing nothing.
Time spent in composing our undo structure went from ~800ms to ~550ms
with this change.

The other change just seemed obvious - when visits aren't recent,
we shouldn't add them to 'recently visited' lists, which seem to use
'time this function was called' as the time associated with an entry,
which is incorrect.

MozReview-Commit-ID: 2I0D5ApOCI7
2017-02-20 16:06:27 +00:00
Gijs Kruitbosch
e1717a1338 Bug 1341097 - part 2: allow turning off notifications for individual inserted results when calling updatePlaces, r=mak
This sets a property on the callback object rather than passing an argument
to handleCompletion, to avoid accidentally breaking consumers who don't
expect arguments. The downside is that this required more changes to C++
consumers, but we control all of those so that seemed an acceptable
trade-off.

We should probably actually report errors for all the migrators, but I didn't
want to add risk (what if in some edge-case there are lots?) so I didn't. I'll
file a followup to update them to Cu.reportError() any errors.

MozReview-Commit-ID: Hue9Ci3hyVz
2017-02-21 14:20:21 +00:00
Gijs Kruitbosch
705481de09 Bug 1341097 - part 1: group frecency notifications from history notifications, r=mak
When updating a large number of places, sending runnables to the main thread
for every single one of them whose frecency we update is not conducive to a
responsive UI. This only gets worse once more observers care about these
notifications (e.g. when the library is open).

To avoid this on startup when importing from other browsers, this patch adds
and uses an option to group the frecency notifications. Later patches will
also use the option to avoid other notifications where possible.

MozReview-Commit-ID: D5KqPDu86bo
2017-02-21 20:00:24 +00:00
Masatoshi Kimura
4f2e64ad3d Bug 1342144 - Remove version parameter from the type attribute of script elements. r=jmaher
This patch is generated by the following sed script:
find . ! -wholename '*/.hg*' -type f \( -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \) -exec sed -i -e 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;

MozReview-Commit-ID: AzhtdwJwVNg
2017-02-23 06:10:07 +09:00
Carsten "Tomcat" Book
9fbc541997 merge mozilla-inbound to mozilla-central a=merge 2017-02-20 14:05:25 +01:00
Jessica Jong
afd549bc70 Bug 1338911 - Ensure page is loaded before proceeding in test_refresh_firefox.py. r=Gijs 2017-02-19 19:18:00 -05:00
Dão Gottwald
112e3a6175 Bug 1338522 - Add telemetry for UI responsiveness during import of profile data from another browser. r=francois,Gijs
MozReview-Commit-ID: Cmh0rhZEPDo
2017-02-18 00:01:50 +01:00
Dão Gottwald
e2442d9cea Bug 1339413 - Implement prefs for capping the amount of history we import from Chrome. r=Gijs
MozReview-Commit-ID: BdlNxS76Ko9
2017-02-15 18:42:15 +01:00
Gregory Moore
4248c7de55 Bug 883627 - Updated CreateResetProfile() to use the existing profile name for the newly created profile, r=gijs
MozReview-Commit-ID: Gkul477NIDG
2017-02-09 15:29:58 -08:00
Dão Gottwald
f0d1f68adc Bug 1338812 - Call TelemetryStopwatch only once per item (history / bookmarks / logins) rather than for each resource. r=Gijs
MozReview-Commit-ID: 7c5DgKDIFTv
2017-02-11 21:14:52 +01:00
Gijs Kruitbosch
6fd139c0ac Bug 1335442 - update wording of automigration notification bar and add tests, r=jaws
MozReview-Commit-ID: EkuOQmRjqOF
2017-02-03 14:04:40 +00:00
Gijs Kruitbosch
d8ac970efb Bug 1335442 - deal correctly with not importing anything, r=jaws
MozReview-Commit-ID: 3WZCxXV48Ms
2017-02-03 14:04:23 +00:00
Andrea Marchesini
964dd600c8 Bug 1335536 - File.createFromNsIFile and File.createFromFileName should be async - part 1 - tests, r=smaug 2017-02-08 10:18:32 +01:00
Marco Bonardo
ffd0d0c669 Bug 1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays. r=Gijs
Currently an Array is bound as a blob. Unfortunately this occupies the best javascript
code path to bind an array to an IN clause in the future.
We would like Arrays to bind to IN lists, while still keeping a nice interface to bind blobs.
This patch makes Uint8Array bind to blob, while Array is left available for future use.

MozReview-Commit-ID: 7xzumBs8JTe
2017-02-06 19:30:19 +01:00
Gijs Kruitbosch
a89bdb9b5d Bug 1335349 - add survey link option to 'undo' for automigration, r=Dolske
MozReview-Commit-ID: BGsxAdsTu7X
2017-01-31 12:32:27 +01:00
Gijs Kruitbosch
5f65f1cb7e Bug 1333734 - fix chrome password import if it contains items we can't read as a URI, r=mak
MozReview-Commit-ID: CAwIVNz70hs
2017-01-30 10:51:21 +01:00
Gijs Kruitbosch
a09465abe7 Bug 1333233 - part 2: add telemetry for the time it takes to do individual undo operations, r=bsmedberg,Dolske
MozReview-Commit-ID: Lf7roH3EswB
2017-01-26 17:00:00 +00:00
Gijs Kruitbosch
72cc1c8b09 Bug 1333233 - part 1: add telemetry for error counts from undo operations, r=bsmedberg,Dolske
MozReview-Commit-ID: EdelbiibVWi
2017-01-26 15:54:41 +00:00
Gijs Kruitbosch
9b0008fae2 Bug 1333484 - make Firefox refresh marionette test not rely on previous tests, r=mikedeboer
MozReview-Commit-ID: APQf2XMG8JV
2017-01-24 18:29:46 +00:00
George Veneel Dogga
34e3070268 Bug 887876 - Use Sqlite.jsm in browser/components/migration. r=mak 2017-01-20 04:35:00 -05:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Gijs Kruitbosch
bb9d4d9bcc Bug 1331800 - catch errors from history removals and don't block undo on them, r=Dolske
MozReview-Commit-ID: JhWAs6rvBnW
2017-01-18 18:07:47 +00:00
Gijs Kruitbosch
e413139a90 Bug 1331888 - immediately remove (and don't reshow) notification bars once user chooses to undo, r=dao
The automated test verifies that we remove the notification bars immediately.
Unfortunately, I couldn't think of a way to verify we won't allow reshowing the notification bar while an undo is ongoing,
because for that to happen I'd need to get one to show while an undo is ongoing, which isn't reliably possible in an
automated test.

MozReview-Commit-ID: EYHNIPEaOOo
2017-01-18 11:07:47 +00:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Gijs Kruitbosch
45937d187a Bug 1330384 - force a refresh of the new tab page after automigration undo, r=jaws
MozReview-Commit-ID: KoqbAgPkcLC
2017-01-12 16:00:27 +00:00
Mark Banner
ac52569fff Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6
2017-01-09 10:12:26 +00:00
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
7c1615ceba Bug 1329014 - Enable the no-extra-bind rule and use eslint --fix to autofix the errors. r=standard8
MozReview-Commit-ID: BwK94W2mHXS
2017-01-05 16:43:29 -05:00
Gijs Kruitbosch
7d09e4d45e Bug 1322730 - display undo migration message on about:newtab, r=Dolske
MozReview-Commit-ID: 8nIGdD9XyFH
2017-01-04 19:05:50 +00:00
Sebastian Hengst
6d6d937b45 Backed out changeset 9647d2c82af4 (bug 1322730) for eslint failures. r=backout 2017-01-04 20:05:06 +01:00
Gijs Kruitbosch
7fba8ab892 Bug 1322730 - display undo migration message on about:newtab, r=Dolske
MozReview-Commit-ID: 8nIGdD9XyFH
2016-12-15 16:54:36 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
21fc75d491 Bug 1326479 - Fix 'indent' eslint errors now that eslint scans multiline array and object definitions. r=Gijs
MozReview-Commit-ID: 99mWjxu8PPn
2017-01-03 10:07:50 -05:00
Jared Wein
e10047cd07 Bug 1326479 - Enable more options for the 'indent' rule. r=Gijs
MozReview-Commit-ID: EuxayyLNHNt
2016-12-30 18:32:56 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Aman Dwivedi
aec48bf322 Bug 1323685 - Remove workarounds for bug 449811. r=mak 2016-12-22 16:33:28 +05:30
Gijs Kruitbosch
898e262c96 Bug 1285577 - part 4: save, use and delete implementations for import undo state, r=mak
MozReview-Commit-ID: FVy2MMpvV65
2016-12-20 22:49:05 +00:00
Gijs Kruitbosch
a9c9eea221 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak
MozReview-Commit-ID: 7HCA7cKhws4
2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
7c7e220663 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN
MozReview-Commit-ID: JZbOkmZ7ZZG
2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
e6f654cf66 Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak
MozReview-Commit-ID: 8pKlBmDVX5X
2016-11-30 11:48:03 +00:00
Gijs Kruitbosch
e5b59d7fbd Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne
2016-11-30 11:03:21 +00:00
Sebastian Hengst
e906b9416f Backed out changeset 61029bd1995a (bug 1285577) for failing test_autofill_https_upgrade.html at least on Linux. r=backout 2016-12-20 22:56:02 +01:00
Sebastian Hengst
13307cb1ae Backed out changeset 12aa73f4a982 (bug 1285577) 2016-12-20 22:54:35 +01:00