The implementations of browserAction, pageAction, and menu onClick
handlers now stash the current <browser> until we get a reply from
the extension process indicating that the handler has finished running.
We also have to take care to keep that <browser> around even if the
permissions api has to be loaded asynchronously.
MozReview-Commit-ID: BYJaiwdj40u
The implementations of browserAction, pageAction, and menu onClick
handlers now stash the current <browser> until we get a reply from
the extension process indicating that the handler has finished running.
We also have to take care to keep that <browser> around even if the
permissions api has to be loaded asynchronously.
MozReview-Commit-ID: BYJaiwdj40u
We intermittently receive an extra onFocusChanged event with a windowId of browser.windows.WINDOW_ID_NONE
when a window is closed. The test has been updated to ignore one of these events.
MozReview-Commit-ID: 8O1YvoKBvkH
When debugging the test failures in this test, I noticed that the info() messages indicated we *were* using
moz-extension icon references even when we shouldn't be - they just didn't include the 'fox.svg' bit.
When pausing in the debugger, you can see that all the buttons are blank - we don't load any icon in this case.
This seemed bad, so I updated the test to actually check if we're using a moz-extension URI at all,
and then updated the implementation to actually make it work.
MozReview-Commit-ID: GGXaivJrzxj
Add histogram for WEBEXT_BROWSERACTION_POPUP_OPEN_MS to track the amount of time it takes to open a browserAction popup.
Add histogram for WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT to track how often a popup preload results in a popup being shown, vs a popup being cancelled, both after hover and after mousedown.
MozReview-Commit-ID: L8xlSJxgTzX
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.
MozReview-Commit-ID: 45aYzVHwRYv
The browser-chrome test suite now detects and reports unhandled rejections of native Promises, in addition to those created by Promise.jsm. The whitelisting mechanism is updated to use primarily the PromiseTestUtils.expectUncaughtRejection function. Tests will fail if a rejection that is not whitelisted occurs, or if a whitelisted rejection does not occur anymore.
MozReview-Commit-ID: 1beGB5GG8Ty
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.
MozReview-Commit-ID: 45aYzVHwRYv
Use DevToolsShim to access devtools APIs from webextensions code.
For webextensions tests using DevTools, tests are accessing DevToolsShim.gDevTools
which is fine for test purposes.
MozReview-Commit-ID: 66gFV98xvpf
This is the second step to migrating the policy service to pure native code,
with similar impacts and reasoning to the previous patch.
MozReview-Commit-ID: L5XdPzWNZXM
