Commit Graph

1787 Commits

Author SHA1 Message Date
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Paolo Amadini
228a7145fc Bug 1424264 - Part 3 - Use the minimum height from the older transitioning view. r=Gijs
This also fixes the clean up of the width and height properties of the viewContainer.

MozReview-Commit-ID: 28XQlUoLLCr
2018-01-26 14:20:10 +00:00
Paolo Amadini
178efe65fc Bug 1424264 - Part 2 - Move state related to view sizing to the PanelView class. r=Gijs
MozReview-Commit-ID: IsywTHd3qVV
2018-01-26 14:19:53 +00:00
Paolo Amadini
4ed7980f43 Bug 1424264 - Part 1 - Always update min-width and max-width before showing views. r=Gijs
This also removes some unneeded checks for variables that are now never false.

MozReview-Commit-ID: KVVwARLrpYO
2018-01-26 14:05:11 +00:00
Paolo Amadini
7281a38d7e Bug 1432016 - Part 4 - Move keyboard navigation to the PanelView class. r=Gijs
This allows removing the separate keyboard navigation map.

MozReview-Commit-ID: 2N0wflAvg7Y
2018-01-22 14:42:24 +00:00
Paolo Amadini
1958720fa5 Bug 1432016 - Part 3 - Use the PanelView class for knownViews and openViews. r=Gijs
MozReview-Commit-ID: CQ0Ao3FlRRc
2018-01-22 13:06:55 +00:00
Paolo Amadini
2f84510771 Bug 1432016 - Part 2 - Move descriptionHeightWorkaround and some other methods to the PanelView class. r=Gijs
MozReview-Commit-ID: 59fUuB35Ygy
2018-01-25 15:35:45 +00:00
Paolo Amadini
82768948ee Bug 1432016 - Part 1 - Add a PanelView class using a base class shared with PanelMultiView. r=Gijs
Only one method is moved to the PanelView class to simplify the keyboard navigation test.

MozReview-Commit-ID: CHB5FiT9ptn
2018-01-22 12:46:48 +00:00
Paolo Amadini
3970ea11c7 Bug 1432015 - Part 5 - Remove unused code. r=Gijs
MozReview-Commit-ID: IoURPSdQAiR
2018-01-21 11:37:50 +00:00
Paolo Amadini
42fddc9dc0 Bug 1432015 - Part 4 - Separate the set of known views from the stack of open views. r=Gijs
This makes the code easier to follow and facilitates future refactoring, for example the set of known views can be removed entirely by making the clean up and navigation code use the stack of open views.

The SlidingPanelView class can thus be removed, saving various lines of code. The class implemented a small optimization for garbage collection, that was already less effective because various other objects are created during each view transition anyways.

MozReview-Commit-ID: Z4JJMklUMf
2018-01-21 17:27:11 +00:00
Paolo Amadini
f6b0b3a5cf Bug 1432015 - Part 3 - Ensure that views passed to showSubView are added to the list of known views without having to reset the internal _panelViews variable. r=Gijs
MozReview-Commit-ID: Hld45ghdduv
2018-01-17 15:04:18 +00:00
Paolo Amadini
01051cc093 Bug 1432015 - Part 2 - Remove the setMainView methods. r=Gijs
The setMainView method of PanelMultiView controls the "mainview" attribute, which is already set or removed later in the showSubView method. When called at construction time, it changes the mainViewId if there is at least one child in the "panelmultiview" element and the original mainViewId does not already reference the first child. This would be incorrect, but in practice it never happens for either ephemeral or static panels, and can be avoided for the throw-away activated page action panel.

The setMainView method of PanelUI is never called, and this makes the corresponding PanelMultiView method removable.

MozReview-Commit-ID: 5bNidHfKFTA
2018-01-21 15:59:41 +00:00
Kris Maglione
1046270983 Backed out 3 changesets (bug 1431533) for Android mochitest bustage. CLOSED TREE
MozReview-Commit-ID: 5ubE9EMQpZ9
2018-01-24 22:04:59 -08:00
Kris Maglione
50ace7f99d Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
MozReview-Commit-ID: 8V1ZT53ReiP
2018-01-24 15:48:47 -08:00
Dão Gottwald
310b23880b Bug 1430747 - Stop setting unused customization-lwtheme attribute and --toolbox-rect-height, --toolbox-rect-height-with-unit CSS variables. r=mikedeboer
MozReview-Commit-ID: HpdE3I7ZeDY
2018-01-16 12:38:41 +01:00
Csoregi Natalia
338b1e39fe Merge inbound to mozilla-central r=merge a=merge 2018-01-12 23:59:06 +02:00
Gijs Kruitbosch
494c89092f Bug 1426250 - make tests actually pass valid mouse coordinates when testing Customize Mode, r=jaws
MozReview-Commit-ID: IglKedBqrWQ
2018-01-05 21:35:27 +00:00
Gijs Kruitbosch
c48f97be11 Bug 1426250 - allow changing log preference at runtime for CUI.jsm, r=jaws
MozReview-Commit-ID: 9kYBC27wowg
2018-01-05 21:31:53 +00:00
Tim Nguyen
e0347f3526 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs
MozReview-Commit-ID: 1ppfxI7yYJW
2018-01-11 16:35:17 +00:00
Dão Gottwald
9f79dc1a2c Bug 1430128 - Remove remnants of the iconsize attribute. r=Gijs
MozReview-Commit-ID: 3a80XcR3NUM
2018-01-12 16:03:44 +01:00
Tim Nguyen
a9632f876e Bug 1430009 - Remove reference to externalToolbars in customizableui toolbar.xml binding. r=Gijs
MozReview-Commit-ID: CMKNn7jdcVq
2018-01-12 08:56:31 +00:00
Paolo Amadini
f708b42b64 Bug 1425736 - Don't show the attention badge for download failures on the application menu button. r=Gijs
MozReview-Commit-ID: A882hXl5o0
2018-01-09 15:51:19 +00:00
Dorel Luca
e197266a19 Backed out 11 changesets (bug 1252998) for faling browser-chrome on browser/base/content/test/sanitize/browser_sanitize-offlineData.js
Backed out changeset a9ec63c01c50 (bug 1252998)
Backed out changeset a3e5299b882a (bug 1252998)
Backed out changeset aa511b206e21 (bug 1252998)
Backed out changeset 5875848a48ab (bug 1252998)
Backed out changeset 7fd2523680d1 (bug 1252998)
Backed out changeset a45e28e573a4 (bug 1252998)
Backed out changeset 92e8cc81b417 (bug 1252998)
Backed out changeset da38d133549e (bug 1252998)
Backed out changeset 5be23a98b47c (bug 1252998)
Backed out changeset 609093736110 (bug 1252998)
Backed out changeset f4955cf6447f (bug 1252998)
2018-01-08 11:00:39 +02:00
Andrea Marchesini
63c92e2751 Bug 1252998 - StorageActivityService - part 5 - nsIStorageActivityService::getActiveOrigins, r=asuth 2018-01-08 08:31:38 +01:00
Edouard Oger
d1f9d25af4 Bug 1426444 - Make Synced Tabs unverified state consistent. r=markh
MozReview-Commit-ID: D62SqelGXw2
2017-12-20 14:52:33 -05:00
Ian Moody
b2249f925b Bug 1425972 - Add a test for subview navigation on space keydown. r=Gijs
MozReview-Commit-ID: Hb5WlqOtibS
2017-12-20 16:48:19 +00:00
Ian Moody
bc029b73c8 Bug 1425972 - Add a test for interleaved arrow and tab navigation in the browser panel. r=Gijs
MozReview-Commit-ID: DBIop59CWCG
2017-12-20 02:19:35 +00:00
Ian Moody
cb2a7eebf6 Bug 1425972 - Add a test for tab navigation in the browser panel. r=Gijs
MozReview-Commit-ID: L3C65YgRYd5
2017-12-20 00:18:19 +00:00
Ian Moody
db7adf1a0b Bug 1425972 - Manually handle Tab navigation in PanelMultiView so it syncs with Arrow navigation. r=Gijs
MozReview-Commit-ID: 5PjXFZBeWzM
2017-12-19 19:37:34 +00:00
Florian Quèze
bda5a0bd38 Bug 1394914 - toolbars no longer need to wait for xul overlays to load before initializing CustomizableUI icons (avoid sidebar icon flickering), r=Gijs. 2017-12-19 23:40:40 +01:00
Margareta Eliza Balazs
b7c990be5d Backed out changeset 7c96cab6821a (bug 1394914) for failing bc in browser/base/content/test/performance/browser_windowopen_reflows.js r=backout a=backout on a CLOSED TREE 2017-12-20 14:32:53 +02:00
Margareta Eliza Balazs
5a94a14ee9 Merge inbound to mozilla-central r=merge a=merge 2017-12-20 11:47:11 +02:00
Florian Quèze
f1150a28b1 Bug 1394914 - toolbars no longer need to wait for xul overlays to load before initializing CustomizableUI icons (avoid sidebar icon flickering), r=Gijs. 2017-12-19 23:40:40 +01:00
Gijs Kruitbosch
447d01f074 Bug 1424452 - stop having 2 different values for the 'panel' area type, r=jaws
MozReview-Commit-ID: 3spDhRhlOTF
2017-12-09 12:37:20 +00:00
Tooru Fujisawa
151e2af9f6 Bug 1424877 - Wait for the next event tick in promisePanelElementHidden in browser/components/customizableui/test/head.js. r=Gijs 2017-12-14 14:49:32 -06:00
Tooru Fujisawa
6b750d7fec Bug 1424083 - Wait for the mouseover event instead of attribute in browser_customizemode_uidensity.js r=Paolo 2017-12-09 06:08:44 +09:00
Tooru Fujisawa
4b70335909 Bug 1416446 - Part 0.2: Fix browser_981418-widget-onbeforecreated-handler.js to wait for events in correct order and timing. r=Paolo 2017-12-09 06:08:43 +09:00
Dorel Luca
8bde17d8fe Backed out changeset 8ad560283f5e (bug 1416446) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 2017-12-09 18:59:48 +02:00
Dorel Luca
f017c5ef0e Backed out changeset 56343b0de5c2 (bug 1424083) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 2017-12-09 18:58:40 +02:00
Tooru Fujisawa
0796fcbdfd Bug 1424083 - Wait for the mouseover event instead of attribute in browser_customizemode_uidensity.js r=Paolo 2017-12-09 06:08:44 +09:00
Tooru Fujisawa
91166ab47b Bug 1416446 - Part 0.2: Fix browser_981418-widget-onbeforecreated-handler.js to wait for events in correct order and timing. r=Paolo 2017-12-09 06:08:43 +09:00
Cosmin Sabou
e988ee0d5d Merge mozilla-inbound to mozilla-central r=merge a=merge 2017-12-08 11:56:44 +02:00
Bill McCloskey
142c9a9dbb Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
shindli
9c6ef418d6 Merge mozilla-central to autoland. r=merge a=merge CLOSED TREE 2017-12-08 00:24:48 +02:00
Paolo Amadini
13d678e2e6 Bug 1423891 - Panel header is gone when going back from Bookmarks to Library. r=Gijs
MozReview-Commit-ID: Bfgg61BH9L8
2017-12-07 15:32:40 +00:00
Neil Deakin
c6f8af3264 Bug 1419925, implement a promise-oriented version of waitForClipboard, promiseClipboardChange, change a selection of tests to use this instead. Simplify some other clipboard tests that were unreliable before the fix for 1394757. r=jmaher 2017-12-07 08:39:50 -05:00
Gijs Kruitbosch
94d5dc912b Bug 1415056 - reverse direction of horizontal shift in RTL when shifting palette items in customize mode, r=jaws
This also fixes the vertical offset because we take the correct branch in the yDiff if block lower down.

MozReview-Commit-ID: KbHkRx1575X
2017-12-04 12:31:39 +00:00
Gijs Kruitbosch
53164a15e5 Bug 1415056 - re-enable animations in the palette in customize mode, r=jaws
MozReview-Commit-ID: DXYBPCdXMBG
2017-12-04 12:15:10 +00:00