Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198826
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198825
This introduces `mainview-with-header` attribute for panels that their
mainview should have a header (no matter where they appear); and
`has-custom-header` for panels that their panelview (not necessarily a
mainview) has a custom design for a header, one that headerText setter
can't anticipate in advance (due to UX needs that may arise).
If one of these attributes are set on the panel, this signals headerText
that the panelview's header should NOT be removed and that the markup
should be respected.
Differential Revision: https://phabricator.services.mozilla.com/D196671
Since the crash in the bug 1868456 was fixed, we could re-enable these 3 test files that were previously crashing on trunk while a11y-checks were running, thus we are removing the `skip-if` notations from their test manifests.
Depends on D195646
Differential Revision: https://phabricator.services.mozilla.com/D195647
On Linux it doesn't look as bad without this, but on macOS it's very
noticeable.
This ensures that items are properly centered.
The flex display / alignment of the link isn't needed (it only has text
anyways).
Differential Revision: https://phabricator.services.mozilla.com/D193784
The `<panelview>` data-l10n-id is often set immediately before rendering the subview. If the subview has previously been rendered, its title may be obsolete, and so the value needs to be checked directly -- the later l10n DOM update won't be caught by the panelview, and in any case we want the header to be set correctly before we show it.
Differential Revision: https://phabricator.services.mozilla.com/D190920
The test is sending a click to a button on a doorhander that is normally accessible, but the a11y-checks are consistenly failing the test, because in some cases the event is sent while the panel is still `showing`. We need to wait for the panel to change it's status to `open` and to observe the `popup-shown` event to ensure the test is continued as it was expected to.
Differential Revision: https://phabricator.services.mozilla.com/D193115
There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.
Related bugs:
- Fail-if tests: meta bug 1848402
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D192086
There are 2 failing tests for the `PanelMultiView`s that appear to create mock toolbarbutton and panel for the purposes of testing PanelMultiView, but the anchor (`gAnchor`) or a toggle (`gToggle`) do not have an a11y label (because they were not really intended to be seen by a user).
We are adding a test label for each of them to keep the a11y_checks test harness happy and removing the `fail-if` annotations from the test manifest that was added by bug 1854536 before the investigation in the meta bug 1854537.
Differential Revision: https://phabricator.services.mozilla.com/D192289
The `<panelview>` data-l10n-id is often set immediately before rendering the subview. If the subview has previously been rendered, its title may be obsolete, and so the value needs to be checked directly -- the later l10n DOM update won't be caught by the panelview, and in any case we want the header to be set correctly before we show it.
Differential Revision: https://phabricator.services.mozilla.com/D190920
By requesting two animation frames, the test consistently covers the
case where missing Fluent strings can appear in Firefox View when
the customize mode UI is active.
Differential Revision: https://phabricator.services.mozilla.com/D190732
By requesting two animation frames, the test consistently covers the
case where missing Fluent strings can appear in Firefox View when
the customize mode UI is active.
Differential Revision: https://phabricator.services.mozilla.com/D190732
By requesting two animation frames, the test consistently covers the
case where missing Fluent strings can appear in Firefox View when
the customize mode UI is active.
Differential Revision: https://phabricator.services.mozilla.com/D190732
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.
This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific meta bug 1854537
- Explore capturing click events for a11y_checks: bug 1692110
Depends on D189410
Differential Revision: https://phabricator.services.mozilla.com/D188926
Drag/drop generates click events, but these aren't actually a click event intended to activate a control.
Therefore, we don't want to run accessibility checks for the target.
To achieve this, EventUtils.synthesizeDropAfterDragOver instructs AccessibilityUtils to ignore click events while the event is being sent.
This requires that EventUtils has the reference to AccessibilityUtils set by the browser test harness.
As such, some tests had to be adjusted so that they use EventUtils from the browser test scope, rather than loading their own copy of EventUtils.
Depends on D190004
Differential Revision: https://phabricator.services.mozilla.com/D185776
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific meta bug 1854537
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D188926
Drag/drop generates click events, but these aren't actually a click event intended to activate a control.
Therefore, we don't want to run accessibility checks for the target.
To achieve this, EventUtils.synthesizeDropAfterDragOver instructs AccessibilityUtils to ignore click events while the event is being sent.
This requires that EventUtils has the reference to AccessibilityUtils set by the browser test harness.
As such, some tests had to be adjusted so that they use EventUtils from the browser test scope, rather than loading their own copy of EventUtils.
Differential Revision: https://phabricator.services.mozilla.com/D185776
