corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
860,944 Commits 1 Branch 0 Tags
fe7d3691c44bf51af967eaae330a0bbf156cd541
Commit Graph

90 Commits

Author SHA1 Message Date
Mark Banner
f65518c3c0 Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak 
Differential Revision: https://phabricator.services.mozilla.com/D203026
 2024-03-13 14:51:06 +00:00
Mark Banner
12acbf468b Bug 1884181 - Introduce a DefaultEngineDropDown class for search preferences and have EngineStore notify it and EngineView appropriately. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204024
 2024-03-12 13:38:15 +00:00
Mark Banner
2fe70e7c07 Bug 1884181 - Make EngineStore._engines a public property, remove the setter/getter. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204023
 2024-03-12 13:38:14 +00:00
Mark Banner
29f80a5587 Bug 1884181 - Move EngineStore/EngineView functions out of gSearchPane and into the relevant class. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D204022
 2024-03-12 13:38:14 +00:00
Mark Banner
7bc3786c4f Bug 1884181 - Rename EngineStore._defaultEngines for better clarity. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204021
 2024-03-12 13:38:14 +00:00
Mark Banner
4960f5682d Bug 1884181 - Avoid calling buildDefaultEngineDropDowns twice when opening preferences. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204020
 2024-03-12 13:38:13 +00:00
Mark Banner
3707c6f50d Bug 1884181 - Change search preferences EngineStore and EngineView to be classes. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204019
 2024-03-12 13:38:13 +00:00
Dale Harvey
8b8718db79 Bug 1883776 - Remove hardcoded detection of trending engines. r=Standard8,settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D203896
 2024-03-07 21:58:01 +00:00
Dave Townsend
b7532be063 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 18:28:32 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE 
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
 2024-03-01 18:25:05 +02:00
Dave Townsend
b6eba7ca5c Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 15:20:18 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE 
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
 2024-03-01 12:58:03 +02:00
Dave Townsend
2a38962b3a Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202952
 2024-03-01 10:10:09 +00:00
Dale Harvey
27c8990068 Bug 1878279 - Have preferences recognise Bing as engine that supports trending. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D200509
 2024-02-06 20:57:33 +00:00
Karandeep
f11961815d Bug 1852048 - Move address bar to search preferences. r=dao,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D194895
 2024-01-04 09:11:22 +00:00
Karandeep
4d994d852f Bug 1868756 - For users with the search bar disabled, "Show search suggestions" should be unchecked when either browser.search.suggest.enabled or browser.urlbar.suggest.searches are false. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D195889
 2023-12-27 17:51:38 +00:00
Mark Banner
0d18781645 Bug 1870644 - Remove nsISearchEngine.iconURI and replace by the new getIconURL function. r=search-reviewers,extension-reviewers,settings-reviewers,mconley,mcheang,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D196734
 2023-12-20 13:28:24 +00:00
Mark Banner
6288c316b3 Bug 1869613 - Remove unused function EngineStore.reloadIcons. r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D196226
 2023-12-12 21:54:42 +00:00
Karandeep
d41e533454 Bug 1852045 - Hide the "Show search suggestions in address bar results" checkbox when the search bar isn't in the toolbar. r=dao,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D192571
 2023-12-05 11:04:39 +00:00
Cristian Tuns
ffdaa2ecdb Backed out changeset 25b74ab09261 (bug 1852045) for causing bc failures in browser_searchShowSuggestionsFirst.js CLOSED TREE 2023-11-29 12:15:07 -05:00
Karandeep
a7df4578f7 Bug 1852045 - Hide the "Show search suggestions in address bar results" checkbox when the search bar isn't in the toolbar r=dao,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D192571
 2023-11-29 15:53:48 +00:00
Karandeep
e2ba36560e Bug 1852042 - Move checkbox from search bar section to the default search engine section in search pref page. r=dao,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D191978
 2023-11-01 11:21:14 +00:00
Dale Harvey
9aed4a17ff Bug 1852848 - Implement recent searches provider. r=mak,fluent-reviewers,flod,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189104
 2023-10-11 00:06:32 +00:00
Dale Harvey
aea5f8d8f6 Bug 1851449 - Ensure trending checkbox is disabled correctly. r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D187488
 2023-09-06 19:19:20 +00:00
Dale Harvey
95ab1ce9c9 Bug 1848048 - Add a result menu to disable trending results. r=dao,fluent-reviewers,settings-reviewers,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D187066
 2023-09-01 08:38:54 +00:00
Mark Banner
a858a2d3b0 Bug 1847246 - Remove remaining parts of browser.search.hiddenOneOffs preference. r=search-reviewers,settings-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D185444
 2023-08-05 09:21:56 +00:00
Karandeep
d759f51203 Bug 1643887 - Move handling of search engine one-off hidden from preferences into the search settings. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D180229
 2023-06-12 18:03:52 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Emilio Cobos Álvarez
08bd936126 Bug 1824957 - Null-check tree selection in preferences search. r=Gijs 
The selection getter is nullable. Not having this check causes
browser_experimental_features_filter.js to fail due to the thrown
exception.

Differential Revision: https://phabricator.services.mozilla.com/D173847
 2023-03-28 14:46:52 +00:00
Barret Rennie
0604905647 Bug 1818738 - Make the feature update event API more ergonomic r=aminomancer,settings-reviewers,search-reviewers,Gijs,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D172035
 2023-03-16 22:20:14 +00:00
Mark Banner
4cff9fea92 Bug 1816939 - Use search engine ids rather than objects for updating the list in preferences. r=settings-reviewers,Gijs 
Comparing objects may be unreliable, using search engine ids are guarenteed to be unique.

Differential Revision: https://phabricator.services.mozilla.com/D170209
 2023-02-20 13:36:41 +00:00
Mark Banner
a484144da1 Bug 1781768 - When live language switching ensure that search engines installed via add-ons also update. r=search-reviewers,settings-reviewers,mconley,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D168279
 2023-02-02 11:38:28 +00:00
James Teow
14f7ec50f1 Bug 1800851 - showSearchTerms checkbox should listen to search bar changes - r=adw,settings-reviewers 
While trying to simplify the test code prior to landing the initial preference
panel update, I removed some checks in the test that ensured the checkbox
was actually being checked if the user enabled the search bar while the search
panel was opened. Hence how the tests passed despite the fact that I neglected
to include a listener.

Differential Revision: https://phabricator.services.mozilla.com/D162583
 2022-11-22 18:20:22 +00:00
James Teow
cc3a7abd51 Bug 1779470 - Part 2: Add show search terms in url bar feature to about:preferences#search - r=adw,flod 
See https://www.figma.com/file/Ock0cYjzi7I1GmcctqOr9K/Search-settings-updates?node-id=2%3A112 for mockup.

Depends on D159462

Differential Revision: https://phabricator.services.mozilla.com/D155866
 2022-11-05 02:13:29 +00:00
mcheang
7aba04e4e0 Bug 1786324 - Change SearchService to reference engines by Ids rather than names. r=Standard8 
An id is created for every new instance of SearchEngine. The new
getEngineById method should be called to return an engine rather than
calling getEngineByName.

Differential Revision: https://phabricator.services.mozilla.com/D155236
 2022-11-02 12:17:38 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157471
 2022-09-28 09:40:36 +00:00
Mark Banner
24d0fe0f57 Bug 1786899 - Remove unused BrowserSearch.loadAddEngines and remove formatURL. r=jteow,preferences-reviewers 
formatURL is only used in one other place - nsContextMenu.js, so we don't really need that when we can call the necessary function direct.

Also moves `searchEnginesURL` into SearchUIUtils, as that seems a reasonable place to start storing things like that.

Differential Revision: https://phabricator.services.mozilla.com/D155496
 2022-08-26 07:55:44 +00:00
mcheang
27d628ba02 Bug 1777278 - Change all references of originalEngine to appDefaultEngine in search. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D150599
 2022-06-30 19:26:20 +00:00
Michael Kohler
9411e8107e Bug 1761513 - Remove Engine(about:preferences#search) should be disabled for current Default Engine r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148389
 2022-06-30 11:44:30 +00:00
Mike Kaply
a83f31cc7d Bug 1499095 - Remove engines hidden by policy after restoring defaults. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D142888
 2022-04-12 14:58:45 +00:00
Greg Tatum
255724edea Bug 1758730 - Ensure no errors or warning show on search engine prefs; r=Standard8 
The live language reloading triggers code that will run that assumes the view
is visible, when in fact it may not be on the dom. This fixes that. In addition
it fixes the error where the engine tries to update after it has been removed.

Differential Revision: https://phabricator.services.mozilla.com/D141685
 2022-03-28 19:08:49 +00:00
Greg Tatum
197c0886b9 Bug 1758730 - Reload search preferences UI on live language switch; r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D141684
 2022-03-28 19:08:48 +00:00
Greg Tatum
ae3edd02be Bug 1758730 - Slightly refactor search engine code; r=Standard8 
This is to minimize the upcoming code diff fixing live language switching
for this code.

Differential Revision: https://phabricator.services.mozilla.com/D141683
 2022-03-28 19:08:48 +00:00
Gijs Kruitbosch
41fdc16945 Bug 1294999 - put module getters in preferences.js and de-duplicate them, r=jaws,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D132529
 2021-12-01 16:35:25 +00:00
Drew Willcoxon
85983d13bf Bug 1728430 - Part 2: Update the Firefox Suggest preferences UI. r=mak 
This implements the spec in https://mozilla-hub.atlassian.net/browse/SNT-26, but
Natalie and I have made some tweaks over Slack that aren't reflected in that
ticket.

We want to move the Firefox Suggest preferences from the Search pane to the
Address Bar section of the Privacy pane. There are now two Firefox Suggest
checkboxes instead of one: a main one that enables Firefox Suggest suggestions
and another one that enables sponsored suggestions separately. If the main one
is checked but the sponsored one isn't, then the user will see only
non-sponsored suggestions.

I renamed and modified the browser_searchQuickSuggest.js test I added in
D105701, but a lot of the test changed and it's probably not helpful to look at
the diff against the old version.

Previously strings were hardcoded in search.js. I've added the new ones to the
new preview Fluent file for Firefox Suggest.

Depends on D124300

Differential Revision: https://phabricator.services.mozilla.com/D124431
 2021-09-06 18:56:11 +00:00
Harry Twyford
87f29f6e7f Bug 1717509 - Part 1 - Hook up UrlbarProviderPlaces and fix various lint issues. r=adw,preferences-reviewers 
UnifiedComplete must stick around to serve as an mozIPlacesAutoComplete implementation for XUL consumers like search.js and privacy.js.

Differential Revision: https://phabricator.services.mozilla.com/D119306
 2021-07-09 23:52:37 +00:00
Nan Jiang
be7e67dbe2 Bug 1714344 - Replace the deprecated Nimbus.url.getValue calls r=adw,andreio,preferences-reviewers,jaws 
Differential Revision: https://phabricator.services.mozilla.com/D116724
 2021-06-03 23:19:56 +00:00
Andrei Oprea
5fd4c4ba70 Bug 1699701 - Convert all usages of ExperimentFeature to singleton API r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D110284
 2021-04-09 14:13:13 +00:00
Sebastian Hengst
cba2b35987 Backed out changeset d402c8657d3f (bug 1699701) for failing newtab's activity-stream:AboutPreferences Feed and more. CLOSED TREE 2021-04-09 15:35:48 +02:00