Commit Graph

44 Commits

Author SHA1 Message Date
Kirk Steuber
3a1f5f441a Bug 1420514 - Remove pref app.update.enabled from the update mechanism r=rstrong
Getting rid of this pref allowed some other code to be removed:
 - Changed nsIUpdateService::stopChecking(duration) to nsIUpdateService::stopCurrentCheck() and got rid of the constants representing durations. The available durations were CURRENT_CHECK, CURRENT_SESSION, and ANY_CHECKS, but only CURRENT_CHECK was ever used.
 - nsIUpdateChecker::stopChecking(CURRENT_SESSION) and nsIUpdateChecker::stopChecking(ANY_CHECKS) were the only mechanisms for setting Checker::_enabled to false, so Checker::_enabled and Checker::enabled were removed. References to Checker::enabled were replaced with checks for nsUpdateService::canCheckForUpdates.
 - In browser/base/content/aboutDialog-appUpdater.js, the updateDisabledAndLocked() function was renamed to updateDisabledByPolicy, since the old name is no longer accurate and the new function name is a better description of the function's actual use.

MozReview-Commit-ID: 4wwqo4ROr1V
2018-05-21 14:58:34 -07:00
Andreea Pavel
044d437861 Backed out 7 changesets (bug 1420514) for breaking bc on different files on a CLOSED TREE
Backed out changeset 5a46a221b6e8 (bug 1420514)
Backed out changeset 48ed6dfe8772 (bug 1420514)
Backed out changeset 01bf643c77e5 (bug 1420514)
Backed out changeset 5791b17ccb82 (bug 1420514)
Backed out changeset 416e398d942f (bug 1420514)
Backed out changeset de4a4592dbd9 (bug 1420514)
Backed out changeset d3399edf0197 (bug 1420514)
2018-07-12 21:22:32 +03:00
Kirk Steuber
96b559b3de Bug 1420514 - Remove pref app.update.enabled from the update mechanism r=rstrong
Getting rid of this pref allowed some other code to be removed:
 - Changed nsIUpdateService::stopChecking(duration) to nsIUpdateService::stopCurrentCheck() and got rid of the constants representing durations. The available durations were CURRENT_CHECK, CURRENT_SESSION, and ANY_CHECKS, but only CURRENT_CHECK was ever used.
 - nsIUpdateChecker::stopChecking(CURRENT_SESSION) and nsIUpdateChecker::stopChecking(ANY_CHECKS) were the only mechanisms for setting Checker::_enabled to false, so Checker::_enabled and Checker::enabled were removed. References to Checker::enabled were replaced with checks for nsUpdateService::canCheckForUpdates.
 - In browser/base/content/aboutDialog-appUpdater.js, the updateDisabledAndLocked() function was renamed to updateDisabledByPolicy, since the old name is no longer accurate and the new function name is a better description of the function's actual use.

MozReview-Commit-ID: 4wwqo4ROr1V
2018-05-21 14:58:34 -07:00
Kris Maglione
582a21b473 Bug 1456035: Part 5 - Convert manual QueryInterface to ChromeUtils.generateQI. r=mccr8
Manually-implemented QueryInterface functions don't benefit from the
MozQueryInterface optimizaions, and a lot of them are in hot code, and
implement a large number of interfaces.

MozReview-Commit-ID: 8OzglraowZt
2018-04-23 12:58:34 -07:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Kirk Steuber
a754bb5f5f Bug 1429150 - Change nsIApplicationUpdateService::canCheckForUpdates implementation to respect new enterprise policy preventing app update r=Felipe,mhowell
MozReview-Commit-ID: 7vPaDbONcRr
2018-02-08 09:41:54 -08:00
Cosmin Sabou
83bfbe8ae5 Backed out 3 changesets (bug 1429150) for Android mochitest failures on RobocopTestRunner on a CLOSED TREE.
Backed out changeset dbdd43825f46 (bug 1429150)
Backed out changeset 23a86891fdaf (bug 1429150)
Backed out changeset 1f2d0e869605 (bug 1429150)
2018-02-09 00:39:23 +02:00
Kirk Steuber
7c3096a5db Bug 1429150 - Change nsIApplicationUpdateService::canCheckForUpdates implementation to respect new enterprise policy preventing app update r=Felipe,mhowell
MozReview-Commit-ID: 7vPaDbONcRr
2018-02-08 09:41:54 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mark Banner
5ab2bd1b7a Bug 1421376 - Change various instances of manually calling getService to use Services.jsm in browser/. r=mossop
MozReview-Commit-ID: FW3X2fkOwK2
2017-11-28 19:21:33 +00:00
Evan Tseng
9d1311a9ea Bug 1390561 - Add a new param "buttonAutoFocus" for appUpdater object to focus the button automatically because we need auto focus in about dialog but do not need it in preferences page. r=jaws
MozReview-Commit-ID: KcQVPguaP1o
2017-08-18 16:11:34 +08:00
Ricky Chien
2fe34d6874 Bug 1388796 - Remove unexpected horizontal scrollbar in about:preferences r=jaws 2017-08-24 11:58:50 +08:00
Dan Banner
69fb4d8501 Bug 1392119 - Enable the ESLint no-caller rule across mozilla-central r=standard8
MozReview-Commit-ID: JOC1330iFnh
2017-08-23 13:38:24 +01:00
Evan Tseng
f7fbbb5f30 Bug 1365133 - Reorganize Preferences sections and regroup <xul:groupbox> elements by new categories - Part 1. r=jaws
MozReview-Commit-ID: Lh8iduzVoad
2017-06-16 16:24:33 +08:00
Sebastian Hengst
0e2f88676f Backed out changeset 19d1e9dccdbb (bug 1365133) for frequently failing modified browser/components/preferences/in-content-new/tests/browser_change_app_handler.js. r=backout 2017-07-14 11:35:49 +02:00
Evan Tseng
0c4c6d710c Bug 1365133 - Reorganize Preferences sections and regroup <xul:groupbox> elements by new categories - Part 1. r=jaws
MozReview-Commit-ID: Lh8iduzVoad
2017-06-16 16:24:33 +08:00
Sebastian Hengst
a3d08d451a Backed out changeset 74b19063d4e2 (bug 1365133) for failing browser/components/preferences/in-content-new/tests/browser_security.js and leaking in browser_notification_open_settings.js on Linux debug. r=backout on a CLOSED TREE 2017-06-28 06:24:50 +02:00
Evan Tseng
cdaae1ff38 Bug 1365133 - Reorganize Preferences sections - Part 1. r=jaws
MozReview-Commit-ID: HqgWtyN3G6J
2017-06-06 13:55:45 +08:00
Timothy Guan-tin Chien
150cf9f11b Bug 1365839 - Include build ID on the download and install button. r=mikedeboer
MozReview-Commit-ID: IVGnhuN894z
2017-05-18 13:33:22 +08:00
Timothy Guan-tin Chien
e0d28a9253 Bug 1356507 - Show version and updater in the preferences update pane. r=jaws
This change includes unmodified aboutDialog-appUpdater.js into
preferences.xul, so we could enable the updater UI there. Also,
copied code on version/distribution strings from aboutDialog.js.

MozReview-Commit-ID: 7o24az7Tn28
2017-04-27 19:59:14 +08:00
Sebastian Hengst
cdcf8145fd Backed out changeset 2768a8779068 (bug 1356507) for eslint failure at advanced.js:72. r=backout 2017-05-03 11:10:26 +02:00
Timothy Guan-tin Chien
b77d22d101 Bug 1356507 - Show version and updater in the preferences update pane. r=jaws
This change includes unmodified aboutDialog-appUpdater.js into
preferences.xul, so we could enable the updater UI there. Also,
copied code on version/distribution strings from aboutDialog.js.

MozReview-Commit-ID: 7o24az7Tn28
2017-04-27 19:59:14 +08:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Mark Banner
1b6f3efb6e Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
MozReview-Commit-ID: BuTyJAfUoWR
2017-02-22 17:02:59 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Mark Banner
6b3a6a4cda Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11
2016-10-31 10:33:38 +00:00
Robert Strong
8e4f168bdc bug 1296207 Firefox code - Remove unused app update billboard capability. r=jaws 2016-08-25 13:32:07 -07:00
Jared Wein
0acd9d45c8 Bug 1289283 - Define the lazy service getters at the beginning of the appUpdater function to ensure that they are available to any code that may reference them. r=Gijs
MozReview-Commit-ID: 1YVOCdqkNjd
2016-07-26 01:10:49 -04:00
Jared Wein
a6d4c60593 Bug 1286930 - Allow the About dialog to show the application update UI even if the separate Update Available window is shown. r=rstrong
MozReview-Commit-ID: 1jUyLx4KsZG
2016-07-14 15:22:11 -04:00
Timothy Guan-tin Chien
a38ee9ec94 Bug 1277747 - Show "Restarting..." label when we restart from about dialog updater, r=mikedeboer
Restart might not happen instantly when the user clicks the restart
button. Ideally we want to provide instant feedback in that case. This
patch will switch the UI to a "Restarting..." label as soon as the user
clicks the restart button.

The button is restored if the restart action is aborted.

MozReview-Commit-ID: BfMVla87FmT
2016-06-03 14:01:38 +08:00
Stephen A Pohl
8387f93469 Bug 394984: Enable any admin user on OSX to update Firefox, front-end and updater changes. r=rstrong 2016-05-24 22:25:11 -04:00
Robert Strong
7a928c7499 Bug 1267891 - browser changes - Remove license capability from application update. r=felipc 2016-04-29 10:01:25 -07:00
Robert Strong
0f0d448ce7 Bug 1262880 - browser changes - Remove add-on compatibility check from application update. r=felipc 2016-04-29 10:01:00 -07:00
Felipe Gomes
e2ae8d08b3 Bug 1228655 - Remove ifdefs in aboutDialog.js. r=Gijs 2015-12-01 20:06:02 -02:00