corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
879,387 Commits 1 Branch 0 Tags
fd3ca178356a738d5970a057874e595983c20e4d
Commit Graph

89 Commits

Author SHA1 Message Date
Dão Gottwald
d0520687fb Bug 1924105 - Move tab tests from browser/base/ to browser/components/tabbrowser/. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D225356
 2024-10-11 20:50:10 +00:00
Dão Gottwald
b6f07a6c23 Bug 1924036 - Remove obsolete showOnlyTheseTabs API and reimplement in BrowserTestUtils. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D225323
 2024-10-11 14:25:13 +00:00
DJ
44408879b4 Bug 1918687 - addTabGroup: select unused color if no color specified. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D225102
 2024-10-10 20:00:23 +00:00
Jeremy Swinarton
0026e1e3bc Bug 1922262: Tab group context menu chicklet uses correct styling r=dao,desktop-theme-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D224547
 2024-10-10 15:00:02 +00:00
DJ
7d6283ad1c Bug 1908433 - Add UI for editing an existing tab group. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D223876
 2024-10-09 14:49:18 +00:00
Dão Gottwald
29cb81fbbd Bug 1923294 - Use removeTabGroup helper function in new tab group sub tests. r=jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D224917
 2024-10-08 13:38:37 +00:00
Tom Schuster
dfdbca9500 Bug 1901728 - Add a "Tabs from other devices" item to the tab manager. r=dao,fluent-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220048
 2024-10-02 07:29:48 +00:00
DJ
d6722b5ab0 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222017
 2024-10-02 00:48:13 +00:00
Jeremy Swinarton
f7d52456e8 Bug 1918710: Move tab to tab group from tab context menu r=dao,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222487
 2024-10-01 17:25:28 +00:00
Dão Gottwald
99d5970ee3 Bug 1921858 - Wait for TabGroupRemove event when removing groups. r=jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D224208
 2024-10-01 13:24:27 +00:00
Butkovits Atila
883f96f3dd Backed out changeset 2e5b4312b174 (bug 1908426) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-10-01 13:17:36 +03:00
DJ
5cf4713f6b Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222017
 2024-09-30 20:57:36 +00:00
Dão Gottwald
373871a3e7 Bug 1920775 - Selecting tab in collapsed tab group should expand tab group. r=sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D224064
 2024-09-30 14:58:29 +00:00
Jeremy Swinarton
669e5f193b Bug 1920731: Prevent gBrowser.tabs from returning tab groups r=dwalker,sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D223362
 2024-09-25 17:31:38 +00:00
Sarah Clements
02a48271c6 Bug 1906881 - Update tab context menu strings for vertical tabs mode r=fluent-reviewers,mconley,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223153
 2024-09-25 10:32:30 +00:00
Jeremy Swinarton
054865a576 Bug 1917417: Prevent intermittents by closing tabs in tests without animation r=dao,sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D223182
 2024-09-25 06:20:49 +00:00
Dão Gottwald
b05aac4958 Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D223292
 2024-09-25 05:08:37 +00:00
Norisz Fay
09a2236ef6 Backed out changeset fad1cda93cc8 (bug 1908426) for causing multiple failures CLOSED TREE 2024-09-24 02:13:41 +03:00
DJ
6ca1b918f3 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222017
 2024-09-23 21:17:14 +00:00
Joel Maher
1217ef421e Bug 1919776 - part 1, adjust browser/base and browser/components osx skip-if conditions to be more specific. r=sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D222841
 2024-09-20 13:15:23 +00:00
Jeremy Swinarton
ca4df10a2c Bug 1908424: Context menu to create a group from single or multiple tabs r=dao,dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D221825
 2024-09-19 18:54:12 +00:00
Joel Maher
04cf186cea Bug 1917223 - re-enable many tests on browser/components/[pri*-urlbar]/**/browser.toml. r=aryx,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,urlbar-reviewers,dao,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D221309
 2024-09-18 23:37:52 +00:00
Emilio Cobos Álvarez
90897ae6d8 Bug 1917458 - Remove bookmarks-toolbar-overlapping-browser code. r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.

Differential Revision: https://phabricator.services.mozilla.com/D221996
 2024-09-16 13:21:51 +00:00
Emilio Cobos Álvarez
b13159498a Bug 1917458 - Only send resizes for remote browsers once per frame. r=mstange,extension-reviewers,tabbrowser-reviewers,dao,robwu 
Do it at the same time as UpdateRemoteFrameEffects() (so, intersection
observer timing). Otherwise we can see flickering sometimes from the
resize with the previous patch (and this should be less work, when we
resize).

Non-remote frames need to synchronously communicate their resizes
(because JS could access the frame), but that's not an issue for
remote frames.

This should also more reliably prevent issues like bug 1910887 or like
bug 1764655, and paves the way for fixing bug 1750189 (which stalled) in
a similar fashion.

I tested this in a build with a couple hundred tabs open and it doesn't
measurably show up. I think we should consider not communicating resizes
to background tabs / hidden remote iframes, at least for top levels.

Differential Revision: https://phabricator.services.mozilla.com/D221405
 2024-09-15 21:57:40 +00:00
Cristian Tuns
482d5b9f87 Backed out 5 changesets (bug 1917458) for causing wpt failures in no_window_open_when_term_nesting_level_nonzero.window.html CLOSED TREE 
Backed out changeset 157eb2ada2ca (bug 1917458)
Backed out changeset 3f6d758ac9c6 (bug 1917458)
Backed out changeset 65384dcd3d9a (bug 1917458)
Backed out changeset e4cca274eb5a (bug 1917458)
Backed out changeset 2b1c3c2aef15 (bug 1917458)
 2024-09-14 21:04:04 -04:00
Emilio Cobos Álvarez
8d2ba7e03e Bug 1917458 - Remove bookmarks-toolbar-overlapping-browser code. r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.

Differential Revision: https://phabricator.services.mozilla.com/D221996
 2024-09-14 23:23:52 +00:00
Emilio Cobos Álvarez
c35fde2a5b Bug 1917458 - Only send resizes for remote browsers once per frame. r=mstange,extension-reviewers,tabbrowser-reviewers,dao,robwu 
Do it at the same time as UpdateRemoteFrameEffects() (so, intersection
observer timing). Otherwise we can see flickering sometimes from the
resize with the previous patch (and this should be less work, when we
resize).

Non-remote frames need to synchronously communicate their resizes
(because JS could access the frame), but that's not an issue for
remote frames.

This should also more reliably prevent issues like bug 1910887 or like
bug 1764655, and paves the way for fixing bug 1750189 (which stalled) in
a similar fashion.

I tested this in a build with a couple hundred tabs open and it doesn't
measurably show up. I think we should consider not communicating resizes
to background tabs / hidden remote iframes, at least for top levels.

Differential Revision: https://phabricator.services.mozilla.com/D221405
 2024-09-14 23:05:27 +00:00
DJ
c1bc3a2807 Bug 1912391 - position tab preview appropriately when in vertical mode. r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D219326
 2024-09-09 05:06:29 +00:00
DJ
e3acb876f7 Bug 1908415 - fire DOM events on tab group create, delete, group, ungroup. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220741
 2024-09-06 17:31:13 +00:00
Joel Maher
3c323306ab Bug 1917158 - move some skip-if -> run-if for browser/components/**/browser.toml. r=sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D221286
 2024-09-06 10:08:18 +00:00
Dão Gottwald
47916b2da7 Bug 1916622 - Remove the browser.tabs.tabmanager.enabled pref. r=tabbrowser-reviewers,extension-reviewers,desktop-theme-reviewers,emilio,robwu,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D221005
 2024-09-05 13:37:09 +00:00
Dão Gottwald
ddb9309ce9 Bug 1915599 - Consolidate tabbrowser arrowscrollbox initialization and overflow/overflowing attribute checks. r=extension-reviewers,desktop-theme-reviewers,jswinarton,emilio,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D220594
 2024-09-04 08:18:46 +00:00
Jeremy Swinarton
8a865f454f Bug 1908408: API to move tab group to a new window r=dao,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220601
 2024-09-03 14:06:07 +00:00
Stanca Serban
629a9a3617 Backed out changeset b20f0a3ffccf (bug 655445) for causing mochitests failures in browser_new_tab_insert_position.js. CLOSED TREE 2024-09-03 17:43:52 +03:00
codesuki
e60bdb02a5 Bug 655445 - Add setting to control position of tabs opened from pinned tabs. r=dao,tabbrowser-reviewers 
This patch introduces `browser.tabs.insertAfterCurrentExceptPinned`.
Setting it to `true` open links from pinned tabs at the end of the tabbar.

Differential Revision: https://phabricator.services.mozilla.com/D69489
 2024-09-03 13:12:27 +00:00
isaacylee
cfa004f3c1 Bug 1558149 - Use 'loadFlags' instead of 'flags' for flags eventually passed to 'loadURI' or 'fixupAndLoadURIString' r=Gijs,geckoview-reviewers,tabbrowser-reviewers,dao,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D216324
 2024-08-31 22:00:59 +00:00
Jeremy Swinarton
aaa87e6120 Bug 1908413: Delete tab group when closing the last tab r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220486
 2024-08-29 15:29:03 +00:00
Emilio Cobos Álvarez
f481b9fc6e Bug 1915266 - Make overflowTabs wait for the overflow event. r=dao,tabbrowser-reviewers 
This is a test issue only. We now fire the overflow event later, not off
arbitrary flushes, so we gotta wait for it before trying to click the
new tab button, which might not be visible yet otherwise.

While at it, wait for the opened tabs too, which was done manually on
the caller.

Differential Revision: https://phabricator.services.mozilla.com/D220416
 2024-08-28 20:11:18 +00:00
Dão Gottwald
f308c86db8 Bug 935372 - Enable browser_overflowScroll.js on Win11. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D220404
 2024-08-28 14:41:48 +00:00
Jeremy Swinarton
6a9ffdb4fe Bug 1908411: API to remove tab group r=dao,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220273
 2024-08-28 11:29:44 +00:00
Jeremy Swinarton
86a3077de9 Bug 1908407: Add tab groups API to ungroup tabs r=dao,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220001
 2024-08-26 17:22:09 +00:00
DJ
6248ea2cf3 Bug 1908419 - add method to retrieve list of groups from tabContainer. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220142
 2024-08-26 16:59:51 +00:00
DJ
bfb53ac9de Bug 1908405 - accept optional list of tabs in addTabGroup. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D219941
 2024-08-23 09:44:53 +00:00
Jeremy Swinarton
1ca50f8860 Bug 1912275: Collapsing tab group changes selected tab r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218888
 2024-08-14 13:56:29 +00:00
Jeremy Swinarton
0d521d1f2b Bug 1908416: gBrowser.visibleTabs handles tab groups r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218796
 2024-08-08 16:23:24 +00:00
Jeremy Swinarton
cd95d6d498 Bug 1908404: Click to expand/collapse tab group r=dao,desktop-theme-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218434
 2024-08-07 14:59:36 +00:00
Sarah Clements
39bf719fce Bug 1909843 - Vertical tab fixes r=tabbrowser-reviewers,desktop-theme-reviewers,dao 
* Fix rule to show favicon when icons are missing
* Fix typo name change that affects unpinning tabs
* Fix padding issue for arrowscrollbox that affects alignment

Differential Revision: https://phabricator.services.mozilla.com/D218052
 2024-08-06 14:48:27 +00:00
Jeremy Swinarton
535307654a Bug 1908873: THP appears as tooltip to accessibility tools r=dwalker,accessibility-frontend-reviewers,ayeddi,tabbrowser-reviewers,Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D217631
 2024-08-06 14:44:44 +00:00
Anna Yeddi
f351d96411 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod 
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
 2024-08-06 13:51:06 +00:00
Dão Gottwald
5cc15d0779 Bug 1908412 - add API for adding tabs to a group. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218204
 2024-08-05 09:25:19 +00:00