Commit Graph

144 Commits

Author SHA1 Message Date
Catalin Badea
fc6ab5f0ea Bug 651120 - Remove index argument from content removed/appended/inserted notifications. r=peterv 2017-10-03 11:09:08 +01:00
Matthew Noorenberghe
80e800c67b Bug 1378754 - Don't clear marked fields in nsFormFillController upon a persisted pagehide. r=smaug
While moving to a new window (using SwapDocShells), a pagehide event[1] is dispatched causing nsFormFillController to clean up mPwmgrInputs and mAutofillInputs for the document. This commit changes the pagehide handler to not clear the hash tables or mutation observers with persisted=true (which would also fix the same bug in password manager autocomplete).

This approach comes at the cost of increased memory (hash table entries for fields in session history) but would reduce CPU usage compared to the alternative of re-marking password manager and autofill fields upon every pageshow event. This approach also solves the issue of autofill and password manager autocomplete not working after session history navigation.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/SwapDocShells

MozReview-Commit-ID: 8DFWuFynDex
2017-07-21 13:32:48 -07:00
Matthew Noorenberghe
2d3e8270ae Bug 1378754 - Add MOZ_LOG logging to nsFormFillController.cpp. r=steveck
MozReview-Commit-ID: KJ7TnnlzrGC
2017-07-21 15:32:18 -07:00
Bill McCloskey
ce42826bdf Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Ehsan Akhgari
2b4811fa0d Bug 1374887 - Remove nsIFormAutoComplete::StopControllingInput() from the C++ side; r=MattN
This currently only incurs some XPConnect and exception creation
overhead, as the method has no implementation.
2017-06-21 23:43:37 -04:00
Ehsan Akhgari
b9bffa40b9 Bug 1374893 - Don't handle the input event for inputs that aren't text controls; r=MattN 2017-06-21 23:29:15 -04:00
Carsten "Tomcat" Book
238bf154d5 Backed out changeset 4f6302a98ae4 (bug 1372405) 2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993 Backed out changeset 9846de3bd954 (bug 1372405) 2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Ehsan Akhgari
c6aa106d58 Bug 1373063 - Make nsFormFillController::HandleEvent() a bit faster by avoiding some string comparisons; r=MattN 2017-06-15 09:39:30 -04:00
Ehsan Akhgari
8ddf0fb7cd Bug 1372794 - Cache the form autocomplete service instead of repeatedly getting it in the form fill controller; r=MattN 2017-06-14 08:24:16 -04:00
Jonathan Guillotte-Blouin
e813613649 Bug 1365068 - Added missing brackets & refactored some conditional statements. r=MattN
MozReview-Commit-ID: 1eOkjI06RCJ
2017-05-16 15:56:28 -07:00
Ray Lin
d37849aaa3 Bug 1340483 - Part 3. Enable preview function only when input is marked as autofill field. r=heycam
MozReview-Commit-ID: FFqYJ3icRd7
2017-03-22 16:55:56 +08:00
Mike Conley
dbab8e7198 Bug 1350243 - Combine e10s and non-e10s code paths when reacting to datalist updates. r=MattN
MozReview-Commit-ID: 1O3wAzzwWAR
2017-04-06 16:39:08 -04:00
Johann Hofmann
2852b063d7 Bug 1337772 - Part 1 - Use mousedown instead of contextmenu to avoid showing the password autocomplete. r=MattN
MozReview-Commit-ID: EUZ1f6Qdm0c
2017-04-07 00:01:31 +02:00
Olli Pettay
45822311b7 Bug 1351860 - Move mType from HTMLInputElement to nsIFormControl and make GetType non-virtual inlined, r=jessica 2017-03-31 22:49:00 -04:00
Olli Pettay
694b05ce02 Backout Bug 1351860, r=backout 2017-03-31 16:55:32 -04:00
Olli Pettay
fa83f6684e Bug 1351860 - Move mType from HTMLInputElement to nsIFormControl and make GetType non-virtual inlined, r=jessica 2017-03-31 13:13:36 -04:00
Boris Zbarsky
34042de72d Bug 1343037 part 16. Implement a version of nsTextEditorState::SetSelectionRange that takes a string for the direction. r=ehsan
MozReview-Commit-ID: E8zYAWolg94
2017-03-09 14:44:06 -05:00
Boris Zbarsky
b55933e687 Bug 1343037 part 2. Get rid of nsIDOMHTMLInputElement's selectionEnd accessors. r=ehsan,MattN
MozReview-Commit-ID: L2Ozu7Vvort
2017-03-09 14:44:03 -05:00
Boris Zbarsky
da687175e6 Bug 1343037 part 1. Get rid of nsIDOMHTMLInputElement's selectionStart accessors. r=ehsan,MattN
MozReview-Commit-ID: IyFv8NRuZIO
2017-03-09 14:44:03 -05:00
Johann Hofmann
48b937717f Bug 1337772 - Fix intermittent browser_context_menu_autocomplete_interaction.js. r=MattN
MozReview-Commit-ID: 6vAWN4z2wRP
2017-03-01 20:05:38 +01:00
Johann Hofmann
b114c94ba3 Bug 1337259 - Don't show password autocomplete upon a right click into the password field. r=mconley
MozReview-Commit-ID: JEODCfZOMRW
2017-02-10 12:45:26 +01:00
Luke Chang
ceb079459c Bug 1341582 - Apply form autofill to an already-focused input, r=MattN
MozReview-Commit-ID: C6zT7jKBb4c
2017-02-23 14:44:07 +08:00
Matthew Noorenberghe
d2593e96a9 Bug 1330111 - Expose nsFormFillController's showPopup via nsIFormFillController. r=felipe
MozReview-Commit-ID: 9pc2QDDWTrQ
2017-02-03 12:44:49 -08:00
Matthew Noorenberghe
5e1ddd57d4 Bug 1330111 - Convert the getFocusedInput method on nsIFormFillController to an attribute. r=felipe
The convention is to use an attribute. This also fixes reference counting.

MozReview-Commit-ID: B38ZVNt4Ugi
2017-01-31 23:57:49 -08:00
Matthew Noorenberghe
595105ed4f Bug 1330111 - Always attempt to autocomplete on type=password fields upon focus. r=daleharvey
Let password manager handle opening the popup on username fields itself.

MozReview-Commit-ID: FbI6CgsadEd
2017-02-07 11:15:35 +08:00
Carsten "Tomcat" Book
4ee0fb6b85 Backed out changeset 6b7069ed30e0 (bug 1330111) for causing frequent timeouts in browser_autocomplete_insecure_warning.js 2017-02-07 14:03:42 +01:00
Carsten "Tomcat" Book
c8f64dc715 Backed out changeset dee4bf1753cd (bug 1330111) 2017-02-07 14:03:21 +01:00
Carsten "Tomcat" Book
dca15269f2 Backed out changeset e0f1b7028872 (bug 1330111) 2017-02-07 14:03:20 +01:00
Matthew Noorenberghe
05b8b298fc Bug 1330111 - Expose nsFormFillController's showPopup via nsIFormFillController. r=felipe
MozReview-Commit-ID: 9pc2QDDWTrQ
2017-02-03 12:44:49 -08:00
Matthew Noorenberghe
0910b872a4 Bug 1330111 - Convert the getFocusedInput method on nsIFormFillController to an attribute. r=felipe
The convention is to use an attribute. This also fixes reference counting.

MozReview-Commit-ID: B38ZVNt4Ugi
2017-01-31 23:57:49 -08:00
Matthew Noorenberghe
cdf7ab4697 Bug 1330111 - Always attempt to autocomplete on type=password fields upon focus. r=daleharvey
Let password manager handle opening the popup on username fields itself.

MozReview-Commit-ID: FbI6CgsadEd
2017-02-07 11:15:35 +08:00
Wes Kocher
b2c1cc5f1d Backed out 9 changesets (bug 1330111) for bc bustage in various tests a=backout
Backed out changeset e87c86970a29 (bug 1330111)
Backed out changeset 9e2e44a7a159 (bug 1330111)
Backed out changeset 7abc377ef809 (bug 1330111)
Backed out changeset f1e782d1c944 (bug 1330111)
Backed out changeset d94d72846952 (bug 1330111)
Backed out changeset 23180cae4a46 (bug 1330111)
Backed out changeset 09c59f5c572a (bug 1330111)
Backed out changeset e208e0b51349 (bug 1330111)
Backed out changeset 271035a2bc64 (bug 1330111)

MozReview-Commit-ID: 6mfKgu07dow
2017-02-06 17:54:14 -08:00
Matthew Noorenberghe
f135b57802 Bug 1330111 - Expose nsFormFillController's showPopup via nsIFormFillController. r=felipe
MozReview-Commit-ID: 9pc2QDDWTrQ
2017-02-03 12:44:49 -08:00
Matthew Noorenberghe
bc02a87553 Bug 1330111 - Convert the getFocusedInput method on nsIFormFillController to an attribute. r=felipe
The convention is to use an attribute. This also fixes reference counting.

MozReview-Commit-ID: B38ZVNt4Ugi
2017-01-31 23:57:49 -08:00
Matthew Noorenberghe
2f92a5df80 Bug 1330111 - Always attempt to autocomplete on type=password fields upon focus. r=daleharvey
Let password manager handle opening the popup on username fields itself.

MozReview-Commit-ID: FbI6CgsadEd
2017-02-03 17:19:02 -08:00
Boris Zbarsky
e7ae250672 Bug 1332812. Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj 2017-02-02 10:32:58 -05:00
Sebastian Hengst
7e11a9fec6 Backed out changeset c724fbd9c326 (bug 1332812) for build bustage. r=backout on a CLOSED TREE 2017-02-02 16:58:52 +01:00
Boris Zbarsky
391a68c2da Bug 1332812. Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj 2017-02-02 10:32:58 -05:00
Matthew Noorenberghe
8e3b5ecb32 Bug 1334026 - Show the the insecure field warning on insecure password fields even if they're not marked. r=mconley
MozReview-Commit-ID: JwEYWQmexj
2017-01-30 15:53:27 -08:00
Phil Ringnalda
aa56652d4a Backed out changeset 25c931f199e8 (bug 1334026) for Android crashes @ nsFormFillController::StartSearch
CLOSED TREE
2017-01-26 21:30:50 -08:00
Matthew Noorenberghe
b5ecd9ef6b Bug 1334026 - Show the the insecure field warning on insecure password fields even if they're not marked. r=mconley
MozReview-Commit-ID: JwEYWQmexj
2017-01-26 18:03:16 -08:00
Ryan VanderMeulen
2011aa053e Backed out changeset 1ddaf704683d (bug 1334026) for browser_aboutHome.js crashes on a CLOSED TREE. 2017-01-26 20:49:17 -05:00
Matthew Noorenberghe
7e61303245 Bug 1334026 - Show the the insecure field warning on insecure password fields even if they're not marked. r=mconley
MozReview-Commit-ID: JwEYWQmexj
2017-01-26 15:22:05 -08:00
steveck-chung
41aee8d40d Bug 1300992 - Part 1: Communication between processes, r=MattN
MozReview-Commit-ID: IfeRsX9ErBj
2016-12-30 17:00:27 +08:00
Matthew Noorenberghe
8afaef40f9 Bug 1329351 - Only autocomplete on password fields which were marked. r=mconley
MozReview-Commit-ID: 3xNSPrlhOik
2017-01-19 01:06:47 -08:00
Wes Kocher
e04e60de15 Backed out changeset cca78c809a20 (bug 1329351) for test_password_field_autocomplete.html failures a=backout CLOSED TREE
MozReview-Commit-ID: 43v5di5qqHh
2017-01-12 16:15:25 -08:00
Matthew Noorenberghe
74f07f2996 Bug 1329351 - Only autocomplete on password fields which were marked. r=mconley
MozReview-Commit-ID: 3xNSPrlhOik
2017-01-12 12:52:42 -08:00