Commit Graph

443 Commits

Author SHA1 Message Date
Gijs Kruitbosch
3df219d2cc Bug 1529577 - stop tracking window minimization in BrowserWindowTracker, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D19186
2019-02-08 16:34:41 +00:00
Orangelynx
b622c318c4 Bug 384278 - Added additional state variable to store window state before window minimization. r=mikedeboer
Current window state in the sessionstore system includes `sizeMode` which can be "normal", "minimized", "maximized". However, the OS also remembers whether the window was "normal" or "maximized" before minimization to restore it appropriately. With this fix, sessionstore does likewise.

Differential Revision: https://phabricator.services.mozilla.com/D13234
2019-02-20 09:03:09 +00:00
Shane Caraveo
1e0dd4dc35 Bug 1525125 block newtab and homepage overrides in private windows r=rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18730
2019-02-19 19:19:44 +00:00
Jonathan Kingston
540181c731 Bug 1521549 - Move (de)serializePrincipal from sessionstore Utils to E10SUtils. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D17261
2019-02-19 02:34:09 +00:00
Valentin Gosu
83082cfa48 Bug 1521808 - Implement process switching based on Cross-Opener-Origin-Policy header r=nika,qdot
* New topLevel loads get the nsILoadInfo.openerPolicy of the current top level document
* Parsing the Cross-Opener-Origin-Policy of a channel will update mLoadInfo.openerPolicy and this value will get propagated to the child process.
* SessionStore now checks nsIHttpChannel.hasCrossOriginOpenerPolicyMismatch (preffed off) and performs a process switch if needed

Differential Revision: https://phabricator.services.mozilla.com/D19000
2019-02-15 22:02:47 +00:00
Nika Layzell
d2c955d6fe Bug 1522637 - Part 6: Perform process switches separtely from on-examine-response, r=valentin
Issues were occuring where a process swap would be decided upon during
on-examine-response, but before the swap could be handled by the
channel, the channel was redirected.

This new code takes the mildly hacky approach of simply using a separate
observer notification which is fired at the correct time. A better
solution may be to use a dedicated service for responding to these
events, however that was not implemented for this initial patch.

Depends on D18606

Differential Revision: https://phabricator.services.mozilla.com/D19691
2019-02-15 19:49:17 +00:00
Nika Layzell
96e8470115 Bug 1522637 - Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
Depends on D18604

Differential Revision: https://phabricator.services.mozilla.com/D18605
2019-02-15 19:49:13 +00:00
Nika Layzell
8eb68bcb39 Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604
2019-02-15 19:49:11 +00:00
Nika Layzell
1380effa94 Bug 1522637 - Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
Depends on D18602

Differential Revision: https://phabricator.services.mozilla.com/D18603
2019-02-15 19:49:04 +00:00
Razvan Maries
e54d0a34a1 Backed out changeset 10528ad0d7a1 (bug 1525125) for frequently failing bug 1528134. a=backout 2019-02-15 18:23:14 +02:00
Razvan Maries
25ef899b22 Backed out 9 changesets (bug 1522637) for causing bug 1528188. a=backout
Backed out changeset e4ca191d62a5 (bug 1522637)
Backed out changeset 540e5f318768 (bug 1522637)
Backed out changeset 0886a317a108 (bug 1522637)
Backed out changeset 4c7c512a262d (bug 1522637)
Backed out changeset d7eb272688be (bug 1522637)
Backed out changeset 67e838f49f4b (bug 1522637)
Backed out changeset 7e38890c72fa (bug 1522637)
Backed out changeset e6ca9ad18d15 (bug 1522637)
Backed out changeset 0f759e91eca8 (bug 1522637)
2019-02-15 18:21:36 +02:00
Shane Caraveo
572260cbf2 Bug 1525125 block newtab and homepage overrides in private windows r=rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18730
2019-02-14 19:46:00 +00:00
Nika Layzell
327d5ed4dd Bug 1522637 - Part 7: Perform process switches separtely from on-examine-response, r=valentin
Issues were occuring where a process swap would be decided upon during
on-examine-response, but before the swap could be handled by the
channel, the channel was redirected.

This new code takes the mildly hacky approach of simply using a separate
observer notification which is fired at the correct time. A better
solution may be to use a dedicated service for responding to these
events, however that was not implemented for this initial patch.

Depends on D18607

Differential Revision: https://phabricator.services.mozilla.com/D19691
2019-02-14 15:37:06 +00:00
Nika Layzell
636c9bfcef Bug 1522637 - Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
Depends on D18604

Differential Revision: https://phabricator.services.mozilla.com/D18605
2019-02-14 15:14:01 +00:00
Nika Layzell
aa7faefb58 Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604
2019-02-14 15:36:02 +00:00
Nika Layzell
d46aa7503c Bug 1522637 - Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
Depends on D18602

Differential Revision: https://phabricator.services.mozilla.com/D18603
2019-02-14 15:12:51 +00:00
Bogdan Tara
cf2a8a5e80 Backed out 8 changesets (bug 1522637) for browser_all_files_referenced.js failures CLOSED TREE
Backed out changeset f7ab0e6e739b (bug 1522637)
Backed out changeset 3d24e8e81c02 (bug 1522637)
Backed out changeset 41ca0b87537e (bug 1522637)
Backed out changeset 6e0d4b6b1c93 (bug 1522637)
Backed out changeset 8f494271ec06 (bug 1522637)
Backed out changeset 6b4d010964ec (bug 1522637)
Backed out changeset 5eeda2ba8e79 (bug 1522637)
Backed out changeset 5988b8e7d17c (bug 1522637)
2019-02-14 19:20:58 +02:00
Nika Layzell
1820c519dd Bug 1522637 - Part 7: Perform process switches separtely from on-examine-response, r=valentin
Issues were occuring where a process swap would be decided upon during
on-examine-response, but before the swap could be handled by the
channel, the channel was redirected.

This new code takes the mildly hacky approach of simply using a separate
observer notification which is fired at the correct time. A better
solution may be to use a dedicated service for responding to these
events, however that was not implemented for this initial patch.

Depends on D18607

Differential Revision: https://phabricator.services.mozilla.com/D19691
2019-02-14 15:37:06 +00:00
Nika Layzell
78fedee2c9 Bug 1522637 - Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
Depends on D18604

Differential Revision: https://phabricator.services.mozilla.com/D18605
2019-02-14 15:14:01 +00:00
Nika Layzell
efa3555cc6 Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604
2019-02-14 15:36:02 +00:00
Nika Layzell
631ef4c975 Bug 1522637 - Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
Depends on D18602

Differential Revision: https://phabricator.services.mozilla.com/D18603
2019-02-14 15:12:51 +00:00
Bogdan Tara
2e3873efad Backed out changeset 14f7c02566c2 (bug 1525125) for browser_ext_windows_create_tabId.js failures CLOSED TREE 2019-02-14 17:29:40 +02:00
Shane Caraveo
d5f0871903 Bug 1525125 block newtab and homepage overrides in private windows r=rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18730
2019-02-14 12:44:07 +00:00
Dorel Luca
e3bc01d732 Backed out 4 changesets (bug 1521808) for build bustage. CLOSED TREE
Backed out changeset 80aeea5f7abe (bug 1521808)
Backed out changeset c8c151d92c03 (bug 1521808)
Backed out changeset cc0a5c7dabb4 (bug 1521808)
Backed out changeset 8d5174a560fa (bug 1521808)
2019-02-12 14:54:45 +02:00
Valentin Gosu
f8ad4b68d8 Bug 1521808 - Implement process switching based on Cross-Opener-Origin-Policy header r=nika,qdot
* New topLevel loads get the nsILoadInfo.openerPolicy of the current top level document
* Parsing the Cross-Opener-Origin-Policy of a channel will update mLoadInfo.openerPolicy and this value will get propagated to the child process.
* SessionStore now checks nsIHttpChannel.hasCrossOriginOpenerPolicyMismatch (preffed off) and performs a process switch if needed

Differential Revision: https://phabricator.services.mozilla.com/D19000
2019-02-12 12:16:58 +00:00
Nika Layzell
2ebd47ca7a Bug 1522839 - Cache permanentKey in case it changes during navigateAndRestore, r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D19402
2019-02-12 02:47:51 +00:00
shindli
1bcd12d6dd Backed out 6 changesets (bug 1522637) for en-US failures in testing/firefox-ui/tests/functional/safebrowsing/test_notification.py TestSafeBrowsingNotificationBar.test_notification_bar CLOSED TREE
Backed out changeset 18a809d53298 (bug 1522637)
Backed out changeset 9e9fd362dd8f (bug 1522637)
Backed out changeset f1191be4243a (bug 1522637)
Backed out changeset 5a8067fd848c (bug 1522637)
Backed out changeset 5f49cd87b1bd (bug 1522637)
Backed out changeset f82ba91f5ea2 (bug 1522637)
2019-02-09 03:12:53 +02:00
Nika Layzell
90a487ebef Bug 1522637 - Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
Depends on D18604

Differential Revision: https://phabricator.services.mozilla.com/D18605
2019-02-08 17:36:04 +00:00
Nika Layzell
d8f5cbfa8d Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604
2019-02-08 17:36:02 +00:00
Nika Layzell
cfd4cc62c7 Bug 1522637 - Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
Depends on D18602

Differential Revision: https://phabricator.services.mozilla.com/D18603
2019-02-08 17:36:00 +00:00
Cosmin Sabou
59f8929c31 Backed out changeset a1f9a3e18986 (bug 384278) for browser chrome failures on browser_sizemodeBeforeMinimized.js. 2019-02-03 17:08:18 +02:00
Orangelynx
7a774219ae Bug 384278 - Added additional state variable to store window state before window minimization. r=mikedeboer
Current window state in the sessionstore system includes `sizeMode` which can be "normal", "minimized", "maximized". However, the OS also remembers whether the window was "normal" or "maximized" before minimization to restore it appropriately. With this fix, sessionstore does likewise.

Differential Revision: https://phabricator.services.mozilla.com/D13234
2019-02-03 14:29:29 +00:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Shane Caraveo
f0ffc7e6f1 Bug 1516704 incognito support in session api, r=rpl,mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D16921
2019-01-29 20:18:36 +00:00
Razvan Maries
7c9dececde Backed out changeset 64d26b5a25b8 (bug 1516704) for bc failures at browser_ext_sessions_incognito.js. CLOSED TREE 2019-01-29 05:30:25 +02:00
Shane Caraveo
99e2d4e946 Bug 1516704 incognito support in session api, r=rpl,mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D16921
2019-01-28 12:39:39 +00:00
Nika Layzell
baa4ee233f Bug 1467223 - Part 5: Perform parent-process interception for HTTP loads, r=qdot,valentin
This will only happen if the pref is enabled, and works through the existing
mechanism for process switching loads. It should enable POST data to be
preserved when performing a process switch, for example when submitting
a form on a file:// or moz-extension:// URI to a http:// URI.

Depends on D15611

Differential Revision: https://phabricator.services.mozilla.com/D15612
2019-01-23 21:07:10 +00:00
Johann Hofmann
65314d413a Bug 1483440 - Part 2 - Don't use purge-domain-data to clear session history for a domain. r=mikedeboer,baku
Differential Revision: https://phabricator.services.mozilla.com/D16461
2019-01-17 17:41:23 +00:00
Kris Maglione
2fe938bed2 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888
2018-10-25 19:04:01 -07:00
arthur.iakab
60aefe8252 Backed out 2 changesets (bug 1482091) for bc failures on browser_domFullscreen_fullscreenMode.js
Backed out changeset bc03f101937e (bug 1482091)
Backed out changeset 28a19b7290ab (bug 1482091)
2018-11-03 01:08:36 +02:00
Kris Maglione
937d3bc224 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888
2018-10-25 19:04:01 -07:00
arthur.iakab
0b02a4f71d Backed out 2 changesets (bug 1482091)for failing browser chrome failures on browser_panelUINotifications_fullscreen_noAutoHideToolbar.js
Backed out changeset afd0a13bcfff (bug 1482091)
Backed out changeset a19c6b3e0402 (bug 1482091)
2018-11-02 23:01:15 +02:00
Kris Maglione
31d1c1a1da Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888
2018-10-25 19:04:01 -07:00
Jay Lim
a7fa1a522a Bug 1472212 - Prevent focusing on the tab's content area during session restoration for special URLs for new tabs. r=dao
Since about:newtab now runs in the privileged content process, SessionStore
will attempt restore the tab's content whenever we perform a process switch.
This causes the tab's content area to be focused. We will add a condition to
prevent focusing on the tab's content area.

This patch also focuses on the URL bar first before opening a new tab to avoid
flickering.

MozReview-Commit-ID: FRKR6pReiZz
2018-07-20 19:47:56 -04:00
Jay Lim
f780a5acbd Bug 1472212 - Ensure that tab does not show busy or burst status whenever we navigate to about:home, about:newtab, or about:welcome in a new window. r=Gijs
Now that we have moved some about: pages to the privileged content process,
opening these URLs from a non-privileged content process will trigger SessionStore
to restore the tab state due to a process flip. We will set favicons for these
URLs earlier to avoid flickering and improve perceived performance.

This patch also prevents the spinner whenever a page with a local about: URI
(about:blank and about: pages that resolve to jar:// or file:// URIs) is
loaded from a process that the URI cannot load in (e.g. loading about:newtab
in the web content process), as well as during tab duplication or session
restoration for such local about: URIs.

Before this patch, there were additional frames when opening a new window, causing
browser/base/content/test/performance/browser_windowopen.js to fail. This patch
will reduce the number of frames when opening a new window.

MozReview-Commit-ID: yjj2964KSz
2018-07-20 16:43:12 -04:00
Ciure Andrei
1f3e650127 Backed out 10 changesets (bug 1501044, bug 1472212) for fetch-destination.https.html perma failure CLOSED TREE
Backed out changeset aa35078cabaa (bug 1472212)
Backed out changeset bf02793f802d (bug 1472212)
Backed out changeset 95a7ef6102a6 (bug 1472212)
Backed out changeset 7b7fa6ab2229 (bug 1472212)
Backed out changeset 4fe4ec18f2f3 (bug 1472212)
Backed out changeset 18f824674b76 (bug 1472212)
Backed out changeset 1978a7837502 (bug 1472212)
Backed out changeset 21a6f1a83c73 (bug 1472212)
Backed out changeset 48242d39d532 (bug 1472212)
Backed out changeset 0b5cf2f4305a (bug 1501044)
2018-10-30 23:31:10 +02:00
Jay Lim
315223429e Bug 1472212 - Prevent focusing on the tab's content area during session restoration for special URLs for new tabs. r=dao
Since about:newtab now runs in the privileged content process, SessionStore
will attempt restore the tab's content whenever we perform a process switch.
This causes the tab's content area to be focused. We will add a condition to
prevent focusing on the tab's content area.

This patch also focuses on the URL bar first before opening a new tab to avoid
flickering.

MozReview-Commit-ID: FRKR6pReiZz
2018-07-20 19:47:56 -04:00
Jay Lim
a0680e88ae Bug 1472212 - Ensure that tab does not show busy or burst status whenever we navigate to about:home, about:newtab, or about:welcome in a new window. r=Gijs
Now that we have moved some about: pages to the privileged content process,
opening these URLs from a non-privileged content process will trigger SessionStore
to restore the tab state due to a process flip. We will set favicons for these
URLs earlier to avoid flickering and improve perceived performance.

This patch also prevents the spinner whenever a page with a local about: URI
(about:blank and about: pages that resolve to jar:// or file:// URIs) is
loaded from a process that the URI cannot load in (e.g. loading about:newtab
in the web content process), as well as during tab duplication or session
restoration for such local about: URIs.

Before this patch, there were additional frames when opening a new window, causing
browser/base/content/test/performance/browser_windowopen.js to fail. This patch
will reduce the number of frames when opening a new window.

MozReview-Commit-ID: yjj2964KSz
2018-07-20 16:43:12 -04:00
Csoregi Natalia
bd7ac4afbb Backed out 9 changesets (bug 1472212) for browser-chrome tests run issues on Linux x64 asan and failures on browser_ext_windows_create_tabId.js. CLOSED TREE
Backed out changeset 18e46df44cd1 (bug 1472212)
Backed out changeset 2e5de66c1f60 (bug 1472212)
Backed out changeset b94f9883aef0 (bug 1472212)
Backed out changeset ebdca743668c (bug 1472212)
Backed out changeset f8a06d01437e (bug 1472212)
Backed out changeset b6996abc7d90 (bug 1472212)
Backed out changeset 24c257cd18c3 (bug 1472212)
Backed out changeset 176f3ee14e67 (bug 1472212)
Backed out changeset b4baa63e5b1b (bug 1472212)
2018-10-30 01:58:21 +02:00
Jay Lim
5a67038807 Bug 1472212 - Prevent focusing on the tab's content area during session restoration for special URLs for new tabs. r=dao
Since about:newtab now runs in the privileged content process, SessionStore
will attempt restore the tab's content whenever we perform a process switch.
This causes the tab's content area to be focused. We will add a condition to
prevent focusing on the tab's content area.

This patch also focuses on the URL bar first before opening a new tab to avoid
flickering.

MozReview-Commit-ID: FRKR6pReiZz
2018-07-20 19:47:56 -04:00