Commit Graph

6 Commits

Author SHA1 Message Date
Ed Lee
bdcdeb3c15 Bug 1525452 - Add Message component, visibility capping and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D18841
2019-02-06 15:58:38 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Ursula Sarracini
d8f0c8f7df Bug 1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D5914
2018-09-20 18:36:20 +00:00
Bogdan Tara
959605aa80 Backed out changeset 8dde92f89a24 (bug 1489962) for browser_asrouter_cfr.js failures. a=backout 2018-09-20 02:42:00 +03:00
Ed Lee
f7f0cd229e Bug 1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D5914
2018-09-19 13:53:10 +00:00
Ursula Sarracini
2e6b296592 Bug 1474414 - Move most of browser/extensions/activity-stream to browser/components/newtab r=Mardak
MozReview-Commit-ID: GnMIh1n4d3c
2018-07-26 20:50:49 -07:00