This test was intermittently timing out, mostly on debug builds, because there
was a chance that from time to time the sidebar could have been loaded for the
first time while the background page of the test extension was still being loaded.
The test was sending an extension test message as soon as the sidebar was loaded
for the first time, and so if the background page didn't yet added its test message
listener, the test cases did never get started and the entire test was getting stuck.
The changes included in this patch prevents this intermittent failures by ensuring
that the test always waits for the background page and the sidebar to be both loaded
and ready before sending the test message that starts to run the test cases.
Differential Revision: https://phabricator.services.mozilla.com/D20657
This better reflects what the property is (i.e. a
WebConsoleUI instance), and avoid confusion with
the panel's hud (created in webconsole.js).
We take that as an opportunity to clean things up
a bit (e.g. don't access the webConsoleUI through
JsTerm).
Differential Revision: https://phabricator.services.mozilla.com/D19783
This patch changes ext-history.js and ext-browsingData.js to ensure that these API modules are importing PlacesUtils in the same way as ext-bookmarks.js, because mixing CU.defineModuleGetter and CU.import would raise an error and it would break those two WebExtensions APIs if the ext-bookmarks.js gets loaded first.
Differential Revision: https://phabricator.services.mozilla.com/D18683
We will no longer parse Breakpad-generated .sym files, and we will no longer
call out to dump_syms.exe or nm.
This has a number of advantages:
- It's simpler.
- It's faster, especially for local builds on Windows.
- It's more extensible. For example, we can now easily add code to the wasm
module which consults debugging information in order to obtain filename +
line information or inlined call stacks.
- On Macs that don't have the Xcode command line tools installed, Xcode will
no longer pop up a dialog because we no longer attempt to run 'nm'.
Depends on D13005
Differential Revision: https://phabricator.services.mozilla.com/D13006
The module can dump ELF binaries, Mach-O binaries, and pdb files. So it works
for all our supported platforms.
The module is currently hosted on https://zealous-rosalind-a98ce8.netlify.com/ ,
which is a netlify server that serves files from the following repo:
https://github.com/mstange/profiler-assets
To make all of this look a bit more official, I'm planning on doing two things:
- Move the github repo under the devtools-html organization
- Get a firefox.com subdomain such as profiler-assets.firefox.com for hosting
Depends on D13004
Differential Revision: https://phabricator.services.mozilla.com/D13005
This is a rollup of all the patches that have landed on the cedar project branch:
891252fdd0
Bug 1492475 - Part 1: Migrate most, if not all nsSearchService consumers to use async APIs. r=florian
79b2eb2367
Bug 1492475 - Part 2: Move nsIBrowserSearchService.idl to toolkit/components/search/nsISearchService.idl and update references. r=florian
a947d3cdf0
Bug 1492475 - Part 3: The search service init() method should simply return a Promise. r=florian
c1e172dfac
Bug 1492475 - Part 4: Remove the synchronous initialization flow. r=florian
cd41189eac
Bug 1492475 - Part 5: Since async initialization of the search service now is implicit behavior, remove the distinctive verbiage used internally. r=florian
2ae7189dfa
Bug 1492475 - Part 6: Update the cache build task to work with an actual Promise and re-initialize only once at the same time - all to fix race conditions here. r=florian
c8ee92973f
Bug 1492475 - Part 7: Make the region fetch not block the init flow, to ensure it's as fast as possible. r=florian
c44e674e16
Bug 1492475 - Part 8: Introduce an init flag, which can only be used privately, that allows to explicitly skip waiting for the region check process to complete. r=florian
6c79eaf1d3
Bug 1492475 - Part 9: Update unit tests to stop using 'currentEngine', in favor of 'defaultEngine'. r=Standard8
21b3aa17ee
Bug 1492475 - Part 10: Update unit tests to be fully aware of the new, async signatures of the search service API and remove sync init flow tests. r=mkaply,florian
ce5ba69019
Bug 1492475 - Part 11: Repair incorrect usage of the `identifier` property of nsISearchEngine instances. r=florian
fd177a7994
Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r=florian
3653d8ee22
Bug 1523708 - Change the search service interaction in the show-heartbeat action to use the new async API. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D18355
This patch makes it so that all target fronts inherits from a Target class mixin.
We are using a mixin as fronts should inherit from a custom Front class,
which is augmented with its own RDP request and events defined in its spec.
(This is done via FrontClassWithSpec(spec))
Depends on D15830
Differential Revision: https://phabricator.services.mozilla.com/D15831
This patch applies the following changes:
- make sure that the WebExtensions internals do not create any devtools_page related to a private tabs' toolbox
if the extension is not allowed to access the private browsing windows
- define a new mochitest to verify the expended behaviors on the private windows when the extension is
allowed and not allowed
Depends on D15948
Differential Revision: https://phabricator.services.mozilla.com/D15949
This patch moves some "devtools related" test helpers into a shared support file,
and updates all the existing devtools API mochitests to use the new shared test helpers.
This change has also the following nice side-effects:
- remove any usage of the custom devtools module loader from the webextensions mochitests.
- use a custom "test blank toolbox panel" in all the devtools API tests that doesn't need a specific
panel to be selected (which should help to make the test able to run a bit faster because none of
the more expensive devtools panels is going to be loaded during the tests if not actually needed).
Differential Revision: https://phabricator.services.mozilla.com/D15948
This patch applies the following changes:
- Reduce the chances of retrieving the initial popup panel size while it is resizing, by comparing the
content dimensions retrieved before and after the delay (which is already set to a value comparable
to the time used by the resize debouncing timer), and wait until both the dimensions collected are the same
- split browser_ext_browserAction_popup_resize.js into two test files (as it seems, based on the investigations
I did by reproducing this intermittent locally, that the part that can still fail intermittently from time
to time with the change describe above is related to the testBrowserActionMenuResizeBottomArrow test case)
- move the test helpers shared between the two test files into a new head_browserAction.js support file
- re-enabled browser_ext_browserAction_popup_resize.js
- mark the new browser_ext_browserAction_popup_resize_bottom.js as disabled on debug build,
because it is consistently triggering a "shutdown leak" failure when running locally
Differential Revision: https://phabricator.services.mozilla.com/D17267
This changes the policy to use the pref and permissions rather than a boolean flag. Using permissions gets us proper settings on startup without introducing any new overhead. Going this way flips our tests around so rather than testing an override to turn off private browsing support, we test overrides to enable private browsing support.
Differential Revision: https://phabricator.services.mozilla.com/D14482
This patch applies the following changes:
- Reduce the chances of retrieving the initial popup panel size while it is resizing, by comparing the
content dimensions retrieved before and after the delay (which is already set to a value comparable
to the time used by the resize debouncing timer), and wait until both the dimensions collected are the same
- split browser_ext_browserAction_popup_resize.js into two test files (as it seems, based on the investigations
I did by reproducing this intermittent locally, that the part that can still fail intermittently from time
to time with the change describe above is related to the testBrowserActionMenuResizeBottomArrow test case)
- move the test helpers shared between the two test files into a new head_browserAction.js support file
- re-enabled browser_ext_browserAction_popup_resize.js
- mark the new browser_ext_browserAction_popup_resize_bottom.js as disabled on debug build,
because it is consistently triggering a "shutdown leak" failure when running locally
Differential Revision: https://phabricator.services.mozilla.com/D17267
