Adds a global .eslintrc file for all source files in /browser/devtools.
This file defines a set of global variables that are commonly used in
/browser/devtools code.
The files that import modules with Cu.import will need to define their
own globals as /* globals ... */ comments.
This file also defines the configuration for all the rules we want to
use.
This also adds a set of .eslintrc files, one per test directory in
/browser/devtools. Each of these files extend from one of 2 parent config
files: .eslintrc.xpcshell or .eslintrc.mochitest.
The parent config define the set of globals these types of tests have
access to (test runner functions, assertion functions, etc.).
Finally, this also adds .eslintrc files in /toolkit/devtools for code and
tests, which just extend from their counterparts in /browser/devtools.
This adds two tests:
1. browser_fontinspector_edit-previews.js checks that
* if the text is changed, the preview images should change
* if the text field is empty, the initial previews should be shown
It doesn't check the exact preview images because they are drawn on a canvas
causing them to vary between systems, platforms and software versions.
2. browser_fontinspector_edit-previews-show-all.js checks that the 'Show all'
mode is remembered if the preview text is edited after the button is clicked.
An input box similar to those in rule and computed views (without the search
symbol) is added to the font-inspector panel which can be used to control the
preview text. The updates are throttled to avoid unnecessary updates while the
text is being edited.
Since the PageStyleActor has allowed clients to define the preview text for a
while now, this feature is also enabled for older targets too.
This patch adds a new method openFontInspectorForURL to the head.js file which
a) opens a new tab with the given URL
b) opens inspector for the tab
c) selects font-inspector and waits for it to initialize
Previously the only font-inspector test was doing all that inside the test but
as new tests require the similar functionality it's better to reside in
head.js.
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
