Commit Graph

273 Commits

Author SHA1 Message Date
Butkovits Atila
f9c2c4cdab Backed out 2 changesets (bug 1954826) for causing failures at browser_webconsole_stubs_page_error.js. CLOSED TREE
Backed out changeset 8ea416e43464 (bug 1954826)
Backed out changeset 7581b670c001 (bug 1954826)
2025-03-21 19:37:09 +02:00
Julien Wajsberg
8d3ee78b61 Bug 1954826 - Remove ContentTaskUtils from the list of eslint globals for tests r=frontend-codestyle-reviewers,mossop
It's still added dynamically for some specific cases such as in the
callback for SpecialPowers.spawn.

Differential Revision: https://phabricator.services.mozilla.com/D242122
2025-03-21 14:34:59 +00:00
Hanna Jones
5ae6dcb546 Bug 1921095 - set up tests for stylelint-plugin-mozilla r=frontend-codestyle-reviewers,Standard8
This patch sets up basic tests for our custom stylelint plugin. Additional work to get these running on automation will be done in bug 1948141 if we're alright with this approach.

Differential Revision: https://phabricator.services.mozilla.com/D238126
2025-02-18 13:55:11 +00:00
Andrew Halberstadt
629c3f0c5a Bug 1944916 - [mozlint] Add ability to lint files from stdin to mozlint, r=linter-reviewers,sylvestre
This allows `./mach lint` to be used with integrations that expect to
pass in file contents on stdin and get a fixed version of the file on
stdout.

Differential Revision: https://phabricator.services.mozilla.com/D236224
2025-02-06 19:54:47 +00:00
Gregory Pappas
cbb36dfedd Bug 1875216 - part 2: Remove linting for XPCOMUtils.defineLazyGetter r=arai,Standard8,frontend-codestyle-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D202127
2025-02-03 14:49:37 +00:00
Sylvestre Ledru
b588c53a93 Bug 1943936 - codespell 2.4.0: typo fixes r=linter-reviewers,profiler-reviewers,canaltinova,ahal
Differential Revision: https://phabricator.services.mozilla.com/D235601
2025-01-27 15:28:31 +00:00
Tooru Fujisawa
94bba12a39 Bug 1936051 - Part 15: Remove JSM handling from eslint config. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D233741
2025-01-23 12:09:37 +00:00
Tooru Fujisawa
a52536e7e4 Bug 1936051 - Part 7: Remove JSM handling from the use-isInstance rule. r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233733
2025-01-23 12:09:34 +00:00
Tooru Fujisawa
1c92ef1014 Bug 1936051 - Part 6: Remove JSM handling from the reject-eager-module-in-lazy-getter rule. r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233732
2025-01-23 12:09:33 +00:00
Tooru Fujisawa
2b05a3b05e Bug 1936051 - Part 5: Remove the reject-global-this rule. r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233731
2025-01-23 12:09:33 +00:00
Tooru Fujisawa
7ea13bcadf Bug 1936051 - Part 4: Remove the use-chromeutils-import rule. r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233730
2025-01-23 12:09:32 +00:00
Tooru Fujisawa
404a6afa61 Bug 1936051 - Part 3: Remove the reject-chromeutils-import rule. r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233729
2025-01-23 12:09:32 +00:00
Tooru Fujisawa
77aae738a1 Bug 1936051 - Part 2: Remove the reject-chromeutils-import-params rule. r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233728
2025-01-23 12:09:31 +00:00
Tooru Fujisawa
142c49a4d5 Bug 1936051 - Part 1: Remove the mark-exported-symbols-as-used rule. r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233727
2025-01-23 12:09:30 +00:00
Mark Banner
7ba14bc2ee Bug 1940268 - Add a linter for names in node package.json files. r=linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D233181
2025-01-10 08:41:05 +00:00
Sylvestre Ledru
d7c69961bb no bug - mozlint/clippy: refresh of the doc r=linter-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D231425
2024-12-09 21:04:22 +00:00
longsonr
a1e0dc11f4 Bug 1931617 Part 2 - Remove mentions of Algorithm.h where it's no longer used r=emilio,application-update-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D229205
2024-11-19 11:25:39 +00:00
Adi
96cdd300d5 Backed out 2 changesets (bug 1931617) for causing for causing build bustages @sVersionComparator.cpp. CLOSED TREE
Backed out changeset 7376753fb852 (bug 1931617)
Backed out changeset 4cd29d936b4b (bug 1931617)
2024-11-19 11:11:50 +02:00
longsonr
2431f88b47 Bug 1931617 Part 2 - Remove mentions of Algorithm.h where it's no longer used r=emilio,application-update-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D229205
2024-11-19 08:26:38 +00:00
Mark Banner
ccaff2bd0a Bug 1928625 - Remove ESLint rule mozilla/consistent-if-bracing as curly already enforces more than it. r=frontend-codestyle-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D227658
2024-11-04 13:48:54 +00:00
serge-sans-paille
c2bbe8fb3a Bug 1920717 - Add static checker for global variables with runtime initialisation r=glandium
This patch both:

1. Provides a static checker to detect global variables which may not be
   initialized at compile-time

2. Verify that variables flagged as MOZ_RUNINIT are indeed
   initialized at runtime

3. In case of variables whose initialisation status varies based on
   macro definition or template parameters, just flag them as
   MOZ_GLOBINIT.

Differential Revision: https://phabricator.services.mozilla.com/D223342
2024-10-30 11:05:25 +00:00
serge-sans-paille
5946338a6a Bug 1920718 - Annotate all global variable with runtime initialization attributes r=glandium,application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh,geckoview-reviewers,win-reviewers,gstoll,m_kato
MOZ_RUNINIT => initialized at runtime
MOZ_CONSTINIT => initialized at compile time
MOZ_GLOBINIT => initialized either at runtime or compile time, depending on template parameter, macro parameter etc
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
2024-10-30 11:05:24 +00:00
Tamas Szentpeteri
8285dfaab8 Backed out changeset 4b1409597101 (bug 1920718) for causing bp bustages on rapl.cpp. 2024-10-08 23:27:18 +03:00
serge-sans-paille
1966f9a43c Bug 1920718 - Annotate all global variable with runtime initialization as MOZ_RUNINIT r=application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
2024-10-08 16:49:51 +00:00
Hanna Jones
e98c8e4379 Bug 1838298 - Custom Stylelint plugin to prevent color tokens from being used directly r=Standard8,frontend-codestyle-reviewers,desktop-theme-reviewers,dao
This patch lays the foundation for a Mozilla-specific Stylelint plugin that we can continue to expand on with new rules as needed. For the first rule I've implemented a simple check to ensure our color tokens are being used as intended.

Differential Revision: https://phabricator.services.mozilla.com/D223204
2024-09-27 14:58:41 +00:00
Mark Banner
1b9a4bcf9e Bug 1920970 - Move ESLint node_modules bundles away from tooltool and into the toolchain. r=jcristau
Differential Revision: https://phabricator.services.mozilla.com/D223647
2024-09-26 10:55:31 +00:00
Julian Descottes
f62a855e09 Bug 1917003 - [eslint] Add linter rule to ban await await r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221187
2024-09-16 09:13:30 +00:00
Bryan Olsson
9af95c3720 Bug 1915749 - Update Localization documentation post GitHub transition, r=flod
Differential Revision: https://phabricator.services.mozilla.com/D220638
2024-09-04 05:28:00 +00:00
Mark Banner
66e8ca14df Bug 1907841 - Change ESLint's .eslintignore to be an imported module. r=frontend-codestyle-reviewers,zeid,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D216540
2024-07-16 12:53:09 +00:00
Mark Banner
57b142b0fe Bug 1907860 - Clean up remaining parts of format-source. r=sheehan
Differential Revision: https://phabricator.services.mozilla.com/D216546
2024-07-15 14:00:10 +00:00
Andrew McCreight
7e5cd3bd2b Bug 1902344 - Remove outdated data structure references in "Using C++ in Mozilla code" and elsewhere. r=xpcom-reviewers,nika DONTBUILD
nsAutoTArray was renamed to AutoTArray.

nsDataHashtable and nsJSThingHashtable don't exist any more.

nsTHashMap and nsTHashSet now exist.

nsDeque is properly typed now.

Pair is now CompactPair.

Differential Revision: https://phabricator.services.mozilla.com/D213624
2024-06-13 22:41:51 +00:00
Mark Banner
94a2472342 Bug 1897898 - Separate out ESLint rule rollouts configurations to a separate module. r=frontend-codestyle-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D210992
2024-05-21 13:38:01 +00:00
Botond Ballo
fb1065c0c3 Bug 1858446 - Document that classes representing HTML elements should live in the mozilla::dom namespace. r=peterv DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D210576
2024-05-17 23:23:44 +00:00
Andrew Halberstadt
a680bcd3e1 Bug 1868440 - [ci] Upgrade taskcluster-taskgraph to v7.4.0, r=perftest-reviewers,geckoview-reviewers,ci-and-tooling,devtools-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,omc-reviewers,jmaher,hneiva,aminomancer,jari,dom-storage-reviewers,afinder,asuth,bhearsum,owlish
Differential Revision: https://phabricator.services.mozilla.com/D206260
2024-04-18 20:39:09 +00:00
Stanca Serban
3dbb534055 Backed out 2 changesets (bug 1868440) for gecko decision task broken. CLOSED TREE
Backed out changeset 4b22948d849a (bug 1868440)
Backed out changeset 837bdcb3694a (bug 1868440)
2024-04-18 21:25:43 +03:00
Andrew Halberstadt
ef4f1e168b Bug 1868440 - [ci] Upgrade taskcluster-taskgraph to v7.4.0, r=perftest-reviewers,geckoview-reviewers,ci-and-tooling,devtools-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,omc-reviewers,jmaher,hneiva,aminomancer,jari,dom-storage-reviewers,afinder,asuth,bhearsum,owlish
Differential Revision: https://phabricator.services.mozilla.com/D206260
2024-04-18 17:50:50 +00:00
Greg Mierzwinski
2181bf39d4 Bug 1890318 - Update perfdocs linter documentation. r=perftest-reviewers,kshampur DONTBUILD
This patch updates the perfdocs linter documentation to contain the new config schema, and information about how to add documentation for the metrics.

Differential Revision: https://phabricator.services.mozilla.com/D206953
2024-04-17 12:34:31 +00:00
Gijs Kruitbosch
94e799935c Bug 1880899 - add lint rule that prevents adding more browser.js globals, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D202804
2024-03-16 15:14:07 +00:00
Gijs Kruitbosch
2b6df36c8c Bug 1856535 - allow linters to work by excluding extensions instead of including them, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D202635
2024-03-13 09:40:27 +00:00
Mark Banner
0a0c3c6972 Bug 1884623 - Cleanup jsm references in ESLint files. r=mossop,devtools-reviewers,omc-reviewers,ochameau,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204180
2024-03-11 15:26:27 +00:00
Tooru Fujisawa
69f8a594a2 Bug 1879254 - Verify .gitignore and .hgignore consistency. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D201072
2024-02-22 04:48:27 +00:00
Mark Banner
e012a72f1c Bug 1878848 - Remove ESLint support for .jsm.js extensions. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D200771
2024-02-06 13:32:52 +00:00
Tom Marble
a42a175006 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-26 20:06:56 +00:00
Gregory Pappas
8e0ae3e9ae Bug 1872922 - Replace last few uses of XPCOMUtils.defineLazyGetter with ChromeUtils.defineLazyGetter and add linter error for XPCOMUtils.defineLazyGetter r=extension-reviewers,credential-management-reviewers,devtools-reviewers,Standard8,arai,robwu,Gijs,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D198677
2024-01-17 15:54:00 +00:00
Gijs Kruitbosch
9547bd9ce0 Bug 1780071 - add eslint rule for misuse of assignments or conditions inside ok(), r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D198593
2024-01-17 15:04:34 +00:00
Luca Greco
af88486ae1 Bug 1868144 - Introduce a new condprof-addons linter and condprof-addons-verify taskcluster task. r=sparky,jmaher,linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D195434
2024-01-17 14:07:53 +00:00
Cristian Tuns
fc22950f3d Backed out 2 changesets (bug 1868144, bug 1874487) for causing mozlint-condprof-addons failures CLOSED TREE
Backed out changeset 7a65679aabcf (bug 1874487)
Backed out changeset cd38cf3f7807 (bug 1868144)
2024-01-16 16:34:11 -05:00
Luca Greco
47d4a95f67 Bug 1868144 - Introduce a new condprof-addons linter and condprof-addons-verify taskcluster task. r=sparky,jmaher,linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D195434
2024-01-16 21:11:33 +00:00