Commit Graph

384 Commits

Author SHA1 Message Date
Mats Palmgren
f85d73c25c Bug 233463, patch 5 - Remove nsFrameList(nsIFrame*) ctor. r=bzbarsky 2009-09-18 13:09:36 +02:00
Zack Weinberg
b6fe8205dd Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc 2009-09-12 17:49:24 +01:00
Boris Zbarsky
23db8f4fa3 Bug 281387. Make nsIFrame::Append/InsertFrames use nsFrameList. r=bernd,roc, sr=dbaron 2009-07-30 13:23:32 -04:00
Boris Zbarsky
a8b4b2dc7e Bug 504221 part 12. Switch SetInitialChildList to nsFrameList. r=fantasai, r+sr=roc 2009-07-28 08:53:20 -04:00
Boris Zbarsky
f3c6270c7b Bug 504221 part 5. Switch from GetFirstChild to GetChildList (returning an nsFrameList). For now, keep a GetFirstChild shim so callers don't have to be updated. r=fantasai, r+sr=roc 2009-07-28 08:51:09 -04:00
Masayuki Nakano
8cf4b22364 Bug 502799 add new nsISound method for the event sounds r=roc+neil, sr=roc 2009-07-09 10:55:46 +09:00
Gavin Sharp
f9f7691e26 Bug 496103: don't cancel mousedown events for menus (prevents dragging bookmark folders on the bookmark toolbar), r+sr=Neil. Test by Marco Bonardo <mak77@bonardo.net>, r=dietrich 2009-06-03 22:43:03 -04:00
Neil Rashbrook
0c90913208 Bug 488752 Incorrect menulist behaviour on Mac OS X r=enn sr=roc 2009-05-01 13:24:49 +01:00
Jeremy D. Lea
500e189d56 Bug 431634 - Part 1 - clean up header pollution; r+sr=roc 2009-04-01 13:59:02 -08:00
Arpad Borsos
73675ccdd1 Bug 399753 - Remove nsISupportsArray in the layout directory; r+sr=roc 2009-03-30 20:08:06 +02:00
Neil Rashbrook
ed135a547f Bug 311053 XUL frames should respect preventDefault() [e.g. when menus are open] r=Enn sr=jst 2009-02-27 10:48:25 +00:00
Boris Zbarsky
1b29d18b8a Bug 473390 part 10. Move various XUL nsIBoxLayout stuff out of the frame constructor into frame creation functions, and make the XUL frame creation functions have the right signature to fit into the new world. r+sr=roc 2009-01-19 13:31:33 -05:00
Benjamin Smedberg
0f95227641 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
7a084ac404 Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
991a16d8bc Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Masayuki Nakano
751df4bc30 Bug 83056 Add support for windows sounds to Menus r=enndeakin, sr=roc, ui=jboriss 2008-12-11 02:23:20 +09:00
Olli Pettay
2f67623b93 Bug 466326 - #!!! ASSERTION: killing mutation events: 'nsContentUtils::IsSafeToRunScript(), r=enn,sr=sicking 2008-12-03 12:56:58 +02:00
Arpad Borsos
40a654b059 Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
3409b972d8 Bug 411048 - "Menu remains highlighted after being dismissed by middle-click" (clear active state when destroying menu frame) [p=enndeakin@sympatico.ca (Neil Deakin) r=Smaug sr=Neil a1.9=damons] 2008-01-29 23:18:07 -08:00
a4db825823 Bug 366531 - "deCOMtaminate nsBox.h [BoundsCheck()]" [p=ldx@users.sourceforge.net (Lorenzo Dieryckx) r+sr=roc a1.9=damons] 2008-01-04 21:49:44 -08:00
b54b2e501a Bug 407601, use preferred size when calculating popup position and size instead of current size, fixes extraneous layouts and scrolling position changes, r+sr=bz,a=shrep 2007-12-19 08:37:32 -08:00
da8ae79238 Bug 401627, better way of handling click to close menu so that it doesn't reopen the menu again, r+sr=roc 2007-12-03 08:33:42 -08:00
06c9f32689 Bug 395628 - ""ASSERTION: post-reflow queues not empty" with feed in <frame>" [p=mats.palmgren@bredband.net (Mats Palmgren) r=smaug r+sr=dbaron a=blocking1.9+] 2007-11-30 23:22:44 -08:00
16d7837d15 Bug 394600, address bz's additional popup reworking comments, add tests for removing popups, r+sr=bz,a=beltzner 2007-11-17 07:47:38 -08:00
4fa40ba0dd Discard aPrevFrame if it's the mPopupFrame since it's on a different lists. b=394800 r=enndeakin sr=bzbarsky a=dbaron 2007-10-19 22:43:38 -07:00
774bc27401 Bug 397012, add null check otherwise tests crash 2007-10-09 10:48:30 -07:00
a1adf57d0b Bug 397012, menus don't close on second click, r+sr=bz 2007-10-09 10:21:36 -07:00
17d021cba5 Bug 387990 [a11y] mouse pointer position can prevent keyboard access to submenus r=enndeakin sr=roc 2007-10-02 02:41:29 -07:00
9f351ff772 remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc 2007-10-01 16:20:37 -07:00
825a2cb3fa Bug 392652, nsXULPopupManager::Rollup should hide popups synchronously, r+sr=bz, a=mconnor 2007-09-18 08:00:43 -07:00
c475ca69f7 Bug 394301, bookmark menu shown too short, r+sr=bz, a=mconnor 2007-09-18 07:35:17 -07:00
3f642bbb03 Bug 387981 No focus events when exiting XUL submenus
r=surkov.alexander, enndeakin sr=neil
2007-07-25 21:14:32 -07:00
0f07c9a9b6 Bug 388361, dropdowns in font dialog not always working, make sure to reset cached size when a frame is added or removed, r+sr=bz 2007-07-18 19:02:04 -07:00
905f533e37 Bug 387142, submenus collapsing incorrectly, also ensure parent menu gets highlighted again when a subitem is selected, r+sr=bz
CVS: ----------------------------------------------------------------------
2007-07-11 05:05:40 -07:00
98de634631 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
a7249af232 Bug 279703, rework XUL popups to use asynchronous opening, plus many other fixes, attempt 2 with creating widgets later, r=bz,neil,roc,sr=bz 2007-07-04 08:49:38 -07:00
2ce3a601f3 Bug 279703, backing out the popup changes due to performance regressions. sigh. 2007-06-29 15:15:59 -07:00
9feb664c79 Bug 279703, rework XUL popups to use asynchronous opening, plus many other fixes, r=bz,neil,sr=bz 2007-06-29 12:04:45 -07:00
cdb5b22b87 Change the FrameNeedsReflow API to pass the dirty flags to be added directly tothe method, instead of setting them before calling the method. That way we canavoid reflowing the ancestor of a reflow root which is not itself dirty but hasdirty children. This also makes it harder to set dirty bits inconsistentlywith the FrameNeedsReflow call. Bug 378784, r+sr=dbaron, pending rbs' reviewon the mathml parts. 2007-05-06 12:16:51 -07:00
e0f90db412 Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc. 2007-03-30 14:11:41 -07:00
7e4e3ec68f 375196, r+sr=roc 2007-03-25 22:38:22 -07:00
Olli.Pettay@helsinki.fi
4099d59436 Bug 368501, Table Properties Windows Cut Off, r=bz, sr=roc 2007-03-05 21:55:23 +00:00
mats.palmgren@bredband.net
ae679372a4 [DEBUG only] Warn when 'key' cannot be found. b=370453 r=neil@httl.net sr=bzbarsky 2007-02-24 05:42:36 +00:00
bzbarsky@mit.edu
c9c9579477 deCOMtaminate SetBounds(), GetChildBox(), GetNextBox(), GetParentBox(),
GetVAlign(), GetHAlign().  Remove GetInset().  Bug 243370, patch by Andreas
Lange <anlan@lange.cx>, r+sr=roc
2007-02-22 18:05:14 +00:00
jonas@sicking.cc
7a41bbf68d Bug 370332: Kill nsIBindingManager and nsIStyleRuleSupplier. r=dbaron for the layout/style parts, r/sr=jst for the rest. 2007-02-16 23:02:08 +00:00
Olli.Pettay@helsinki.fi
dda4efb9cc Bug 243370, deCOMtaminate parts of nsIFrame that come from nsIBox, part 2, p=anlan@lange.cx, r+sr=roc 2007-01-31 16:02:42 +00:00
cvshook@sicking.cc
e80f1dba4e Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128 2007-01-30 00:06:41 +00:00
bzbarsky@mit.edu
81d8934573 deCOMtaminate nsIFrame::GetMinSize/GetPrefSize/GetMaxSize. Bug 243370, patch
by Andreas Lange <anlan@lange.cx>, r+sr=roc
2007-01-08 02:57:59 +00:00
timeless@mozdev.org
f4ef17d178 Bug 355300 There should be only one nsGkAtoms creature
r=dbaron
2006-12-26 17:47:52 +00:00
dbaron@dbaron.org
d21cb374bd Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213. 2006-12-08 05:38:33 +00:00