corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
780,267 Commits 1 Branch 0 Tags
f7a4fadf48f9962a35a3ccae37d2ad681a1e758c
Commit Graph

5715 Commits

Author SHA1 Message Date
Sandor Molnar
9a4a56ad39 Backed out changeset 45ea391514c0 (bug 1790855) for causing bc failures in browser_contextmenu CLOSED TREE 2022-10-04 06:41:48 +03:00
Niklas Baumgardner
f8ddf4dd71 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 02:09:08 +00:00
Sandor Molnar
624e213832 Backed out changeset d8835c4ab04f (bug 1790855) for causing bc failures in browser/components/screenshots/tests/browser/browser_screenshots_test_toggle_pref.js CLOSED TREE 2022-10-04 04:12:42 +03:00
Niklas Baumgardner
cc57189ab5 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 00:03:56 +00:00
Csoregi Natalia
d301388c8f Backed out changeset d91a621a39be (bug 1785853) for multiple failures e.g.browser_setup_state.js CLOSED TREE 2022-10-03 19:48:44 +03:00
Sarah Clements
f13f2edf01 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-03 16:07:54 +00:00
Dão Gottwald
474fd7d31f Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158396
 2022-09-30 20:04:37 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
4ab80589c9 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin 
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
 2022-09-27 04:18:16 +00:00
Marian-Vasile Laza
338fc0a451 Backed out changeset 2f74f8f2ed19 (bug 1689816) for causing reftest failures on skip-ink-multiline-position.html. 2022-09-26 23:24:03 +03:00
Emilio Cobos Álvarez
ba878e30c1 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin 
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
 2022-09-26 17:40:30 +00:00
Emilio Cobos Álvarez
11f34416e8 Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes 
.browserContainer is relatively positioned, so we can position the
tab-modal dialogs absolutely inside it instead of making them part of
the browser stack.

While at it, make the rdm toolbar part of the regular browserContainer,
just like the regular devtools toolbox is. That way there's no need to
do ResizeObserver shenanigans to be able to let it grow. Keep it also
absolutely positioned tho, because we need to overlay the whole
container when the device modal is opened. That's somewhat gross.

This should in general be simpler to understand than the current set-up,
and more performant to since it avoids the dialog stack from forming
part of the browser element's flow.

Differential Revision: https://phabricator.services.mozilla.com/D157912
 2022-09-23 22:23:37 +00:00
Brian
0b327f0974 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs. 
Differential Revision: https://phabricator.services.mozilla.com/D157034
 2022-09-23 21:19:12 +00:00
Evan
7be0d917de Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157039
 2022-09-23 18:11:48 +00:00
Daisuke Akatsuka
dacc90003d Bug 1790814: Depends on existing tabs to change the tab to open about:addons page. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157400
 2022-09-21 22:58:47 +00:00
Ryan VanderMeulen
a42176cf02 Bug 1784692 - Revert focus behavior for new windows introduced by bug 1770818. a=backout 2022-09-21 14:08:31 -04:00
Niklas Baumgardner
170ca9103e Bug 1790823 - Firefox View button should not be open when added to toolbar. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D157662
 2022-09-19 21:54:45 +00:00
Julian Descottes
41bc0c5d10 Bug 1790753 - [devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs 
The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets

This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets.

Differential Revision: https://phabricator.services.mozilla.com/D157300
 2022-09-14 19:11:22 +00:00
Sarah Clements
e04c7ffb66 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
2e7d3531bc Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
26d455d485 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Brian
b5ffb06e87 Bug 1788776 - Convert screenshots component from JSM to ESM. r=niklas. 
Differential Revision: https://phabricator.services.mozilla.com/D157038
 2022-09-11 19:08:38 +00:00
Bernard Igiri
adad7e83e9 Bug 1784054 - Enable full height scrolling in Colorway Closet modal in small windows r=dao 
Updated SubDialog.jsm's sizeTo=available to have better support for responsive layouts with the ability to specify max height and widths on the dialog.

Differential Revision: https://phabricator.services.mozilla.com/D155014
 2022-09-08 17:43:58 +00:00
Mark Banner
73631b4520 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 14:40:07 +00:00
Norisz Fay
6008f8d423 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE 
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
 2022-09-08 17:14:00 +03:00
Mark Banner
e8c3c1e5b4 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 12:43:32 +00:00
Dão Gottwald
5709bd7bd4 Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156412
 2022-09-07 12:21:25 +00:00
Katherine Patenio
5061ac8cb5 Bug 1767827: Use Nimbus feature (with pref fallback) as the condition for enabling Firefox View r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D156004
 2022-09-02 15:45:21 +00:00
Gijs Kruitbosch
40bbc1905a Bug 1787437 - close the Firefox View tab when removing the FxView toolbar item completely, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D155921
 2022-09-02 12:49:54 +00:00
James Teow
d8e65a02b2 Bug 1779465 - Part 1: Show search term on default SERP - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D153280
 2022-09-01 19:26:29 +00:00
Niklas Baumgardner
712e8dd8c0 Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154825
 2022-09-01 13:06:50 +00:00
Daisuke Akatsuka
8b7719fb66 Bug 1786249: Fixup sponsored link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D155807
 2022-08-30 22:02:18 +00:00
Butkovits Atila
8594347f5a Backed out 2 changesets (bug 1676492) for causing failures at test_navigation.py. CLOSED TREE 
Backed out changeset 09fd88048f35 (bug 1676492)
Backed out changeset bc76e6966ec9 (bug 1676492)
 2022-08-30 20:56:51 +03:00
Sean Feng
27b1c54544 Bug 1750034 - Remove lazyload telemetry related code r=emilio 
We have decided to use 600px in all directions, there's no need
to keep the telemetry stuff around.

Differential Revision: https://phabricator.services.mozilla.com/D155879
 2022-08-30 16:00:11 +00:00
Neil Deakin
7f8f002700 Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D155003
 2022-08-30 14:02:02 +00:00
Neil Deakin
22f97e250b Bug 1676492, create a special blank tab page that will show the bookmarks toolbar when 'Only Show on New Tab' is used' even when the new tab page is disabled, r=Gijs,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D154319
 2022-08-30 14:02:01 +00:00
Meg Viar
c114df74a0 Bug 1786356 - Create Firefox View open Tracker r=niklas,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D155432
 2022-08-26 16:16:17 +00:00
Gijs Kruitbosch
4803f07d33 Bug 1787443 - ensure fxview button is always present by default, also for upgrading profiles, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D155695
 2022-08-26 15:50:18 +00:00
Mark Banner
af3b7062df Bug 1786899 - Remove unused uri argument to BrowserSearch.addEngine. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D155498
 2022-08-26 07:55:44 +00:00
Mark Banner
24d0fe0f57 Bug 1786899 - Remove unused BrowserSearch.loadAddEngines and remove formatURL. r=jteow,preferences-reviewers 
formatURL is only used in one other place - nsContextMenu.js, so we don't really need that when we can call the necessary function direct.

Also moves `searchEnginesURL` into SearchUIUtils, as that seems a reasonable place to start storing things like that.

Differential Revision: https://phabricator.services.mozilla.com/D155496
 2022-08-26 07:55:44 +00:00
Paul Zuehlcke
b036de13fc Bug 1751481 - Enable felt privacy features by default and integrate with Nimbus. r=dao,preferences-reviewers,Gijs 
Depends on D155013

Differential Revision: https://phabricator.services.mozilla.com/D155065
 2022-08-25 11:17:39 +00:00
Dão Gottwald
c8e65627ce Bug 1786293 - Move Firefox View button from CustomizableWidgets to markup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155356
 2022-08-24 15:51:44 +00:00
Norisz Fay
4c9cbdf45f Backed out changeset ebba7740ac81 (bug 1784294) for causing bc failures on browser_setup_state.js CLOSED TREE 2022-08-24 09:33:55 +03:00
Niklas Baumgardner
c2ee1cbc9d Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154825
 2022-08-24 02:43:35 +00:00
Daisuke Akatsuka
d066036ed7 Bug 1565751: Use 'SetURI' event for custom new window. r=adw,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D155184
 2022-08-24 00:43:04 +00:00
Dão Gottwald
d32e73692a Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154398
 2022-08-23 09:50:42 +00:00
Dão Gottwald
7f9a2aae48 Bug 1785819 - Announce Firefox View toolbar button as a tab to screen readers. r=ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D154986
 2022-08-18 17:02:02 +00:00
Daisuke Akatsuka
3fcf717749 Bug 1784369: Make opening in new window target for inheritance of sponsored sessions. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D154483
 2022-08-16 00:41:01 +00:00
Norisz Fay
e7039bb6db Backed out 3 changesets (bug 1784369, bug 1784242) for causing node newtab failures CLOSED TREE 
Backed out changeset f19a8a76a85b (bug 1784242)
Backed out changeset 0722fc4bb4fa (bug 1784242)
Backed out changeset 2d4131b0ca28 (bug 1784369)
 2022-08-16 03:19:32 +03:00
Daisuke Akatsuka
a42205a33c Bug 1784369: Make opening in new window target for inheritance of sponsored sessions. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D154483
 2022-08-15 23:45:32 +00:00