Commit Graph

773 Commits

Author SHA1 Message Date
Mark Banner
f733d566c8 Bug 1646183 - Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag
Differential Revision: https://phabricator.services.mozilla.com/D150353
2022-06-29 22:37:57 +00:00
Joel Maher
5d7fe68032 Bug 1769154 - Run some xpcshell tests with a conditioned profile. r=aryx,extension-reviewers,kmag
Differential Revision: https://phabricator.services.mozilla.com/D149937
2022-06-22 16:47:06 +00:00
Bogdan Szekely
72726c29d0 Backed out changeset 7b707ff8a7d1 (bug 1769154) for causing xpcshell failures on test_system_upgrades.js 2022-06-22 17:17:10 +03:00
Joel Maher
c0af767fd4 Bug 1769154 - Run some xpcshell tests with a conditioned profile. r=aryx,extension-reviewers,kmag
Differential Revision: https://phabricator.services.mozilla.com/D149937
2022-06-22 13:03:46 +00:00
Joel Maher
01d9fd61d4 Bug 1769257 - run a subset of mochitests with a conditioned profile. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D148651
2022-06-10 19:57:36 +00:00
Mark Banner
ea07246325 Bug 1770727 - Fix remaining ESLint rules for sjs files. r=Gijs,necko-reviewers,kershaw
Depends on D147082

Differential Revision: https://phabricator.services.mozilla.com/D147083
2022-06-07 19:14:09 +00:00
Mark Banner
d9a3157f4e Bug 1770727 - Fix failures of ESLint rule mozilla/use-includes-instead-of-indexOf in sjs files. r=Gijs
Depends on D147081

Differential Revision: https://phabricator.services.mozilla.com/D147082
2022-06-07 19:14:08 +00:00
Mark Banner
347474e794 Bug 1770727 - Fix some more ESLint rules on sjs files. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D147080
2022-06-07 19:14:08 +00:00
Molnar Sandor
84cba2a6db Backed out 4 changesets (bug 1770727) for causing mochitest failures in test_bug1180105/test_access_control. CLOSED TREE
Backed out changeset 6323b526b0ac (bug 1770727)
Backed out changeset fc7ea80aa2ff (bug 1770727)
Backed out changeset 2a358ba86652 (bug 1770727)
Backed out changeset 464d1af6523b (bug 1770727)
2022-05-24 17:24:40 +03:00
Mark Banner
3a1785495f Bug 1770727 - Fix remaining ESLint rules for sjs files. r=Gijs,necko-reviewers,kershaw
Depends on D147082

Differential Revision: https://phabricator.services.mozilla.com/D147083
2022-05-24 12:59:10 +00:00
Mark Banner
9bc6698ada Bug 1770727 - Fix failures of ESLint rule mozilla/use-includes-instead-of-indexOf in sjs files. r=Gijs
Depends on D147081

Differential Revision: https://phabricator.services.mozilla.com/D147082
2022-05-24 12:59:09 +00:00
Mark Banner
2b13cf4485 Bug 1770727 - Fix some more ESLint rules on sjs files. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D147080
2022-05-24 12:59:08 +00:00
Norisz Fay
65fc7c27f9 Bug 1769828 - Fix lint failure in test_dbservice.js r=fix CLOSED TREE 2022-05-19 16:36:17 +03:00
Dimi
4d3c63fd4f Bug 1769825 - Enable SafeBrowsing features when running test in test_classifier.html r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D146613
2022-05-19 12:41:11 +00:00
Dimi
c81559cca2 Bug 1769828 - Do not assume there is only test tables when running test_dbservice.js r=timhuang
This patch uses Array.includes instead of exact matching to check
whether the test table is present.
This is to address the problem when there is other safe browsing tables
, the testcase fails because `parts` variable contains all the tables.

Differential Revision: https://phabricator.services.mozilla.com/D146614
2022-05-19 12:39:53 +00:00
Mark Banner
cc09541457 Bug 1769569 - Automatically replace Components.* with C* in sjs files. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D146451
2022-05-18 08:13:19 +00:00
Sebastian Hengst
e8e4f38731 Backed out 5 changesets (bug 1769569) for causing devtools' browser/browser_page_redirection.js to fail. CLOSED TREE
Backed out changeset 66a42eb3a366 (bug 1769569)
Backed out changeset d3cc9629cd9a (bug 1769569)
Backed out changeset edcd3dade079 (bug 1769569)
Backed out changeset 29d8dd058b7a (bug 1769569)
Backed out changeset 1aed34fdf2d3 (bug 1769569)
2022-05-17 19:49:17 +02:00
Mark Banner
82aef582ff Bug 1769569 - Automatically replace Components.* with C* in sjs files. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D146451
2022-05-17 16:50:33 +00:00
lyavor
d77f6d400a Bug 1767952 - Update all .sjs test files that use base64ToString() instead of atob. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D145701
2022-05-13 12:20:23 +00:00
Norisz Fay
859fb66266 Backed out changeset 31a206537bb6 (bug 1767952) for causing lint failure on authenticate.sjs CLOSED TREE 2022-05-12 17:47:13 +03:00
lyavor
a66a97d43e Bug 1767952 - Update all .sjs test files that use base64ToString() instead of atob. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D145701
2022-05-12 13:58:24 +00:00
Mathieu Leplatre
9c4746ef13 Bug 1767890 - Prevent packaged dump from being loaded r=robwu
Change tests and snippets in documentation to use `Date.now()` instead of an arbitrary number like `42`.
This way, we make sure the packaged dump isn't loaded on top of the tests data. Indeed, since Bug 1718083 we load the packaged dump if it's newer than local data.

Differential Revision: https://phabricator.services.mozilla.com/D145579
2022-05-10 09:51:50 +00:00
Nika Layzell
d10ace1831 Bug 1761511 - Part 5: Fix gtest deprecation warnings, r=ahal
The TEST_CASE_P macros are deprecated in newer versions of gtest.

Differential Revision: https://phabricator.services.mozilla.com/D142612
2022-04-14 02:09:22 +00:00
Cosmin Sabou
46df1845ed Backed out 5 changesets (bug 1761511) for causing build bustages. CLOSED TREE
Backed out changeset 687de8c00013 (bug 1761511)
Backed out changeset 88e6cf5c70e5 (bug 1761511)
Backed out changeset 4c40758f54f1 (bug 1761511)
Backed out changeset 8a18abcccda4 (bug 1761511)
Backed out changeset 1afb1f32a6a4 (bug 1761511)
2022-04-07 00:13:00 +03:00
Nika Layzell
f105462911 Bug 1761511 - Part 5: Fix gtest deprecation warnings, r=ahal
The TEST_CASE_P macros are deprecated in newer versions of gtest.

Differential Revision: https://phabricator.services.mozilla.com/D142612
2022-04-06 20:45:08 +00:00
Frederik Braun
3b6457c94b Bug 1752475 - Change nsICookie/CookieStruct to implicitly flip SameSite in getter func r=dveditz,dragana,freddyb
Given that we only support samesite lax/strict/none in our storage schema,
it's useful to introduce a default value, as required by the spec.
However, that would it hard to distinguish between none/lax when we switch
the default.
So, instead of doing that we use the peculiarities of our current schema
to our advantage: There's a "sameSite" attribute and a "rawSameSite"
attribute, where the latter is the literal value we received from the
server. With this patch, we'll interpret the "sameSite" attribute
based on the laxByDefault pref. This also has the advantage that various
front-end code (e.g., in DevTools) is always reading the "sameSite"
value of nsICookies.

Differential Revision: https://phabricator.services.mozilla.com/D137460
2022-04-05 08:20:25 +00:00
Tim Huang
33f7474029 Bug 1750025 - Make the test test_classify_by_default.html using the correct cookie behavior. r=dimi
The testing cookies are set on the first test page that will be using
the default cookie behavior instead of the one that the test sets. To
fix this, we open a new window to set up the testing cookies, so that it
will be set under the correct cookie behavior.

Differential Revision: https://phabricator.services.mozilla.com/D136735
2022-01-26 08:51:11 +00:00
Nika Layzell
dc116daf53 Bug 1749059 - Remove Quantum DOM support from IPDL, r=ipc-reviewers,mccr8
This is no longer necessary as the Quantum DOM project is no longer
happening, and removing support simplifies various components inside of
IPDL.

As some code used the support to get a `nsISerialEventTarget` for an
actor's worker thread, that method was replaced with a method which
instead pulls the nsISerialEventTarget from the MessageChannel and
should work on all actors.

Differential Revision: https://phabricator.services.mozilla.com/D135411
2022-01-25 20:29:46 +00:00
Henri Sivonen
a8ed2707bb Bug 1701828 - meta charset rewrite. r=smaug
Implements https://github.com/whatwg/html/issues/6962 . Improves performance
when <meta charset> occurs in head but after the first kilobyte and aligns
behavior better with WebKit and Blink.

The main change is to avoid reloads when meta appears within head but
after the first kilobyte. Prior to this change, Gecko reloaded in that
case (in compliance with the spec!) even though WebKit and Blink did not.

Differences from WebKit and Blink:

* WebKit and Blink honor <meta charset> in <noscript>. This implementation
  does not.
* WebKit and Blink look for meta as if the tree builder was unaware of
  foreign content. This implementation is foreign content-aware. This
  makes a difference for CDATA sections that contain a > before the meta
  as well as style and script elements within foreign content. This could
  happen if the CDATA section that has mysteriously been introduced around
  a what looks like a meta tag also contains another prior tag-looking
  run of text.
* This implementation processes rel=preload and speculative loads that are
  seen before <meta charset> has been seen. WebKit and Blink instead first
  look for the meta and rewind before starting speculative parsing.
* Unlike WebKit, if there is neither an honored meta nor syntax resembling
  an XML declaration, detection from content takes place (as in Blink).
* Unlike Blink, if there is neither an honored meta nor syntax resembling
  an XML declaration, the detection from content is not dependent of network
  buffer boundaries.
* Unlike Blink, detection from content can trigger a reload at the end of
  the stream if the guess made at that point differs from the first guess.
  (See below for the definition of the input to the first guess.)

Differences from the old spec and Gecko previously:

* Meta inside script and RCDATA elements is no longer honored.
* Late meta is now ignored and no longer triggers a reload.
* Later meta counts as early enough meta: In addition to the previous
  meta within the first 1024 bytes, now a meta that started within the first
  1024 bytes counts as early enough. Additionally, if by then there hasn't
  been a template start tag and head hasn't ended, meta occurring before the
  earlier of the end of the head or a template start tag counts as early
  enough.
* Meta now counts as not-late even if the encoding label has numeric
  character reference escapes.
* Syntax resembling an XML declaration longer than a kilobyte is honored if
  there is no honored meta.
* If there is neither an honored meta nor syntax resembling an XML declaration,
  the initial chardetng scan is potentially longer than before: the first 1024
  bytes, the token spanning the 1024-byte boundary if there is such a token,
  and, if by then head hasn't ended and there hasn't been a template start tag
  until the end of the template start tag or the end of the token that causes
  head to end, ever comes first. However, if the token implying the end of the
  head is a text token, bytes only to the end of the previous non-text token is
  considered. (This definition avoids depending on network buffer boundaries.)
* XML View Source now uses the code for syntax resembling an XML declaration
  instead of expat for extracting the internal encoding label.

Reftest are added as both WPT and Gecko reftests in order to test both http:
and file: URL scenarios. The Gecko tests retain the WPT <link> tags in order
to use the exact same bytes.

An encoding declaration has been added to a number of old tests that didn't
intend to test the new speculation behavior especially in the context of
https://bugzilla.mozilla.org/show_bug.cgi?id=1727750 .

Differential Revision: https://phabricator.services.mozilla.com/D125808
2021-12-08 11:34:20 +00:00
Norisz Fay
e844dde8a6 Backed out changeset 3dfd3c94a105 (bug 1701828) for causing mochitest failures on browser_hsts_host.js CLOSED TREE 2021-12-07 12:05:44 +02:00
Henri Sivonen
37fade70f0 Bug 1701828 - meta charset rewrite. r=smaug
Implements https://github.com/whatwg/html/issues/6962 . Improves performance
when <meta charset> occurs in head but after the first kilobyte and aligns
behavior better with WebKit and Blink.

The main change is to avoid reloads when meta appears within head but
after the first kilobyte. Prior to this change, Gecko reloaded in that
case (in compliance with the spec!) even though WebKit and Blink did not.

Differences from WebKit and Blink:

* WebKit and Blink honor <meta charset> in <noscript>. This implementation
  does not.
* WebKit and Blink look for meta as if the tree builder was unaware of
  foreign content. This implementation is foreign content-aware. This
  makes a difference for CDATA sections that contain a > before the meta
  as well as style and script elements within foreign content. This could
  happen if the CDATA section that has mysteriously been introduced around
  a what looks like a meta tag also contains another prior tag-looking
  run of text.
* This implementation processes rel=preload and speculative loads that are
  seen before <meta charset> has been seen. WebKit and Blink instead first
  look for the meta and rewind before starting speculative parsing.
* Unlike WebKit, if there is neither an honored meta nor syntax resembling
  an XML declaration, detection from content takes place (as in Blink).
* Unlike Blink, if there is neither an honored meta nor syntax resembling
  an XML declaration, the detection from content is not dependent of network
  buffer boundaries.
* Unlike Blink, detection from content can trigger a reload at the end of
  the stream if the guess made at that point differs from the first guess.
  (See below for the definition of the input to the first guess.)

Differences from the old spec and Gecko previously:

* Meta inside script and RCDATA elements is no longer honored.
* Late meta is now ignored and no longer triggers a reload.
* Later meta counts as early enough meta: In addition to the previous
  meta within the first 1024 bytes, now a meta that started within the first
  1024 bytes counts as early enough. Additionally, if by then there hasn't
  been a template start tag and head hasn't ended, meta occurring before the
  earlier of the end of the head or a template start tag counts as early
  enough.
* Meta now counts as not-late even if the encoding label has numeric
  character reference escapes.
* Syntax resembling an XML declaration longer than a kilobyte is honored if
  there is no honored meta.
* If there is neither an honored meta nor syntax resembling an XML declaration,
  the initial chardetng scan is potentially longer than before: the first 1024
  bytes, the token spanning the 1024-byte boundary if there is such a token,
  and, if by then head hasn't ended and there hasn't been a template start tag
  until the end of the template start tag or the end of the token that causes
  head to end, ever comes first. However, if the token implying the end of the
  head is a text token, bytes only to the end of the previous non-text token is
  considered. (This definition avoids depending on network buffer boundaries.)
* XML View Source now uses the code for syntax resembling an XML declaration
  instead of expat for extracting the internal encoding label.

Reftest are added as both WPT and Gecko reftests in order to test both http:
and file: URL scenarios. The Gecko tests retain the WPT <link> tags in order
to use the exact same bytes.

An encoding declaration has been added to a number of old tests that didn't
intend to test the new speculation behavior especially in the context of
https://bugzilla.mozilla.org/show_bug.cgi?id=1727750 .

Differential Revision: https://phabricator.services.mozilla.com/D125808
2021-12-07 07:35:32 +00:00
Niklas Goegge
4e4ae334a9 Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
2021-11-17 11:04:34 +00:00
criss
350a48be09 Backed out 2 changesets (bug 1617611) for causing mochitest failures on storageAccessWithDynamicFpi.js. CLOSED TREE
Backed out changeset fdb2c6bfc0c6 (bug 1617611)
Backed out changeset c3352f4b3681 (bug 1617611)
2021-11-16 13:02:05 +02:00
Niklas Goegge
76c2b4259c Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
2021-11-16 10:15:45 +00:00
Christoph Kerschbaumer
9feca6c264 Bug 1737262: Update tests within toolkit/components/url-classifier/tests/mochitest to work with https-first enabled r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D129260
2021-11-02 07:38:09 +00:00
Riya
98b768ee4a Bug 1730126 - Enable ESLint rule no-loss-of-precision. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D129336
2021-10-29 08:29:26 +00:00
Evgenia Kotovich
685e68c48b Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-18 09:26:33 +00:00
Noemi Erli
b1ebbba564 Backed out changeset 2ab6bb03dcc1 (bug 1576768) for causing failures in test_double_submit.html CLOSED TREE 2021-10-18 02:05:57 +03:00
Evgenia Kotovich
59d14912a7 Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-17 14:59:14 +00:00
Alexandru Michis
fdd29e992c Backed out changeset 7c08aa027893 (bug 1576768) for causing multiple failures.
CLOSED TREE
2021-10-15 16:52:43 +03:00
Evgenia Kotovich
8d5d1cda5f Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-15 12:58:11 +00:00
Jens Stutte
e7d28b3e05 Bug 1731564: Use motivated SpinEventLoopUntil inside toolkit/*. r=Gijs
Depends on D127233

Differential Revision: https://phabricator.services.mozilla.com/D127234
2021-10-07 08:06:15 +00:00
Marian-Vasile Laza
7de6967c5a Backed out 18 changesets (bug 1731564) for causing build bustages on SpinEventLoopUntil. CLOSED TREE
Backed out changeset 0464dbdc8584 (bug 1731564)
Backed out changeset 0d996df13545 (bug 1731564)
Backed out changeset 5630a0e7a109 (bug 1731564)
Backed out changeset 37b41d187cdb (bug 1731564)
Backed out changeset d37700fa60b6 (bug 1731564)
Backed out changeset b0ce7db44b99 (bug 1731564)
Backed out changeset aa5ec3aa1535 (bug 1731564)
Backed out changeset 73b648f1fa70 (bug 1731564)
Backed out changeset bb8fb0f9833e (bug 1731564)
Backed out changeset 0d8905144f5d (bug 1731564)
Backed out changeset 2cfb094a1ec3 (bug 1731564)
Backed out changeset 78d3b0257a6a (bug 1731564)
Backed out changeset e9d32926e93c (bug 1731564)
Backed out changeset 874cab520ce5 (bug 1731564)
Backed out changeset d8071cc32bd9 (bug 1731564)
Backed out changeset 283c5393cbbc (bug 1731564)
Backed out changeset 317bc38e3de5 (bug 1731564)
Backed out changeset 53e3f4862439 (bug 1731564)
2021-10-07 00:09:19 +03:00
Jens Stutte
25eeb7d613 Bug 1731564: Use motivated SpinEventLoopUntil inside toolkit/*. r=Gijs
Depends on D127233

Differential Revision: https://phabricator.services.mozilla.com/D127234
2021-10-06 19:45:17 +00:00
Andi-Bogdan Postelnicu
f221c438ca Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium
Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.

This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.

Differential Revision: https://phabricator.services.mozilla.com/D122345
2021-08-25 10:46:17 +00:00
Tim Huang
34f103bb6c Bug 1698195 - Part 2: Enable test_classifier.html for fission. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D122518
2021-08-13 09:32:36 +00:00
Tim Huang
7283251594 Bug 1698195 - Part 1: Change the test domain to mochi.test for test_classifier.html to comply with principal vetting. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D122517
2021-08-13 09:32:36 +00:00
Christoph Kerschbaumer
3c12a4bedc Bug 1723115: Update tests within toolkit/components to work with https-first enabled r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D121365
2021-07-30 13:50:59 +00:00
Christoph Kerschbaumer
84559c5091 Bug 1711918: Update PBM tests within toolkit/components/url-classifier/ to work with https-first-mode enabled r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D115499
2021-05-20 09:12:19 +00:00
Paul Zuehlcke
e7228cfa51 Bug 1699668 - Tests for shim warning. r=webcompat-reviewers,johannh,denschub
Differential Revision: https://phabricator.services.mozilla.com/D109718
2021-04-13 16:11:21 +00:00