Commit Graph

1536 Commits

Author SHA1 Message Date
Anny Gakhokidze
e1bf9e611c Bug 1646356 - Wait for hashchange event in a different way for browser_sessionHistory.js, r=kashav
Differential Revision: https://phabricator.services.mozilla.com/D119458
2021-07-09 20:58:17 +00:00
Alexandru Michis
89e1d83836 Bug 1638958 - Disable browser_label_and_icon.js on OS X 10.15 for frequent failures. r=intermittent-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D118297
2021-06-26 21:23:31 +00:00
Kashav Madan
3b6f8b305d Bug 1703692 - Update SessionStore and TabState{,Cache} functions to take a permanentKey, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D118541
2021-06-26 20:25:29 +00:00
Dorel Luca
c293dee662 Backed out 3 changesets (bug 1703692) for Browser-chrome failures in browser/components/sessionstore/test/browser_broadcast.js. CLOSED TREE
Backed out changeset fe5703d7b580 (bug 1703692)
Backed out changeset eec4a4138ca7 (bug 1703692)
Backed out changeset 6745b363a745 (bug 1703692)
2021-06-26 10:09:23 +03:00
Kashav Madan
d3a7f8a79a Bug 1703692 - Update SessionStore and TabState{,Cache} functions to take a permanentKey, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D118541
2021-06-26 05:49:12 +00:00
Anny Gakhokidze
3325abe58b Bug 1646356 - Add extra logs to browser_sessionHistory.js, r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D118867
2021-06-25 21:10:50 +00:00
Iulian Moraru
6f300817be Backed out 3 changesets (bug 1703692) for causing bc failures on multiple files.
Backed out changeset a199dfd8ce8d (bug 1703692)
Backed out changeset 599a0a99ded9 (bug 1703692)
Backed out changeset 14fe807e6be4 (bug 1703692)
2021-06-25 00:43:23 +03:00
Kashav Madan
7728d0686d Bug 1703692 - Update SessionStore and TabState{,Cache} functions to take a permanentKey, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D118541
2021-06-24 20:26:14 +00:00
Kashav Madan
16ff97f61f Bug 1713900 - Remove platform-specific Fission sessionstore annotations from bug 1694824, r=neha
Most of these fail very rarely (if at all), and the ones that do already have
intermittent bugs filed.

See comment #6.

Differential Revision: https://phabricator.services.mozilla.com/D118005
2021-06-16 16:26:42 +00:00
Kashav Madan
d2b4f475d7 Bug 1701337 - Respect browser.sessionstore.debug.no_auto_updates in native flushers, r=nika
We should not be doing any timed flushes if the pref is set to true.

See https://searchfox.org/mozilla-central/rev/d97dca5907e2a0a77a2435b24ef980268cd3c4fe/browser/components/sessionstore/ContentSessionStore.jsm#402
for how the pref is used in non-SHIP code.

Fixes browser_async_window_flushing.js, which relies on us not sending automatic
updates.

Differential Revision: https://phabricator.services.mozilla.com/D117953
2021-06-16 00:37:53 +00:00
Anny Gakhokidze
c2b1603140 WIP: Bug 1713713 - Remove pref that decides if OriginAttributes should be used in a remote type r=nika
Differential Revision: https://phabricator.services.mozilla.com/D117926
2021-06-16 00:31:15 +00:00
Kashav Madan
ad9c02d578 Bug 1715852 - Fix SessionHistoryEntry::mSrcdocData to work with session restore, r=peterv
Not setting mIsSrcdocEntry causes us to drop srcdoc data and not set
INTERNAL_LOAD_FLAGS_IS_SRCDOC in FillLoadInfo for srcdoc restores.

Differential Revision: https://phabricator.services.mozilla.com/D117479
2021-06-15 13:34:01 +00:00
Kris Maglione
799bf19224 Bug 1646560: Part 2 - Move allowJavascript and friends from DocShell to BrowsingContext and WindowContext. r=jdescottes,nika,geckoview-reviewers,devtools-backward-compat-reviewers,agi
This is slightly complicated by the fact that the editor code wants to be able
to set this from the content process, so we really need separate
BrowsingContext and WindowContext flags, the latter of which can be set by the
owning process.

Differential Revision: https://phabricator.services.mozilla.com/D114899
2021-06-15 04:40:11 +00:00
Ed Lee
5e8f1563a8 Bug 1633883 - TelemetryTestUtils.assertScalar assumes Number (so behaves odd for boolean, strings) r=chutten
Split assertScalar to assertScalarUnset to allow the former to plain check the value including strings, false and 0.

Differential Revision: https://phabricator.services.mozilla.com/D117457
2021-06-11 21:06:26 +00:00
Anny Gakhokidze
819beec24f Bug 1709136 - Part 2: Update SessionHistoryEntry in ReplaceLoadingSessionHistoryEntryForLoad, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D117238
2021-06-11 20:12:10 +00:00
Anny Gakhokidze
f50e5a2271 Bug 1709136 - Part 1: Remove the explicit remoteness switch that happens during the restore process, r=nika,kashav
Differential Revision: https://phabricator.services.mozilla.com/D116209
2021-06-11 20:12:10 +00:00
Kashav Madan
05ebd073f0 Bug 1715264 - Fix browser_async_remove_tab.js for SHIP, r=farre
Relies on frame script message ordering.

Differential Revision: https://phabricator.services.mozilla.com/D117233
2021-06-10 14:31:00 +00:00
Kashav Madan
a3884cf2cb Bug 1715264 - Fix browser_async_flushes.js for SHIP, r=farre
Relies on frame script message ordering.

Differential Revision: https://phabricator.services.mozilla.com/D117232
2021-06-10 14:31:00 +00:00
Kashav Madan
f333797e09 Bug 1715264 - Remove annotations for browser_sessionHistory.js, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D117231
2021-06-10 14:30:59 +00:00
Andreas Farre
7f00bb04af Bug 1710004 - Part 3: Restore session storage from the parent process. r=kashav,asuth
Depends on D116007

Differential Revision: https://phabricator.services.mozilla.com/D116213
2021-06-08 13:42:33 +00:00
Andreas Farre
4ae50334b4 Bug 1710004 - Part 1: Remove dataset concept from Session Storage. r=asuth
Session Storage used to share implementation with Local Storage, where
a distinction of a default data set from a session data set made
sense. In Session Storage all data is actually scoped by the
session. Since Bug 1322316 Session Storage no longer share
implementation with Local Storage, which makes it safe to collapse the
datasets in Session Storage to one dataset, which makes life easier,
especially for Session (Re-)Store.

Differential Revision: https://phabricator.services.mozilla.com/D116609
2021-06-08 13:42:33 +00:00
Butkovits Atila
062f432f2a Bug 1713975 - disable browser_sessionHistory.js on Linux_opt for frequent failures. r=intermittent-reviewers,bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D116944
2021-06-07 20:00:20 +00:00
Andrew Halberstadt
b3eb1cd91a Bug 1714225 - Expand skip annotation in 'browser_async_remove_tab.js' for MacOS fission perma-fail, r=intermittent-reviewers,bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D117019
2021-06-07 15:16:58 +00:00
Andrew Halberstadt
0e38db81bd Bug 1714225 - Skip 'browser/components/sessionstore/test/browser_async_remove_tab.js' on Windows fission for perma-fail, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D116731
2021-06-03 17:51:38 +00:00
Andrew Halberstadt
cbd804bdc5 Bug 1694824 - [ci] Annotate browser-chrome manifests for new fission failures, r=jmaher,extension-reviewers,preferences-reviewers,zombie
Differential Revision: https://phabricator.services.mozilla.com/D116276
2021-06-02 19:22:25 +00:00
Kashav Madan
e4319dbdca Bug 1706445 - Fix test helpers that use "SessionStore:update", r=nika,perftest-reviewers,sparky
Also skips a frame script OOM test for Fission.

Differential Revision: https://phabricator.services.mozilla.com/D115930
2021-06-01 20:06:48 +00:00
Andreas Farre
6363db0f16 Bug 1713098 - Make modifySessionStorage use browsing context to get subframe. r=kashav
Differential Revision: https://phabricator.services.mozilla.com/D116102
2021-05-28 07:48:51 +00:00
Andreas Farre
f48f673e2a Part 3: Bug 1700623 - Used TabStateFlusher.flush to guarantee session store state. r=kashav
Depends on D111429

Differential Revision: https://phabricator.services.mozilla.com/D111430
2021-05-26 07:14:04 +00:00
Alexandru Michis
26d8e32b13 Backed out 9 changesets (bug 1700623) for causing bc failures in browser_history_menu.js
CLOSED TREE

Backed out changeset 5eae296ad8b5 (bug 1700623)
Backed out changeset 97c3add3b00a (bug 1700623)
Backed out changeset 7ab483627a27 (bug 1700623)
Backed out changeset a4e673640de5 (bug 1700623)
Backed out changeset 513ea16be430 (bug 1700623)
Backed out changeset 88b4add342df (bug 1700623)
Backed out changeset c13bdee1b526 (bug 1700623)
Backed out changeset 26df421dac02 (bug 1700623)
Backed out changeset 6cd0b7a269e5 (bug 1700623)
2021-05-21 11:43:54 +03:00
Andreas Farre
78a8e64c47 Part 3: Bug 1700623 - Used TabStateFlusher.flush to guarantee session store state. r=kashav
Depends on D111429

Differential Revision: https://phabricator.services.mozilla.com/D111430
2021-05-20 12:48:21 +00:00
Anny Gakhokidze
c8002511a8 Bug 1707138 - Don't send session store updates after we start process switching, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D115015
2021-05-18 20:01:55 +00:00
Anny Gakhokidze
f97d657a0f Bug 1703326 - Stop relying on ContentSessionStore for SessionStore:crashedTabRevived, r=kashav
Differential Revision: https://phabricator.services.mozilla.com/D113425
2021-05-12 19:33:47 +00:00
Kashav Madan
72326e982d Bug 1703556 - Wait for individual SSTabRestored events before proceeding, r=annyG
Awaiting setWindowState doesn't actually work here, since we fire the
SSWindowRestored event before the tabs finish restoring (bug 1709411 to rename
the event). It works to just wait for the individual SSTabRestored events, since
we'll only fire those after each tab is restored.

Differential Revision: https://phabricator.services.mozilla.com/D114261
2021-05-06 13:55:15 +00:00
Kashav Madan
20acb75b2d Bug 1702055 - Fix how the expected SSTabRestored count is calculated in waitForBrowserState, r=nika
SessionStore factors both prefs into the decision about if a tab is restored
lazily, but this helper only uses the `restore_tabs_lazily` pref.

Depends on D114001

Differential Revision: https://phabricator.services.mozilla.com/D114002
2021-05-03 18:16:42 +00:00
Kashav Madan
2fdef46f8f Bug 1690134 - Fix flakiness in browser_history_persist.js, r=annyG
Waiting for the about:robots load explicitly ensures we don't proceed until all
history changes have fully propagated.

Differential Revision: https://phabricator.services.mozilla.com/D113686
2021-04-28 21:49:15 +00:00
Kashav Madan
4abf228317 Bug 1696137 - Fix timeouts in browser_reopen_all_windows.js, r=annyG
We currently wait for the "sessionstore-single-window-restored" notification and
*then* start listening for individual "SSTabRestored" events. This doesn't work
because we may fire those events before we get the chance to create the listener.

Listening for "browser-window-before-show" works consistently, but we need
references to the windows *before* they start restoring, so we have
to manually run the "Restore All Windows" code, instead of clicking the Library
button.

Originally part of the patch stack for bug 1703556.

Differential Revision: https://phabricator.services.mozilla.com/D112887
2021-04-26 18:08:11 +00:00
Joel Maher
5a5bc0c176 Bug 1706716 green up mda, xpcshell, browser-chrome, reftest for apple silicon. r=necko-reviewers,extension-reviewers,preferences-reviewers,application-update-reviewers,zombie,ahal,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D113001
2021-04-22 18:39:40 +00:00
Anny Gakhokidze
b5550e7d69 Bug 1701735 - Skip browser_scrollPositions.js when fission is disabled, r=nika
We have fixed this test previously for fission, and it's only failing without
it.

Differential Revision: https://phabricator.services.mozilla.com/D113044
2021-04-22 17:42:10 +00:00
Kashav Madan
991fe1e4cc Bug 1702797 - Split up the SingleSelect and MultipleSelect cases in RestoreFormEntry, r=nika
A document that changes the "multiple" attribute of the <select> element after
the load event (eg., perhaps in response to user action) will crash the browser
since we will attempt to restore data collected for a multi-select into a
single-select.

Differential Revision: https://phabricator.services.mozilla.com/D112057
2021-04-20 16:01:10 +00:00
Alexandru Michis
922ef41b13 Backed out changeset ead1910420a0 (bug 1702797) for causing bc failures in browser_multiple_select_after_load.js
CLOSED TREE
2021-04-16 19:42:35 +03:00
Kashav Madan
4180e5f2c6 Bug 1702797 - Split up the SingleSelect and MultipleSelect cases in RestoreFormEntry, r=nika
A document that changes the "multiple" attribute of the <select> element after
the load event (eg., perhaps in response to user action) will crash the browser
since we will attempt to restore data collected for a multi-select into a
single-select.

Differential Revision: https://phabricator.services.mozilla.com/D112057
2021-04-16 15:59:27 +00:00
Kashav Madan
67b28ebc8d Bug 1704553 - Fix browser_frametree.js and browser_sessionHistory.js for BFCache+Fission, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D111685
2021-04-12 17:05:29 +00:00
Anny Gakhokidze
780445a687 Bug 1698601 - Part 1: Extend existing session store test files with COOP document testing, r=smaug
Modify related test files to test documents with COOP headers enabled.

There are some tests that fail when run with new COOP configurations without
Fission enabled, prior to fixes that come in part 2. This means that some of
the COOP behaviour was already broken. Since fixing non-Fission COOP
behaviour prior to this patch is out of scope, I skipped calling `addCoopTask`
to test COOP documents in non Fission cases for such tests.

Even with COOP headers disabled, some tests fail when the document they load
is served over httpS and not http. For a single test where this behaviour was
occuring prior to fixes in part 2, I skipped testing an HTTPS non-COOP
document and filed 1703351 to fix such behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D110993
2021-04-09 17:46:52 +00:00
Kashav Madan
0d84c0d1e4 Bug 1602687 - Re-enable some sessionstore tests, r=farre
These were fixed by bug 1572084 and bug 1597499. Two are still skipped and will
be fixed in bug 1700623 and bug 1703556.

Differential Revision: https://phabricator.services.mozilla.com/D110999
2021-04-07 15:30:26 +00:00
Gijs Kruitbosch
baf37ddb29 Bug 1701202 - fix some browser mochitests to pass with proton enabled, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D109910
2021-03-26 21:37:18 +00:00
Csoregi Natalia
e4acbbb296 Backed out changeset d885acd20f7e (bug 1701202) for causing failures on browser_synced_tabs_menu.js. CLOSED TREE 2021-03-26 21:42:09 +02:00
Gijs Kruitbosch
31c59a7040 Bug 1701202 - fix some browser mochitests to pass with proton enabled, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D109910
2021-03-26 17:13:27 +00:00
Anny Gakhokidze
af797a1153 Bug 1698104 - Fix session restore for about:reader, r=nika,kashav
Implement an observer to wait for correct window events in order to restore tab
content.  Non-SHIP code restores about:reader scroll position after receiving
"AboutReaderContentReady" event, so to achieve the same thing with session
history in parent enabled, we can wait for "AboutReader:Ready" event.

Differential Revision: https://phabricator.services.mozilla.com/D108712
2021-03-23 18:01:23 +00:00
Kashav Madan
86731a9e7f Bug 1597499 - Enable some sessionstore Fission/SHIP tests, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D108693
2021-03-23 18:01:22 +00:00
smolnar
ede838631a Backed out 4 changesets (bug 1597499) for causing Fission crashes (bug 1699349). a=backout
Backed out changeset 0df7b8660446 (bug 1597499)
Backed out changeset d015ba9097c5 (bug 1597499)
Backed out changeset e84054ccadb0 (bug 1597499)
Backed out changeset 12762a25c4fa (bug 1597499)
2021-03-18 11:29:08 +02:00