Commit Graph

71 Commits

Author SHA1 Message Date
Michelle Goossens
03efbb72dc Bug 1714349 - Remove browser.proton.modals.enabled pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D116903
2021-06-11 18:14:26 +00:00
Dorel Luca
a209313c07 Backed out 3 changesets (bug 1714349) for Browser-chrome failures in browser/components/places/tests/browser/browser_addBookmarkForFrame.js. CLOSED TREE
Backed out changeset 598f8e7d73ef (bug 1714349)
Backed out changeset cc7365aacdbb (bug 1714349)
Backed out changeset f0f942a93495 (bug 1714349)
2021-06-09 04:48:41 +03:00
Michelle Goossens
eb770bc002 Bug 1714349 - Remove browser.proton.modals.enabled pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D116903
2021-06-08 22:16:33 +00:00
Michelle Goossens
3c5cf97d9b Bug 1714352 - Remove browser.proton.doorhangers.enabled pref r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D117091
2021-06-08 00:41:43 +00:00
Mark Banner
f144cfcf62 Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D115233
2021-05-18 16:27:44 +00:00
Daisuke Akatsuka
e17f7bc3a8 Bug 1511062: Remove onItemMoved from nsINavBookmarkObserver. r=mak
Depends on D102574

Differential Revision: https://phabricator.services.mozilla.com/D102575
2021-05-06 04:24:35 +00:00
Daisuke Akatsuka
9dd25c8501 Bug 1511062: Apply bookmark-moved event. r=mak
Depends on D102573

Differential Revision: https://phabricator.services.mozilla.com/D102574
2021-05-06 04:24:35 +00:00
Daisuke Akatsuka
d117f59c8f Bug 1511062: Remove old/new parent id from onItemMoved in nsINavBookmarkObserver. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D102572
2021-05-06 04:24:34 +00:00
Csoregi Natalia
ce52bc5e1a Backed out 4 changesets (bug 1511062) for causing bustage on nsNavHistoryResult.cpp. CLOSED TREE
Backed out changeset ed9ac8c3097b (bug 1511062)
Backed out changeset dc8c9488cf1a (bug 1511062)
Backed out changeset 2cf6fca33bf3 (bug 1511062)
Backed out changeset 87b0bbbcb0e6 (bug 1511062)
2021-05-06 05:53:12 +03:00
Daisuke Akatsuka
28b00086fd Bug 1511062: Remove onItemMoved from nsINavBookmarkObserver. r=mak
Depends on D102574

Differential Revision: https://phabricator.services.mozilla.com/D102575
2021-05-06 02:29:44 +00:00
Daisuke Akatsuka
cf9542ed5b Bug 1511062: Apply bookmark-moved event. r=mak
Depends on D102573

Differential Revision: https://phabricator.services.mozilla.com/D102574
2021-05-06 02:29:44 +00:00
Daisuke Akatsuka
43e96443cc Bug 1511062: Remove old/new parent id from onItemMoved in nsINavBookmarkObserver. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D102572
2021-05-06 02:29:43 +00:00
Csoregi Natalia
010df0501b Backed out changeset e01ec8694924 (bug 1700957) as requested. CLOSED TREE 2021-04-28 18:09:01 +03:00
Emma Malysz
91c90b996d Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 03:17:56 +00:00
Butkovits Atila
e3f5ddbc25 Backed out changeset 1c362512f27b (bug 1700957) for causing failures at test_chrome_only_media_queries.html. CLOSED TREE 2021-04-28 05:55:14 +03:00
Emma Malysz
75fb2ad086 Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 00:29:45 +00:00
Neil Deakin
9ea279221e Bug 1703002, don't scroll when focusing the textbox in the edit bookmark panel, r=mak
Note that Element.select() always focuses the element without scrolling, so the call to focus()
is redundant, but we'll leave it in anyway in case that changes.

Differential Revision: https://phabricator.services.mozilla.com/D111114
2021-04-08 13:32:45 +00:00
Mike Conley
553db97ffc Bug 1697507 - Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
This updates the styling of the Bookmarks Panel for Proton, and also:

* Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
* Makes text input elements in panels be 32px tall, per spec

Depends on D109376

Differential Revision: https://phabricator.services.mozilla.com/D109638
2021-03-30 17:51:58 +00:00
Dorel Luca
56872eef65 Backed out 2 changesets (bug 1697507, bug 1697491) for Browser-chrome in browser/components/places/tests/browser/browser_bookmark_remove_tags.js. CLOSED TREE
Backed out changeset 83a561e6c1d0 (bug 1697507)
Backed out changeset 319022b89093 (bug 1697491)
2021-03-30 20:17:13 +03:00
Mike Conley
2699b0b497 Bug 1697507 - Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
This updates the styling of the Bookmarks Panel for Proton, and also:

* Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
* Makes text input elements in panels be 32px tall, per spec

Differential Revision: https://phabricator.services.mozilla.com/D109638
2021-03-30 16:40:32 +00:00
Micah Tigley
e4dc9471fb Bug 1693139 - Add label captions for tags and keyword fields. r=Gijs,fluent-reviewers
Depends on D108871

Differential Revision: https://phabricator.services.mozilla.com/D108872
2021-03-30 00:56:36 +00:00
Daisuke Akatsuka
dd7b0db1ba Bug 897954: Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105441
2021-02-25 01:58:24 +00:00
smolnar
34fc339425 Backed out 3 changesets (bug 897954) for causing node test failures in PlacesFeed. CLOSED TREE
Backed out changeset 0a60eb3f7ba8 (bug 897954)
Backed out changeset 9443814d173b (bug 897954)
Backed out changeset 2e558ac8e419 (bug 897954)
2021-02-25 03:21:58 +02:00
Daisuke Akatsuka
75041c3461 Bug 897954: Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105441
2021-02-25 00:12:40 +00:00
Marco Bonardo
5fee7240ed Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
2020-11-23 16:28:04 +00:00
Butkovits Atila
c08d529090 Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
2020-11-23 16:49:31 +02:00
Marco Bonardo
ae29233b62 Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
2020-11-23 12:56:40 +00:00
Gijs Kruitbosch
dffaa65a4a Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96329
2020-11-09 23:16:56 +00:00
Csoregi Natalia
6a0cdbf039 Backed out changeset ca520bfdc084 (bug 1674515) for failures on browser_autoshow_bookmarks_toolbar.js. CLOSED TREE 2020-11-09 19:32:08 +02:00
Gijs Kruitbosch
f6a60b989e Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96329
2020-11-09 16:00:29 +00:00
Gijs Kruitbosch
0a0c86d14c Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94880
2020-11-05 21:08:10 +00:00
Narcis Beleuzu
f5b44dd87b Backed out 4 changesets (bug 1425290, bug 1432604, bug 1665389) for bc failures on browser_bookmarkProperties_addKeywordForThisSearch.js . CLOSED TREE
Backed out changeset 455ff5647429 (bug 1432604)
Backed out changeset cf70da964b70 (bug 1425290)
Backed out changeset e6b38d403cc3 (bug 1425290)
Backed out changeset 09f049232773 (bug 1665389)
2020-11-05 23:01:31 +02:00
Gijs Kruitbosch
393befad12 Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94880
2020-11-04 23:43:05 +00:00
Gijs Kruitbosch
9b68e0e813 Bug 1475489 - stop editing folder names when closing the folder tree in the edit bookmark panel, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D94227
2020-10-27 13:05:44 +00:00
Jared Wein
64176c986d Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers,marionette-reviewers,whimboo
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-26 02:32:07 +00:00
Marco Bonardo
2126d8e487 Bug 1626016 - Remove createFixupURI and move postData inside URIFixupInfo. r=Gijs,geckoview-reviewers,preferences-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D93189
2020-10-13 10:20:16 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128
2020-03-13 23:38:52 +00:00
Marco Bonardo
0e20e092dc Bug 1616460 - Star panel tree view can move bookmarks even when it's not visible. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D64011
2020-02-25 14:04:43 +00:00
Siddhant085
cff5c6c597 Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753
2020-01-16 18:38:54 +00:00
shindli
c78593bc8c Backed out changeset 1bdfd7c37b02 (bug 1511700) for causing newtab node test failure CLOSED TREE 2020-01-13 22:33:58 +02:00
Siddhant085
841c112b92 Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753
2020-01-13 16:25:39 +00:00
fluks
1cb49f0898 Bug 1230453 - Add a hidden preference to change the number of folders in the recent list of the "bookmark this page" popup. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D43679
2019-10-22 07:57:49 +00:00
Tim Nguyen
cf28796916 Bug 1586997 - Fix focusing the first input of edit bookmark dialogs. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48955
2019-10-11 14:16:42 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Victor Porof
07a8b5ebf6 Bug 1523957 - Convert trees to custom elements, r=bgrins, mak, standard8, MattN
***
Bug 1523957 - Part 0: Whitespace changes in tree.js, r=bgrins
***
Bug 1523957 - Part 1.1: Naively convert tree to a custom element, r=bgrins
***
Bug 1523957 - Part 1.2: Properly mixin BaseControl and extend XULTreeElement, r=bgrins
***
Bug 1523957 - Part 1.3: Use Shadow DOM for slotting children, r=bgrins
***
Bug 1523957 - Part 1.4: Properly handle key events in combination with shift modifiers, r=bgrins
***
Bug 1523957 - Part 1.5: Lint for the lint gods in tree.js, r=bgrins, standard8
***
Bug 1523957 - Part 2.1: Naively convert places-tree to a custom element, preserving history, r=bgrins
***
Bug 1523957 - Part 2.2: Lint for the lint gods in places-tree.js, r=bgrins
***
Bug 1523957 - Part 2.3: Fix browser_passwordmgr_editing.js, r=MattN
***
Bug 1523957 - Part 2.4: Fix browser_bookmarksProperties.js, r=bgrins
***
Bug 1523957 - Part 2.5: Make the edit bookmark tree lazily constructed so there aren't any trees left in the browser window markup, r=bgrins
***
Bug 1523957 - Part 2.6: Add eslint globals to places-tree.js, r=bgrins, standard8
2019-02-21 15:39:53 +01:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
James Lee
9366fd6f82 Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries r=Standard8
Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't
(and will not) support read only folders.

Differential Revision: https://phabricator.services.mozilla.com/D12821
2018-11-26 13:18:05 +00:00
Marco Bonardo
54feed2b6f Bug 1506461 - Enable inline suggestions for bookmark tags autocomplete. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D11773
2018-11-21 15:10:53 +00:00