Commit Graph

2571 Commits

Author SHA1 Message Date
Kagami Sascha Rosylight
d6ec873f16 Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-04-06 11:57:57 +00:00
Gijs Kruitbosch
edda40141b Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 16:16:42 +00:00
Norisz Fay
e1d7571cc8 Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
1214ac636b Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 08:18:51 +00:00
criss
0038e58f1f Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight
f3126104f8 Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-03-29 13:11:00 +00:00
Mark Banner
d22663f0f9 Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-17 22:13:08 +00:00
Cristian Tuns
a180c6cba3 Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE 2022-03-14 12:27:48 -04:00
Mark Banner
beed912c8e Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-14 10:19:40 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
Gijs Kruitbosch
a408c9940d Bug 1749537 - remove obsolete _formatPrintButtonShortcuts(), r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D135949
2022-02-28 14:33:29 +00:00
Gijs Kruitbosch
b17d515fe6 Bug 1745810 - remove use of ChromeUtils.import(..., null) from CustomizableUI tests, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D139477
2022-02-25 22:18:32 +00:00
Emilio Cobos Álvarez
08a3c18595 Bug 1755315 - Add more convenient accessors for widget screen to chrome code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D138662
2022-02-17 16:22:58 +00:00
Emilio Cobos Álvarez
2b4bcbce12 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-16 12:18:12 +00:00
smolnar
ac36389b37 Backed out 6 changesets (bug 1753836) for causing mochitest failures in test_event_screenXY_with_zoom. CLOSED TREE
Backed out changeset a572cbc0fac2 (bug 1753836)
Backed out changeset 371a495ff728 (bug 1753836)
Backed out changeset 774af76be463 (bug 1753836)
Backed out changeset faa8a8f2d40f (bug 1753836)
Backed out changeset 9209832ecffe (bug 1753836)
Backed out changeset db443ce0406d (bug 1753836)
2022-02-16 01:47:51 +02:00
Emilio Cobos Álvarez
1f6fc3a3d9 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-15 22:25:04 +00:00
Emilio Cobos Álvarez
09d941de74 Bug 1741830 - Fix front-end callers of screenForRect in HiDPI environments. r=Gijs
screenForRect takes screen coordinates (device pixels, for our purpose here).

However screenX / screenY are in CSS pixels, so we need to convert them to the
right coordinate space before looking up the screen.

Differential Revision: https://phabricator.services.mozilla.com/D137895
2022-02-05 15:44:43 +00:00
Gijs Kruitbosch
fb2c0a460f Bug 1752460 - drop references to unused 'navigable' class name from panel UI menu handling, r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D137449
2022-01-31 20:41:02 +00:00
Julien Wajsberg
a0311c9aa8 Bug 1745208 - [utilityOverlay] Make getTopWin take an option parameter r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133376
2022-01-26 17:26:19 +00:00
Mike Conley
abe9b18fc5 Bug 1748907 - Check the value rather than the presence of 'overflowable' when tearing down a CUI window. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D135254
2022-01-06 20:12:28 +00:00
Jonathan Watt
79109555b9 Bug 1702501 - Remove print.tab_modal.enabled pref and old frontend print preview code. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D134699
2022-01-06 18:55:38 +00:00
Jonathan Watt
8bf216317f Bug 1745332 - Remove print.tab_modal.enabled checks from CustomizableUI code. r=mconley
The old UI is going away.

Differential Revision: https://phabricator.services.mozilla.com/D133451
2022-01-06 18:55:37 +00:00
Emilio Cobos Álvarez
1a62d9d1e2 Bug 1747609 - Don't auto-hide panel on click inside a menupopup. r=Gijs
This matches the current macOS behavior with native context menus.

The issue is that closing the panels causes the destruction of the
menupopup while the activate event hasn't run yet, see comment 9.

Executing the command event synchronously like we do for <button>s is
probably worth it to some extent, though note that on macOS with
non-native menus it'd still need to be async because of the
blinking-before-activation that menuitems have. Gnarly :-(

Of course we always use native menus for context menus so it's not a big
deal, but it still affects the content <select> dropdown, I believe.

So this is the less-invasive change.

Differential Revision: https://phabricator.services.mozilla.com/D134777
2021-12-31 18:33:59 +00:00
criss
4315b33d67 Backed out changeset 309f9ab93b03 (bug 1747609) for causing failures on browser_popup-record-capture-view.js. CLOSED TREE 2021-12-30 05:09:51 +02:00
Emilio Cobos Álvarez
4105547bed Bug 1747609 - Don't auto-hide panel on click inside a menupopup. r=Gijs
This matches the current macOS behavior with native context menus.

The issue is that closing the panels causes the destruction of the
menupopup while the activate event hasn't run yet, see comment 9.

Executing the command event synchronously like we do for <button>s is
probably worth it to some extent, though note that on macOS with
non-native menus it'd still need to be async because of the
blinking-before-activation that menuitems have. Gnarly :-(

Of course we always use native menus for context menus so it's not a big
deal, but it still affects the content <select> dropdown, I believe.

So this is the less-invasive change.

Differential Revision: https://phabricator.services.mozilla.com/D134777
2021-12-30 00:30:38 +00:00
Mike Conley
aeb6969fe7 Bug 1746670 - Make it possible to register CUI areas with overflowable: false. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D134196
2021-12-17 21:52:46 +00:00
Jonathan Watt
1d71bee374 Bug 1745230 - port browser_947914_button_print.js to new print UI. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D133386
2021-12-09 18:03:41 +00:00
Rob Wu
b6b78cf0cc Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-07 11:50:19 +00:00
Butkovits Atila
f90ffaea22 Backed out changeset 6e298bdd0dd8 (bug 1714846) for causing assertion failures at CompositorBridgeParent.cpp. CLOSED TREE 2021-12-03 23:30:10 +02:00
Rob Wu
68e93f997c Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-03 19:16:51 +00:00
Julian Descottes
62d7925d62 Bug 1741369 - [devtools] Update paths to loader files outside devtools/ r=perftest-reviewers,preferences-reviewers,sparky,Gijs
Depends on D131217

Differential Revision: https://phabricator.services.mozilla.com/D131218
2021-11-17 12:43:27 +00:00
Scott
9c09e77b2e Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D130770
2021-11-16 00:35:34 +00:00
Emilio Cobos Álvarez
92f83cf19e Bug 1739539 - Rename titlebar pref and add migration from old pref. r=mconley
Something like this ought to do?

Differential Revision: https://phabricator.services.mozilla.com/D130858
2021-11-10 21:17:32 +00:00
Julien Wajsberg
146e0feb81 Bug 1738871 - [CustomizableUI] Support the button-and-view custom widget type in the overflow menu when Fluent is used r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D130365
2021-11-08 19:26:35 +00:00
Tooru Fujisawa
9281ca231f Bug 1706650 - Split localization item for update banner label for each notification. r=zbraniecki,fluent-reviewers,Gijs
Instead of copying from label-* attributes, set data-l10n-id for each
notification

Also, stop using attributes for checking if the notification is supported.

Differential Revision: https://phabricator.services.mozilla.com/D129270
2021-10-26 18:32:36 +00:00
Emilio Cobos Álvarez
d37eb95bc7 Bug 1736518 - Make browser.tabs.drawInTitlebar a tri-state. r=stransky,Gijs
To more properly support Linux having a different default at runtime.

Expose the resolved value in appinfo for convenience, and use it in the
front-end as needed.

Differential Revision: https://phabricator.services.mozilla.com/D129004
2021-10-21 09:07:12 +00:00
Neil Deakin
0d6adaeabb Bug 1733786, replace uitour implementation of show how button with one that focuses the item on the app menu and submenu instead, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D128428
2021-10-19 14:54:45 +00:00
Michael Kohler
87790d1825 Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak
Differential Revision: https://phabricator.services.mozilla.com/D127588
2021-10-14 07:51:14 +00:00
Julien Wajsberg
78d61c1786 Bug 1681539 - Add a profiler marker for descriptionHeightWorkaround r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D126203
2021-10-05 09:13:12 +00:00
Neil Deakin
64285e432e Bug 1724962, when the uitour highlight opens from the show how button on the session restore infobar, also highlight the restore session option from the history menu when it is opened, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D127198
2021-10-02 12:20:08 +00:00
Emma Malysz
6aa62ca44e Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125850
2021-09-28 20:01:35 +00:00
criss
f157e7c832 Backed out changeset ec019c0205a9 (bug 1725430) for causing failures on dbg-toggling-tools.js 2021-09-28 00:42:30 +03:00
Emma Malysz
058eca39a9 Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125850
2021-09-27 17:30:35 +00:00
Harry Twyford
3043fad3a2 Bug 1729534 - Change Customize window theme picker to a button that points to about:addons#themes. r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125120
2021-09-23 13:55:07 +00:00
Narcis Beleuzu
64df090f34 Backed out changeset ceaaed353b66 (bug 1725430) for assertion failure on ErrorResult.h . CLOSED TREE 2021-09-22 01:09:22 +03:00
Emma Malysz
b1d78a7427 Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125850
2021-09-21 20:37:48 +00:00
Harry Twyford
eba55a238f Bug 1730262 - Add first monochromatic theme. r=desktop-theme-reviewers,dao,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D125283
2021-09-21 13:32:57 +00:00
Butkovits Atila
91d0db9a30 Backed out 3 changesets (bug 1719939, bug 1726437, bug 1730262) for causing failures on test_browserGlue_migration_ctrltab_recently_used_order.js.
Backed out changeset ea1653e9644f (bug 1719939)
Backed out changeset 01f90db715a7 (bug 1726437)
Backed out changeset c0e23b2acfbb (bug 1730262)
2021-09-21 05:15:31 +03:00