corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
909,065 Commits 1 Branch 0 Tags
f5a2f8839a08d97df2d6e23f6b9fde252d6cc7c0
Commit Graph

52 Commits

Author SHA1 Message Date
Mark Banner
cd639ffbbf Bug 1963781 - Improve some type definitions in the browser/components/search code. r=mbeier 
Differential Revision: https://phabricator.services.mozilla.com/D247423
 2025-05-13 18:36:08 +00:00
Mark Banner
878a5d5415 Bug 1951652 - Convert browser/components/search/ modules to use moz-src uris. r=search-reviewers,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D240333
 2025-03-05 09:24:37 +00:00
Moritz Beier
152f732f88 Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235597
 2025-02-04 11:07:12 +00:00
Moritz Beier
22925f7a1e Bug 1907034 - Allow using shift-enter/shift-click to open the search engine page without a search from the search bar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D220446
 2024-09-02 12:37:01 +00:00
Stanca Serban
f02002455b Backed out changeset d53fd34c2b24 (bug 1907034) for causing mochitests failures in browser_urlbarSearchMode.js. CLOSED TREE 2024-08-29 19:59:35 +03:00
Moritz Beier
51dd58b8f1 Bug 1907034 - Allow using shift-enter/shift-click to open the search engine page without a search from the search bar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D220446
 2024-08-29 15:51:46 +00:00
Moritz Beier
3ac77d2134 Bug 1904014 - Remove function to do an empty search using the search bar one-off buttons. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D214834
 2024-07-08 12:12:01 +00:00
pstanciu
cd0b5dbe48 Backed out changeset 80bffab6cb97 (bug 1904014) for causing bc failures on browser_oneOffContextMenu.js CLOSED TREE 2024-07-03 17:21:47 +03:00
Moritz Beier
fcb61b2ae0 Bug 1904014 - Remove function to do an empty search using the search bar one-off buttons. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D214834
 2024-07-03 13:30:46 +00:00
Mark Banner
f65518c3c0 Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak 
Differential Revision: https://phabricator.services.mozilla.com/D203026
 2024-03-13 14:51:06 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204182
 2024-03-11 15:26:28 +00:00
Mark Banner
0d18781645 Bug 1870644 - Remove nsISearchEngine.iconURI and replace by the new getIconURL function. r=search-reviewers,extension-reviewers,settings-reviewers,mconley,mcheang,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D196734
 2023-12-20 13:28:24 +00:00
Dão Gottwald
869594b77f Bug 1852056 - [Firefox Suggest Opt-in Experiment] Implement layout for opt-in UI after one-off button row. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D193437
 2023-11-15 07:21:17 +00:00
Iulian Moraru
a57167e10f Backed out 2 changesets (bug 1852056, bug 1864122) for causing bc failures on browser_shortcuts_add_search_engine.js. CLOSED TREE 
Backed out changeset 095c9d5d982c (bug 1864122)
Backed out changeset 42e41cb8b18f (bug 1852056)
 2023-11-15 00:32:50 +02:00
Dão Gottwald
4160ef5c85 Bug 1852056 - [Firefox Suggest Opt-in Experiment] Implement layout for opt-in UI after one-off button row. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D193437
 2023-11-14 20:31:19 +00:00
Mark Banner
54e1395751 Bug 1849924 - Remove unnecessary init-complete observers from search bar and search one-offs code. r=search-reviewers,mcheang 
Depends on D186737

Differential Revision: https://phabricator.services.mozilla.com/D186741
 2023-08-28 13:31:15 +00:00
Marco Bonardo
0a487b36b8 Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-07 15:48:34 +00:00
Butkovits Atila
ceeb51063d Backed out changeset 986f4f6398a4 (bug 1816572) for causing failures at browser_search_bookmarks.js. CLOSED TREE 2023-07-04 16:29:04 +03:00
Marco Bonardo
dc48e94cda Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-04 09:28:46 +00:00
Mark Banner
0677cff70b Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky 
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
 2023-06-15 08:33:57 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Karandeep
d759f51203 Bug 1643887 - Move handling of search engine one-off hidden from preferences into the search settings. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D180229
 2023-06-12 18:03:52 +00:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-05-18 17:19:45 +00:00
Marco Bonardo
52f8c82c3f Bug 1809218 - Use a more generic element id for search shortcuts. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166420
 2023-01-11 16:54:33 +00:00
Mark Banner
104bf81d34 Bug 1801808 - Automatically replace Cu.reportError with console.error (search). r=scunnane 
Manual fixing of tests.

Differential Revision: https://phabricator.services.mozilla.com/D162696
 2022-11-23 12:29:20 +00:00
trickypr
ed1b5fe3ae Bug 1510561 - Part 5: Apply plugin:mozilla/require-jsdoc to browser/components/search. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159470
 2022-10-24 13:32:37 +00:00
trickypr
beac0753a6 Bug 1510561 - Part 4: Apply plugin:mozilla/valid-jsdoc to browser/components/search. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159469
 2022-10-24 13:32:36 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157471
 2022-09-28 09:40:36 +00:00
Mark Banner
79b9557a71 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
b7f6194b8d Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner
5dcae1ed44 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 18:51:57 +00:00
Narcis Beleuzu
95ae6b7d0f Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
ff212fab8b Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 16:51:10 +00:00
Daisuke Akatsuka
7bb745d2b1 Bug 1782311: Avoid flickering due to showing/hiding one-off buttons. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D154784
 2022-08-21 21:35:52 +00:00
Daisuke Akatsuka
ca83f90a92 Bug 1782311: Do not hide oneoff buttons area when there is additional engine. r=Standard8,adw 
The cause of this bug was that we don’t consider the Add Engines to show/hide the
container of SearchOneOffs. To resolve the issue, we incorporated that into
__rebuild() function. This feature is only for search bar.

Differential Revision: https://phabricator.services.mozilla.com/D154627
 2022-08-21 21:35:51 +00:00
Iulian Moraru
93ab026b85 Backed out 2 changesets (bug 1782311) for causing mochitest failures on browser_heuristicNotAddedFirst.js. CLOSED TREE 
Backed out changeset 23414a710c13 (bug 1782311)
Backed out changeset 7307730b93c9 (bug 1782311)
 2022-08-19 11:53:36 +03:00
Daisuke Akatsuka
356084f87f Bug 1782311: Avoid flickering due to showing/hiding one-off buttons. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D154784
 2022-08-19 08:14:55 +00:00
Daisuke Akatsuka
2876516d7b Bug 1782311: Do not hide oneoff buttons area when there is additional engine. r=Standard8,adw 
The cause of this bug was that we don’t consider the Add Engines to show/hide the
container of SearchOneOffs. To resolve the issue, we incorporated that into
__rebuild() function. This feature is only for search bar.

Differential Revision: https://phabricator.services.mozilla.com/D154627
 2022-08-19 08:14:54 +00:00
Emilio Cobos Álvarez
80a0d32343 Bug 1776417 - Prevent bad HTML/XUL layout interaction in search one-offs. r=desktop-theme-reviewers,dao 
The regression here happens because the jsm code was looking into
this.popup.clientWidth, which can be larger than
this.popup.panelContent.clientWidth (which is the right thing to look
at) on Linux (and on Windows after bug 1768278).

However, this is all working around a weird HTML/XUL layout interaction
(the buttons not wrapping correctly unless max-width is set, because XUL
boxes don't understand when a child has flex layout).

Instead, use display: block on the container and header. This prevents
the weird layout interaction altogether and we can avoid the hacky
workarounds.

Differential Revision: https://phabricator.services.mozilla.com/D151139
 2022-08-08 09:14:34 +00:00
Mark Banner
89c201a8bd Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-26 15:11:31 +00:00
smolnar
4cb3dcaaa2 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE 
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
 2022-07-25 21:00:07 +03:00
Mark Banner
41d1e736b0 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-25 12:46:49 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
1a7f25b6f9 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-20 15:50:43 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE 
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
 2022-07-20 14:57:48 +03:00
Mark Banner
2302d51735 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-20 10:36:53 +00:00