Commit Graph

100 Commits

Author SHA1 Message Date
Thomas Wisniewski
0e211b23a7 Bug 1852340 - part 2: Simplify the fallback Report Site Issue feature to not have redundant actors and experimental APIs; r=webcompat-reviewers,ksenia
Depends on D190647

Differential Revision: https://phabricator.services.mozilla.com/D190648
2023-11-20 01:50:36 +00:00
Cristian Tuns
8e6281d821 Backed out 3 changesets (bug 1852340) for causing frequent mochitest failures in docshell/test/chrome/ CLOSED TREE
Backed out changeset 61875987e62c (bug 1852340)
Backed out changeset 05320d6c0441 (bug 1852340)
Backed out changeset 411374d444d1 (bug 1852340)
2023-11-19 11:46:26 -05:00
Thomas Wisniewski
15d53250a6 Bug 1852340 - part 2: Simplify the fallback Report Site Issue feature to not have redundant actors and experimental APIs; r=webcompat-reviewers,ksenia
Depends on D190647

Differential Revision: https://phabricator.services.mozilla.com/D190648
2023-11-19 15:34:41 +00:00
Natalia Csoregi
f0be2f0119 Backed out 3 changesets (bug 1852340) for causing failures due to reportBrokenSite.ftl. CLOSED TREE
Backed out changeset 86f9e01f70d6 (bug 1852340)
Backed out changeset 0049d0494b17 (bug 1852340)
Backed out changeset 7851355d5c95 (bug 1852340)
2023-11-19 10:50:25 +02:00
Thomas Wisniewski
dcce3bf266 Bug 1852340 - part 2: Simplify the fallback Report Site Issue feature to not have redundant actors and experimental APIs; r=webcompat-reviewers,ksenia
Depends on D190647

Differential Revision: https://phabricator.services.mozilla.com/D190648
2023-11-19 07:31:32 +00:00
Benjamin VanderSloot
4dfecc097a Bug 1850955 - Add current GPC setting to webcompat reports - r=timhuang,twisniewski,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189659
2023-10-10 15:24:21 +00:00
Sylvestre Ledru
2e0e132821 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Masatoshi Kimura
8262afb8c6 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 19:00:07 +00:00
Noemi Erli
8561f7ec9a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
2023-10-02 21:16:25 +03:00
Masatoshi Kimura
89e9a36583 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 17:36:27 +00:00
Markus Stange
cd95754542 Bug 1611626 - Remove gfx.webrender.blob-images. r=nical,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D188489
2023-09-25 23:36:26 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Gregory Pappas
a86990ef18 Bug 1842345 - Remove gfx.webrender.enabled pref r=jrmuizel,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D183071
2023-07-13 04:17:40 +00:00
Mark Banner
544ecba3af Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Gregory Pappas
ca90e02beb Bug 1842470 - Remove unused image.mem.shared pref r=CanadaHonk,webcompat-reviewers,twisniewski
Since bug 1729051 this pref doesn't actually do anything

Differential Revision: https://phabricator.services.mozilla.com/D183091
2023-07-09 17:25:34 +00:00
Rob Wu
bad812f243 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Ksenia Berezina
26854510e5 Bug 1833916 - Add additional data/prefs passed from "Report site issue" to webcompat.com r=webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D178462
2023-05-24 19:22:26 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D176336
2023-05-09 16:14:51 +00:00
anwar
37dde79fd5 Bug 1830075 - Put all mochitests under browser/extensions, browser/modules and browser/tools into alphabetical order. r=mconley,webcompat-reviewers,credential-management-reviewers,twisniewski,dimi
Differential Revision: https://phabricator.services.mozilla.com/D176839
2023-05-02 20:26:16 +00:00
Mark Banner
e8daad195d Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu
Depends on D173450

Differential Revision: https://phabricator.services.mozilla.com/D173451
2023-03-24 19:35:25 +00:00
William Durand
7bc7779e8f Bug 1797777 - Use browser_specific_settings instead of applications in extension manifests. r=rpl,twisniewski,markh,webcompat-reviewers,credential-management-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D167018
2023-01-18 15:57:30 +00:00
Mark Banner
154bea9bfb Bug 1810877 - Automatically replace Cu.reportError with console.error (browser/extensions/report-site-issue/). r=webcompat-reviewers,twisniewski
Depends on D167095

Differential Revision: https://phabricator.services.mozilla.com/D167096
2023-01-18 08:24:40 +00:00
trickypr
3d38bdb78e Bug 1510561 - Part 12: Apply plugin:mozilla/valid-jsdoc to browser/extensions/report-site-issue. r=webcompat-reviewers,twisniewski
Depends on D161386

Differential Revision: https://phabricator.services.mozilla.com/D161387
2022-11-07 12:33:29 +00:00
Andrew Osmond
abcef544cf Bug 1794722 - Part 3. Remove all uses of GfxInfo::GetWebRenderEnabled. r=jrmuizel,webcompat-reviewers,twisniewski
This is always true.

Differential Revision: https://phabricator.services.mozilla.com/D160122
2022-10-28 12:36:06 +00:00
Cristian Tuns
7e753f9368 Backed out 3 changesets (bug 1794722) for causing multiple failures on RemoteProcessMonitor CLOSED TREE
Backed out changeset 0217af5b1aa6 (bug 1794722)
Backed out changeset d7805be9dfb3 (bug 1794722)
Backed out changeset 0093f071f1a5 (bug 1794722)
2022-10-27 20:52:36 -04:00
Andrew Osmond
30537addf0 Bug 1794722 - Part 3. Remove all uses of GfxInfo::GetWebRenderEnabled. r=jrmuizel,webcompat-reviewers,twisniewski
This is always true.

Differential Revision: https://phabricator.services.mozilla.com/D160122
2022-10-28 00:08:04 +00:00
Mark Banner
1e3410cbdd Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Mark Banner
dc49931f4f Bug 1777268 - Support structuredClone in the system global by default. r=webcompat-reviewers,twisniewski,kmag
Differential Revision: https://phabricator.services.mozilla.com/D152196
2022-07-26 20:13:52 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Mark Banner
de855a6172 Bug 1646183 - Use ESLint rule reject-importGlobalProperties to reject all imports in system modules. r=arai,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D150354
2022-06-29 22:37:58 +00:00
Thomas Wisniewski
931665baef Bug 1775402 - disable the report-site-issues tests until we can determine why they intermittently fail in bz1775526; r=ksenia,webcompat-reviewers DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D150269
2022-06-24 16:44:20 +00:00
Thomas Wisniewski
4749ace83d Bug 1775126 - fix a structured-cloning failure in the webcompat report-site-issue feature, and update and re-enable some of its tests; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149847
2022-06-22 03:27:54 +00:00
criss
c895dbf245 Backed out changeset d0771d3e5261 (bug 1775126) for causing mochitest failures on browser_report_site_issue.js. CLOSED TREE 2022-06-21 22:25:58 +03:00
Thomas Wisniewski
96271f2fee Bug 1775126 - fix a structured-cloning failure in the webcompat report-site-issue feature, and update and re-enable its tests; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149847
2022-06-21 12:36:18 +00:00
raquelvargas
782eaca77b Bug 1738229 - Stop using the second argument to ChromeUtils.import in various files in browser. r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D129842
2021-11-02 17:21:07 +00:00
Sam Foster
d96b6ab775 Bug 1708018 - Use toolkit's lightbulb icon for the report-site-issue extension. r=webcompat-reviewers,denschub
Differential Revision: https://phabricator.services.mozilla.com/D117581
2021-06-24 21:59:33 +00:00
Harry Twyford
d501e1afc2 Bug 1707756 - Part 2 - Update lightbulb icon. r=sfoster,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D113531
2021-04-30 20:24:33 +00:00
Cosmin Sabou
753b2b3967 Backed out 2 changesets (bug 1707756) for causing build bustages. CLOSED TREE
Backed out changeset ddfb12358dcd (bug 1707756)
Backed out changeset be804f37dfe3 (bug 1707756)
2021-04-29 19:05:09 +03:00
Harry Twyford
9b49e4b74e Bug 1707756 - Part 2 - Update lightbulb icon. r=sfoster,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D113531
2021-04-29 15:42:24 +00:00
Luca Greco
8ddd2337e9 Bug 1700184 - Bump report-site-issue version and remove redundant Services definition from aboutConfigPrefs.js API. r=twisniewski,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D109394
2021-03-31 11:40:18 +00:00
Dorel Luca
d05b58692c Backed out 4 changesets (bug 1700184) for Browser-chrome failures in formautofill/test/browser/browser_check_installed.js. CLOSED TREE
Backed out changeset 2944365f6a2e (bug 1700184)
Backed out changeset b48692ff9385 (bug 1700184)
Backed out changeset 1fc2d71ba21c (bug 1700184)
Backed out changeset c4ac52593f2e (bug 1700184)
2021-03-31 03:39:22 +03:00
Luca Greco
053b920d08 Bug 1700184 - Bump report-site-issue version and remove redundant Services definition from aboutConfigPrefs.js API. r=twisniewski,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D109394
2021-03-30 20:46:43 +00:00
Luca Greco
bb4051ec3b Bug 1698158 - part 3.1 - Remove unnecessary imports from builtin addons experimental API. r=mixedpuppy,webcompat-reviewers,denschub
Depends on D108227

Differential Revision: https://phabricator.services.mozilla.com/D108228
2021-03-16 18:15:41 +00:00
Luca Greco
70734319b1 Bug 1696490 - Fix errors loading report-site-issue builtin extension triggered by pageActionExtras.js due to the pageAction removal. r=mconley,denschub,webcompat-reviewers
This patch does remove the pageActionExtras experimental API, which is what started triggering
those errors after the pageAction manifest property was removed from the manifest in Bug 1690573:

- The pageActionExtras API was internally retrieving the pageAction API class
  (see https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/browser/extensions/report-site-issue/experimentalAPIs/pageActionExtras.js#12-16)
  which is a bit of an hack and it used to work because there was a pageAction property in the
  manifest.json file (and that was what used to guarantee that the ext-pageAction.js API module
  was always loaded before the background page of the extension did have a chance to run)

- In Bug 1690573 we removed the pageAction property from the manifest and as a side-effect the
  ext-pageAction.js module wouldn't be loaded anymore, which did break the assumption in
  the pageActionExtras API (and the extension background page script as a side effect of that)

I assume that if we removed the pageAction from the manifest, then we don't need the pageActionExtras
experimental API neither (it seems that its purpose was to localize the pageAction and to set a custom
telemetry label for it) and so to fix the regression I opted to remove the remaining traces of the
pageActionExtras experimental API.

NOTE: there are some more traces left in head.js, which are used for the test cases.
All the tests are currently disabled and it seems that they are meant to be re-enabled
as part or as a follow up of Bug 1693119 and so I think that for those parts we can
wait to get there.

Differential Revision: https://phabricator.services.mozilla.com/D107326
2021-03-08 16:32:18 +00:00
Mike Conley
09f7764241 Bug 1690573 - Migrate the report-site-issue UI access point to the Help menu. r=denschub,mixedpuppy,fluent-reviewers,webcompat-reviewers,flod
We're not 100% certain if Help is the right spot for this, but we're going
to give it a shot and see. If it turns out it _is_ the right spot, we'll
probably do something a little more self-contained, and less hacky.

I'm leaving the old .properties file just in case we change our mind here.
Yes, we'll want to port to Fluent anyways, but our ultimate choice of where
we put this thing is probably going to dictate where the string lives.

Differential Revision: https://phabricator.services.mozilla.com/D104832
2021-02-23 00:11:05 +00:00