corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
810,378 Commits 1 Branch 0 Tags
f45aacc84161ee35c1981fbf19b563fae97a91e3
Commit Graph

60 Commits

Author SHA1 Message Date
Karandeep
b4cba16887 Bug 1853910 - Remove Legacy Event Telemetry Dependencies. r=mak,extension-reviewers,robwu 
Depends on D188721

Differential Revision: https://phabricator.services.mozilla.com/D189558
 2023-10-11 07:45:13 +00:00
Stanca Serban
341caf1e76 Backed out 2 changesets (bug 1853910) for causing mochitests failures in browser_ext_urlbar_attributionURL.js. CLOSED TREE 
Backed out changeset eea288462cbb (bug 1853910)
Backed out changeset 75543d7d4250 (bug 1853910)
 2023-10-07 00:17:27 +03:00
Karandeep
45ddb19915 Bug 1853910 - Remove Legacy Event Telemetry Dependencies. r=mak,extension-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D189558
 2023-10-06 12:33:14 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Marco Bonardo
e8db79b5ea Bug 1846781 - Use recalc_frecency for updating origins frecency instead of triggers. r=daisuke 
Until now we updated origins frecency using direct SQL triggers.
While that guaranteed good performance, it also had some downsides:
 * replacing the algorithms is complicate, the current system only works
   with a straight sum of page frecencies. We are planning to experiment with
   different algorithms in the future.
 * it requires using multiple temp tables and DELETE triggers, that is error
   prone for consumers, that may forget to DELETE from the temp tables, and thus
   break data coherency.
 * there's not much atomicity, since the origins update must be triggered apart
   and a crash would lose some of the changes

This patch is changing the behavior to be closer to the recalc_frecency one that
is already used for pages.
When a page is added, visited, or removed, recalc_frecency of its origin is set
to 1. Later frecency of invalidated origins will be recalculated in chunks.
While this is surely less efficient than the existing system, it solves the
problems presented above.
A threshold is recalculated at each chunk, and stored in the moz_meta table.
This patch continues using the old STATS in the moz_meta table, to allow for
easier downgrades. Once a new threshold will be introduced we'll be able to
stop updating those.

The after delete temp table is maintained because there's no more efficient way
to remove orphan origins promptly. Thus, after a removal from moz_places,
consumers MUST still DELETE from the temp table to cleanup orphan origins.
This also introduces a delayed removal of orphan origins when their frecency
becomes 0.

Differential Revision: https://phabricator.services.mozilla.com/D186070
 2023-09-13 13:58:30 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
Bilal
19e224dcb3 Bug 1816987 - ESMified browser/components/enterprisepolicies/schemas r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D174495
 2023-04-27 19:23:00 +00:00
Stephanie Cunnane
6859613568 Bug 1815549 - Remove references to non-existent Assert.fail method. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D169137
 2023-02-07 22:53:32 +00:00
Mark Banner
9f5558b211 Bug 1812977 - Remove now unnecessary import-globals-from statements in browser. r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D168070
 2023-01-30 19:33:37 +00:00
trickypr
f28fa5aa80 Bug 1510561 - Part 6: Apply plugin:mozilla/valid-jsdoc to browser/components/urlbar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159471
 2022-10-24 13:32:37 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Mark Banner
cd9bed2e7a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-26 15:11:30 +00:00
smolnar
4cb3dcaaa2 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE 
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
 2022-07-25 21:00:07 +03:00
Mark Banner
bf597b1f3a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-25 12:46:48 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
78524564fc Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-20 15:50:42 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Mark Banner
9cb7e8c83c Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-20 10:36:51 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Gijs Kruitbosch
c7e262c3b0 Bug 1753696 - move common setup/init tasks in head.js files to use add_setup, r=Standard8 
Without this, changing to add_setup in individual test files causes the tasks to be reordered, which causes tests to fail.

I also had to adjust an enterprise policy test that was expecting setup tests to run inbetween tasks.

Differential Revision: https://phabricator.services.mozilla.com/D142457
 2022-03-30 16:16:43 +00:00
Bogdan Tara
9175d14e52 Backed out changeset 5c2127a7d44e (bug 1688000) for gecko decision task complaining about browser.ini CLOSED TREE 2021-01-27 00:01:01 +02:00
harry
8de2855c57 Bug 1688000 - Add experimental suggestionsEnabled WebExtension API. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D102645
 2021-01-22 19:17:05 +00:00
harry
bc0fb0df43 Bug 1686767 - Unhide urlbar.extension.enabled pref and add experimental APIs to set it. r=adw 
Having browser.urlbar.extension.enabled be a hidden pref was causing issues with the new experimental APIs and their tests. Both the APIs and their tests first read the value of the pref before modifying it so it can later be restored to its default value. The default value of a hidden pref is undefined, which was causing errors. It's not a particularly sensitive pref, so I think unhiding it is preferable to finding a workaround to get the APIs/tests working with hidden prefs.

Differential Revision: https://phabricator.services.mozilla.com/D101799
 2021-01-14 23:44:04 +00:00
Narcis Beleuzu
3a21c5f3c1 Backed out changeset 663e0df951c7 (bug 1686767) for bustages on browser.ini . CLOSED TREE 2021-01-15 00:28:17 +02:00
harry
d9577b3393 Bug 1686767 - Unhide urlbar.extension.enabled pref and add experimental APIs to set it. r=adw 
Having browser.urlbar.extension.enabled be a hidden pref was causing issues with the new experimental APIs and their tests. Both the APIs and their tests first read the value of the pref before modifying it so it can later be restored to its default value. The default value of a hidden pref is undefined, which was causing errors. It's not a particularly sensitive pref, so I think unhiding it is preferable to finding a workaround to get the APIs/tests working with hidden prefs.

Differential Revision: https://phabricator.services.mozilla.com/D101799
 2021-01-14 21:49:02 +00:00
harry
69a7a24468 Bug 1680022 - Add idMap property to getViewUpdate and prohibit dynamic results from setting their own IDs. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D100402
 2020-12-24 04:44:09 +00:00
Drew Willcoxon
5eb2c44695 Bug 1632105 - Implement dynamic result types. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D71921
 2020-06-23 19:14:43 +00:00
Harry Twyford
38726ff902 Bug 1641661 - Remove urlbar.experiments.openViewOnFocus WebExt API. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D77339
 2020-05-28 19:40:56 +00:00
Harry Twyford
b2e5795fb1 Bug 1627989 - Remove the browser.urlbar.openViewOnFocus pref. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D76247
 2020-05-27 16:46:43 +00:00
Harry Twyford
c1f33cff59 Bug 1606924 - Remove unused urlbar WebExtension APIs. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D69820
 2020-04-07 04:43:47 +00:00
Dão Gottwald
ef321fc334 Bug 1539838 - Move SetPageProxyState into UrlbarInput. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D66288
 2020-03-12 18:15:58 +00:00
Mark Banner
d375cfec54 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703
 2020-03-07 10:09:44 +00:00
Drew Willcoxon
b3b84fdecf Bug 1608601 - Add browser.experiments.urlbar.clearInput() experiment API. r=harry 
We need to also set the pageproxystate to invalid so that we show the magnifying glass icon in the input instead of the lock and shield.

This is used in the extension's background script here: https://github.com/0c0w3/urlbar-tips-experiment/pull/8/files#diff-961641dd6af66f5e3313307cf4eb8f1dR339  (Bug 1608613 tracks that PR)

Differential Revision: https://phabricator.services.mozilla.com/D59591
 2020-01-12 02:49:06 +00:00
Emma Malysz
ba6b2f0a9b Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D55857
 2019-12-11 17:44:54 +00:00
Gurzau Raul
c2d189a7a6 Backed out changeset dd809e835f2a (bug 1601093) for eslint failures at alert.xhtml and commonDialog.xhtml on a CLOSED TREE. 2019-12-11 19:27:28 +02:00
Emma Malysz
abfeb3aaa3 Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D55857
 2019-12-11 17:02:20 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D55751
 2019-12-11 00:27:19 +00:00
Drew Willcoxon
420606cb77 Bug 1601369 - Fix intermittent browser/components/urlbar/tests/ext/browser/update/browser_installBrowserUpdateAndRestart.js. r=mak 
The test needs to wait until the status of the mock update becomes downloadAndInstall before calling `installBrowserUpdateAndRestart`. The test fails intermittently because `installBrowserUpdateAndRestart` bails early if the status isn't that, so the test doesn't continue on the mock update path like it should. I also `await ext.awaitMessage("done")` before continuing with the mock update to make sure the extension has called `installBrowserUpdateAndRestart` first.

Try is green after many retriggers: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c6046c9633a84ccf741dd304a5abb54a6b34adc

My earlier attempts at fixing this were orange very quickly, e.g.: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e650fc0976febe4b0195bede281b40a4473f0d2

Differential Revision: https://phabricator.services.mozilla.com/D55920
 2019-12-06 01:01:44 +00:00
Drew Willcoxon
b703569d86 Bug 1600860 - Add browser.experiments.urlbar.installBrowserUpdateAndRestart. r=mak,mixedpuppy 
Users can opt out of automatic updates. In that case, when an update is available, we need to let the user download and install it and restart the browser. This case isn't covered in the interventions spec, but it's consistent with the intention to give the user a one-click way to continue on their upgrade path, so I think we should handle it.

This patch adds a `browser.experiments.urlbar.installBrowserUpdateAndRestart` function. At first I made it only install the update, and then the extension called our existing `restartBrowser` function once that finished. But it didn't work because `restartBrowser` must be called from a user-input handler, and apparently by awaiting the install function, any code running after the `await` isn't considered to be in the user-input handler.

Differential Revision: https://phabricator.services.mozilla.com/D55608
 2019-12-04 16:58:19 +00:00
Drew Willcoxon
28d9e27732 Bug 1596258 - Add browser.experiments.urlbar.checkForBrowserUpdate and getBrowserUpdateStatus. r=mak,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D54397
 2019-12-03 22:10:20 +00:00
Harry Twyford
1838a61241 Bug 1594786 - Part 2 - WebExt API: Add browser.experiments.app.openClearHistoryDialog call. r=mixedpuppy,adw,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D52842
 2019-11-22 13:14:15 +00:00
Razvan Maries
dc988b804a Backed out 2 changesets (bug 1594786) for perma fails on test_ext_all_apis.html. CLOSED TREE 
Backed out changeset 6f9f1ab36756 (bug 1594786)
Backed out changeset da5d5f59a7da (bug 1594786)
 2019-11-22 15:09:00 +02:00
Harry Twyford
395db517ee Bug 1594786 - Part 2 - WebExt API: Add browser.experiments.app.openClearHistoryDialog call. r=mixedpuppy,adw,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D52842
 2019-11-21 21:37:32 +00:00
Drew Willcoxon
5ef1ecd793 Bug 1596980 - Copy browser.experiments.urlbar.engagementTelemetry from top sites experiment to our mozilla-central experiment files r=mak,mixedpuppy 
Original code by Marco Bonardo <mbonardo@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D53311
 2019-11-20 22:51:19 +00:00