Commit Graph

2970 Commits

Author SHA1 Message Date
Dão Gottwald
cf2f871874 Bug 1868131 - [Firefox Suggest Opt-in Experiment] Further improve wrapping behavior. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D195635
2023-12-07 10:19:35 +00:00
Marc Seibert
ba88c2739e Bug 1863110 - If trimHttps is enabled, domain highlighting is not applied when loading suggested bookmark.r=dao
Differential Revision: https://phabricator.services.mozilla.com/D192941
2023-12-07 09:04:44 +00:00
Drew Willcoxon
880b3168e6 Bug 1821112 - Make the urlbar muxer take span and count limits into account when adding suggested-index results. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D195335
2023-12-07 00:19:46 +00:00
Dão Gottwald
f32d82a62a Bug 1867308 - Add null-check in #isQuickSuggestOptInElement. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D195089
2023-12-01 09:56:44 +00:00
Dale Harvey
ad17f07d3b Bug 1867375 - Enable RichSuggestions in release. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D195071
2023-11-30 18:34:53 +00:00
Benjamin VanderSloot
24f33e0e84 Bug 1525943 - Show identity section for web controlled about:blank. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D193804
2023-11-30 18:32:48 +00:00
Dale Harvey
39a9ac3c24 Bug 1867323 - Disable quickactions for rich suggestions test. r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D195027
2023-11-30 03:26:16 +00:00
Perry McManis
d4d8f5865d Bug 1862660 - Prevent setting of empty strings in quick suggest pings r=chutten,adw
Differential Revision: https://phabricator.services.mozilla.com/D192707
2023-11-29 20:50:52 +00:00
Dale Harvey
f050034465 Bug 1865273 - Don't group rich suggestions last in urlbar results. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D194177
2023-11-29 15:56:08 +00:00
Cristian Tuns
11a7654db7 Backed out changeset d7e5b4cd4c20 (bug 1865273) for causing bc failures in browser_searchShowSuggestionsFirst.js CLOSED TREE 2023-11-29 11:53:54 -05:00
Dale Harvey
263da5e4cd Bug 1865273 - Don't group rich suggestions last in urlbar results. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D194177
2023-11-29 15:56:08 +00:00
Anna Yeddi
545506947d Bug 1864941 - Add exceptions from a11y_checks for 3 tests clicking outside of the urlbar in Search and Address Bar. r=adw
It appears that `browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js` and  `browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js` tests the mouse/touch-specific behavior: the test cases are [sending a click event somewhere on the window to test that the tooltip would, in fact, disappear or not](https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js#61) (depending on the test case), while there are other ways to dismiss the tooltip that are accessible (i.e. by pressing `Esc` key, testing which is included in one of the test cases).

Similarly, `browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js` sends a `mouseup` events to the `<html:body>` to dismiss the url bar with a mouse-specific tests.

These clicks are not expected or do not have to be done by a keyboard-only user and it does not have to confirm the keyboard focusability as part of the accessibility of these elements.

We adding an exception from a11y_checks for these clicks, because the clicks are testing mouse-specific behavior where keyboard accessible alternative is available and is tested, and we removing the `fail-if` notation that was added by bug 1854660 before the investigation in the meta bug 1854661.

Differential Revision: https://phabricator.services.mozilla.com/D193699
2023-11-29 00:00:24 +00:00
Karandeep
2607779a04 Bug 1866616 - Save the current date when starting a search from the search bar. r=dao,search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D194754
2023-11-28 12:20:43 +00:00
Dão Gottwald
be2ceefbdf Bug 1866230 - Record impression event only when query finished. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D194690
2023-11-28 12:19:30 +00:00
Dão Gottwald
f5bb7a907b Bug 1866076 - Only check prefs, not queryContext when deciding whether to remove the contextual opt-in UI. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D194528
2023-11-28 12:11:10 +00:00
Dão Gottwald
402c6a1544 Bug 1866292 - Add fxsuggest_data_sharing_opt_in as a recorded result type. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D194689
2023-11-28 07:59:32 +00:00
Dão Gottwald
9c4a268f65 Bug 1866069 - Announce title and description on the contextual opt-in row when selecting the first element (i.e. the learn more link). r=daleharvey
This is a hack for the experiment and likely not ideal for screen readers, but better than what we have. I'm reaching out to a11y folks to figure out the right long-term solution here. I'll make an effort to get that ready for the experiment too, but would like to get this landed as a backup.

Differential Revision: https://phabricator.services.mozilla.com/D194501
2023-11-28 07:58:01 +00:00
Dão Gottwald
221ee286cf Bug 1866620 - [Firefox Suggest Opt-in Experiment] Bring narrow layout for topPosition=false in line with topPosition=true. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D194691
2023-11-28 07:56:47 +00:00
Dale Harvey
5c52093b54 Bug 1797488 - Ensure switchtotab loads URL in a tab if record is missing. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D194170
2023-11-28 06:33:56 +00:00
Drew Willcoxon
7bc090a509 Bug 1866858 - Document rs_mdn, rust_amo, and rust_pocket result types in urlbar's metrics.yaml. r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D194800
2023-11-27 22:51:37 +00:00
Malte Juergens
cb0c39606c Bug 1863281 - Fix tests that would break with dom.security.https_first_schemeless enabled by default r=freddyb,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192923
2023-11-27 09:51:46 +00:00
Anna Yeddi
932ff54356 Bug 1864962 - Update urlbar-go-button to be a button and pass a11y_checks in Search and Address Bar. r=Jamie,adw
We provide `role=button` to the image control that can be clicked (with a mouse or with an assistive technology as speech-to-text/voice control) as an alternative way of the urlbar search query submission, where other ways are accessible (and are tested here too).

Setting an environment to `focusableRule: false` allows us to flag to the AccessibilityUtils that this specific button is purposefully not made focusable and its keyboard focusability should not be tested.

The previously failing accessibility checks should now be passing, thus we are also removing the `fail-if` notations that were added by bug 1854660 before the investigation in the meta bug 1854661.

Differential Revision: https://phabricator.services.mozilla.com/D193703
2023-11-23 02:33:10 +00:00
Dão Gottwald
4be2dc5fec Bug 1865862 - [Firefox Suggest Opt-in Experiment] Update descriptions as per final figma. r=daleharvey
Not updating the ids here as these strings aren't localized.

Differential Revision: https://phabricator.services.mozilla.com/D194244
2023-11-21 19:40:51 +00:00
Anna Yeddi
8c5259f5e5 Bug 1864751 - Pt.2. Remove fail-if notations for a11y_checks of one-off-items in Search and Address Bar and Session Restore. r=adw,Jamie,sessionstore-reviewers,sclements
With the AccessibilityUtils tests updated in D193591 to pass a11y_checks for for keyboard focusable URL bar's `.searchbar-engine-one-off-item` buttons and `.urlbarView-row-inner` results options that are purposefully made focusable with arrow keys only (instead of a Tab that would create more tiring, cumbersome experience navigating Awesomebar for keyboard-only users), we could now remove the `fail-if` notations from a series of tests that were previously failing. Also, there are 12 tests that would also be affected, but they have other elements that are throwing warning or failing a11y_checks besides the one-off controls, thus we'd be keeping them to expect to fail until these items are resolved separately.

These tests were `fail-if`ed by bug 1854660 and bug 1854528, before the investigation in the meta bug 1854661 and bug 1854529.

Differential Revision: https://phabricator.services.mozilla.com/D193849
2023-11-21 18:42:51 +00:00
Joel Maher
33fa84a382 Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Dale Harvey
b0afb7af34 Bug 1803576 - Add Save page as PDF Quickaction. r=daisuke,fluent-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D193757
2023-11-20 19:57:32 +00:00
Karandeep
b738a1c8bd Bug 1860548 - Enable the URL Paste Suggestion feature by default in Nightly. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D191868
2023-11-20 17:14:25 +00:00
Marc Seibert
300545756c Bug 1657237 - Address Bar flashes punycode when loading page.r=mak
Differential Revision: https://phabricator.services.mozilla.com/D192696
2023-11-20 17:11:23 +00:00
Dão Gottwald
f75a21c8fa Bug 1852058 - [Firefox Suggest Opt-in Experiment] Implement Glean probes for all treatment branches. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D193767
2023-11-17 10:35:03 +00:00
Natalia Csoregi
9be0cd71c3 Backed out changeset e7983ca0617d (bug 1852058) for causing build bustages. CLOSED TREE 2023-11-17 09:39:15 +02:00
Dão Gottwald
f156367315 Bug 1852058 - [Firefox Suggest Opt-in Experiment] Implement Glean probes for all treatment branches. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D193767
2023-11-17 07:00:42 +00:00
Karandeep
499e1c4a7e Bug 1852046 - Convert "Suggestions from the web" and "Suggestions from sponsors" toggles to checkboxes on privacy prefs page r=dao,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D191641
2023-11-16 07:19:42 +00:00
Dão Gottwald
0b3462869a Bug 1864121 - [Firefox Suggest Opt-in Experiment] Add Shortcuts group label when contextual opt-in UI is shown above top sites. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D193649
2023-11-16 07:17:13 +00:00
Narcis Beleuzu
ec313d1988 Backed out changeset 74497487caf9 (bug 1860548) for bc failure on browser_rich_suggestions.js 2023-11-15 21:02:51 +02:00
Karandeep
d93a0aa5e2 Bug 1860548 - Enable the URL Paste Suggestion feature by default in Nightly. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D191868
2023-11-15 10:51:27 +00:00
Dão Gottwald
869594b77f Bug 1852056 - [Firefox Suggest Opt-in Experiment] Implement layout for opt-in UI after one-off button row. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D193437
2023-11-15 07:21:17 +00:00
Iulian Moraru
a57167e10f Backed out 2 changesets (bug 1852056, bug 1864122) for causing bc failures on browser_shortcuts_add_search_engine.js. CLOSED TREE
Backed out changeset 095c9d5d982c (bug 1864122)
Backed out changeset 42e41cb8b18f (bug 1852056)
2023-11-15 00:32:50 +02:00
Dale Harvey
9eadf1b3d7 Bug 1852442 - Remove delay for heuristic result. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D192462
2023-11-14 20:42:35 +00:00
Dão Gottwald
4160ef5c85 Bug 1852056 - [Firefox Suggest Opt-in Experiment] Implement layout for opt-in UI after one-off button row. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D193437
2023-11-14 20:31:19 +00:00
Anna Yeddi
1ff2d7d161 Bug 1863584 - Remove skip-if for a11y_checks that previously crashed with @ mozilla::detail::InvalidArrayIndex r=Gijs,Standard8
We had to skip-if those tests that were crashing during a11y_checks and since the bug 1849230 is resolved now these test can be re-enabled (whenever possible). Two tests have also been failing intermittently, thus they are remaining skipped, but the comment is updated to remove the mention of the crash.

Differential Revision: https://phabricator.services.mozilla.com/D193230
2023-11-11 10:47:21 +00:00
Dão Gottwald
d8353059ce Bug 1852055 - [Firefox Suggest Opt-in Experiment] Implement opt-in UI at the top of the results list. r=daleharvey,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D193198
2023-11-10 11:28:14 +00:00
Cristian Tuns
7b79c3c251 Backed out changeset 09cf9c007215 (bug 1657237) for causing bc failures in browser_enter.js CLOSED TREE 2023-11-10 06:24:46 -05:00
Marc Seibert
e621f5f210 Bug 1657237 - Address Bar flashes punycode when loading page.r=mak
Differential Revision: https://phabricator.services.mozilla.com/D192696
2023-11-10 09:51:36 +00:00
Natalia Csoregi
ab3b33ee93 Backed out changeset 555c786396f8 (bug 1852046) as requested. CLOSED TREE 2023-11-09 20:53:42 +02:00
Stanca Serban
014881cc49 Backed out changeset e65fca949600 (bug 1858994) for causing xpcshell failures in test_autofill_bookmarked.js. 2023-11-08 12:47:20 +02:00
Marc Seibert
c5a7631ede Bug 1858994 - Punycode is shown in heuristic result.r=mak
Differential Revision: https://phabricator.services.mozilla.com/D191218
2023-11-08 09:21:29 +00:00
Cosmin Sabou
7ad28e385c Backed out changeset 41043c74e42a (bug 1860548) for bc failures on browser_quicksuggest_addons.js. CLOSED TREE 2023-11-08 01:06:14 +02:00
Karandeep
a919ed09a3 Bug 1860548 - Enable the URL Paste Suggestion feature by default in Nightly. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D191868
2023-11-07 15:14:38 +00:00
Vinny Diehl
903aa9bb71 Bug 1858854 - Validate input to setTimeZone r=arai
Differential Revision: https://phabricator.services.mozilla.com/D191935
2023-11-04 09:30:35 +00:00
Mark Banner
89ef560a9e Bug 1861676 - Use the new queryParamNames SERP telemetry parameter by default. r=search-reviewers,jteow
Differential Revision: https://phabricator.services.mozilla.com/D191649
2023-11-03 10:35:04 +00:00