corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
810,378 Commits 1 Branch 0 Tags
f45aacc84161ee35c1981fbf19b563fae97a91e3
Commit Graph

203 Commits

Author SHA1 Message Date
Niklas Baumgardner
cfe93676db Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-12-01 16:07:25 +00:00
Stanca Serban
64e390b1b0 Backed out changeset 87051213c0bc (bug 1801954) for causing mochitests failures in browser_overlay_keyboard_test.js and on OSX. CLOSED TREE 2023-12-01 03:44:32 +02:00
Niklas Baumgardner
1b10dae70a Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-11-30 22:11:53 +00:00
Niklas Baumgardner
472611a2c2 Bug 1864889 - Only allow left mouse button on screenshots overlay. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D193680
 2023-11-28 02:33:17 +00:00
Niklas Baumgardner
59a1e1e591 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-14 15:57:46 +00:00
Norisz Fay
1b95461566 Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-11-14 04:06:58 +02:00
Niklas Baumgardner
80c28a9bea Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-13 23:57:17 +00:00
Niklas Baumgardner
6fa986e102 Bug 1862663 - Rename panel-footer-button to footer-button for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D192580
 2023-11-02 18:07:29 +00:00
Niklas Baumgardner
f9babae778 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-02 18:06:38 +00:00
Norisz Fay
15564eb9be Backed out changeset 80cec114b8a6 (bug 1859882) for causing bc failures on browser_screenshots_telemetry_tests.js 2023-11-01 18:00:54 +02:00
Niklas Baumgardner
5f8d4b6939 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-01 15:06:22 +00:00
Niklas Baumgardner
944d49954c Bug 1860611 - Do not skip test_content_events screenshots test. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191667
 2023-10-24 01:04:09 +00:00
Niklas Baumgardner
8331e6faf7 Bug 1855313 - Show current selection size in screenshots overlay. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D189312
 2023-10-20 23:25:37 +00:00
Niklas Baumgardner
3318443a35 Bug 1859394 - Use global styles for screenshots panel buttons. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D191213
 2023-10-20 21:20:58 +00:00
Niklas Baumgardner
6ec1dd524f Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Cosmin Sabou
059db96270 Backed out changeset 08bb959c7dca (Bug 1857946) for being partially backed out by merge back commit. 2023-10-19 07:47:11 +03:00
Sandor Molnar
daf83aa70e Merge mozilla-central to autoland. a=merge 2023-10-19 07:22:30 +03:00
Niklas Baumgardner
7902d47e40 Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Sandor Molnar
f8ed820f86 Backed out changeset b4a0f8afc02e (bug 1857946) for causing bc failures at browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js 2023-10-19 03:33:17 +03:00
Sandor Molnar
8b3c82a079 Backed out changeset b4a0f8afc02e (bug 1857946) for causing bc failures at browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js 2023-10-19 03:33:17 +03:00
Niklas Baumgardner
03bdb6d702 Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-18 20:33:53 +00:00
Emilio Cobos Álvarez
cf3158e57e Bug 1858752 - Explicitly z-sort bghighlight. r=niklas 
Before bug 1799036, this was not an issue because the background and the
highlight ended up in different containing blocks.

Depends on D191137

Differential Revision: https://phabricator.services.mozilla.com/D191138
 2023-10-17 17:24:22 +00:00
Emilio Cobos Álvarez
66cd465db8 Bug 1858752 - Simplify screenshots component markup. r=niklas 
This doesn't fix the issue at hand, but makes stuff easier to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D191137
 2023-10-17 17:24:22 +00:00
Emilio Cobos Álvarez
b12b572bf0 Bug 1859058 - Fix button position after showing them on both sides. r=niklas 
Drive-by, but I noticed it while poking so might as well fix it.

Depends on D191138

Differential Revision: https://phabricator.services.mozilla.com/D191139
 2023-10-17 14:49:22 +00:00
Niklas Baumgardner
5764e40cb8 Bug 1854953 - Improve performance when taking large screenshots. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189158
 2023-10-12 16:15:41 +00:00
Cristina Horotan
29fed10407 Backed out changeset 919bb91f27bb (bug 1854953) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-10-11 00:38:25 +03:00
Niklas Baumgardner
6f5f28c5bf Bug 1854953 - Improve performance when taking large screenshots. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189158
 2023-10-10 16:39:02 +00:00
Sam Foster
52016ee064 Bug 1812202 - Reduce the max capture dimension by 1px. r=niklas 
* Captures at exactly the max dimension (32767) result in a fully transparent image.
* Import these dimensions to use in tests so we have a single source of truth
* Update the same constant in the extension

Differential Revision: https://phabricator.services.mozilla.com/D190221
 2023-10-06 22:37:16 +00:00
Niklas Baumgardner
153c4392df Bug 1855061 - Screenshots overlay buttons should be centered vertically. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189159
 2023-09-28 15:33:08 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Sam Foster
c20c018e69 Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas 
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
  - Separate out getting the panel from creating it
  - closePanel only closes the buttons panel
  - Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Differential Revision: https://phabricator.services.mozilla.com/D185379
 2023-09-19 00:14:27 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Niklas Baumgardner
5eafa5cac5 Bug 1844171 - Update screenshots tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183912
 2023-07-27 16:15:03 +00:00
Niklas Baumgardner
8464bcdbb9 Bug 1844171 - Refactor screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183313
 2023-07-27 16:15:02 +00:00
Sebastian Hengst
945cff3a90 Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js. Complete backout. CLOSED TREE 
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
 2023-07-26 21:24:18 +02:00
Norisz Fay
b81bfc15de Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js CLOSED TREE 
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
 2023-07-26 21:58:58 +03:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Niklas Baumgardner
b6300b00f6 Bug 1844171 - Update screenshots tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183912
 2023-07-26 15:37:45 +00:00
Niklas Baumgardner
51b2d1bafb Bug 1844171 - Refactor screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183313
 2023-07-26 15:37:45 +00:00
Niklas Baumgardner
1f9eb86c84 Bug 1827977 - Use in-content styles for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183423
 2023-07-17 18:39:08 +00:00
Neil Deakin
c2bdd9ab4a Bug 1840269, nsFilePicker::GetFile can return a different object on each call, so only call it once, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D183363
 2023-07-13 20:44:04 +00:00
Emilio Cobos Álvarez
c8d2c23403 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-09 11:34:05 +00:00
Stanca Serban
27c720052b Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE 2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez
8053b896a6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-05 21:59:44 +00:00
Cosmin Sabou
20fa44fbeb Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE 
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
 2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez
b1433254b6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-05 18:21:31 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE 
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
 2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 10:21:37 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D178590
 2023-05-26 11:36:33 +00:00