Commit Graph

577 Commits

Author SHA1 Message Date
Mike Conley
73f229a967 Bug 1841506 - Make sure to run MigrationUtils.finishMigration when tearing down the migration wizard. r=kpatenio
This is needed in order to clear the gProfileStartup state after a startup
migration from a profile reset.

Differential Revision: https://phabricator.services.mozilla.com/D182733
2023-07-04 19:18:57 +00:00
Mike Conley
bf24e238c7 Bug 1840917 - Add a probe to measure how long it takes to show both the legacy and new migration wizard. data-review=jhirsch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182389
2023-07-04 15:36:56 +00:00
Sandor Molnar
baa557ca94 Backed out changeset d4e89e0e7e9b (bug 1840917) for causing bc failures in browser/components/migration/tests/browser/browser_entrypoint_telemetry.js CLOSED TREE 2023-06-30 04:48:41 +03:00
Mike Conley
cd4dc3db2f Bug 1840917 - Add a probe to measure how long it takes to show both the legacy and new migration wizard. data-review=jhirsch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182389
2023-06-29 23:57:26 +00:00
William Durand
daf67c6f7a Bug 1840843 - Handle Chrome extensions without a description in their manifest. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D182353
2023-06-28 19:18:01 +00:00
Mike Conley
875b2b901a Bug 1840488 - Change from classes to a state attribute for the migration wizard progress icon. r=tgiles,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D182274
2023-06-28 16:46:19 +00:00
Mike Conley
a984381bf2 Bug 1840393 - Test that only Chrome (for now) offers extension importing. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182277
2023-06-28 14:15:46 +00:00
Mike Conley
81021b0f18 Bug 1839650 - Add more extension migration tests. r=niklas a=reland CLOSED TREE
Depends on D182116

Differential Revision: https://phabricator.services.mozilla.com/D182117
2023-06-27 16:14:04 +00:00
Mike Conley
ebf4a103b5 Bug 1839650 - Update browser_do_migration test to test extensions resource migration. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D182116
2023-06-27 16:14:04 +00:00
Iulian Moraru
35e017d832 Backed out 2 changesets (bug 1839650) for causing mochitest-chrome failures on test_history.html. CLOSED TREE
Backed out changeset da38525a017e (bug 1839650)
Backed out changeset 397a3150e68c (bug 1839650)
2023-06-27 22:28:09 +03:00
Mike Conley
1c50fdedba Bug 1839650 - Add more extension migration tests. r=niklas
Depends on D182116

Differential Revision: https://phabricator.services.mozilla.com/D182117
2023-06-27 16:14:04 +00:00
Mike Conley
63f241d695 Bug 1839650 - Update browser_do_migration test to test extensions resource migration. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D182116
2023-06-27 16:14:04 +00:00
Mike Conley
22d6bfe4bf Bug 1838926 - Record interaction preference when CSV passwords are imported from the migration wizard. data-review=jhirssch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D181286
2023-06-23 14:14:26 +00:00
William Durand
409e3fa522 Bug 1839830 - Integrate AMBrowserExtensionsImport with the migration wizard UI. r=mconley,mixedpuppy
Depends on D181465

Differential Revision: https://phabricator.services.mozilla.com/D181747
2023-06-23 12:25:55 +00:00
Mike Conley
a049470152 Bug 1839827 - Display a generic error message for password and bookmark file migrations despite the exception. r=kpatenio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D181801
2023-06-23 00:00:52 +00:00
Mike Conley
3f3eff7779 Bug 1839872 - Fix progress and success states for file migrators. r=kpatenio
In bug 1836555, we changed the progress update messages from MigrationWizardParent
from being a binary "in progress" and "not in progress" to a series of possible
values defined under MigrationWizardConstants.PROGRESS_VALUE.

We forgot to update the file migrators to use this, and they were still using
the old `inProgress` flag. This means that the migration occurred, but progress
updates weren't properly displayed.

We had a test for this, but the test was actually broken - it was querying for
the progress groups using a broken query selector. I've fixed the test, added
an additional check to ensure that the progress icons are in the completed
state, and confirmed that the test fails without the fix, and passes with it.

Differential Revision: https://phabricator.services.mozilla.com/D181783
2023-06-22 23:00:48 +00:00
Tim Giles
6d7971b059 Bug 1836773 - Support the new MigrationResource in the migration wizard. r=mconley,willdurand,fluent-reviewers,desktop-theme-reviewers,flod
Enables support for migrating extensions from Chrome once we have the
API to match and install extensions from the add-ons store.

Adds a new ProgressState object to delineate between various progress
states. This new object has four properties: value, message, linkURL,
and linkText. See migration-wizard-constants for more information.

MigrationWizard.#onShowingProgress uses the new ProgressState object
to handle the new LOADING, SUCCESS, ERROR and INFO values for progress.
This has the added benefit of updating the UI on error cases for the
existing resource groups.

Adds a new details object parameter to MigratorBase.migrate which is
currently used in the Chrome extensions import case.
See ChromeProfileMigrator.GetExtensionsResource for an example of
creating this details object.
See MigrationWizardParent.#doBrowserMigration for example usage of this
details object.

Adds support-text links under each resource type group in the markup.
This is currently used only by extensions in the partial matching and
no matching extensions cases.

Refactor MigrationUtils.installExtensionsWrapper to return an array
with the progress state (LOADING, SUCCESS, ERROR, INFO) and any
imported extensions.

Depends on D180005

Differential Revision: https://phabricator.services.mozilla.com/D180876
2023-06-21 20:24:56 +00:00
Cosmin Sabou
3a0d2da9d4 Backed out changeset 5be10443a2ea (bug 1807618) for mochitest failures on test_autocomplete_password_generation.html. 2023-06-16 00:48:28 +03:00
Neil Deakin
410283a615 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-06-15 20:39:05 +00:00
Marco Castelluccio
e242e5b9dd Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-15 08:10:45 +00:00
Noemi Erli
7ca9d6cc02 Backed out changeset 63ccd00a399a (bug 898315) for causing failures in test_no_window_update_restart.py CLOSED TREE 2023-06-15 03:21:27 +03:00
Marco Castelluccio
747c4ff841 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-14 20:55:52 +00:00
Mike Conley
a998b6f44b Bug 1837367 - Throw an error if the bookmarks file migrator doesn't import anything. r=tgiles,fluent-reviewers,flod
An earlier patch in the series makes the error message appear in the
migration wizard on the selection page.

Depends on D180490

Differential Revision: https://phabricator.services.mozilla.com/D180491
2023-06-13 14:53:00 +00:00
Mike Conley
99e87d9a44 Bug 1837367 - Allow file migrators to show an error message if migration failed for some reason. r=kpatenio,desktop-theme-reviewers
The spec calls for a special-case in the event that file migration
ever fails - the wizard should be sent back to the selection page,
have the associated file migrator still set in the dropdown, and
show an error message.

A later patch in this series will add such an error message for
the bookmarks file migrator.

Depends on D180458

Differential Revision: https://phabricator.services.mozilla.com/D180490
2023-06-13 14:53:00 +00:00
Mike Conley
1ddda0a319 Bug 1837619 - Make sure to clear the file progress status message when going back to in-progress. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D180458
2023-06-12 19:45:51 +00:00
Mike Conley
e27d937911 Bug 1823537 - Add tests for the ported telemetry probes. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D180232
2023-06-09 17:39:51 +00:00
Mike Conley
9dcf68ac4d Bug 1823537 - Use new migration wizard for startup and profile reset migrations. r=kpatenio,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D180230
2023-06-09 17:39:51 +00:00
Mark Banner
40de601f11 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Mike Conley
eee3689314 Bug 1833460 - Don't run test_Chrome_credit_cards.js on official builds. r=NeilDeakin
This appears to be a limitation of what we can do on official builds, and so
we just simply don't run these kinds of tests on official builds.

Differential Revision: https://phabricator.services.mozilla.com/D179493
2023-06-01 13:58:54 +00:00
Sandor Molnar
178e788bb5 Backed out changeset fbac3e184322 (bug 1833460) for causing xpc failures in browser/components/migration/tests/unit/test_Chrome_credit_cards.js CLOSED TREE 2023-06-01 01:45:36 +03:00
Mike Conley
73aff02250 Bug 1833460 - Don't run test_Chrome_credit_cards.js on official builds. r=NeilDeakin
This appears to be a limitation of what we can do on official builds, and so
we just simply don't run these kinds of tests on official builds.

Differential Revision: https://phabricator.services.mozilla.com/D179493
2023-05-31 20:59:57 +00:00
Mark Striemer
44dc08eca6 Bug 1236916 - Part 2: Test Safari history migration r=mconley
Depends on D179104

Differential Revision: https://phabricator.services.mozilla.com/D179170
2023-05-30 17:06:53 +00:00
Norisz Fay
6b675bf3ee Backed out 2 changesets (bug 1236916) for causing xpcshell failures on test_Safari_bookmarks.js
Backed out changeset 539dfe08bec7 (bug 1236916)
Backed out changeset a0b5a7ade705 (bug 1236916)
2023-05-30 19:20:17 +03:00
Mark Striemer
35c661e687 Bug 1236916 - Part 2: Test Safari history migration r=mconley
Depends on D179104

Differential Revision: https://phabricator.services.mozilla.com/D179170
2023-05-30 14:27:50 +00:00
Mike Conley
4972dd2d5f Bug 1833427 - Add bookmark import from HTML file in new migration wizard. r=fluent-reviewers,kpatenio,flod
Original patch by Tim Giles <tgiles@mozilla.com>, completed by Mike Conley <mconley@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D179273
2023-05-30 13:37:54 +00:00
Stanca Serban
756a528d42 Backed out 2 changesets (bug 1236916) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE
Backed out changeset 2c9ee3c4df9f (bug 1236916)
Backed out changeset 7989dfc3c15c (bug 1236916)
2023-05-29 22:31:01 +03:00
Mark Striemer
d80c089ec1 Bug 1236916 - Part 2: Test Safari history migration r=mconley
Depends on D179104

Differential Revision: https://phabricator.services.mozilla.com/D179170
2023-05-29 17:30:16 +00:00
Mike Conley
e62aa51bdc Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
2023-05-29 16:12:41 +00:00
Butkovits Atila
9664e002bb Backed out changeset 863fae78db03 (bug 1825874) for causing failures at browser_disabled_migrator.js. CLOSED TREE 2023-05-29 18:34:53 +03:00
Mike Conley
e359cbe532 Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
2023-05-29 14:39:59 +00:00
Sandor Molnar
58302e881e Backed out 2 changesets (bug 1236916) for causing xpc failures in browser/components/migration/tests/unit/test_Safari_history.js CLOSED TREE
Backed out changeset 2f004b59bfdb (bug 1236916)
Backed out changeset a2f5b34d7551 (bug 1236916)
2023-05-27 00:31:36 +03:00
Mark Striemer
c5c9f8dcf6 Bug 1236916 - Part 2: Test Safari history migration r=mconley
Depends on D179104

Differential Revision: https://phabricator.services.mozilla.com/D179170
2023-05-26 20:30:53 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
Mike Conley
19c3af2752 Bug 1835116 - Make it possible to disable payment method import from Chrome via a pref. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D179122
2023-05-25 20:16:04 +00:00
Mike Conley
dc1b375397 Bug 1826149 - Add payment method migration experience in new migration wizard. r=niklas,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D178364
2023-05-25 20:16:04 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D177423
2023-05-24 15:52:34 +00:00
Mike Conley
12aaa8d45f Bug 1830891 - Clear new migration wizard progress strings when going back to in-progress. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D178856
2023-05-23 23:13:26 +00:00
Natalia Csoregi
1b67d0b941 Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
2023-05-24 04:29:45 +03:00
Mark Banner
d1fc869252 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 19:09:29 +00:00
Noemi Erli
1f146f097e Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
2023-05-23 12:14:37 +03:00