Commit Graph

1467 Commits

Author SHA1 Message Date
Sidharth Sachdev
43b6f2450c Bug 1867031 - Update miscellaneous Strings, e.g. Migration Wizard. r=issammani,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D195376
2023-12-04 14:21:19 +00:00
Sylvestre Ledru
5bd4bc54a3 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot
clang-format version 17.0.6 (taskcluster-QueHFUviQeyM8Y7r_d7MQQ)

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D195397
2023-12-04 10:09:36 +00:00
Joel Maher
33fa84a382 Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Mike Conley
1201221bf2 Bug 1860606 - Get rid of migration.ftl in favour of migrationWizard.ftl. r=kpatenio,fluent-reviewers,bolsson
migration.ftl was used by the old, legacy XUL migration dialog that was removed
in bug 1824851.

There were still a few strings being used by migration.ftl, but I've moved those
over to migrationWizard.ftl, and gone ahead and just removed the old file.

Differential Revision: https://phabricator.services.mozilla.com/D192509
2023-11-02 22:03:26 +00:00
Mike Conley
882584cc9e Bug 1824851 - Remove the legacy XUL-based migration dialog. r=kpatenio
This also gets rid of some Histograms and Scalars that only the legacy wizard was
using, and also gets rid of the "legacy_wizard" object for migration wizard events.

Differential Revision: https://phabricator.services.mozilla.com/D191227
2023-10-23 16:08:06 +00:00
Cosmin Sabou
b76dbd47b9 Bug 1858783 - Fix browser_permissions.js filtering failures. a=test-only CLOSED TREE 2023-10-19 00:23:36 +03:00
Mike Conley
ee031a3626 Bug 1858783 - Add a telemetry event for when migration permissions are requested for Snap packages. data-review=jhirsch,r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D190934
2023-10-18 19:16:38 +00:00
Dave Townsend
f2f7777e96 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-18 07:04:41 +00:00
Anna Yeddi
e2a8d8ebc6 Bug 1858041 - Temporarily skip of fail-if some Tier 2 a11y_checks failing or crashing on Autoland. r=Jamie,fxview-reviewers,ochameau,devtools-reviewers,places-reviewers,mixedpuppy
There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.

Related bugs:
- Fail-if tests: meta bug 1848402
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D190890
2023-10-17 18:00:05 +00:00
Mike Conley
3c473874e4 Bug 1855280 - Remove the ability to switch to the old migration wizard. r=kpatenio,omc-reviewers,settings-reviewers,credential-management-reviewers,negin,aminomancer,mtigley
This removes the pref to re-enable the legacy wizard, and all of the things that used
to read from it.

It also disables the ability to use the legacy wizard from about:welcome with the
aboutWelcomeBehavior feature.

It also removes the closeMigrationWizard utility from BrowserTestUtils, since that
effectively became a thin-wrapper around BrowserTestUtils.removeTab.

Finally, this patch also removes some documentation about the legacy migration wizard,
and tests that specifically check the legacy dialog behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D190716
2023-10-16 18:24:42 +00:00
Sandor Molnar
099f0fd4c3 Backed out 4 changesets (bug 1857999) for causing dt failures on browser_theme_switching.js & Mn failures at test_element_state_chrome.py CLOSED TREE
Backed out changeset 75f5e6e3d917 (bug 1857999)
Backed out changeset 0d0c1d1e80e7 (bug 1857999)
Backed out changeset b8a03d31ecea (bug 1857999)
Backed out changeset dd5a10f9cfff (bug 1857999)
2023-10-16 14:12:22 +03:00
Dave Townsend
92c3ea0f78 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-16 09:43:26 +00:00
Mike Conley
1ba58e779d Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
Depends on D188874

Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 20:09:22 +00:00
Mike Conley
5085c317ab Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 20:09:21 +00:00
Sandor Molnar
d8a0e28ce0 Backed out 2 changesets (bug 1818237) for causing xpc failures on browser/components/migration/tests/unit/test_Chrome_permissions.js CLOSED TREE
Backed out changeset e5d78a9ddcb4 (bug 1818237)
Backed out changeset 87f67f05c8a8 (bug 1818237)
2023-10-11 19:53:35 +03:00
Anna Yeddi
d3ec1141aa Bug 1858037 - Temporarily skip some tests to investigate intermittent a11y_checks results. r=Jamie,devtools-reviewers,mixedpuppy
These tests were failing on Try but are passing on Autoland or vice versa. We need to skip them while we investigate it

Differential Revision: https://phabricator.services.mozilla.com/D190523
2023-10-11 15:26:25 +00:00
Mike Conley
3c1fdf043c Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
Depends on D188874

Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 14:53:56 +00:00
Mike Conley
1452dbdc7b Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 14:53:55 +00:00
Sandor Molnar
3a1563107d Backed out 2 changesets (bug 1818237) for causing mochitest/xpc failures on browser/components/migration/<...>.js CLOSED TREE
Backed out changeset a8584f57dc7c (bug 1818237)
Backed out changeset 477292e081b3 (bug 1818237)
2023-10-11 09:32:23 +03:00
Mike Conley
bb96d52ce8 Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
Depends on D188874

Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 04:16:49 +00:00
Mike Conley
bcdf5f918d Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 04:16:49 +00:00
Anna Yeddi
e520bc6b10 Bug 1855491 - Temporarily fail-if one Tier 2 a11y_checks for Profile Migration. r=Jamie,Gijs
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.

This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Fail-if tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Profile Migration-specific bug 1855492
- Explore capturing click events for a11y_checks: bug 1692110

Depends on D188925

Differential Revision: https://phabricator.services.mozilla.com/D189410
2023-10-09 18:20:20 +00:00
Cristian Tuns
896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
2023-10-07 14:43:05 -04:00
Anna Yeddi
d6d0ef33bc Bug 1855491 - Temporarily disable one Tier 2 a11y_checks for Profile Migration. r=Jamie,Gijs
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Profile Migration-specific bug 1855492
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D189410
2023-10-06 18:11:37 +00:00
Spiros Vita
058b7629b6 Bug 1013947 - Removed signons.sqlite references r=mak,credential-management-reviewers,dimi
Added functionality to remove signons.sqlite.corrupt and fixed code

Differential Revision: https://phabricator.services.mozilla.com/D189349
2023-10-05 12:29:05 +00:00
Sylvestre Ledru
2e0e132821 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Masatoshi Kimura
8262afb8c6 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 19:00:07 +00:00
Noemi Erli
8561f7ec9a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
2023-10-02 21:16:25 +03:00
Masatoshi Kimura
89e9a36583 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 17:36:27 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Mike Conley
a6165845b4 Bug 1853765 - Use BrowserTestUtils.is_visible instead of workaround in browser_file_migration.js. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D188517
2023-09-19 20:42:16 +00:00
Marco Bonardo
6874dffc71 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Mike Conley
537ddd9c0c Bug 1852973 - Delegate the responsibility of opening about:addons from the migration wizard to MigrationWizardParent. r=tgiles
Originally, we had had the extensions migration success link work by using a normal
anchor element with "about:addons" set as the href. This works on privileged pages like
about:preferences, but not for unprivileged pages like about:welcome - unprivileged
pages are generally unable to directly link to most about: pages.

The solution here is to continue to use an anchor element, but to use an event handler
on it rather than a "href" attribute, and have the MigrationWizardParent hear that
click event and take responsibility for opening about:addons.

As part of this, we're also intentionally choosing to open about:addons in a background
tab so that the user can continue to work through their onboard flow uninterrupted
should they click on the link while on about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D188116
2023-09-13 21:28:21 +00:00
Tom Marble
d70780c99c Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D187597
2023-09-13 18:28:32 +00:00
Hanna Jones
537a724772 Bug 1810890 - Part 4: remove Storybook CSS path rewrite from migration wizard r=mconley
Depends on D185092

Differential Revision: https://phabricator.services.mozilla.com/D185093
2023-09-05 17:48:25 +00:00
Mike Hommey
36d173450d Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw
For some reason, its value in the Google style we use is 80... except
for Objective-C, where it's 100, which led to things like:
https://hg.mozilla.org/mozilla-central/rev/31bf68247e6e
https://hg.mozilla.org/mozilla-central/rev/64ceb33533a4.

There's probably a discussion to have about whether 80 is the right
limit, but since it's what's used for everything except ObjC, let's roll
with it.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D187409
2023-09-05 11:23:01 +00:00
serge-sans-paille
19ef354875 Bug 1850477 - unified sources for browser/components/migration r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D187022
2023-08-30 08:52:26 +00:00
Neil Deakin
90a396f96a Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin

Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-15 00:21:05 +00:00
negin
767e32c8ae Bug 1847276 - [about:welcome] Make Embedded Migration wizard variant 1 design default experiment r=pdahiya,mconley
Differential Revision: https://phabricator.services.mozilla.com/D185462
2023-08-10 16:26:34 +00:00
Mike Conley
b068011380 Bug 1847815 - Allow embedders of the migration-wizard to override the variant pref via an attribute. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D185707
2023-08-09 18:57:07 +00:00
Gregory Pappas
e10089e029 Bug 1847816 - Remove unneeded Windows version checks in EdgeProfileMigrator r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D185700
2023-08-08 21:15:25 +00:00
Sandor Molnar
2899c1f4da Backed out changeset b463b9cd8aef (bug 1846036) for causing failures in toolkit/components/passwordmgr/test/mochitest/test_prompt.html CLOSED TREE 2023-08-05 02:15:47 +03:00
Neil Deakin
5e36a94898 Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin

Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-04 18:36:03 +00:00
Natalia Csoregi
d056914a5b Bug 1840718 - Disabled browser_extension_migration.js for having a high failure rate almost exclusively on Windows 11. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D185378
2023-08-04 01:06:17 +00:00
Gregory Pappas
e6625835b6 Bug 1846934 - Remove IE7FormPasswords migrator r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D185267
2023-08-03 19:07:06 +00:00
Gregory Pappas
cbc509b483 Bug 1846843 - Remove Windows 8 checks from WindowsVaultFormPasswords migrator r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D185209
2023-08-03 19:06:41 +00:00
Mike Conley
e0e8f038f1 Bug 1807023 - Record successfully matched and failed-to-match extension ids during import. data-review=chutten. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D184512
2023-08-03 13:13:43 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00