Commit Graph

37992 Commits

Author SHA1 Message Date
Thomas Wisniewski
5d319651cd Bug 1866291 - Display messages when Report Broken Site disables its send button; r=Gijs,fluent-reviewers,desktop-theme-reviewers,flod,Itiel
Depends on D195568

Differential Revision: https://phabricator.services.mozilla.com/D195129
2023-12-07 21:38:13 +00:00
Mark Banner
9591aa584c Bug 1868114 - Drop schema support for chrome_settings_overrides.searchProvider.params in Manifest v3. r=extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D195775
2023-12-07 21:12:22 +00:00
Thomas Wisniewski
8491d00e6d Bug 1867690 - Fix ARIA annotations for Report Broken Site so NVDA reads more of the dialog; r=ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D195624
2023-12-07 20:10:26 +00:00
Iulian Moraru
97e8a43b88 Backed out 2 changesets (bug 1844869, bug 1861462) for causing bc failures on browser_alertDismissedAfterChangingPassword.js. CLOSED TREE
Backed out changeset 8abe07143c80 (bug 1861462)
Backed out changeset e4b8ac1dfda7 (bug 1844869)
2023-12-07 17:59:58 +02:00
Sidharth Sachdev
cb02a2e3a8 Bug 1861462 - Update tests for about logins based on the new command-button component. r=credential-management-reviewers,issammani
Differential Revision: https://phabricator.services.mozilla.com/D194543
2023-12-07 15:00:49 +00:00
Sidharth Sachdev
da25916d01 Bug 1844869 - Clean up and make each login-command-button self-contained for about:logins. r=credential-management-reviewers,desktop-theme-reviewers,dao,mtigley,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D189607
2023-12-07 15:00:49 +00:00
Kelly Cochrane
187108a7a7 Bug 1868443 - Update calculation for viewport height in Firefox View r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D195723
2023-12-07 13:54:25 +00:00
Mike Kaply
e6dba2f53b Bug 1868137 - Allow setting alerts. prefs via policy. r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D195731
2023-12-07 13:45:11 +00:00
Anna Yeddi
932f6dd99d Bug 1868707 - Make Clear-icon control in the search field in Firefox View accessible. r=fxview-reviewers,sclements
Adding a role and including the implicit button in the logical focus order of the page.

Differential Revision: https://phabricator.services.mozilla.com/D195742
2023-12-07 11:50:08 +00:00
Dão Gottwald
cf2f871874 Bug 1868131 - [Firefox Suggest Opt-in Experiment] Further improve wrapping behavior. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D195635
2023-12-07 10:19:35 +00:00
Marc Seibert
ba88c2739e Bug 1863110 - If trimHttps is enabled, domain highlighting is not applied when loading suggested bookmark.r=dao
Differential Revision: https://phabricator.services.mozilla.com/D192941
2023-12-07 09:04:44 +00:00
Jason Prickett
b93d412443 Bug 1831144 - Add fox doodle spotlight message and fix failure of unrelated tests r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D191878
2023-12-07 08:07:22 +00:00
Chris Peterson
4713f925af Bug 1865766 - Freeze the Android OS version in Firefox Android’s User-Agent string at "Android 10". r=geckoview-reviewers,necko-reviewers,valentin,owlish
This will match Chrome Android's UA string. As part of Chrome’s UA reduction, Google froze the Android OS version exposed in Chrome’s UA string to "10". Google finished rolling out that change in Chrome 110 in May 2023: https://www.chromium.org/updates/ua-reduction

Goals:

1. Reduce fingerprintable entropy passively exposed to the web.
2. Reduce risk of webcompat breakage for new Android OS versions.

Differential Revision: https://phabricator.services.mozilla.com/D194686
2023-12-07 04:51:39 +00:00
Chris Peterson
6120ef2962 Bug 1865766 - Replace osVersion with "Windows 10.0" in browser_navigator.js tests. r=necko-reviewers,valentin
The UA string's Windows OS version was frozen at version "10.0" in bug 1841425.

Differential Revision: https://phabricator.services.mozilla.com/D194685
2023-12-07 04:51:39 +00:00
Drew Willcoxon
880b3168e6 Bug 1821112 - Make the urlbar muxer take span and count limits into account when adding suggested-index results. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D195335
2023-12-07 00:19:46 +00:00
Jules Simplicio
4636220632 Bug 1825032 - How to guide for design tokens r=morgan,reusable-components-reviewers,desktop-theme-reviewers,hjones,dao
Differential Revision: https://phabricator.services.mozilla.com/D189004
2023-12-06 22:46:22 +00:00
Jason Prickett
da24bddf95 Bug 1866501 - Add style to shopping survey and onboarding card to support variable width r=pdahiya,omc-reviewers,negin
Simple fix to address the survey container's overflow issue in the sidebar. This allows the survey to stretch to fit the outer container, which allows the rest of the container's content to flow responsively.

Differential Revision: https://phabricator.services.mozilla.com/D195063
2023-12-06 22:26:23 +00:00
Emily McMinn
af3335ba5f Bug 1861457 - Handle FR and DE domains for onboarding subtitle r=jhirsch,fluent-reviewers,flod,shopping-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D194568
2023-12-06 21:57:33 +00:00
Anna Yeddi
e04f794cdd Bug 1857056 - Re-enabling 3 test for a11y-checks after the crash was fixed. r=dholbert,extension-reviewers,rpl
Since the crash in the bug 1868456 was fixed, we could re-enable these 3 test files that were previously crashing on trunk while a11y-checks were running, thus we are removing the `skip-if` notations from their test manifests.

Depends on D195646

Differential Revision: https://phabricator.services.mozilla.com/D195647
2023-12-06 21:17:28 +00:00
Mike Conley
4936b01244 Bug 1715158 - Remove Snippets enterprise policy support. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D195448
2023-12-06 16:15:17 +00:00
Mike Conley
6be1cf7b49 Bug 1715158 - Document how the IndexedDB 'snippets' store is used for more than just snippet data these days. r=pdahiya
Depends on D193856

Differential Revision: https://phabricator.services.mozilla.com/D193857
2023-12-06 16:15:16 +00:00
Mike Conley
811a60b0f5 Bug 1715158 - Remove traces of snippets from source documentation. r=pdahiya,perftest-reviewers,sparky
Depends on D193855

Differential Revision: https://phabricator.services.mozilla.com/D193856
2023-12-06 16:15:16 +00:00
Mike Conley
a3b3f76e18 Bug 1715158 - Remove snippet-related SCSS/CSS. r=thecount
Depends on D193854

Differential Revision: https://phabricator.services.mozilla.com/D193855
2023-12-06 16:15:15 +00:00
Mike Conley
b6711f55d6 Bug 1715158 - Remove ASRouterUISurface, snippet templates, and associated tests. r=pdahiya
Depends on D193853

Differential Revision: https://phabricator.services.mozilla.com/D193854
2023-12-06 16:15:15 +00:00
Mike Conley
3ba090a3e4 Bug 1715158 - Remove snippets ASRouter infrastructure and stop using ASRouterUISurface in Base.jsx. r=pdahiya,thecount
Depends on D193852

Differential Revision: https://phabricator.services.mozilla.com/D193853
2023-12-06 16:15:14 +00:00
Mike Conley
6b4b6388f9 Bug 1715158 - Remove snippets preference in about:preferences. r=Gijs,fluent-reviewers
Depends on D193851

Differential Revision: https://phabricator.services.mozilla.com/D193852
2023-12-06 16:15:14 +00:00
Mike Conley
6bed43f224 Bug 1715158 - Remove tests and ASRouterAdmin capabilities for snippets / ASRouterUISurface. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D193851
2023-12-06 16:15:13 +00:00
Sam Foster
64aa7a8980 Bug 1863642 - Move the open tabs context menu functionality to its own component. r=fxview-reviewers,sclements
* Create a new OpenTabsContextMenu to replace the inlined menu content in the open tabs template
* Fetch the devices list when the menu opens, rather than updating it in the background
* Add a getLogger to the helpers module to easily create named loggers

Differential Revision: https://phabricator.services.mozilla.com/D193138
2023-12-05 23:29:16 +00:00
Perry McManis
c597e5e9aa Bug 1849006 - Remove PingCentre instrumentation from Messaging System r=chutten,dmose,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D195031
2023-12-05 22:38:44 +00:00
Katherine Patenio
d26d5f694d Bug 1858374 - improve HCM accessibility for accordion shopping cards r=shopping-reviewers,desktop-theme-reviewers,ayeddi,niklas,reusable-components-reviewers,tgiles,dao
This patch makes the accordion cards act more like dropdowns, mainly for improved HCM usability. This affects:
- background-color, text color for `summary` and chevron icon when hovering/activating

Figma: https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Review-Checker-Spec?node-id=61%3A21653&mode=dev

Slack conversation: https://mozilla.slack.com/archives/C0568AAEX2A/p1697484887557989

Differential Revision: https://phabricator.services.mozilla.com/D190737
2023-12-05 17:29:01 +00:00
Thomas Wisniewski
98c5f0a5ba Bug 1866120 - do not use color-background-success for the Report Broken Site confirmation screen if @media(prefers-contrast); r=Gijs,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D195536
2023-12-05 15:58:44 +00:00
Dão Gottwald
0c05b05153 Bug 1868238 - Fix password reveal button styling. r=emilio,desktop-theme-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D195529
2023-12-05 15:53:33 +00:00
Karandeep
d41e533454 Bug 1852045 - Hide the "Show search suggestions in address bar results" checkbox when the search bar isn't in the toolbar. r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D192571
2023-12-05 11:04:39 +00:00
Sarah Clements
e761c059e2 Bug 1863692 - Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao
* add new marionette test

Differential Revision: https://phabricator.services.mozilla.com/D195006
2023-12-05 10:54:20 +00:00
Sarah Clements
c1ec906f3c Bug 1867773 - Set up triage rotation r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D195231
2023-12-05 10:46:24 +00:00
Nipun Shukla
d49395ed96 Bug 1867080 - Implemented macOS functionality to find all other installed applications which support a protocol r=mhughes
Differential Revision: https://phabricator.services.mozilla.com/D195203
2023-12-05 05:38:34 +00:00
Sidharth Sachdev
eada5ad9df Bug 1867013 - Update Strings for about:logins - Import Passwords. r=credential-management-reviewers,bolsson,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195048
2023-12-05 00:17:49 +00:00
Iulian Moraru
99771d0bc6 Backed out changeset 978a1152fffd (bug 1867080) for causing build bustages on nsMacShellService.cpp. CLOSED TREE 2023-12-05 01:30:10 +02:00
Nipun Shukla
bb2b826e38 Bug 1867080 - Implemented macOS functionality to find all other installed applications which support a protocol r=mhughes
Differential Revision: https://phabricator.services.mozilla.com/D195203
2023-12-04 21:54:20 +00:00
Anna Yeddi
45a064e6b8 Bug 1866598 - Temporary fail-if two Tier 2 a11y-checks for Firefox View side navigation. r=fxview-reviewers,sfoster
There are 2 tests that are related to the bug 1867170 changes to the AccessibilityUtils, and the general case of the `<fxview-category-button>` and other navigation sidebar-related focusability false-positive a11y-check fails. We are temporary add `skip-if` condition to these two failing tests while we continue working on the bug 1867378 work to fine-tune the AccessibilityUtils. The bug 1867378 patch would also include removing those temporary `skip-if`s from the Fx View manifest too.

Related Firefox View bugs:
- Disabling tests: meta bug 1854625
- Investigation and remediation for components with disabled tests: meta bugs 1854625 and 1858041
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D195461
2023-12-04 20:30:30 +00:00
Kelly Cochrane
c3711a4fb7 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-12-04 17:50:04 +00:00
Nikki Sharpley
04bac1a986 Bug 1864505 - Move "Connect another device" button to top of the page of "Tabs from other devices" r=desktop-theme-reviewers,fxview-reviewers,kcochrane
- Moved "footer" to within sticky container above cards and renamed to "header".
- Update "Connect another device" button to use the `.small-button` styling
- Conditionally display `Recently closed tabs` `h2` on the corresponding view only (an existing bug revealed in this patch)
- Update `.sticky-container` to reflect upcoming styling with the inclusion of search and other secondary headers.

Please see link to bug for screenshot of intended appearance.

Differential Revision: https://phabricator.services.mozilla.com/D193930
2023-12-04 17:16:29 +00:00
Sidharth Sachdev
43b6f2450c Bug 1867031 - Update miscellaneous Strings, e.g. Migration Wizard. r=issammani,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D195376
2023-12-04 14:21:19 +00:00
Johannes J. Schmidt
0b4bf0b0eb Bug 1867015 - Update Strings for about:preferences - Sync page - r=credential-management-reviewers,fluent-reviewers,settings-reviewers,flod,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195118
2023-12-04 13:55:36 +00:00
Eemeli Aro
07145792f8 Bug 1814969: Migrate ContextualIdentityService strings to Fluent r=geckoview-reviewers,fluent-reviewers,mconley,owlish,flod
This includes a containers.json version increment and the necessary migration,
as the StringBundle identifiers are replaced with a Fluent reference.

As it's not possible to filter the attributes that are applied with DOM localization,
the code in utilityOverlay.js is a little clumsy. The non-acceskey versions are needed
due to bug 1297738, i.e. the long-press menu available from the tab bar down arrow.

Previously, the "Manage containers" menu item and its accesskey were defined in two places.
These are here combined into one.

Differential Revision: https://phabricator.services.mozilla.com/D194510
2023-12-04 13:09:15 +00:00
Noemi Erli
8b8bc7d73b Backed out changeset e1a0d895f3a9 (bug 1863692) for causing failures in test_restore_manually.py 2023-12-04 14:52:24 +02:00
Sarah Clements
f32c50299f Bug 1863692 - Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao
* add new marionette test

Differential Revision: https://phabricator.services.mozilla.com/D195006
2023-12-04 11:28:16 +00:00
Sylvestre Ledru
5bd4bc54a3 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot
clang-format version 17.0.6 (taskcluster-QueHFUviQeyM8Y7r_d7MQQ)

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D195397
2023-12-04 10:09:36 +00:00
Emilio Cobos Álvarez
c9bf1fd2ae Bug 1867769 - Fix one left-over usage of checkbox variables that I thought was independent of the rest.
MANUAL PUSH: Trivial fix CLOSED TREE
2023-12-02 21:19:29 +01:00
Sidharth Sachdev
298dee8184 Bug 1867014 - Update Strings for about:logins - Default. r=credential-management-reviewers,bolsson,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195047
2023-12-02 17:02:25 +00:00