corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
895,929 Commits 1 Branch 0 Tags
f43ce0afa5e7b44d41bf559cbb30f23cfa4604d3
Commit Graph

516 Commits

Author SHA1 Message Date
Jonathan Sudiaman
ff8389ea29 Bug 1946868 - Remove "Turn on/off Vertical Tabs" in the tab context menu r=sidebar-reviewers,tabbrowser-reviewers,nsharpley,dao 
Backout of Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs.

Differential Revision: https://phabricator.services.mozilla.com/D238106
 2025-02-14 00:55:12 +00:00
Sam Foster
8559325d30 Bug 1947526 - Preserve user's visibility pref value and fix default expanded state when switching to vertical tabs. r=sidebar-reviewers,nsharpley,kcochrane 
* Make sure we don't overwrite a user's choice to hide-sidebars in vertical tabs at startup
* Roll in a fix to bug 1947257 and ensure the launcher is initially expanded when enabling vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D237849
 2025-02-13 23:45:43 +00:00
Sandor Molnar
5e5967d04b Bug 1898739 - Disable test 'browser_toolbar_sidebar_button.js' on win/linux/mac for frequent failures. r=intermittent-reviewers,jmaher 
Differential Revision: https://phabricator.services.mozilla.com/D238111
 2025-02-13 22:11:48 +00:00
Ryan Safaeian
3b015b140d Bug 1946830 - [contextual-password-manager] Add new probe for when CPM is toggled in sidebar. r=mtigley,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237931
 2025-02-13 21:03:21 +00:00
Alexandru Marc
02f189b30b Bug 1919183 - Disable browser_glean_sidebar.js on win/mac/linux x64 for frequent failures r=intermittent-reviewers,jmaher DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D237862
 2025-02-12 14:56:18 +00:00
Emilio Cobos Álvarez
c67d8c9c9c Bug 1946764 - Support non-boolean media query prefs via -moz-pref(). r=firefox-style-system-reviewers,desktop-theme-reviewers,settings-reviewers,tabbrowser-reviewers,places-reviewers,sidebar-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,dao,mconley,dshin,mak 
Allow querying int and string prefs too via functional syntax:

```
@media -moz-pref("pref-name", <value>) {
```

No argument means the pref exists and has a non-zero/false/empty value.
Unfortunately stylelint is still unhappy with this so we need to keep
the annoying comments...

Differential Revision: https://phabricator.services.mozilla.com/D237275
 2025-02-12 12:14:42 +00:00
Butkovits Atila
3bc2e1759e Backed out changeset f1089681a6c6 (bug 1946764) for causing failures at browser_preferences_usage.js. 2025-02-11 21:24:36 +02:00
Emilio Cobos Álvarez
bab7f36d0f Bug 1946764 - Support non-boolean media query prefs via -moz-pref(). r=firefox-style-system-reviewers,desktop-theme-reviewers,settings-reviewers,tabbrowser-reviewers,places-reviewers,sidebar-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,dao,mconley,dshin,mak 
Allow querying int and string prefs too via functional syntax:

```
@media -moz-pref("pref-name", <value>) {
```

No argument implies bool. Unfortunately stylelint is still unhappy with
this so we need to keep the annoying comments...

Differential Revision: https://phabricator.services.mozilla.com/D237275
 2025-02-11 17:26:17 +00:00
Nikki Sharpley
94a85bdc4f Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-11 16:29:47 +00:00
Jonathan Sudiaman
80c4ec2838 Bug 1946188 - Add test for resizing the sidebar after toggling revamp on and off r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236935
 2025-02-11 00:05:12 +00:00
Jonathan Sudiaman
5e9cd630a5 Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-11 00:05:12 +00:00
Norisz Fay
322845f56e Backed out changeset 022da00de2e7 (bug 1944910) for causing failures on browser_vertical_tabs.js CLOSED TREE 2025-02-11 05:34:20 +02:00
Nikki Sharpley
3b00c42254 Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-10 14:32:23 +00:00
Alexandru Marc
88bcc4fdba Backed out 2 changesets (bug 1946188, bug 1945927) for causing bc failures @ browser_sidebar_max_width.js 
Backed out changeset 12f92dcdff8d (bug 1946188)
Backed out changeset b71374a4ec8d (bug 1945927)
 2025-02-10 16:59:42 +02:00
Jonathan Sudiaman
856cc21a41 Bug 1946188 - Add test for resizing the sidebar after toggling revamp on and off r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236935
 2025-02-10 13:31:32 +00:00
Jonathan Sudiaman
fa275b3b28 Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-10 13:31:32 +00:00
Alexandru Marc
f43ff8bcd9 Backed out changeset 24d23a09f65c (bug 1944910) for causing bc failures @ browser_newtabButton.js CLOSED TREE 2025-02-08 15:17:08 +02:00
Nikki Sharpley
88603ffd0e Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-07 22:03:50 +00:00
Nikki Sharpley
a2d5c620ea Bug 1903937 - Disable browser_customize_sidebar.js on linux1804 for frequent failures r=intermittent-reviewers,sidebar-reviewers,jmaher,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D237229
 2025-02-07 20:42:33 +00:00
Kelly Cochrane
6fd7168076 Bug 1946675 - Fix for sidebar animations after recent changes for expand on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D237233
 2025-02-07 19:36:03 +00:00
Butkovits Atila
d45f0bd128 Backed out changeset e38f4befbd26 (bug 1946675) for causing failures at browser_parsable_css.js. CLOSED TREE 2025-02-07 21:14:51 +02:00
Kelly Cochrane
b5ee7175f0 Bug 1946675 - Fix for sidebar animations after recent changes for expand on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D237233
 2025-02-07 17:57:42 +00:00
Sarah Clements
7f4a749225 Bug 1946589 - Vertical pinned tabs should not close when clicking top corner r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D237242
 2025-02-07 17:50:49 +00:00
Kelly Cochrane
9430fe2dd3 Bug 1946532 - Temporarily remove expand on hover styles/listeners if toolbar button is used to expand the sidebar in expand on hover mode r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D237101
 2025-02-07 15:14:54 +00:00
Sam Foster
3212d879b7 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-07 00:33:29 +00:00
Stanca Serban
35dcb51890 Backed out changeset e1b44a36cc7b (bug 1944931) for causing mochitests failures in browser_toolbarKeyNav.js. CLOSED TREE 2025-02-06 23:07:09 +02:00
Sam Foster
9e30d4a3f1 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-06 19:24:32 +00:00
Goloman Adrian
d2c88036c2 Backed out changeset ff0ae341ed38 (bug 1945927) for causing bc failures @browser_customize_sidebar.js. CLOSED TREE 2025-02-06 18:52:47 +02:00
Jonathan Sudiaman
094417d2bf Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-06 15:27:35 +00:00
Alexandru Marc
b68ad3585c Backed out changeset cef2da85ff94 (bug 1945927) for causing bc failures @ browser_glean_sidebar.js CLOSED TREE 2025-02-06 03:34:55 +02:00
Jonathan Sudiaman
56a6d4edfc Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-05 23:28:14 +00:00
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 18:04:20 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Nikki Sharpley
410e500446 Bug 1944576 - Fix accessibility issue causing failures in browser_glean_sidebar.js r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236737
 2025-02-05 14:56:26 +00:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 14:05:08 +00:00
Goloman Adrian
29382f98d1 Backed out changeset 0923d9bb2550 (bug 1944931) for causing bc failures @browser_reviewchecker_sidebar.js. CLOSED TREE 2025-02-05 02:17:40 +02:00
Sam Foster
ba5b624404 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-04 19:08:22 +00:00
Jonathan Sudiaman
6bb4358a74 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane 
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
 2025-02-04 14:18:08 +00:00
Sam Foster
c32900b41c Bug 1942314 - Avoid showing sidebars and responding to sidebar events in popup windows. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
- Guard the main entry-points in SidebarController to handle the window being a popup
- Amend the test to also try the shortcut to show a sidebar in a popup window

Differential Revision: https://phabricator.services.mozilla.com/D236292
 2025-02-04 07:43:21 +00:00
Jonathan Sudiaman
0979dad16f Bug 1944842 - Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r=sidebar-reviewers,sfoster 
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.

This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.

Differential Revision: https://phabricator.services.mozilla.com/D236240
 2025-02-03 15:05:46 +00:00
Gijs Kruitbosch
37d1770eaf Bug 1944627 - update sidebar button checked state for non-revamped sidebar cases, r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236419
 2025-02-01 14:34:59 +00:00
Nikki Sharpley
3a0cdaac95 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-31 17:20:04 +00:00
Ed Lee
8b77709dbf Bug 1933524 - Flip chatbot default and remove from Labs in Nightly and Release r=ngrato,settings-reviewers,sidebar-reviewers,nsharpley,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,jsudiaman,Gijs,sclements,desktop-theme-reviewers,hjones 
Flip default pref to true and remove featuregate entry/strings/styles. Switch actor enabled to actual opt-in / provider. Update sidebar tests for chatbot as default tool.

Differential Revision: https://phabricator.services.mozilla.com/D233204
 2025-01-31 16:58:55 +00:00
Nikki Sharpley
e88f046412 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-31 15:31:22 +00:00
Stanca Serban
20ad1078ea Backed out changeset fed22f8c018a (bug 1944842) for causing mochitests failures in browser_toolbar_sidebar_button.js. CLOSED TREE 2025-01-31 18:02:47 +02:00
Jonathan Sudiaman
5effea42bc Bug 1944842 - Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r=sidebar-reviewers,sfoster 
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.

This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.

Differential Revision: https://phabricator.services.mozilla.com/D236240
 2025-01-31 14:09:59 +00:00
Goloman Adrian
f318ff63af Backed out changeset 93bbf90232b7 (bug 1944190) for causing bc failures @browser_fullscreen_context_menu.js. CLOSED TREE 2025-01-31 03:18:31 +02:00
Nikki Sharpley
7ecca5c680 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-31 00:36:53 +00:00
Goloman Adrian
2d40cae4ae Backed out changeset 55b692ccd15f (bug 1944190) for causing bc failures @browser_fullscreen_context_menu.js. CLOSED TREE 2025-01-31 00:51:02 +02:00
Nikki Sharpley
ae210aa960 Bug 1944190 - Add new options to the tab strip context menu for sidebar revamp r=sidebar-reviewers,fluent-reviewers,bolsson,jsudiaman 
Horizontal tabs mode
- Turn on Vertical Tabs

Vertical tabs mode
- Turn off Vertical Tabs
- Customize Sidebar

Differential Revision: https://phabricator.services.mozilla.com/D236013
 2025-01-30 21:00:20 +00:00