corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

2780 Commits

Author SHA1 Message Date
Drew Willcoxon
0ee680e59e Bug 1846291 - Use Pocket favicon when showing Pocket suggestions at 16px. r=dao 
Please see the bug for context. For pixel-perfect accuracy, we should just use
the favicon when showing the icon at 16px. We can continue to use the svg when
showing it at the larger best-match size.

Differential Revision: https://phabricator.services.mozilla.com/D185475
 2023-08-07 21:33:46 +00:00
Drew Willcoxon
7643b2bbe6 Bug 1831529 - Don't perform the primary intervention action when the help command is clicked. r=mak 
The provider needs to check whether the help command was picked before
performing the primary action. Opening the help page is done by UrlbarInput
while intervention actions are done by the interventions provider.

Differential Revision: https://phabricator.services.mozilla.com/D185495
 2023-08-07 21:30:44 +00:00
Dão Gottwald
5ebbacb887 Bug 1846765 - Various code style fixes. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D185262
 2023-08-07 10:01:12 +00:00
Daisuke Akatsuka
3b11ed6b92 Bug 1847275: Change MDN brand name to 'MDN Web Docs' r=flod,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D185514
 2023-08-07 06:12:58 +00:00
mcheang
0089b57552 Bug 1835918 - Add test to check urlbar shows history and bookmark results when search service has failed to initialize. r=Standard8,mak 
Differential Revision: https://phabricator.services.mozilla.com/D184866
 2023-08-04 16:45:33 +00:00
Daisuke Akatsuka
1ccee30d4f Bug 1846915: Use a different 'Top pick' group label for MDN suggestions r=adw,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D185249
 2023-08-04 13:29:08 +00:00
Daisuke Akatsuka
f647e524d5 Bug 1846907: Limit the description text to 2 or 3 lines r=desktop-theme-reviewers,adw,dao 
Differential Revision: https://phabricator.services.mozilla.com/D185247
 2023-08-04 13:21:14 +00:00
Daisuke Akatsuka
633e2a7437 Bug 1846894: Add 'Mozilla Developer Network' bottom text r=adw,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D185242
 2023-08-03 21:36:07 +00:00
Drew Willcoxon
1a8069bc72 Bug 1846765 - Avoid using -moz-bool-pref CSS for experiments. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D185204
 2023-08-03 01:06:02 +00:00
Sean Feng
776d16366f Bug 1811129 - Update quicksuggestOnboarding.html to reflect the latest <dialog> focusing algorithm changes r=adw 
Given the <dialog> itself becomes focusable, the expected focusing
order has been changed.

Differential Revision: https://phabricator.services.mozilla.com/D185096
 2023-08-02 13:35:47 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Karandeep
bd53812278 Bug 1846028 - Add .featureGate pref to clipboard suggestion. r=mak 
Depends on D184502

Differential Revision: https://phabricator.services.mozilla.com/D184934
 2023-08-01 11:51:59 +00:00
Karandeep
80df50fdaa Bug 1842236 - Limit for displaying clipboard result in URL bar suggestions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D184502
 2023-08-01 11:51:59 +00:00
Karandeep
ef8715ed74 Bug 1842234 - Dismiss clipboard result through result menu button. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D183748
 2023-08-01 11:51:59 +00:00
Karandeep
b0382c3163 Bug 1842230 - URL bar suggested action for paste when clipboard contains valid URL. r=mak,flod 
Differential Revision: https://phabricator.services.mozilla.com/D183747
 2023-08-01 11:51:59 +00:00
Drew Willcoxon
62af15b582 Bug 1846085 - Treat "how to" as one word when matching prefixes for Pocket suggestions. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D184867
 2023-07-31 23:31:09 +00:00
Daisuke Akatsuka
4dd5caeb6d Bug 1844706: Add and use new MDN icon for MDN Suggestions r=desktop-theme-reviewers,adw,dao 
Depends on D184075

Differential Revision: https://phabricator.services.mozilla.com/D184786
 2023-07-30 21:07:01 +00:00
Narcis Beleuzu
df9bffe99c Backed out changeset 783d744d047b (bug 1844706) for xpcshell failure on test_quicksuggest_mdn.js 2023-07-28 23:53:57 +03:00
Daisuke Akatsuka
d6301d5833 Bug 1844706: Add and use new MDN icon for MDN Suggestions r=desktop-theme-reviewers,adw,dao 
Depends on D184075

Differential Revision: https://phabricator.services.mozilla.com/D184786
 2023-07-28 19:56:25 +00:00
Daisuke Akatsuka
1a5f430183 Bug 1844495: Implement base of MDN Suggestions r=adw,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184075
 2023-07-28 00:15:27 +00:00
Iulian Moraru
d0c6f20550 Backed out changeset 058d7fc0c711 (bug 1844495) for causing bc failures on browser_quicksuggest_mdn.js. CLOSED TREE 2023-07-28 02:05:53 +03:00
Daisuke Akatsuka
623872b9c8 Bug 1844495: Implement base of MDN Suggestions r=adw,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184075
 2023-07-27 20:33:57 +00:00
Niklas Baumgardner
5eafa5cac5 Bug 1844171 - Update screenshots tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183912
 2023-07-27 16:15:03 +00:00
Marc Seibert
6bb93e734c Bug 1836962 - Only trim URL if directionality doesn't change to RTL.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D184629
 2023-07-27 11:46:46 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Chris H-C
ad914329f7 Bug 1845400 - reporting_url should be sent on 'quick-suggest' ping r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D184510
 2023-07-25 20:52:31 +00:00
Marc Seibert
5c780ccb5f Bug 1704420 - Test.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D184456
 2023-07-25 15:14:23 +00:00
James Teow
f89157326f Bug 1842766 - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D183753
 2023-07-25 14:39:26 +00:00
Dale Harvey
bc5e0456c4 Bug 1843386 - Dont deduplicate rich suggestions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D183881
 2023-07-21 08:37:25 +00:00
Daisuke Akatsuka
6ea5606c5d Bug 1844266: Check enabling the feature after async processing in onRemoteSettingsSync r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D183951
 2023-07-19 22:27:13 +00:00
Marco Bonardo
dfb55f6331 Bug 1843100 - Address Bar view should not try to reuse rows from different providers. r=daleharvey 
Different providers have different time characteristics, reusing results across
providers may thus cause flicker of results coming from the fastest ones.

Differential Revision: https://phabricator.services.mozilla.com/D183507
 2023-07-19 07:43:40 +00:00
Marc Seibert
77df2cb8ef Bug 1416881 - Entering characters with character/accent marks on macOS doesn't remove the autofilled selected part.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D182664
 2023-07-18 08:00:38 +00:00
Daisuke Akatsuka
2c5a3d58ab Bug 1843186: Append UTM parameter to Pocket suggestions r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D183455
 2023-07-13 21:20:01 +00:00
Marco Bonardo
3eb480f620 Bug 1843074 - SkippableTimer.done should be set immediately. r=scunnane 
Invoking fire() in a loop may invoke the callback multiple times because done
is not set immediately.

Differential Revision: https://phabricator.services.mozilla.com/D183412
 2023-07-13 09:25:37 +00:00
Mark Banner
544ecba3af Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D181159
 2023-07-12 13:38:34 +00:00
Mark Banner
88e658c23d Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw 
Depends on D183308

Differential Revision: https://phabricator.services.mozilla.com/D183309
 2023-07-12 08:07:23 +00:00
Hannah Peuckmann
2bab8aaf0e Bug 1836248 - Update the strip-on-share strings from the prototype for the v1. r=pbz,bolsson 
I got the strings from Martin Balfanz, he worked on them with the content-team. They also requested to have a localization note added.

The strings for the prototype have been added in [D174253](https://phabricator.services.mozilla.com/D174253) and [D174251](https://phabricator.services.mozilla.com/D174251)

Differential Revision: https://phabricator.services.mozilla.com/D183245
 2023-07-12 07:34:16 +00:00
Daisuke Akatsuka
28c94baccd Bug 1838743: Avoid firing paste event when middle-clicking on not editor in Chrome document r=masayuki,dao 
Differential Revision: https://phabricator.services.mozilla.com/D182880
 2023-07-12 01:31:29 +00:00
Marco Bonardo
b98a9b276e Bug 1842381 - The address bar chunk timer is not firing early when all heuristic providers are done. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D183164
 2023-07-11 08:27:37 +00:00
Marco Bonardo
0a487b36b8 Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-07 15:48:34 +00:00
Marco Bonardo
b99e0f7f7e Bug 1827770 - Remove isPrivate argument from onEngagement() since it can be inferred. r=daleharvey 
We can't use context.isPrivate because sometimes context is undefined.
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1841762 about that.

Differential Revision: https://phabricator.services.mozilla.com/D182772
 2023-07-07 10:01:50 +00:00
Marco Bonardo
ff3c4323fc Bug 1827770 - Remove QueryContext.view and pass the controller to onEngagement() instead. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D182771
 2023-07-07 10:01:50 +00:00
Norisz Fay
bdd652b5e3 Backed out changeset 909fc50c54a1 (bug 1838743) for causing failures on browser_947914_button_paste.js CLOSED TREE 2023-07-07 05:57:07 +03:00
Daisuke Akatsuka
a083b83b1c Bug 1838743: Ignore paste event if the event was fired from not urlbar r=masayuki,dao 
Differential Revision: https://phabricator.services.mozilla.com/D182880
 2023-07-07 00:43:34 +00:00
Daisuke Akatsuka
519c3272c6 Bug 1841877: Hide 'Show less frequently' for high confidence matches r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D182822
 2023-07-07 00:31:45 +00:00
Drew Willcoxon
a97e10fc4d Bug 1841409 - Create new row content as necessary to make sure the Feedback button is shown. r=dao 
Depends on D182537

Differential Revision: https://phabricator.services.mozilla.com/D182625
 2023-07-05 18:24:57 +00:00
Stanca Serban
538414cfdf Backed out changeset 5cf32b0ba18a (bug 1841409) for causing mochitests failures. CLOSED TREE 2023-07-06 01:30:56 +03:00
Drew Willcoxon
03f0ab404d Bug 1841409 - Create new row content as necessary to make sure the Feedback button is shown. r=dao 
Depends on D182537

Differential Revision: https://phabricator.services.mozilla.com/D182625
 2023-07-05 18:24:57 +00:00
Drew Willcoxon
f4e3504885 Bug 1841447 - Change the "Top pick" label to "Recommended reads" for Pocket suggestions. r=daisuke,fluent-reviewers,flod 
Depends on D182634

Differential Revision: https://phabricator.services.mozilla.com/D182635
 2023-07-05 15:47:25 +00:00
Drew Willcoxon
d9b865e27c Bug 1841446 - Update the "Not interested" command to disable Pocket suggestions. r=daisuke,fluent-reviewers,flod 
Depends on D182606

Differential Revision: https://phabricator.services.mozilla.com/D182634
 2023-07-05 15:47:24 +00:00