Fixes a defect where the error view was not showing
properly when navigating to a website that triggers
auto-translate failure after previously viewing the panel
on a web page with an unsupported language.
Depends on D185485
Differential Revision: https://phabricator.services.mozilla.com/D185499
Fixes a defect where the revisit view was not showing
properly when navigating to a website that triggers
auto-translate after previously viewing the panel
on a web page with an unsupported language.
Depends on D185484
Differential Revision: https://phabricator.services.mozilla.com/D185485
Fixes an error where translations settings menu checkbox
states were not being updated correctly for pages
whose language is not supported by translations.
They were previously being disabled as intended,
but not unchecked.
Depends on D185483
Differential Revision: https://phabricator.services.mozilla.com/D185484
Refactors the assertions for the always/never translate checkbox
menuitems in the translations panel settings menu.
The checks now verify the displayed language name as well as the
disabled state across all relevant translations tests.
Differential Revision: https://phabricator.services.mozilla.com/D185483
Fixes an intermittent test failure that was sometimes
ocurring due to an async function that was accidentally
not awaited in the test.
Differential Revision: https://phabricator.services.mozilla.com/D185501
There is a bit of dead test code left over from when
languages were labled individually as "beta" in Translations.
This patch removes any such code.
Differential Revision: https://phabricator.services.mozilla.com/D185506
Adds a few more event keys to the translation_request event,
such as the top preferred language, and the detected document
language tag.
Differential Revision: https://phabricator.services.mozilla.com/D185387
Adds a few more event keys to the panel open event, such as the
detected document language tag, and whether the panel was opened
automatically or manually.
Differential Revision: https://phabricator.services.mozilla.com/D185386
This is being triggered by a later patch that is adding new logging. I
believe this is all just because of initialization order.
Differential Revision: https://phabricator.services.mozilla.com/D185210
This is being triggered by a later patch that is adding new logging. I
believe this is all just because of initialization order.
Differential Revision: https://phabricator.services.mozilla.com/D185210
This was racing with the popup being shown and the browser window being
closed. If it lost this race, then it would cause a leak.
Depends on D182926
Differential Revision: https://phabricator.services.mozilla.com/D184516
Handles telemetry events for managing the language-
and site-based settings options from the settings
menu invoked from the Translations panel.
Differential Revision: https://phabricator.services.mozilla.com/D184702
Handles telemetry events that deal with popupshown and
popuphidden for the translations settings menu invoked
from the Translations panel.
Differential Revision: https://phabricator.services.mozilla.com/D184700
Modifies existing telemetry events to maintain the
same flow throughout different error states that may
occur in the translations panel.
Differential Revision: https://phabricator.services.mozilla.com/D184696
Adds the notion of an event being a first-interaction
or not, to better distinguish how users interact with
the translations panel the first time they see it.
Differential Revision: https://phabricator.services.mozilla.com/D184695
This was racing with the popup being shown and the browser window being
closed. If it lost this race, then it would cause a leak.
Depends on D182926
Differential Revision: https://phabricator.services.mozilla.com/D184516
Adds test infrastructure and test cases to assert that the flowId
is being tracked correctly in Translations telemetry events.
Depends on D183045
Differential Revision: https://phabricator.services.mozilla.com/D182613
Unifies the TranslationsTelemetry implementations into a single file
using only one metrics.yaml file as well
Depends on D182610
Differential Revision: https://phabricator.services.mozilla.com/D183044