Commit Graph

340 Commits

Author SHA1 Message Date
Ed Lee
4a2b2e5128 Bug 1744377 - Coalesce next variation to avoid exceptions in tests r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D140707
2022-03-10 21:56:32 +00:00
Barret Rennie
b444763bb2 Bug 1753369 - Use sync PathUtils directory getters on mainthread in browser/components/tests r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D140134
2022-03-10 15:16:40 +00:00
Ed Lee
5ccd66dba0 Bug 1754127 - Reenable test with bug 1754126 fixed r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D140228
2022-03-03 20:23:19 +00:00
Narcis Beleuzu
271417eb7f Bug 1754127 - Disable browser_browserGlue_upgradeDialog_trigger.js. r=aryx DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D138220
2022-02-08 23:25:54 +00:00
Ed Lee
9684b7f323 Bug 1754126 - Skip colorway theme test if it has already expired r=pdahiya
Silently ignore themes that are expired and can't be enabled.

Differential Revision: https://phabricator.services.mozilla.com/D138168
2022-02-08 22:58:52 +00:00
Tim Giles
3d1fb54145 Bug 1745248 - Add form autofill pref migration and tests. r=dimi,sgalich
Depends on D133820

Differential Revision: https://phabricator.services.mozilla.com/D135553
2022-02-08 19:31:59 +00:00
Andreea Pavel
b69d459b50 Bug 1754126 - temporary disable browser_browserGlue_upgradeDialog.js on all platforms CLOSED TREE DONTBUILD 2022-02-08 13:27:03 +02:00
Butkovits Atila
d223812d37 Bug 1744379 - disable browser_browserGlue_upgradeDialog.js on Linux_64 for frequent failures. r=intermittent-reviewers,MasterWayZ CLOSED TREE DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D137961
2022-02-07 03:00:12 +00:00
criss
600a621667 Backed out changeset 44a4e91630c0 (bug 1744379) for perma-failing bug 1754126 2022-02-08 09:35:46 +02:00
Butkovits Atila
0db9c4d998 Bug 1744379 - disable browser_browserGlue_upgradeDialog.js on Linux_64 for frequent failures. r=intermittent-reviewers,MasterWayZ DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D137961
2022-02-07 03:00:12 +00:00
Iulian Moraru
e13fe3ef05 Backed out 4 changesets (bug 1745248) for causing issues with credit card sync. a=backout
Backed out changeset 324a6acb8612 (bug 1745248)
Backed out changeset f54ce6b7dd26 (bug 1745248)
Backed out changeset c7212ce535e4 (bug 1745248)
Backed out changeset 06d57e874522 (bug 1745248)
2022-02-03 00:50:29 +02:00
Joel Maher
6d769aee7c Bug 1750839 - Enable fission browser-chrome for variants. r=mccr8,releng-reviewers,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D136512
2022-02-01 19:30:34 +00:00
Tim Giles
36aa6547bd Bug 1745248 - Add form autofill pref migration and tests. r=dimi,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D135553
2022-01-26 20:11:42 +00:00
Barret Rennie
8ed28d9bdf Bug 1745358 - Remove osfile.jsm from browser/components/tests r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D133825
2021-12-16 22:15:38 +00:00
Nick Alexander
05abfd9e68 Bug 1743914 - Part 3: Telemetry for when Firefox is the default handler. r=chutten,mhowell
This only records whether Firefox is the default PDF handler for now.
But it will accommodate additional file types and protocols in the
future, should they be desired.

This is Windows 10+ only, since we really only care about PDF handling
defaults where Edgium is the OS default.

Differential Revision: https://phabricator.services.mozilla.com/D132659
2021-12-12 03:52:57 +00:00
Butkovits Atila
f5dde92479 Backed out 3 changesets (bug 1743914) for causing failures at browser_setDefaultPDFHandler.js. CLOSED TREE
Backed out changeset 01e19b8ec15b (bug 1743914)
Backed out changeset c46d66869d03 (bug 1743914)
Backed out changeset 57d0f8824e35 (bug 1743914)
2021-12-11 10:48:19 +02:00
Nick Alexander
67477c0843 Bug 1743914 - Part 3: Telemetry for when Firefox is the default handler. r=chutten,mhowell
This only records whether Firefox is the default PDF handler for now.
But it will accommodate additional file types and protocols in the
future, should they be desired.

This is Windows 10+ only, since we really only care about PDF handling
defaults where Edgium is the OS default.

Differential Revision: https://phabricator.services.mozilla.com/D132659
2021-12-11 06:25:57 +00:00
Narcis Beleuzu
bfb7e382db Backed out 3 changesets (bug 1743914) for bc failures on browser_setDefaultPDFHandler.js
Backed out changeset 088401e43bd4 (bug 1743914)
Backed out changeset 7cb74ac80d41 (bug 1743914)
Backed out changeset 20713ede0c08 (bug 1743914)
2021-12-11 03:28:02 +02:00
Nick Alexander
576a1e6fc3 Bug 1743914 - Part 3: Telemetry for when Firefox is the default handler. r=chutten,mhowell
This only records whether Firefox is the default PDF handler for now.
But it will accommodate additional file types and protocols in the
future, should they be desired.

This is Windows 10+ only, since we really only care about PDF handling
defaults where Edgium is the OS default.

Differential Revision: https://phabricator.services.mozilla.com/D132659
2021-12-11 00:02:40 +00:00
Nick Alexander
43a36b7a80 Bug 1243603 - Telemetry for when Windows invokes Firefox to handle a registered file type or protocol. r=Gijs
The `-osint` flag is used as the signal that Windows is invoking
Firefox to handle a file type or protocol.  The `-osint` flag was
introduced in order to mitigate security breaches due to poor argument
quoting (by consumers invoking Firefox); to use it for this new
purpose, it must be preserved for downstream consumers to react to.
Alternately, some marker of the flag could be maintained.  Since the
flag needs to transit through the launcher process, I've elected to
simply not strip it as we validate command lines, and to accommodate
it further downstream.  (It looks like Thunderbird already
accommodates `-osint`: see
https://searchfox.org/comm-central/rev/3e8f926de9ea09945b237177eb6d489c70318f0e/mail/components/MessengerContentHandler.jsm#568.)

The telemetry in this patch achieves two purposes.  The first is to
count the number of times Firefox is invoked to handle a registered
file type or protocol: for this, a new keyed uint scalar was added.
File types start with a ".", just like on Windows; protocols
(equivalently, the schemes used to identify them) do not start with a
".".

The second is to identify times when Firefox is launched (i.e., it was
not already running) to handle a registered file type or protocol.

This generalizes the existing `os.environment.launch_method`,
introducing `os.environment.launched_to_handle` and
`os.environment.invoked_to_handle` string scalars, which record the
file type or protocol.

The command line state `STATE_INITIAL_LAUNCH` is used to discriminate
launching from invoking.

Differential Revision: https://phabricator.services.mozilla.com/D132288
2021-12-11 00:00:55 +00:00
Meg Viar
47ef77461b Bug 1739289 - Remove or update probes expiring in Firefox 97: os.environment.is_kept_in_dock r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D132979
2021-12-10 21:02:21 +00:00
Andrei Oprea
79b5bb3d6b Bug 1738286 - New schema and enrollment flow for rollouts r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D129835
2021-12-09 17:58:18 +00:00
Tooru Fujisawa
b5700ca1d4 Bug 1744591 - Stop collecting telemetry for hidden browser.link.open_newwindow.restriction preference usage. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D133010
2021-12-09 07:58:19 +00:00
Chris H-C
9dccd345c0 Bug 1742133 - Expose FOG service as Services.fog and convert uses r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D132742
2021-12-08 21:18:19 +00:00
Alexandru Michis
f61f031abf Bug 1739289 - Disable browser_browserGlue_telemetry.js for permafailing after m-c version was increased. a=test-only 2021-12-07 03:48:24 +02:00
Alexandru Michis
be8e74ca48 Bug 1739289 - Disable test_browserGlue_newwindow_restriction_telemetry.js for causing permafailures after m-c version was increased. a=test-only 2021-12-07 03:35:39 +02:00
Ed Lee
dfe4a6d637 Bug 1739055 - Reset custom homepage / start page only on saving colorway r=pdahiya
Handle checkbox only from primary button and not any completion of colorway screen.

Depends on D130930

Differential Revision: https://phabricator.services.mozilla.com/D132830
2021-12-04 01:07:33 +00:00
Ed Lee
42952317ed Bug 1740623 - Adjust MR2 upgrade spotlight content r=pdahiya,emcminn
Remove start screen reusing its subtitle on the colorway screen. Get the previous theme before ready as colorway screen is now first and randomly picks a color, so detect testing to remove randomness. Show rounded mostly transparent background for variants now packed more tightly within the disc. Shrink and deemphasize secondary button. Reenable upgrade spotlight after turning off in D131023.

https://www.figma.com/file/blhdnzQOhWYKcdiCzywMuG/MR2-Onboarding?node-id=2548%3A158106

Differential Revision: https://phabricator.services.mozilla.com/D130930
2021-12-04 00:54:47 +00:00
Nick Alexander
bac414edd4 Bug 1742879 - Let Cu.createCommandLine accept arguments and state. r=nika
There's a lot of history in this area that mostly explains why this
has not been supported in the past, leading to several awkward
workarounds in tests.  But it doesn't appear that there's any reason
to prevent tests from creating actual command lines, so that's what we
allow here.

I've elected to flesh out `Cu.createCommandLine` rather than expose
`.init(..._)` directly since `Cu.createCommandLine` is already used in
the relevant tests and is only used in tests.  And I've made the
arguments required, rather than optional, so that consumers think
about the arguments, in particular `state`.

Differential Revision: https://phabricator.services.mozilla.com/D132089
2021-12-02 19:06:44 +00:00
Noemi Erli
28ddec1faa Backed out 2 changesets (bug 1742879) for causing build bustage in nsDebug.h CLOSED TREE
Backed out changeset 994d0986757c (bug 1742879)
Backed out changeset d4b8e45faaec (bug 1742879)
2021-12-02 09:34:25 +02:00
Nick Alexander
fd231497f8 Bug 1742879 - Let Cu.createCommandLine accept arguments and state. r=nika
There's a lot of history in this area that mostly explains why this
has not been supported in the past, leading to several awkward
workarounds in tests.  But it doesn't appear that there's any reason
to prevent tests from creating actual command lines, so that's what we
allow here.

I've elected to flesh out `Cu.createCommandLine` rather than expose
`.init(..._)` directly since `Cu.createCommandLine` is already used in
the relevant tests and is only used in tests.  And I've made the
arguments required, rather than optional, so that consumers think
about the arguments, in particular `state`.

Differential Revision: https://phabricator.services.mozilla.com/D132089
2021-12-02 04:02:07 +00:00
Tooru Fujisawa
9f92967d23 Bug 1740063 - Collect telemetry for hidden browser.link.open_newwindow.restriction preference usage. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D130887
2021-11-17 23:29:56 +00:00
Marco Bonardo
58bada86ee Bug 1740987 - Correct typo in BrowserGlue migration.
Differential Revision: https://phabricator.services.mozilla.com/D131071
2021-11-13 10:00:47 +00:00
Ed Lee
49ea3357f4 Bug 1740819 - Turn off MR2 onboarding in Fx95 r=pdahiya
Turn off by default as "Mikal won't want to see us ship another experience devoid of the pin and set to default prompts."

Differential Revision: https://phabricator.services.mozilla.com/D131023
2021-11-12 04:59:07 +00:00
Ed Lee
129b1a36c1 Bug 1735691 - Quickly clicking "explore colorways" then "keep previous" twice makes upgrade spotlight stuck r=pdahiya
Remember that advance is busy to cancel other advances.

Differential Revision: https://phabricator.services.mozilla.com/D128432
2021-10-14 22:31:14 +00:00
Ed Lee
f349dc2560 Bug 1735388 - Keep the variant when changing colorways on upgrade spotlight and about:welcome r=pdahiya
Rework theme and variant activation to make variants sticky. Reorder Default to show Light then Auto so that Light and Soft are the same index. Also select the initial index based on current dark or light theme. Add transitions for variation children. Compute about:welcome variant index based on active theme instead of specifying both default variants for system and colorways.

Differential Revision: https://phabricator.services.mozilla.com/D128404
2021-10-14 00:40:23 +00:00
James Teh
ddea713bee Bug 1735454 - Provide a more useful a11y label on the theme variation radio buttons in the upgrade spotlight r=pdahiya
Wait for fluent-dom to translate the radio button elements to then copy over the text as aria-label.

Differential Revision: https://phabricator.services.mozilla.com/D128330
2021-10-13 21:31:18 +00:00
Ed Lee
6b3f4e7a6f Bug 1734834 - Show MR2 upgrade dialog on windows 7 r=andreio
Remove win7 restriction and related helpers and tests.

Differential Revision: https://phabricator.services.mozilla.com/D127953
2021-10-08 13:32:23 +00:00
Ed Lee
e6345876a7 Bug 1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r=pdahiya
Add newtab pref checks and record events for when checkbox button is handled. Split up trigger tests to own file and share telemetry helpers from head.js.

Differential Revision: https://phabricator.services.mozilla.com/D127722
2021-10-07 03:59:56 +00:00
Ed Lee
d6e147f358 Bug 1728853 - Update upgrade spotlight for MR2 themes r=pdahiya,fluent-reviewers,flod
Replace almost all MR1 content with MR2 start, colorway and thank you screens. Reuse confetti from about:welcome. Add variant selection with transitions. Update triggering to show for 94 but not for windows 7.

Differential Revision: https://phabricator.services.mozilla.com/D127252
2021-10-03 03:56:10 +00:00
Gijs Kruitbosch
1f2779a37d Bug 1732446 - fix multiple tab warning for quit shortcut usage on Windows, r=NeilDeakin,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D126677
2021-09-28 10:44:37 +00:00
Geoff Brown
a00c449c2d Bug 1730213 - Explicitly skip tests under browser/ on android; r=ahal
These tests are excluded from android test runs in moz.build. Including
an explicit annotation in each manifest avoids scheduling confusion.
browser-chrome and plain-chrome tests in browser/ are of no concern,
since those test types are never scheduled on android.

Differential Revision: https://phabricator.services.mozilla.com/D125266
2021-09-13 15:22:27 +00:00
Neil Deakin
b687da9015 Bug 1726736, test for quit keyboard shortcut opening confirmation dialog, r=mhowell
Depends on D124223

Differential Revision: https://phabricator.services.mozilla.com/D124856
2021-09-08 12:32:58 +00:00
Christoph Kerschbaumer
5ee0a6a910 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D119177
2021-07-28 19:16:16 +00:00
Sandor Molnar
5e383dfda4 Backed out changeset 7eb8945dd8e3 (bug 1719272) for causing bustages in gecko decision task. CLOSED TREE 2021-07-28 19:47:06 +03:00
Christoph Kerschbaumer
8fef13ba13 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D119177
2021-07-28 16:08:07 +00:00
Andrei Oprea
4a4f117b68 Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D118367
2021-07-26 14:48:22 +00:00
Dorel Luca
d152572739 Backed out changeset e7dffca31fa7 (bug 1716736) for Browser-chrome failures in browser/components/shell/test/browser_setDefaultBrowser.js. CLOSED TREE 2021-07-26 14:08:51 +03:00
Andrei Oprea
626914c896 Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D118367
2021-07-26 09:43:28 +00:00
Sandor Molnar
ce4534f206 Backed out changeset e5cfc59f9063 (bug 1716736) for causing bc failures in browser_setDefaultBrowser. CLOSED TREE 2021-07-26 01:17:51 +03:00