Commit Graph

3304 Commits

Author SHA1 Message Date
Luca Greco
82947b143e Bug 1725701 - Make sure resetBrowserToLazyState stores userTypedValue in the tabState if the cacheState only includes the isPrivate key. r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D144161
2022-05-05 09:23:46 +00:00
Joel Maher
4216eeb86c Bug 1751259 - make marionette really use fission. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D144342
2022-04-26 18:21:35 +00:00
Sarah Clements
699d42dff7 Bug 1761784 - Firefox View Recently closed tabs implementation r=fluent-reviewers,dao,flod
* Sketch in recently-closed-tabs section and listing
* Add some styles and suggested markup for the page-level sections & headers

Differential Revision: https://phabricator.services.mozilla.com/D143365
2022-04-26 11:00:30 +00:00
Andreas Farre
ea19a48880 Bug 1739450 - Part 1: Move ownership of session store scroll and form data to platform. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D130389
2022-04-19 15:19:22 +00:00
Paul Zuehlcke
4faa9743bc Bug 1746383 - Set URLBar pageProxyState to invalid for onLocationChange triggered by SessionStore. r=nika,dao
Differential Revision: https://phabricator.services.mozilla.com/D138823
2022-04-12 14:41:06 +00:00
Gijs Kruitbosch
1fb46fa941 Bug 1758250 - deal with non-existing url values from session restore so they don't brick other functionality, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D142947
2022-04-12 10:39:03 +00:00
Barret Rennie
352961fbb0 Bug 1761652 - Fail to write session file more gracefully if we started in permanent private browsing r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D143103
2022-04-07 15:25:29 +00:00
Kagami Sascha Rosylight
d6ec873f16 Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-04-06 11:57:57 +00:00
Luca Greco
74fad3adb6 Bug 1760936 - cache userTypedValue for discarded tab when already navigating or the tab does not have a cached history. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D142372
2022-04-05 14:53:38 +00:00
Jonathan Watt
c9f14e24cd Bug 1757657. Remove some about:printpreview cruft that was missed in 1702501. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D139993
2022-04-04 17:19:24 +00:00
Masatoshi Kimura
4544c0d55b Bug 1762228 - Fix typo in SessionStore.jsm. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D142484
2022-04-01 09:54:18 +00:00
Gijs Kruitbosch
edda40141b Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 16:16:42 +00:00
Norisz Fay
e1d7571cc8 Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
1214ac636b Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 08:18:51 +00:00
criss
0038e58f1f Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight
f3126104f8 Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-03-29 13:11:00 +00:00
Nika Layzell
c6e75b65fa Bug 1728332 - Part 2: Avoid raciness in sqlite interactions in browser_tabs_in_urlbar.js, r=adw
Before this change, there was raciness in this test due to the queries
to insert the opened tabs into the moz_openpages_temp table occuring at
the same time as the queries to read from that table in other
components. This patch makes the test initialize the DB connection
earlier, and ensure that no statements are still pending when running to
hopefully avoid potential races caused by the async nature of the
database connection.

Differential Revision: https://phabricator.services.mozilla.com/D141809
2022-03-25 22:25:55 +00:00
Nika Layzell
3ea77b2aa2 Bug 1728332 - Part 1: Predict remote type when inserting restored tabs, r=Gijs
This should mostly avoid the issue where newly created pinned tabs when
restoring a session are first created in the shared web process, and
migrated into the correct process upon navigating. I also added
remoteType prediction to the undoCloseTab and duplicateTab codepaths
to avoid unnecessary process changes there as well.

Differential Revision: https://phabricator.services.mozilla.com/D141146
2022-03-25 22:25:55 +00:00
Mathew Hodson
df2a53e9ea Bug 1752853 - Stop using a worker to write session store. r=Gijs,Standard8
Remove now unused pref "browser.sessionstore.max_write_failures".
Rename and simplify test_shutdown_cleanup.js to make it more clear that
it is testing the isFinalWrite option.

Differential Revision: https://phabricator.services.mozilla.com/D137930
2022-03-25 19:42:36 +00:00
Cristian Tuns
05d7d28dae Backed out changeset 30fa07c96caa (bug 1728332) for causing mochitest failures on browser_tabs_in_urlbar.js CLOSED TREE 2022-03-21 19:02:16 -04:00
Nika Layzell
3317a3ef3f Bug 1728332 - Predict remote type when inserting restored tabs, r=Gijs
This should mostly avoid the issue where newly created pinned tabs when
restoring a session are first created in the shared web process, and
migrated into the correct process upon navigating. I also added
remoteType prediction to the undoCloseTab and duplicateTab codepaths
to avoid unnecessary process changes there as well.

Differential Revision: https://phabricator.services.mozilla.com/D141146
2022-03-21 21:44:14 +00:00
Mike Conley
cd2f080722 Bug 1759549 - Persist wireframes to Session Store when wireframe capturing is enabled. r=mossop,farre
Differential Revision: https://phabricator.services.mozilla.com/D141001
2022-03-21 17:54:13 +00:00
Henrik Skupin
d785f8a630 Bug 1759574 - [marionette] Move session store tests to browser/components/sessionstore/test/marionette. r=webdriver-reviewers,dao,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D141082
2022-03-21 17:05:26 +00:00
Butkovits Atila
cd585508ce Backed out changeset 583b98909672 (bug 1759549) for causing failures at browser_sessionHistory.js. 2022-03-21 19:34:29 +02:00
Mike Conley
e85aa9661d Bug 1759549 - Persist wireframes to Session Store when wireframe capturing is enabled. r=mossop,farre
Differential Revision: https://phabricator.services.mozilla.com/D141001
2022-03-21 15:43:15 +00:00
Sean Feng
6f2305a872 Bug 1759499 - Allow recording BFCACHE_COMBO probe in parent process r=smaug
With Fission, BFCache is now being used in the parent process,
updating the probe to collect parent process information.

Differential Revision: https://phabricator.services.mozilla.com/D141260
2022-03-18 01:00:50 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
Barret Rennie
60ddecfcfe Bug 1753369 - Use sync PathUtils directory getters on mainthread in browser/components/sessionstore r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D140133
2022-03-10 15:16:39 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
Butkovits Atila
399d5c6e4a Bug 1638958 - disable browser_label_and_icon.js on Linux_64_opt for frequent failures. r=intermittent-reviewers,MasterWayZ DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D140268
2022-03-04 02:51:29 +00:00
Emilio Cobos Álvarez
20ba7daa1c Bug 1753836 - Make window screen and event screen coordinates consistent. r=jfkthame
This basically undoes bug 1246346. The current behavior is pretty bizarre,
the screenX origin / position doesn't match the mouse event coordinates,
because on windows we return device pixels rather than CSS pixels for the
window coordinates.

This makes behavior consistent with how other browsers report these coordinates
at least on Windows in non-mixed DPI mode, and I think is fine.

In mixed DPI mode, there might indeed be overlapping coordinates, but again I
think that's fine, because the CSS coordinate space of the different monitors
is different.  You need to multiply by the devicePixelRatio if you want
coordinates not to overlap.

Depends on D138039

Differential Revision: https://phabricator.services.mozilla.com/D138130
2022-02-16 12:18:12 +00:00
Emilio Cobos Álvarez
2b4bcbce12 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-16 12:18:12 +00:00
smolnar
ac36389b37 Backed out 6 changesets (bug 1753836) for causing mochitest failures in test_event_screenXY_with_zoom. CLOSED TREE
Backed out changeset a572cbc0fac2 (bug 1753836)
Backed out changeset 371a495ff728 (bug 1753836)
Backed out changeset 774af76be463 (bug 1753836)
Backed out changeset faa8a8f2d40f (bug 1753836)
Backed out changeset 9209832ecffe (bug 1753836)
Backed out changeset db443ce0406d (bug 1753836)
2022-02-16 01:47:51 +02:00
Emilio Cobos Álvarez
314f6c7716 Bug 1753836 - Make window screen and event screen coordinates consistent. r=jfkthame
This basically undoes bug 1246346. The current behavior is pretty bizarre,
the screenX origin / position doesn't match the mouse event coordinates,
because on windows we return device pixels rather than CSS pixels for the
window coordinates.

This makes behavior consistent with how other browsers report these coordinates
at least on Windows in non-mixed DPI mode, and I think is fine.

In mixed DPI mode, there might indeed be overlapping coordinates, but again I
think that's fine, because the CSS coordinate space of the different monitors
is different.  You need to multiply by the devicePixelRatio if you want
coordinates not to overlap.

Depends on D138039

Differential Revision: https://phabricator.services.mozilla.com/D138130
2022-02-15 22:25:05 +00:00
Emilio Cobos Álvarez
1f6fc3a3d9 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-15 22:25:04 +00:00
Sarah Clements
ac27d9d5d6 Bug 1747430 - remove tabIndicatorReplacesIcon in browser tabs css file r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137775
2022-02-11 16:19:52 +00:00
Masatoshi Kimura
e1270852a2 Bug 1728800 - Collect window features from chrome flags. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137948
2022-02-07 21:01:19 +00:00
Barret Rennie
3e6dfbcf31 Bug 1749996 - Ensure CrashMonitor writes sessionstore final checkpoint before IOUtils shuts down r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137797
2022-02-05 20:57:50 +00:00
Masatoshi Kimura
ac445526fc Bug 1753608 - Fix Session Restore fails to restore some features. r=Gijs
* I overlooked that some `window.open` feature names are different from
  barprop names.
* Adding "resizable" will regress the maximize button prblem. But it was
  broken even before bug 1564738 and fixing it requires changes to session
  data. The current session data do not contain enough information to restore
  the maximize button state correctly. I'll file a follow-up bug about this.
* I renamed the test file because it is no longer limited to tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D137838
2022-02-04 19:53:24 +00:00
Butkovits Atila
acc15d025a Backed out changeset da0571b0cff0 (bug 1749996) for causing failures at IOUtils. CLOSED TREE 2022-02-04 18:52:19 +02:00
Barret Rennie
2faa8390f8 Bug 1749996 - Ensure CrashMonitor writes all checkpoints before IOUtils shuts down r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137797
2022-02-04 15:58:57 +00:00
Masatoshi Kimura
ea40dd3de8 Bug 1564738 - Set correct features from the start instead of changing visibity after window creation. r=Gijs
Changing visibiity causes some subtle problems.

Differential Revision: https://phabricator.services.mozilla.com/D137750
2022-02-03 23:10:16 +00:00
Joel Maher
6d769aee7c Bug 1750839 - Enable fission browser-chrome for variants. r=mccr8,releng-reviewers,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D136512
2022-02-01 19:30:34 +00:00
Andreas Farre
917a3407ad Bug 1751156 - Make it more clear when SSWindowState{Ready, Busy} are dispatched. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D136466
2022-01-25 07:59:56 +00:00
Neil Deakin
e284566b55 Bug 1745272, remove soon to expire subframe crash telemetry, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D134187
2021-12-18 11:05:21 +00:00
Barret Rennie
458658fdf3 Bug 1745354 - Remove osfile.jsm from browser/components/sessionstore r=annyG
Differential Revision: https://phabricator.services.mozilla.com/D133466
2021-12-15 01:39:36 +00:00
criss
acbfb645ed Backed out changeset ac839ddcb82f (bug 1745354) for causing failures on browser_backup_recovery.js. CLOSED TREE 2021-12-14 09:12:19 +02:00
Barret Rennie
8a3c38779b Bug 1745354 - Remove osfile.jsm from browser/components/sessionstore r=annyG
Differential Revision: https://phabricator.services.mozilla.com/D133466
2021-12-14 06:29:05 +00:00
Ryan VanderMeulen
31cffbff09 Bug 1271024 - Re-enable browser_purge_shistory.js when SHIP is enabled. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D133116
2021-12-10 13:43:55 +00:00