corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1701 Commits

Author SHA1 Message Date
Mark Banner
a858a2d3b0 Bug 1847246 - Remove remaining parts of browser.search.hiddenOneOffs preference. r=search-reviewers,settings-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D185444
 2023-08-05 09:21:56 +00:00
James Teow
88c7ce5120 Bug 1836156 - Remove extraPageRegexps from search-telemetry-v2 - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D180862
 2023-08-04 15:04:02 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Stephanie Cunnane
a42fff340b Bug 1829671 - Move search telemetry tests into a separate sub-directory. r=jteow,search-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D182196
 2023-07-25 16:02:25 +00:00
Dale Harvey
bc5e0456c4 Bug 1843386 - Dont deduplicate rich suggestions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D183881
 2023-07-21 08:37:25 +00:00
Marco Bonardo
0a487b36b8 Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-07 15:48:34 +00:00
Jonathan Kingston
96c2a206f7 Bug 1836958 - Update DuckDuckGo favicon with latest version. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D182679
 2023-07-06 09:03:26 +00:00
Drew Willcoxon
bf1430c569 Bug 1841408 - Unify rich suggestions, best match, Firefox Suggest sponsored results, and Pocket Suggestions. r=dao,daleharvey 
This does a few things:

* Unify the view implementations of rich suggestions, Firefox Suggest sponsored
  results, and best match. I did this by using the best match implementation
  and extending it to rich suggestions and Suggest sponsored.
* Use the unified implementation for Pocket suggestions too.
* Add a bottom-text concept since Pocket suggestions shown as top picks need to
  show both a description and some text below it. (The actual bottom text per
  result is added in D182632 since I didn't want to make this patch bigger than
  necessary)

I have a couple motivations for these changes:

* I'm implementing Pocket suggestions, which need to show some text below the
  suggestion title as well as the URL. I was going to just use the Firefox
  Suggest sponsored approach, where the action text is wrapped below the title,
  but that doesn't work because it can't show both the wrapped action text and
  the URL.
* IMO we should use rich suggestions as the basis for all rows going forward,
  i.e., unify the different row implementations around rich suggestions.

The reason I chose the best match implementation instead of the rich suggestions
implementation is because the grid-based approach of rich suggestions doesn't
work well when the URL also needs to be shown. The URL should be
baseline-aligned with the row title, which isn't easy to do when the URL is
outside the grid. The rich suggestions implementation also doesn't wrap the URL.

Other details:

* The `rich-suggestion=no-icon` attribute value is only used for styling, so we
  can replace it with `@supports -moz-bool-pref()`. That lets us make the
  `rich-suggestion` attribute a simple boolean.
* I kept the `isBestMatch` property for results since
  `searchEngagementTelemetryGroup()` uses it to return "top_pick", and the view
  also uses it to create the "Top pick" row/group label. It still has semantic
  meaning so I think that's OK. It's no longer used by the view to create
  different DOM or styling.
* Move `isRichSuggestion` from the payload to the result itself, since it's no
  longer used for only one type of result. It's like `isBestMatch`, which is
  also on the result.
* Add `richSuggestionIconSize` to the result too. The best match icon size
  is 52. The Pocket best match icon size is 24 (but will have added padding and
  a background color to make it appear 52px). IMO this is better than adding
  rules for each type of suggestion to the CSS. It's cleaner and also indicates
  what the "standard" icon sizes are.

Depends on D182580

Differential Revision: https://phabricator.services.mozilla.com/D182537
 2023-07-05 15:47:24 +00:00
James Teow
d926354946 Bug 1839461 - Enable SERP Telemetry improvements on Nightly - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D181596
 2023-07-05 14:30:51 +00:00
Butkovits Atila
ceeb51063d Backed out changeset 986f4f6398a4 (bug 1816572) for causing failures at browser_search_bookmarks.js. CLOSED TREE 2023-07-04 16:29:04 +03:00
Marco Bonardo
dc48e94cda Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-04 09:28:46 +00:00
Dale Harvey
bbfc0cfc2d Bug 1121903 - Use encodeURIComponent for keyword url encoding. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D181697
 2023-06-23 13:31:16 +00:00
James Teow
cff6acbaba Bug 1833495 - Check if an ad is well above the possible viewable window - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D181179
 2023-06-19 14:03:16 +00:00
Mark Banner
d464cf8b22 Bug 1838744 - Unify Search Service channel handling between the production code and tests. r=mkaply 
This makes the code and the tests use the same detection for the channel, to avoid the issue where
ESR builds fail whilst they are setting up the branch (the update channel is set, but the version is not).

Originally, I was thinking that this was reasonable test to ensure the settings are correct on ESR, but it
ends up that the test is only expecting the branch to be on release. Hence, it isn't really a valid test case
and we should trust that the ESR flags are correctly set once ESR starts, and that there's QA/other testing
already in place to verify that fact.

Differential Revision: https://phabricator.services.mozilla.com/D181218
 2023-06-19 13:07:10 +00:00
Mark Banner
0677cff70b Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky 
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
 2023-06-15 08:33:57 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Karandeep
d759f51203 Bug 1643887 - Move handling of search engine one-off hidden from preferences into the search settings. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D180229
 2023-06-12 18:03:52 +00:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
Stephanie Cunnane
6d9273a91c Bug 1825058 - Add test to verify a click on a non-ad link does not record an abandonment event. r=jteow,search-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D180356
 2023-06-09 14:10:40 +00:00
James Teow
2b884da379 Bug 1837429 - Rename hasShoppingTab to shoppingTabDisplayed - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D180346
 2023-06-08 19:55:51 +00:00
James Teow
c3e9fd153f Bug 1836507 - Prevent tab-history events from triggering a click event - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179966
 2023-06-08 16:13:59 +00:00
Mark Banner
9eda2b0fce Bug 1836803 - Drop the language parameter for Bing search suggestions url. r=search-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179973
 2023-06-07 16:13:12 +00:00
Mark Banner
40de601f11 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-06-07 08:42:36 +00:00
Mark Banner
35a53fe97f Bug 1832117 - Ensure places history is cleared between search tests. r=jteow 
This avoids leaking of places data across tests, which may affect suggested results.

Differential Revision: https://phabricator.services.mozilla.com/D179931
 2023-06-05 13:37:19 +00:00
Stephanie Cunnane
ff823ae66a Bug 1829953 - Add follow_on_from_refine_on_SERP tracking to the SERP impression event. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179491
 2023-06-03 17:58:13 +00:00
Mark Banner
232facd440 Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis 
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
 2023-06-02 20:00:35 +00:00
Mark Banner
a2d5839648 Bug 1836107 - Add schema validation testing for search-telemetry-v2. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179582
 2023-06-02 10:11:49 +00:00
James Teow
e76cc25153 Bug 1775917 - Disable the persist search tip from appearing in browser_rich_suggestions.js - r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D179502
 2023-06-01 21:33:10 +00:00
James Teow
adefe13ae5 Bug 1835321 - Allow any link on SERPs that don't match an ad expression to be considered a non-ad - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179367
 2023-06-01 02:13:18 +00:00
James Teow
b3d2e61651 Bug 1834100 - Use timing distribution for categorizing components in SearchSERPTelemetryChild - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179116
 2023-05-31 14:24:34 +00:00
James Teow
2a015a7a12 Bug 1834701 - Refactor SearchSERPTelemetry to have more isolation of page data - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D178911
 2023-05-31 14:24:34 +00:00
Marco Bonardo
ddbafa4329 Bug 1834989 - Clean up UrlbarTestUtils use. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D179056
 2023-05-26 14:56:55 +00:00
Stephanie Cunnane
d5a6f17bab Bug 1834401 - Replace certain calls to SpecialPowers.spawn with calls to BrowserTestUtils.synthesizeMouseAtCenter in search SERP telemetry mochitests. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179126
 2023-05-26 14:40:56 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D178590
 2023-05-26 11:36:33 +00:00
Dão Gottwald
064375dd57 Bug 1834359 - Implement Glean and Legacy Telemetry for Rich Suggestions. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D178689
 2023-05-25 10:50:16 +00:00
Stephanie Cunnane
66b9ea3569 Bug 1816738 - Add opened_in_new_tab tracking to SERP impression event. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D177531
 2023-05-23 22:04:08 +00:00
Natalia Csoregi
1b67d0b941 Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE 
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
 2023-05-24 04:29:45 +03:00
Mark Banner
d1fc869252 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 19:09:29 +00:00
James Teow
5246272dc4 Bug 1833245 - Enable cached page loads to be monitored in SearchSERPTelemetry - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D178502
 2023-05-23 15:06:16 +00:00
Noemi Erli
1f146f097e Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE 
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
 2023-05-23 12:14:37 +03:00
Mark Banner
08ff6c0ad9 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 08:13:08 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Mark Banner
17f6abf4e4 Bug 1834066 - Update Search Engine URL for Gule sider. r=search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D178561
 2023-05-20 09:12:34 +00:00
Mark Banner
bf8f5a87d5 Bug 1834086 - Separate out the search feature in Nimbus into early startup and non-early startup sections. r=jteow 
This separates out the two sets of variables to move the ones in early startup into searchConfiguration.
This will avoid reloading the search engines on startup for most experiments, and ensure that
the experiment is handled correctly for configurations.

The default private handling is retained within the early startup section, as that has an effect on default
search engines which may be affected if engines are loaded without those flags in place.

Differential Revision: https://phabricator.services.mozilla.com/D178552
 2023-05-19 19:49:21 +00:00
James Teow
3eefbb7763 Bug 1833877 - Don't check page for components related to the impression if components don't exist - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D178445
 2023-05-19 02:09:57 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00