Commit Graph

172 Commits

Author SHA1 Message Date
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Niklas Baumgardner
5eafa5cac5 Bug 1844171 - Update screenshots tests. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183912
2023-07-27 16:15:03 +00:00
Niklas Baumgardner
8464bcdbb9 Bug 1844171 - Refactor screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-27 16:15:02 +00:00
Sebastian Hengst
945cff3a90 Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js. Complete backout. CLOSED TREE
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
2023-07-26 21:24:18 +02:00
Norisz Fay
b81bfc15de Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js CLOSED TREE
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
2023-07-26 21:58:58 +03:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Niklas Baumgardner
b6300b00f6 Bug 1844171 - Update screenshots tests. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183912
2023-07-26 15:37:45 +00:00
Niklas Baumgardner
51b2d1bafb Bug 1844171 - Refactor screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-26 15:37:45 +00:00
Niklas Baumgardner
1f9eb86c84 Bug 1827977 - Use in-content styles for screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183423
2023-07-17 18:39:08 +00:00
Neil Deakin
c2bdd9ab4a Bug 1840269, nsFilePicker::GetFile can return a different object on each call, so only call it once, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D183363
2023-07-13 20:44:04 +00:00
Emilio Cobos Álvarez
c8d2c23403 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-09 11:34:05 +00:00
Stanca Serban
27c720052b Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE 2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez
8053b896a6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 21:59:44 +00:00
Cosmin Sabou
20fa44fbeb Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez
b1433254b6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 18:21:31 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
Niklas Baumgardner
655e4f5c79 Bug 1832667 - Add ConfirmationHint when screenshot is copied. r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D178674
2023-05-25 14:27:24 +00:00
Mark Banner
b61a6a6502 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Sam Foster
c3066d257e Bug 1832171 - Link the packaged platform-specific common stylesheets in Screenshots. r=niklas,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D177569
2023-05-10 15:55:46 +00:00
Gijs Kruitbosch
6641241811 Bug 1508369 - clean up browser CSS to pass basic stylelint rules, r=desktop-theme-reviewers,webcompat-reviewers,extension-reviewers,devtools-reviewers,nchevobbe,denschub,dao
Differential Revision: https://phabricator.services.mozilla.com/D177476
2023-05-09 17:12:50 +00:00
Niklas Baumgardner
9bb496859e Bug 1805984 - Update save visible and save full page screenshot buttons. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D176081
2023-05-03 17:53:15 +00:00
Otto Länd
782bf91bbd Bug 1821512: apply code formatting via Lando
# ignore-this-changeset
2023-04-16 15:45:26 +00:00
Lee Salzman
330b1fd3fa Bug 1821512 - Update fuzz for Skia update. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D173326
2023-04-16 15:34:50 +00:00
Natalia Csoregi
a05ee28985 Backed out 6 changesets (bug 1821512) for failures on browser_screenshots_test_full_page.js. CLOSED TREE
Backed out changeset a31f2795710e (bug 1821512)
Backed out changeset 3985c29a6490 (bug 1821512)
Backed out changeset 0d9814a43a4d (bug 1821512)
Backed out changeset e5570884e8e4 (bug 1821512)
Backed out changeset efc92c86fafd (bug 1821512)
Backed out changeset 3222f6498a44 (bug 1821512)
2023-04-16 11:30:32 +03:00
Lee Salzman
1ca9b3427e Bug 1821512 - Update fuzz for Skia update. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D173326
2023-04-16 04:00:01 +00:00
Marco Bonardo
be1ca5c872 Bug 1824117 - Use a custom content prefs group parser in DownloadLastDir. r=Gijs
Make all file: URIs point to the same destination folder.
Make data: URIs point to a destination folder per mime-type. If a mime-type is
not provided it defaults to text/plain, per the data URI spec.
Introduce a migration path in content prefs to remove existing data and file
URIs, users will have to set them again though current ones are not particularly
useful.
Make getFileAsync an async function to simplify the code.

Differential Revision: https://phabricator.services.mozilla.com/D173472
2023-04-14 16:15:59 +00:00
Abhishek Tiwari
cec6f4b2e7 Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu
Differential Revision: https://phabricator.services.mozilla.com/D172245
2023-04-12 17:32:30 +00:00
Niklas Baumgardner
af7af69abe Bug 1814917 - Crop screenshots from overlay when they are too big. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D174896
2023-04-11 13:16:22 +00:00
Iulian Moraru
af50da8673 Backed out 6 changesets (bug 1821512) for causing multiple failures. CLOSED TREE
Backed out changeset 97295a57babe (bug 1821512)
Backed out changeset 698104c7a5d1 (bug 1821512)
Backed out changeset 09aa18e47bf6 (bug 1821512)
Backed out changeset 20b46afb225f (bug 1821512)
Backed out changeset b531f604ea4c (bug 1821512)
Backed out changeset 0a7c0b0773d4 (bug 1821512)
2023-04-11 10:10:41 +03:00
Lee Salzman
f7851e136e Bug 1821512 - Update fuzz for Skia update. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D173326
2023-04-11 05:00:06 +00:00
Niklas Baumgardner
f0190facaa Bug 1824430 - Update screenshots buttons styling. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D173708
2023-03-30 15:30:21 +00:00
Niklas Baumgardner
b418549f7e Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D172043
2023-03-30 15:30:21 +00:00
Iulian Moraru
7237840464 Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
2023-03-30 04:44:53 +03:00
Niklas Baumgardner
5ea1b4a087 Bug 1824430 - Update screenshots buttons styling. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D173708
2023-03-30 00:36:32 +00:00
Niklas Baumgardner
28fe1e62b1 Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D172043
2023-03-30 00:36:31 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
2023-03-29 07:34:10 +00:00
Niklas Baumgardner
1e559272b1 Bug 1811953 - Scroll when resizing near the edge. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D167614
2023-03-22 21:02:49 +00:00
Niklas Baumgardner
ceccf6b94b Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D168315
2023-03-14 17:23:53 +00:00
Niklas Baumgardner
9cadda5534 Bug 1781912 - Fix failing browser_screenshots_drag_test.js test. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D172460
2023-03-14 17:23:29 +00:00
Mark Banner
8aea2c2c67 Bug 1812098 - Fix ESLint raised issues with no-shadow of builtinGlobals in browser .mjs files. r=Gijs,credential-management-reviewers,sgalich,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D169463
2023-03-14 09:13:48 +00:00
Niklas Baumgardner
ca468f920c Bug 1819306 - Set quickactions prefs for screenshots tests. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D171777
2023-03-09 19:05:28 +00:00
Niklas Baumgardner
ed41adbed9 Bug 1820234 - Add margin to screenshots panel buttons. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D172046
2023-03-08 21:31:08 +00:00
Stanca Serban
727887893c Backed out changeset 47a62f76fe40 (bug 1813394) for causing mochitests failures in browser_screenshots_drag_test.js. 2023-03-08 17:37:43 +02:00
Niklas Baumgardner
1dffeba843 Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D168315
2023-03-07 21:25:10 +00:00
Noemi Erli
f8cbf3a235 Backed out changeset a33c121cae89 (bug 1813394) for causing failures in browser_screenshots_test_downloads.js CLOSED TREE 2023-03-07 00:27:21 +02:00