corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

443 Commits

Author SHA1 Message Date
Marco Bonardo
761a9aa462 Bug 1816901 - Stop using promiseItemId in product code. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D180410
 2023-06-24 07:16:51 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Jonathan Sudiaman
9fd065c778 Bug 1820979 - Remove instant apply bookmarks panels code r=mak 
Remove the `browser.bookmarks.editDialog.delayedApply.enabled` pref, and for all usages in conditional branches, assume that it is `true`. (Since we want to be using delayed apply logic going forward.)

`delayed_apply` spinoffs of tests are removed and merged with their instant apply counterparts. The only test removed without a corresponding spinoff is `browser_editBookmark_tags_liveUpdate.js`. That test is checking whether tags are updated in the edit dialog, if they are updated from a different place. The problem is that we don't really want this behavior anymore. It was previously set to only run with `browser.bookmarks.editDialog.delayedApply.enabled` set to `false`, but now that it's no longer configurable, it made most sense to simply get rid of this test.

https://treeherder.mozilla.org/jobs?revision=c0741eca62212a75a9dd52fc2c5c2b6c34f9f2d7&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D176370
 2023-05-09 21:03:19 +00:00
Eemeli Aro
2b4fe0fd44 Bug 1830042 - Migrate places prompt strings to Fluent. r=mak,fluent-reviewers,flod 
As the remaining places.properties strings are used only for
errors and other dialogs from contexts that require sync localization,
it's better to put them in their own new file placesPrompts.ftl.

Differential Revision: https://phabricator.services.mozilla.com/D176646
 2023-05-02 18:34:42 +00:00
Eemeli Aro
fc4f1b6176 Bug 1830042 - Migrate places search & sortby strings to Fluent. r=mak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D176645
 2023-05-02 18:34:41 +00:00
Eemeli Aro
db51c0f57f Bug 1830042 - Migrate detailsPane.noItems and detailsPane.itemsCountLabel strings to Fluent. r=mak,fluent-reviewers,flod 
This also allows dropping the PlacesUIUtils getFormattedString() and getPluralString() functions as unused

Depends on D176643

Differential Revision: https://phabricator.services.mozilla.com/D176644
 2023-05-02 18:34:41 +00:00
Abhishek Tiwari
cec6f4b2e7 Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D172245
 2023-04-12 17:32:30 +00:00
Sarah Clements
34aaa9ccf3 Bug 1819081 - Add telemetry to bookmarks sidebar and library r=mak 
* Add histograms for cumulative searches and utilize scalars added in bug 1815906
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D172596
 2023-03-22 12:39:40 +00:00
Marian-Vasile Laza
33b5136e0f Backed out changeset 811fbfb31174 (bug 1819081) for bc failures on browser_views_liveupdate.js. 2023-03-20 21:10:18 +02:00
Sarah Clements
17b3b13f2a Bug 1819081 - Add telemetry to bookmarks sidebar and library r=mak 
* Add histograms for cumulative searches and utilize scalars added in bug 1815906
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D172596
 2023-03-20 17:46:15 +00:00
Kelly Cochrane
0a91da08b0 Bug 1817251 - Record telemetry for History in sidebar and library when using the context menu r=sclements,mak 
Differential Revision: https://phabricator.services.mozilla.com/D171253
 2023-03-14 10:29:57 +00:00
Kelly Cochrane
f5c7d36f53 Bug 1815906 - Add telemetry for History in Library window r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D169710
 2023-02-22 19:25:52 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D167297
 2023-01-20 17:49:21 +00:00
Marco Bonardo
b7f8cde3d3 Bug 1457131 - Remove no longer necessary getConcreteItemId(). r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D165768
 2023-01-04 13:16:09 +00:00
Mike Conley
1e25b753cb Bug 718280 - Part 5: Use named options rather than an array for showMigrationWizard. r=NeilDeakin,credential-management-reviewers,sgalich 
Depends on D164142

Differential Revision: https://phabricator.services.mozilla.com/D164143
 2022-12-13 17:01:25 +00:00
Sandor Molnar
c46a05c875 Backed out 9 changesets (bug 1800917, bug 718280) for causing xpc failures in browser/components/migration/tests/unit/test_Edge_db_migration.js CLOSED TREE 
Backed out changeset d55b95d9d14f (bug 1800917)
Backed out changeset 8427f1e65df4 (bug 1800917)
Backed out changeset 2d0f77d324f2 (bug 718280)
Backed out changeset eba58fd1ed1c (bug 718280)
Backed out changeset 33027a0f9ce9 (bug 718280)
Backed out changeset 237be1f62d01 (bug 718280)
Backed out changeset 007afe158ae5 (bug 718280)
Backed out changeset f1dea7abdfb7 (bug 718280)
Backed out changeset 47e2cccd33c7 (bug 718280)
 2022-12-13 00:50:16 +02:00
Mike Conley
27adceff4c Bug 718280 - Part 5: Use named options rather than an array for showMigrationWizard. r=NeilDeakin,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D164143
 2022-12-12 16:04:04 +00:00
Mike Conley
6d71851894 Bug 1802961 - Make MigrationUtils an ES6 class singleton. r=kpatenio,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D163256
 2022-12-06 17:50:39 +00:00
Butkovits Atila
b517540509 Backed out 7 changesets (bug 1802358, bug 1801314, bug 1802961) for causing documentation failures. 
Backed out changeset bb0f5e137128 (bug 1802961)
Backed out changeset 4c2a66bfe913 (bug 1802961)
Backed out changeset baaa090cada1 (bug 1802961)
Backed out changeset d98ee38a13bb (bug 1802961)
Backed out changeset 618dcf6d8284 (bug 1802961)
Backed out changeset 59d98ca9fd51 (bug 1802358)
Backed out changeset bce1ea9149bd (bug 1801314)
 2022-12-06 18:21:11 +02:00
Mike Conley
50a3d421f7 Bug 1802961 - Make MigrationUtils an ES6 class singleton. r=kpatenio,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D163256
 2022-12-06 14:46:42 +00:00
Mark Banner
e319b56680 Bug 1801809 - Automatically replace Cu.reportError with console.error (places, download). r=mak 
Depends on D162696

Differential Revision: https://phabricator.services.mozilla.com/D162697
 2022-11-22 16:23:38 +00:00
steven100695
bf405ca708 Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D158655
 2022-10-27 23:52:49 +00:00
Noemi Erli
fa30a0f2a7 Backed out 2 changesets (bug 1788919) for causing failures in browser_noLoginsView.js CLOSED TREE 
Backed out changeset 2f03490ec72e (bug 1788919)
Backed out changeset 449aea6fc974 (bug 1788919)
 2022-10-27 23:45:56 +03:00
steven100695
a150df2a6a Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D158655
 2022-10-27 18:15:55 +00:00
trickypr
fd6c774999 Bug 1510561 - Part 3: Apply plugin:mozilla/require-jsdoc to browser/components/places. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159468
 2022-10-24 13:32:36 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
trickypr
02afbf3322 Bug 1510561 - Part 2: Apply plugin:mozilla/valid-jsdoc to browser/components/places. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D158562
 2022-10-13 10:55:28 +00:00
Masayuki Nakano
3ee9858ad2 Bug 1792759 - part 1: Add nsIEditor.clearUndoRedo() to get rid of nsIEditor.transactionManager r=m_kato,NeilDeakin,Standard8 
`nsIEditor.transactionManager` is used only for some simple purposes, however,
`nsIEditor` exposes the rich API.  That makes it harder to maintain internal
code around transactions.  Instead, `nsIEditor` exposes only simple and
necessary APIs.

This patch creates a new API to clear undo/redo history and make the users in
mozilla-central use it instead of using `nsITransactionManager.clear()`.

Differential Revision: https://phabricator.services.mozilla.com/D158336
 2022-10-09 01:13:49 +00:00
James Teow
87f75837fd Bug 1786518 - Remove ensureRowIsVisible from firing in updateDetailsPane - r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D155391
 2022-08-29 15:15:16 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 10:36:49 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150894
 2022-07-11 12:41:50 +00:00
Kagami Sascha Rosylight
4fb733cb3b Bug 1773740 - Part 4: Reapply mach -l eslint --fix with use-isInstance changes r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148939
 2022-06-27 20:31:34 +00:00
James Teow
d99404900f Bug 1760637 - Upgrade initPanel in instantEditBookmark.js to async r=mak 
In addition to adding async/await, I also added early return statements
when we know initialization is occuring again, or if there is evidence
that it has been uninitialized.

A concrete example of this would be from the Library, where clicking on
on a folder/category on the left will run initPanel at the same time as
the highlighted folder/bookmark on the right changes (also runs initPanel).

Differential Revision: https://phabricator.services.mozilla.com/D141800
 2022-05-17 00:32:48 +00:00
James Teow
5e057f3cf1 Bug 1767434 - Make updateDetailsPane always retrieve treeIndex r=mak 
The problem with my previous solution for bug 1471546 was that bookmarkIndex is
not updated when a user sorts the list of bookmarks. So my solution is to always
use the treeIndex since its more reliable.

I've also added two tests: the first checks if the row the visible after clicking
a bookmark that's close to the bottom of the viewable area, and the second does the
same after re-sorting the list.

Differential Revision: https://phabricator.services.mozilla.com/D145509
 2022-05-16 14:21:59 +00:00
Mark Banner
0f92186309 Bug 1769227 - Remove OS.Path usage from places.js. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D146293
 2022-05-13 12:55:09 +00:00
James Teow
18c273efd8 Bug 1471546 - Scroll to bookmark in bookmark library on initial selection when it's not visible r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D139905
 2022-04-22 13:14:41 +00:00
Mark Banner
2649c5fb78 Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D136368
 2022-01-20 14:15:34 +00:00
Sam Foster
756ed30259 Bug 1747422 - Rename the allDownloads list box. r=dao 
* Having a different id for the container of download items in the download panel vs the all-downloads view (about:downloads and the library/places view) is one of the main reasons we need the %define item, to allow the same included stylesheet to apply to the different markup by virtue of the different selector produced when @item@ is expanded
* As these IDs aren't particularly descriptive, and the distinction isn't meaningful, having each list use the same id allows more direct stylesheet reuse in both places

Differential Revision: https://phabricator.services.mozilla.com/D135399
 2022-01-16 10:54:32 +00:00
Evgenia Kotovich
2d9bc99735 Bug 1747684 - Clone instantEditBookmark.js to editBookmark.js and connect both. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D134774
 2022-01-10 18:40:39 +00:00
Evgenia Kotovich
33a6258c3f Bug 1747684 - Rename editBookmark.js to instantEditBookmark.js. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D134723
 2022-01-10 18:40:39 +00:00
Mark Banner
892d565c43 Bug 1726760 - Replace OS.File with IOUtils in the places browser code. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D123215
 2021-08-21 08:28:58 +00:00
Mark Banner
f144cfcf62 Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D115233
 2021-05-18 16:27:44 +00:00