corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

3580 Commits

Author SHA1 Message Date
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Marco Bonardo
0074eee844 Bug 1846121 - Add places-reviewers group to the docs. r=zeid,places-reviewers,Standard8 DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D184919
 2023-07-31 13:47:50 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Daisuke Akatsuka
2bf471ef0b Bug 1829580: Remove nsNavHistory::VisitIdToResultNode() r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D183337
 2023-07-25 22:47:59 +00:00
Marco Bonardo
530854e412 Bug 1844150 - Don't add moz-anno:favicon to local protocols. r=daisuke,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D184376
 2023-07-25 16:37:14 +00:00
Cristina Horotan
4b34180c2b Backed out changeset 46add7a02063 (bug 1844150) for causing bc failures at browser_readerMode.js CLOSED TREE 2023-07-25 16:31:59 +03:00
Marco Bonardo
b690ec8b26 Bug 1844150 - Don't add moz-anno:favicon to local protocols. r=daisuke,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D184376
 2023-07-25 11:02:18 +00:00
Marco Bonardo
8fd6444a42 Bug 1840207 - The bookmarked-moved event needs all the details to do a remove+insert operation. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D182595
 2023-07-03 08:55:51 +00:00
Masayuki Nakano
f3344407c0 Bug 831008 - Make EventListenerManager assert when a legacy DOM mutation event listener is added in either chrome documents, native anonymous subtrees or the system event groups r=smaug 
The legacy DOM mutation events shouldn't be used even in content and must not be
used in chrome.

This patch makes it crash if legacy mutation event listener is:
* added to a node in a chrome document
* added to a node in a native anonymous subtree
* added to the system event group
* implemented by C++

This causes some crash tests and chrome tests.  Therefore, this patch modifies
them to use `MutationObserver` instead or removes them if it's impossible to
rewrite with `MutationObserver`.

Note that if I prevent to dispatch mutation events in some/all of the cases,
that causes performance regression in Speedometer3.  Therefore, this patch
does not touch `EventDispatcher`.

Differential Revision: https://phabricator.services.mozilla.com/D181828
 2023-06-27 04:20:17 +00:00
Karandeep
eaf5c7d8a6 Bug 1836986 - Hide tags field in the Star ("Bookmark this page") panel when the user has no tags. r=dao,mak 
Differential Revision: https://phabricator.services.mozilla.com/D181557
 2023-06-25 11:19:13 +00:00
Marco Bonardo
202ab1ab80 Bug 1816901 - Remove the Places GuidHelper. r=daisuke,sync-reviewers,skhamis 
Depends on D180411

Differential Revision: https://phabricator.services.mozilla.com/D180412
 2023-06-24 07:16:51 +00:00
Marco Bonardo
761a9aa462 Bug 1816901 - Stop using promiseItemId in product code. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D180410
 2023-06-24 07:16:51 +00:00
Mark Banner
606ebaa93d Bug 1839388 - Convert distribution.js to an ES module. r=mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D181578
 2023-06-22 07:22:13 +00:00
Emilio Cobos Álvarez
45eb2f3d7b Bug 1839066 - Improve selection checks in places-tree. r=mak 
This doesn't fix the bug but I saw some exceptions related to having a
non-null view with a null selection that this fixes.

Differential Revision: https://phabricator.services.mozilla.com/D181379
 2023-06-20 08:58:10 +00:00
Mark Banner
3eff463fbd Bug 1752744 - Fix opening bookmarks from the library window in certain conditions. r=mak,webdriver-reviewers,whimboo 
This fixes the case where there's no browser window open and browser.tabs.loadBookmarksInTabs is true.

Differential Revision: https://phabricator.services.mozilla.com/D181098
 2023-06-19 19:00:30 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Gijs Kruitbosch
3c6e3c3cab Bug 1838632 - fix edit bookmarks dialog's use of non-standard fluent attributes to use more straightforward switches between messages, r=jsudiaman,fluent-reviewers,flod 
Depends on D181229

Differential Revision: https://phabricator.services.mozilla.com/D181230
 2023-06-19 16:30:16 +00:00
Norisz Fay
ef6bd98346 Backed out changeset f67d1786e5a9 (bug 1752744) for causing bustages on testsuite-targets.mk CLOSED TREE 2023-06-19 15:13:03 +03:00
Mark Banner
7a68d3594e Bug 1752744 - Fix opening bookmarks from the library window in certain conditions. r=mak,webdriver-reviewers,whimboo 
This fixes the case where there's no browser window open and browser.tabs.loadBookmarksInTabs is true.

Differential Revision: https://phabricator.services.mozilla.com/D181098
 2023-06-19 11:49:42 +00:00
Dão Gottwald
2b648df481 Bug 1835890 - Make sidebar switcher panel a normal menupopup. r=Itiel,extension-reviewers,mconley,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D179877
 2023-06-15 14:14:43 +00:00
Mark Banner
0677cff70b Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky 
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
 2023-06-15 08:33:57 +00:00
Marco Castelluccio
4c09f5ca03 Bug 1406475 - Use Svc.PrefBranch instead of Svc.Prefs in PlacesUIUtils module. r=sync-reviewers,skhamis 
Depends on D180806

Differential Revision: https://phabricator.services.mozilla.com/D180807
 2023-06-14 23:15:36 +00:00
Malte Juergens
0d2a60e8cf Bug 1835983: Update browser/components/places/tests/browser/browser_bug485100-change-case-loses-tag.js to work with https-first enabled r=freddyb 
Differential Revision: https://phabricator.services.mozilla.com/D179940
 2023-06-08 12:58:37 +00:00
Kershaw Chang
86ab7691ee Bug 1543990 - Simplify nsISpeculativeConnect API, r=necko-reviewers,geckoview-reviewers,search-reviewers,valentin,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D179066
 2023-06-01 09:46:12 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D178590
 2023-05-26 11:36:33 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D177423
 2023-05-24 15:52:34 +00:00
Mark Banner
b61a6a6502 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177938
 2023-05-20 12:26:56 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Marco Bonardo
fe84c45462 Bug 1818461 - Remove the synchronous PlacesUtils.getChildCountForFolder().r=daisuke,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D175532
 2023-05-19 12:17:17 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Jonathan Sudiaman
9fd065c778 Bug 1820979 - Remove instant apply bookmarks panels code r=mak 
Remove the `browser.bookmarks.editDialog.delayedApply.enabled` pref, and for all usages in conditional branches, assume that it is `true`. (Since we want to be using delayed apply logic going forward.)

`delayed_apply` spinoffs of tests are removed and merged with their instant apply counterparts. The only test removed without a corresponding spinoff is `browser_editBookmark_tags_liveUpdate.js`. That test is checking whether tags are updated in the edit dialog, if they are updated from a different place. The problem is that we don't really want this behavior anymore. It was previously set to only run with `browser.bookmarks.editDialog.delayedApply.enabled` set to `false`, but now that it's no longer configurable, it made most sense to simply get rid of this test.

https://treeherder.mozilla.org/jobs?revision=c0741eca62212a75a9dd52fc2c5c2b6c34f9f2d7&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D176370
 2023-05-09 21:03:19 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
Katherine Patenio
2139e0fa1e Bug 1830421 - convert CustomizableWidgets, CustomizeMode, DragPositionManager and SearchWidgetTracker in browser/components/customizableui to ESMs r=Standard8,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D176825
 2023-05-03 18:05:26 +00:00
Eemeli Aro
2b4fe0fd44 Bug 1830042 - Migrate places prompt strings to Fluent. r=mak,fluent-reviewers,flod 
As the remaining places.properties strings are used only for
errors and other dialogs from contexts that require sync localization,
it's better to put them in their own new file placesPrompts.ftl.

Differential Revision: https://phabricator.services.mozilla.com/D176646
 2023-05-02 18:34:42 +00:00
Eemeli Aro
fc4f1b6176 Bug 1830042 - Migrate places search & sortby strings to Fluent. r=mak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D176645
 2023-05-02 18:34:41 +00:00
Eemeli Aro
db51c0f57f Bug 1830042 - Migrate detailsPane.noItems and detailsPane.itemsCountLabel strings to Fluent. r=mak,fluent-reviewers,flod 
This also allows dropping the PlacesUIUtils getFormattedString() and getPluralString() functions as unused

Depends on D176643

Differential Revision: https://phabricator.services.mozilla.com/D176644
 2023-05-02 18:34:41 +00:00
Eemeli Aro
76ff36feab Bug 1830042 - Migrate bookmarksMenuEmptyFolder string to Fluent. r=mak,fluent-reviewers,flod 
Depends on D176642

Differential Revision: https://phabricator.services.mozilla.com/D176643
 2023-05-02 18:34:41 +00:00
Eemeli Aro
41c3009db2 Bug 1830042 - Migrate placesContext_delete_history and placesContext_createBookmark to Fluent. r=mak,fluent-reviewers,flod 
Depends on D176641

Differential Revision: https://phabricator.services.mozilla.com/D176642
 2023-05-02 18:34:41 +00:00
anwar
1d2e079021 Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D176459
 2023-05-02 16:13:24 +00:00
Abhishek Tiwari
cec6f4b2e7 Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D172245
 2023-04-12 17:32:30 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Marco Bonardo
28afd9f1c3 Bug 1820332 - Dragging URL from address bar results in bookmark with the URL instead of the page title. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D173689
 2023-03-27 14:44:50 +00:00
Mark Banner
e8daad195d Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu 
Depends on D173450

Differential Revision: https://phabricator.services.mozilla.com/D173451
 2023-03-24 19:35:25 +00:00
Sarah Clements
34aaa9ccf3 Bug 1819081 - Add telemetry to bookmarks sidebar and library r=mak 
* Add histograms for cumulative searches and utilize scalars added in bug 1815906
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D172596
 2023-03-22 12:39:40 +00:00
Marian-Vasile Laza
33b5136e0f Backed out changeset 811fbfb31174 (bug 1819081) for bc failures on browser_views_liveupdate.js. 2023-03-20 21:10:18 +02:00
Sarah Clements
17b3b13f2a Bug 1819081 - Add telemetry to bookmarks sidebar and library r=mak 
* Add histograms for cumulative searches and utilize scalars added in bug 1815906
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D172596
 2023-03-20 17:46:15 +00:00
Emilio Cobos Álvarez
2d3579a0ff Bug 1823088 - Fix flex-basis in the edit bookmark panel. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D172900
 2023-03-20 11:36:28 +00:00