corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1682 Commits

Author SHA1 Message Date
Csoregi Natalia
5edbe31601 Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE 
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
 2022-10-25 23:47:58 +03:00
Mark Banner
6bff0ab996 Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D160031
 2022-10-25 19:49:26 +00:00
scott
391ec6f20b Bug 1795333 - Pocket newtab adding spoc site id to nimbus variables. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D159413
 2022-10-19 18:12:49 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Chris H-C
4f0806c847 Bug 1795136 - Correct sponsoredness detection for top story impressions, clicks r=nanj,thecount 
I forgot to transmit the information from the content.

Differential Revision: https://phabricator.services.mozilla.com/D159406
 2022-10-14 18:45:45 +00:00
Emily McMinn
b7eb08264b Bug 1786523 - Add a where prop to FXA Accounts to allow opening in a new tab r=negin,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D156206
 2022-10-12 22:10:58 +00:00
Narcis Beleuzu
9f5ad99416 Backed out changeset 20fbab8f376a (bug 1791647) as req by Mardak 2022-10-11 21:09:45 +03:00
hanna alemu
e0c26c226d Bug 1786632 - AboutWelcome progress bar test fails for noninteger display scaling factors r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D158964
 2022-10-11 13:26:54 +00:00
Gavin Suntop
f8b59c716a Bug 1790667 - Design tweaks for STP button r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D157505
 2022-10-07 17:04:27 +00:00
scott
26d7902675 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D158531
 2022-10-05 20:20:02 +00:00
Csoregi Natalia
ca10cb1d71 Backed out changeset 39dd7976006b (bug 1793487) for causing newtab failures. CLOSED TREE 2022-10-05 21:07:56 +03:00
scott
c0bd2e12f8 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D158531
 2022-10-05 17:23:23 +00:00
scott
440b550494 Bug 1792735 - Pocket newtab nimbus variable and fallback pref for spoc placements r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D158277
 2022-10-04 21:13:53 +00:00
Angel_V129
e3be76313a Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157037
 2022-10-04 19:02:24 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
hanna alemu
d1d82341cd Bug 1791647 - Check home page checkbox by default for colorway upgrade screen r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D157989
 2022-09-28 17:55:13 +00:00
Mark Banner
92309dcd01 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D158088
 2022-09-27 18:58:57 +00:00
Cristian Tuns
379cbd0e59 Backed out changeset cd3ab0559b8a (bug 1792344) for causing node failures CLOSED TREE 2022-09-27 14:44:13 -04:00
Mark Banner
87cee1d460 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D158088
 2022-09-27 18:06:46 +00:00
scott
c38905f047 Bug 1791615 - Pocket newtab configurable cache time. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D158059
 2022-09-27 00:53:35 +00:00
scott
554aaaaf6b Bug 1791614 - Pocket newtab adding reader mode links to recent saves. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D157749
 2022-09-20 20:08:51 +00:00
Jonathan Sudiaman
febfadf50b Bug 1790758 - Convert Region.jsm and IgnoreLists.jsm JSM modules to ESMs r=Standard8,preferences-reviewers,credential-management-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D157337
 2022-09-20 12:21:45 +00:00
Shane Hughes
75546a2dcb Bug 1790655 - Include screen list in AboutWelcome telemetry ping message IDs. r=Mardak 
Add a list of screen initials to the message ID strings sent with
AboutWelcomeTelemetry impression pings. Each screen's message ID will
include a string representing the screen ID of each screen in the
message, in addition to information about the screen itself (for
example, `PLSICMG` represents AW_PIN_FIREFOX, AW_LANGUAGE_MISMATCH,
etc). This will support, for example, comparisons of user engagement
between messages with many screens versus messages with few screens.
Also change the screen ID for one screen that was adjacent to another
screen with the same initial, in order to disambiguate them (since both
screens can potentially be removed, currently).

Differential Revision: https://phabricator.services.mozilla.com/D157581
 2022-09-17 18:08:52 +00:00
Ed Lee
655ad8b48c Bug 1782944 - The marketplace buttons from the “Get Firefox Klar” modal no longer redirect to the Firefox Klar on App Store/Google Play using de locale and region r=pdahiya 
Remove image_overrides custom replacing the QR code for FOCUS message and instead use a separate message for de locale that also configures the links correctly like the KLAR message.

Differential Revision: https://phabricator.services.mozilla.com/D157518
 2022-09-16 05:26:14 +00:00
Emily McMinn
fd387bec24 Bug 1790594 - Update button label colors for HCM r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D157246
 2022-09-16 00:48:31 +00:00
Punam Dahiya
e22374b3fb Bug 1790072 - Existing user onboarding colorways screen should select user existing theme intensity r=Mardak 
Configure upgrade spotlight with dark variation to persist variation as bold when starting with a dark theme.

Differential Revision: https://phabricator.services.mozilla.com/D157161
 2022-09-15 02:42:02 +00:00
negin
6e90484073 Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D157144
 2022-09-14 19:44:39 +00:00
Nick Alexander
e0bf9e65d7 Bug 1790444 - Allow to localize action title in Toast Notification actions messages. r=barret 
Differential Revision: https://phabricator.services.mozilla.com/D157165
 2022-09-14 17:47:24 +00:00
Sarah Clements
e04c7ffb66 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
2e7d3531bc Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
26d455d485 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Meg Viar
067eaadd58 Bug 1788991 - Add Messaging Trigger for the nth Closed Tab r=dmose,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156905
 2022-09-13 21:03:46 +00:00
Sandor Molnar
adc341e323 Backed out changeset 658be3acc41a (bug 1788991) for causing bc failures in toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js CLOSED TREE 2022-09-13 23:01:38 +03:00
Meg Viar
edd8a30169 Bug 1788991 - Add Messaging Trigger for the nth Closed Tab r=dmose,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156905
 2022-09-13 18:48:17 +00:00
Punam Dahiya
f332fca018 Bug 1789192 - MR Onboarding Mobile Cross promo QRCode for MozillaOnline partner repack r=jprickett,hectorz 
Differential Revision: https://phabricator.services.mozilla.com/D157000
 2022-09-13 18:35:01 +00:00
Sandor Molnar
03d1865f8f Backed out changeset a224934d4790 (bug 1786523) for causing multiple failures in browser_siteData_multi_select/browser_aboutwelcome_multistage_mr CLOSED TREE 2022-09-13 22:27:08 +03:00
Emily McMinn
ec1c592456 Bug 1786523 - Add a where prop to FXA Accounts to allow opening in a new tab r=negin 
Differential Revision: https://phabricator.services.mozilla.com/D156206
 2022-09-13 17:53:08 +00:00
Mike Conley
023d86fe63 Bug 1775858 - Make sure Discovery Stream cards exist before running about:home startup cache tests. r=daleharvey 
The about:home startup cache tests assert that Discovery Stream nodes are rendered in
the cached page after it loads. It seems that about:home startup is a bit asynchronous,
and _sometimes_ the Discovery Stream cards don't yet exist at the time of caching.

This updates our tests to wait for about:home to have finished loading the Discovery Stream
nodes before continuing.

Differential Revision: https://phabricator.services.mozilla.com/D157147
 2022-09-13 16:30:34 +00:00
Iulian Moraru
dcf1f3817e Backed out changeset b81337fc9ed1 (bug 1789192) for causing multiple bc failures. CLOSED TREE 2022-09-13 19:44:44 +03:00
Punam Dahiya
31a79a1338 Bug 1789192 - MR Onboarding Mobile Cross promo QRCode for MozillaOnline partner repack r=jprickett,hectorz 
Patch updates QR code svg as confirmed in https://bugzilla.mozilla.org/show_bug.cgi?id=1789192#c3

Differential Revision: https://phabricator.services.mozilla.com/D157000
 2022-09-13 15:52:27 +00:00
Dan Mosedale
35c16cc1e4 Bug 1789186 - Fix _showUpgradeDialog race, r=Mardak 
Up until now, we were waiting on `TabSwitchDone` to open the Spotlight dialog. Unfortunately, this sometimes finished too soon, and the `about:home` URI for the new tab load gets set after the dialog is in flight, causing the [TabDialogBox onLocationChange function](https://searchfox.org/mozilla-central/rev/275630dfceb88eee07e4c7d38cd021dd39c2ab23/browser/base/content/browser.js#9241) to abort the dialog entirely.

Now, we use a TabsProgressListener to open the dialog once `onLocationChange` has fired.  [It makes the tests much happier](https://treeherder.mozilla.org/jobs?repo=try&revision=e8b04a4a1b7f8372bd948e4227b042168ed3778a) -- here's [how things looked before](https://treeherder.mozilla.org/jobs?repo=try&revision=6b8356207c0550fe070c050a482a8135c9826c5c). I believe this issue could happen to real users, so I'm inclined to land this for 106.  That said, I have a fair bit of sympathy for the concern that this sort of change could have unintended fallout.

@Mardak, would love your thoughts on when to land...

Differential Revision: https://phabricator.services.mozilla.com/D157142
 2022-09-13 15:43:29 +00:00
Barret Rennie
6b4a7f9717 Bug 1784101 - Add targeting for detecting MR2022 holdback study r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156215
 2022-09-12 20:37:17 +00:00
Barret Rennie
cc4effe4c1 Bug 1784100 - Override aboutwelcome.templateMR feature with majorRelease 2022 r=pdahiya 
I also cleaned up browser_aboutwelcome_multistage_mr.js so that each task is
idempotent and does not pollute the state of other tasks (e.g., by leaving
prefs set).

Differential Revision: https://phabricator.services.mozilla.com/D155886
 2022-09-12 20:37:16 +00:00
Shane Hughes
e641c823dc Bug 1790127 - Hide the secondary CTA on welcome screen if the primary action will have no effect. r=Mardak 
If Firefox is the default app and pinned to the dock/taskbar, the
primary CTA on the welcome screen will have the same effect as the
secondary CTA. So we can hide one of them. The non-MR page already has
this feature and elects to hide the secondary CTA, so do the same here.

Differential Revision: https://phabricator.services.mozilla.com/D157019
 2022-09-11 20:14:53 +00:00
Mark Banner
73631b4520 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 14:40:07 +00:00
Norisz Fay
6008f8d423 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE 
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
 2022-09-08 17:14:00 +03:00
Mark Banner
e8c3c1e5b4 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 12:43:32 +00:00
Shane Hughes
2945ea98f2 Bug 1787115 - Allow Colorways onboarding modal to restore user-installed themes. r=pdahiya 
This is the simplest approach I could think of to allow the welcome screen to
revert back to any theme the user had installed initially. The reason this
wasn't working previously is just that the surface could only retrieve built-in
addon IDs. If we reserve a property for an active non-built-in theme, then the
behavior will be the same for built-in themes and user-installed themes.

Differential Revision: https://phabricator.services.mozilla.com/D155769
 2022-09-08 04:12:28 +00:00
Chris H-C
e004fe0137 Bug 1786612 - Also send 'newtab' pings at component init r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D156123
 2022-09-07 17:28:36 +00:00
Chris H-C
03ec4b9f67 Bug 1786612 - Instrument Pocket interactions with events r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D155756
 2022-09-07 17:28:36 +00:00