Commit Graph

234 Commits

Author SHA1 Message Date
Shane Hughes
075092d296 Bug 1832715 - Allow multistage spotlight OPEN_URL actions to include UTM params. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D177848
2023-06-08 19:20:07 +00:00
Nan Jiang
9ad8b6e8e1 Bug 1834795 - Implement Share-of-Voice for sponsored tiles r=thecount,ttran
Differential Revision: https://phabricator.services.mozilla.com/D179149
2023-05-29 20:44:25 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
scottdowne
272067742c Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D177935
2023-05-15 13:46:01 +00:00
scottdowne
4b486920aa Bug 1812690 - Pocket newtab enabling onboarding experience for new users seeing the Pocket section for the first time. r=gvn,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D174710
2023-04-25 16:49:25 +00:00
scottdowne
de18d8fccf Bug 1812689 - Pocket newtab new regions implementation r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D173853
2023-04-21 17:57:28 +00:00
Mike Conley
1a8461cd0b Bug 1826360 - Do not include sponsored tiles for about:home startup cache r=mconley,thecount
Differential Revision: https://phabricator.services.mozilla.com/D174646
2023-04-04 18:25:43 +00:00
Lina Butler
0ea22d21eb Bug 1821556 - Collect the tile position and number of tile rows in newtab pings. r=nanj
This commit:

* Adds a `position` key to the `topsites.{impression, click}` events.
  This position is zero-based, to align with `pocket_position`.
* Refactors the impression stats actions in `TelemetryFeed` to receive
  the zero-based tile position, and adds one to the structured
  ingestion payloads and scalar values.
* Adds a new Glean metric, `topsites.rows`, to record the number of
  rows shown on the New Tab page.

Differential Revision: https://phabricator.services.mozilla.com/D172292
2023-03-31 05:21:20 +00:00
Lina Butler
d78454e018 Bug 1820707 - Record impressions and clicks for organic tiles. r=nanj
Currently, the Glean `newtab` ping and legacy scalars collect
impressions and clicks for sponsored (Pocket and Contile) tiles, but
not organic tiles from Places.

This commit adds:

* Support for recording organic impressions to the
  `TopSiteImpressionWrapper` component.
* Support for recording organic clicks to the `TopSiteLink`
  component.
* Instrumentation for recording organic impressions and clicks,
  separate from sponsored ones, to `TelemetryFeed`.

Differential Revision: https://phabricator.services.mozilla.com/D171830
2023-03-11 05:24:03 +00:00
scott
173e73bfcf Bug 1805589 - Pocket newtab add Discovery Stream topsites to topsites list earlier.
Differential Revision: https://phabricator.services.mozilla.com/D164625
2023-03-03 21:54:36 +00:00
Stanca Serban
ba2c013d86 Backed out changeset 51080108cc0d (bug 1805589) for causing mochitests failures in browser/components/newtab/test/browser/abouthomecache/browser_no_startup_actions.js. CLOSED TREE 2023-03-03 21:29:55 +02:00
scott
89b0078202 Bug 1805589 - Pocket newtab add Discovery Stream topsites to topsites list earlier. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D164625
2023-03-03 18:22:34 +00:00
Mark Banner
bffb763c63 Bug 1815224 - Migrate newtab's Reducers.jsm to ES modules. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D168955
2023-02-06 19:11:48 +00:00
Mark Banner
00abf03e4f Bug 1808202 - Convert newtab DeDupe.jsm, ActorConstants.jsm and Actions.jsm to ES modules and update imports. r=Mardak
Depends on D165820

Differential Revision: https://phabricator.services.mozilla.com/D165821
2023-01-05 09:58:30 +00:00
Shane Hughes
c145c22abc Bug 1804786 - Fix enzyme unit tests. r=mviar
Modify the enzyme assertions in unit tests so they can fail when
regressed. Update the same tests since now they would fail otherwise.
One of them also required fixing a bug in MSLocalized.jsx.

Differential Revision: https://phabricator.services.mozilla.com/D164403
2022-12-12 18:04:12 +00:00
scott
81b2abcdfd Bug 1803410 - Pocket newtab topsites, fixing replaced pinned edge cases. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163510
2022-12-01 17:38:57 +00:00
scott
34d6c900b7 Bug 1803206 - Pocket newtab sponsored topsite fixing image resize. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163363
2022-11-30 03:57:12 +00:00
scott
e6e0377789 Bug 1803107 - Pocket newtab topsites fixing pinning issue with sponsored Pocket tile. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163339
2022-11-29 19:10:47 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D161942
2022-11-13 21:02:41 +00:00
scott
4f01a04373 Bug 1799649 - Pocket newtab sponsored topsite drag position change fix. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D161625
2022-11-08 21:24:47 +00:00
scott
6b25631050 Bug 1797612 - Newtab prevent sponsored topsites from being dragged r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D161000
2022-11-02 22:12:02 +00:00
Nan Jiang
aa7e4ae5e7 Bug 1794022 - Add telemetry for top sites SPOCS r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D160939
2022-11-01 21:02:26 +00:00
scott
258a894504 Bug 1794020 - topsite promo tiles
Differential Revision: https://phabricator.services.mozilla.com/D160851
2022-10-31 22:05:25 +00:00
Marian-Vasile Laza
fe65732048 Backed out changeset f394d8fa64f3 (bug 1794020) for causing marionette & telemetry failures. CLOSED TREE 2022-10-29 12:17:19 +03:00
scott
3adac7d415 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-29 08:42:00 +00:00
Sandor Molnar
17a6bd06dc Backed out changeset 19fcc2a044a8 (bug 1794020) for causing mochitest failures in lib/DiscoveryStreamFeed.jsm CLOSED TREE 2022-10-28 21:37:39 +03:00
scott
dced0ed94d Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-28 16:03:49 +00:00
Noemi Erli
111f253947 Backed out changeset 12a565036b3c (bug 1794020) for causing DiscoveryStreamFeed.jsm related failures CLOSED TREE 2022-10-28 01:41:55 +03:00
scott
03cc186a29 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-27 21:54:00 +00:00
Marian-Vasile Laza
bafe5f1f3b Backed out changeset ad5bb5f4a576 (bug 1794020) for causing bc failures on browser_policy_firefoxhome.js. CLOSED TREE 2022-10-26 22:37:25 +03:00
scott
e9cf819459 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-26 18:12:26 +00:00
Chris H-C
4f0806c847 Bug 1795136 - Correct sponsoredness detection for top story impressions, clicks r=nanj,thecount
I forgot to transmit the information from the content.

Differential Revision: https://phabricator.services.mozilla.com/D159406
2022-10-14 18:45:45 +00:00
Gavin Suntop
f8b59c716a Bug 1790667 - Design tweaks for STP button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157505
2022-10-07 17:04:27 +00:00
scott
26d7902675 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 20:20:02 +00:00
Csoregi Natalia
ca10cb1d71 Backed out changeset 39dd7976006b (bug 1793487) for causing newtab failures. CLOSED TREE 2022-10-05 21:07:56 +03:00
scott
c0bd2e12f8 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 17:23:23 +00:00
scott
554aaaaf6b Bug 1791614 - Pocket newtab adding reader mode links to recent saves. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D157749
2022-09-20 20:08:51 +00:00
Chris H-C
03ec4b9f67 Bug 1786612 - Instrument Pocket interactions with events r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D155756
2022-09-07 17:28:36 +00:00
scott
9064163ddd Bug 1782318 - Pocket newtab show placeholder thumbnail images for cards without images. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D155126
2022-08-24 15:40:12 +00:00
Daisuke Akatsuka
8eb71d3877 Bug 1785165: Make new window by context menu of tile be target to inheritance of sponsored session. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D154845
2022-08-19 21:14:49 +00:00
scott
854c0a9536 Bug 1782319 - Pocket newtab fix issue if recent saves is paired with save to Pocket card r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D153292
2022-08-04 21:35:39 +00:00
scott
87bfee2269 Bug 1779636 - Pocket newtab login state to events pings r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D152121
2022-07-29 20:46:40 +00:00
scott
9528bf357e Bug 1774471 - Pocket newtab refactor dscard props r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D152599
2022-07-26 22:51:57 +00:00
scott
0bbeca25d3 Bug 1779643 - Pocket newtab remove old border and hero css and options r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151872
2022-07-22 04:31:45 +00:00
scott
acb6544ac6 Bug 1778351 - Removing some old Pocket newtab experiment code. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151666
2022-07-19 17:32:56 +00:00
scott
9d63b57239 Bug 1779459 - Pocket newtab update "more topics" link in topics widget r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151752
2022-07-13 18:23:08 +00:00
scott
75329af4b9 Bug 1777539 - Pocket newtab remove load more button and last card features r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D150789
2022-07-05 19:57:22 +00:00
scott
905f931ec2 Bug 1776202 - Pocket newtab recent saves adding my list link to top right of section r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D150500
2022-07-01 16:20:38 +00:00
scott
af929cc0de Bug 1776770 - Pocket newtab recent saves pref work r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D150579
2022-06-30 03:29:13 +00:00