Commit Graph

1473 Commits

Author SHA1 Message Date
Sandor Molnar
17a6bd06dc Backed out changeset 19fcc2a044a8 (bug 1794020) for causing mochitest failures in lib/DiscoveryStreamFeed.jsm CLOSED TREE 2022-10-28 21:37:39 +03:00
scott
dced0ed94d Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-28 16:03:49 +00:00
Noemi Erli
111f253947 Backed out changeset 12a565036b3c (bug 1794020) for causing DiscoveryStreamFeed.jsm related failures CLOSED TREE 2022-10-28 01:41:55 +03:00
scott
03cc186a29 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-27 21:54:00 +00:00
Jason Prickett
53a8a6f015 Bug 1793657 - Created messages for Feature Callout tour in pdf.js r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D158683
2022-10-27 19:32:04 +00:00
Dan Mosedale
b307d5a622 Bug 1797553 - Add fxms-message-1 to default FxMS features, r=negin
Differential Revision: https://phabricator.services.mozilla.com/D160402
2022-10-26 21:22:58 +00:00
Barret Rennie
b1df109588 Bug 1797202 - Ingest messages from Nimbus rollouts in ASRouter r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D160263
2022-10-26 19:00:03 +00:00
Marian-Vasile Laza
bafe5f1f3b Backed out changeset ad5bb5f4a576 (bug 1794020) for causing bc failures on browser_policy_firefoxhome.js. CLOSED TREE 2022-10-26 22:37:25 +03:00
scott
e9cf819459 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-26 18:12:26 +00:00
Mark Banner
433fff5bca Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D160031
2022-10-26 08:06:35 +00:00
Kirk Steuber
8bbbac70d4 Bug 1727820 - Change nsIUpdateChecker consumers to use the new interface r=bhearsum
This patch misses one notable nsIUpdateChecker consumer: AppUpdater. This patch stack makes major changes to AppUpdater, so those changes will be made in their own patch later in this patch stack.

Differential Revision: https://phabricator.services.mozilla.com/D159295
2022-10-26 07:44:31 +00:00
Ed Lee
c4e86dd0d0 Bug 1797366 - Return "Skip this step" button to the Get Started screen r=pdahiya
Revert D157019 "Bug 1790127 - Hide the secondary CTA on welcome screen if the primary action will have no effect. r=Mardak"
This reverts commit 605b709866e0ccc0e740071d627745c3958bbec4.

Differential Revision: https://phabricator.services.mozilla.com/D160305
2022-10-26 04:10:36 +00:00
Punam Dahiya
7137aedad9 Bug 1795037 - Fix filter of messages in ASRouter state after using PBM r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D160125
2022-10-26 03:15:40 +00:00
Iulian Moraru
902802bebe Backed out 18 changesets (bug 1727820) for causing mochitest failures. CLOSED TREE
Backed out changeset 04a0c1cbeeb3 (bug 1727820)
Backed out changeset a6633d97ba02 (bug 1727820)
Backed out changeset dd7cd58bdf72 (bug 1727820)
Backed out changeset 06b53d536ef1 (bug 1727820)
Backed out changeset 2cbec56223e5 (bug 1727820)
Backed out changeset 7ccc00d36f16 (bug 1727820)
Backed out changeset 023595d9cb76 (bug 1727820)
Backed out changeset 3dafccf3cf28 (bug 1727820)
Backed out changeset c60b9a6a79ce (bug 1727820)
Backed out changeset 9bbb0f0f1caf (bug 1727820)
Backed out changeset 6d8cf5f78de8 (bug 1727820)
Backed out changeset 8ed9a62d4c5a (bug 1727820)
Backed out changeset d429cf593dae (bug 1727820)
Backed out changeset 67ba1beb529a (bug 1727820)
Backed out changeset 15762d60d97e (bug 1727820)
Backed out changeset 04f5ad71363a (bug 1727820)
Backed out changeset 137f1da67f91 (bug 1727820)
Backed out changeset 5b91828ded9b (bug 1727820)
2022-10-26 01:25:06 +03:00
Csoregi Natalia
5edbe31601 Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
2022-10-25 23:47:58 +03:00
Mark Banner
6bff0ab996 Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D160031
2022-10-25 19:49:26 +00:00
Kirk Steuber
c6ba4aa673 Bug 1727820 - Change nsIUpdateChecker consumers to use the new interface r=bhearsum
This patch misses one notable nsIUpdateChecker consumer: AppUpdater. This patch stack makes major changes to AppUpdater, so those changes will be made in their own patch later in this patch stack.

Differential Revision: https://phabricator.services.mozilla.com/D159295
2022-10-25 18:10:18 +00:00
Norisz Fay
11a2b4ece2 Backed out 18 changesets (bug 1727820) for causing mochitest failures on browser_updateAsk.js CLOSED TREE
Backed out changeset 577d5618fcd1 (bug 1727820)
Backed out changeset 9e6a904ec81d (bug 1727820)
Backed out changeset d95a38c6e8b4 (bug 1727820)
Backed out changeset dc9b7d7e97ae (bug 1727820)
Backed out changeset 464b501ae051 (bug 1727820)
Backed out changeset 9729c6dd1aac (bug 1727820)
Backed out changeset 3c67eac7d52e (bug 1727820)
Backed out changeset 7c2a0dfca2d2 (bug 1727820)
Backed out changeset 2021fb0cba9e (bug 1727820)
Backed out changeset 7a02de8e6ca6 (bug 1727820)
Backed out changeset 6e9017360297 (bug 1727820)
Backed out changeset 0bfff694ce96 (bug 1727820)
Backed out changeset 746d1c708507 (bug 1727820)
Backed out changeset 3b14d8d1fb94 (bug 1727820)
Backed out changeset c8a1417f3528 (bug 1727820)
Backed out changeset 69ef434ae92c (bug 1727820)
Backed out changeset ad646b770b07 (bug 1727820)
Backed out changeset 18b9dd91761f (bug 1727820)
2022-10-25 05:31:39 +03:00
Kirk Steuber
80f78afa02 Bug 1727820 - Change nsIUpdateChecker consumers to use the new interface r=bhearsum
This patch misses one notable nsIUpdateChecker consumer: AppUpdater. This patch stack makes major changes to AppUpdater, so those changes will be made in their own patch later in this patch stack.

Differential Revision: https://phabricator.services.mozilla.com/D159295
2022-10-24 20:53:21 +00:00
Emily McMinn
7f463520d0 Bug 1790490 - Added alt tag div & strings for MR onboarding images r=mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D159770
2022-10-24 17:50:06 +00:00
scott
391ec6f20b Bug 1795333 - Pocket newtab adding spoc site id to nimbus variables. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D159413
2022-10-19 18:12:49 +00:00
Shane Hughes
7a6dea3750 Bug 1787532 - Let Feature Callouts perform actions on page events. r=mviar
Add a new module and feature callout functions to support messages
performing actions when a specified event is dispatched from the
content. This will allow Feature Callout messages to be dismissed when a
button is clicked within the page in which they are rendered. A screen
just needs to provide a `page_event_listeners` property, which is an
array of objects, each containing event listener parameters (event type,
target selector, and optional parameters) and an action specification
like those already used for buttons. The event listener will be added to
all elements matching the selector, so multiple different buttons could
dismiss or advance the message, if necessary. The new screen property
has this form:
```
page_event_listeners: [
  {
    params: {
      type: string,
      selectors: string,
      options?: {
        capture?: boolean,
        once?: boolean,
        preventDefault?: boolean,
      },
    },
    action: {
      type?: string,
      data?: object,
      dismiss?: boolean,
      etc...
    },
  },
]
```

Differential Revision: https://phabricator.services.mozilla.com/D158899
2022-10-18 14:29:27 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
hanna alemu
34fd1f0af1 Bug 1794592 - Investigate use of message property in Fx view messages/ remove if not used r=mviar
The "message" property of the pref "browser.firefox-view.feature-tour" seems to have no actual use, and only one value of "FIREFOX_VIEW_FEATURE_TOUR". We can remove it to reduce complexity.

Differential Revision: https://phabricator.services.mozilla.com/D159131
2022-10-13 19:41:01 +00:00
Narcis Beleuzu
9f5ad99416 Backed out changeset 20fbab8f376a (bug 1791647) as req by Mardak 2022-10-11 21:09:45 +03:00
hanna alemu
9dfc61c5c6 Bug 1793800 - [Experiment] The Firefox View CFR message is shown in the Control branch of the MR Holdback studies r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D158682
2022-10-06 04:20:50 +00:00
scott
440b550494 Bug 1792735 - Pocket newtab nimbus variable and fallback pref for spoc placements r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158277
2022-10-04 21:13:53 +00:00
Angel_V129
e3be76313a Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157037
2022-10-04 19:02:24 +00:00
Emily McMinn
627580a470 Bug 1792695 - Update Fluent ID for default colorway tooltip on exisiting user onboarding r=negin
Differential Revision: https://phabricator.services.mozilla.com/D158284
2022-09-29 23:30:15 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
hanna alemu
d1d82341cd Bug 1791647 - Check home page checkbox by default for colorway upgrade screen r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D157989
2022-09-28 17:55:13 +00:00
hanna alemu
e78bca6f49 Bug 1792226 - Fx view CFR profile age of atleast two days r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D158040
2022-09-28 00:39:35 +00:00
Mark Banner
92309dcd01 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158088
2022-09-27 18:58:57 +00:00
Cristian Tuns
379cbd0e59 Backed out changeset cd3ab0559b8a (bug 1792344) for causing node failures CLOSED TREE 2022-09-27 14:44:13 -04:00
Mark Banner
87cee1d460 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158088
2022-09-27 18:06:46 +00:00
scott
c38905f047 Bug 1791615 - Pocket newtab configurable cache time. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158059
2022-09-27 00:53:35 +00:00
Brian
0b327f0974 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs.
Differential Revision: https://phabricator.services.mozilla.com/D157034
2022-09-23 21:19:12 +00:00
Punam Dahiya
a223d61beb Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D157691
2022-09-20 20:31:36 +00:00
hanna alemu
c326560584 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D156588
2022-09-20 19:39:02 +00:00
Emily McMinn
0763ca6c8b Bug 1790487 - Change Colorways tooltip and aria-label r=aminomancer,fluent-reviewers
I'll wait to land this until next week, so that we're not putting in new strings right at the end of Nightly.

I've tested this with MacOS VoiceOver & NVDA on windows and the behaviour is pretty good. VoiceOver will repeat the colorway group & name a few times which is annoying, but it's an existing problem we haven't found a tidy solution for yet.

Differential Revision: https://phabricator.services.mozilla.com/D157369
2022-09-20 15:12:18 +00:00
Jonathan Sudiaman
febfadf50b Bug 1790758 - Convert Region.jsm and IgnoreLists.jsm JSM modules to ESMs r=Standard8,preferences-reviewers,credential-management-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157337
2022-09-20 12:21:45 +00:00
Cosmin Sabou
4d2a07b5af Backed out changeset 4eed140eab3f (bug 1783684) for causing several bc failures. CLOSED TREE 2022-09-18 20:04:16 +03:00
hanna alemu
bd65360b11 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D156588
2022-09-18 16:01:11 +00:00
Shane Hughes
75546a2dcb Bug 1790655 - Include screen list in AboutWelcome telemetry ping message IDs. r=Mardak
Add a list of screen initials to the message ID strings sent with
AboutWelcomeTelemetry impression pings. Each screen's message ID will
include a string representing the screen ID of each screen in the
message, in addition to information about the screen itself (for
example, `PLSICMG` represents AW_PIN_FIREFOX, AW_LANGUAGE_MISMATCH,
etc). This will support, for example, comparisons of user engagement
between messages with many screens versus messages with few screens.
Also change the screen ID for one screen that was adjacent to another
screen with the same initial, in order to disambiguate them (since both
screens can potentially be removed, currently).

Differential Revision: https://phabricator.services.mozilla.com/D157581
2022-09-17 18:08:52 +00:00
Ed Lee
655ad8b48c Bug 1782944 - The marketplace buttons from the “Get Firefox Klar” modal no longer redirect to the Firefox Klar on App Store/Google Play using de locale and region r=pdahiya
Remove image_overrides custom replacing the QR code for FOCUS message and instead use a separate message for de locale that also configures the links correctly like the KLAR message.

Differential Revision: https://phabricator.services.mozilla.com/D157518
2022-09-16 05:26:14 +00:00
Punam Dahiya
e22374b3fb Bug 1790072 - Existing user onboarding colorways screen should select user existing theme intensity r=Mardak
Configure upgrade spotlight with dark variation to persist variation as bold when starting with a dark theme.

Differential Revision: https://phabricator.services.mozilla.com/D157161
2022-09-15 02:42:02 +00:00
Meg Viar
0096bcb2fa Bug 1790321 - Ensure that the Firefox View feature tour is displayed when users already have tab sync enabled r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D157163
2022-09-14 21:33:29 +00:00
Shane Hughes
5b7b6ec7d7 Bug 1788754 - Add a primary CTA to the tab pickup message. r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D157066
2022-09-14 19:54:38 +00:00
negin
6e90484073 Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D157144
2022-09-14 19:44:39 +00:00
Meg Viar
714d96b541 Bug 1790465 - Add MR holdback study targeting to all Feature Callout messages r=barret
Differential Revision: https://phabricator.services.mozilla.com/D157146
2022-09-14 18:50:28 +00:00