corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

136 Commits

Author SHA1 Message Date
Chris H-C
eca601ffd9 Bug 1836283 - Reinstrument contextual services PingCentre pings in parallel with Glean r=perry.mcmanis,nanj,wstuckey 
Covers topsites and quicksuggest impressions, clicks, and blocks.

Removes unused and not-to-be-used topsites-in-urlbar pingcentre instrumentation
rather than reinstrumenting it.

Differential Revision: https://phabricator.services.mozilla.com/D179856
 2023-06-26 19:02:46 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE 
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
 2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 10:21:37 +00:00
Katherine Patenio
a408bb9d46 Bug 1834115 - migrate newtab/lib JSMs that do not import modules to ESMs r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D178568
 2023-05-30 22:44:42 +00:00
Perry McManis
5487344d67 Bug 1825863 - Add a Glean version of onboarding and ASRouter telemetry r=dmose,perry.mcmanis,omc-reviewers 
We consolidate all the "messaging-system"-namespace pings into a single Glean
ping to provide a holistic view of all events in that system.

Differential Revision: https://phabricator.services.mozilla.com/D178477
 2023-05-24 02:39:34 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Shane Hughes
d779f112c6 Bug 1818249 - Add a message property to allow CFRs in Private Browsing. r=omc-reviewers,pdahiya 
Also, because the data collection policy now allows Category 1 and 2
data collection in Private Browsing Mode, these CFRs will record
telemetry in PBM according to the existing CFR policy, which allows
Cat1-3 data for pre-release builds and experiments, and Cat1-2 data for
release builds. PBM windows will be treated in the same way that release
builds treat normal windows. When not enrolled in a CFR experiment, the
PBM window will only collect Cat1-2 data. When enrolled in a CFR
experiment, the PBM window may collect Cat3 data. This patch also adds a
new option to PopupNotifications that allows its usual interaction
probes to be recorded in PBM. That means, outside of an experiment,
pings from a PBM window will look just like pings from a release build
non-PBM window. And inside an experiment, pings from a PBM window will
look just like pings from a non-PBM window in any build. This ensures
that the PBM pings do not intrinsically confer any identifying
information, since their privateness cannot be known with certainty.

Differential Revision: https://phabricator.services.mozilla.com/D174200
 2023-05-18 16:26:49 +00:00
Tif Tran
eca0af9a97 Bug 1828234 - Collect blocked advertisers in Glean New Tab metrics r=lina 
Differential Revision: https://phabricator.services.mozilla.com/D176499
 2023-04-27 22:37:10 +00:00
Tif Tran
e8110668ee Bug 1824842 - Record the advertiser name and tile ID for sponsored tile impressions and clicks r=lina 
Differential Revision: https://phabricator.services.mozilla.com/D174678
 2023-04-19 21:38:12 +00:00
Bilal
f49ad16881 Bug 1817002 - ESMified browser/components/pocket/content. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175700
 2023-04-19 19:18:57 +00:00
Lina Butler
0ea22d21eb Bug 1821556 - Collect the tile position and number of tile rows in newtab pings. r=nanj 
This commit:

* Adds a `position` key to the `topsites.{impression, click}` events.
  This position is zero-based, to align with `pocket_position`.
* Refactors the impression stats actions in `TelemetryFeed` to receive
  the zero-based tile position, and adds one to the structured
  ingestion payloads and scalar values.
* Adds a new Glean metric, `topsites.rows`, to record the number of
  rows shown on the New Tab page.

Differential Revision: https://phabricator.services.mozilla.com/D172292
 2023-03-31 05:21:20 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D172850
 2023-03-30 20:51:58 +00:00
Travis Long
e5e92088ef Bug 1822726 - Remove expiring metric used for Server Knobs Validation. r=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D173474
 2023-03-27 13:46:32 +00:00
Lina Butler
d78454e018 Bug 1820707 - Record impressions and clicks for organic tiles. r=nanj 
Currently, the Glean `newtab` ping and legacy scalars collect
impressions and clicks for sponsored (Pocket and Contile) tiles, but
not organic tiles from Places.

This commit adds:

* Support for recording organic impressions to the
  `TopSiteImpressionWrapper` component.
* Support for recording organic clicks to the `TopSiteLink`
  component.
* Instrumentation for recording organic impressions and clicks,
  separate from sponsored ones, to `TelemetryFeed`.

Differential Revision: https://phabricator.services.mozilla.com/D171830
 2023-03-11 05:24:03 +00:00
Chris H-C
7a3d63a7e6 Bug 1814922 - Instrument PingCentre successes/failures by namespace r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D168842
 2023-02-03 21:48:16 +00:00
Travis Long
e04f138b53 Bug 1811561 - Add a test Glean event to validate the Server Knobs functionality. r=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D168578
 2023-02-02 19:48:18 +00:00
Cristian Tuns
0d1ab03a6e Backed out changeset 6298c18b6129 (bug 1811561) for causing node failures CLOSED TREE 2023-02-02 10:05:30 -05:00
Travis Long
1b82aa4268 Bug 1811561 - Add a test Glean event to validate the Server Knobs functionality. r=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D168578
 2023-02-02 14:09:57 +00:00
Mark Banner
00abf03e4f Bug 1808202 - Convert newtab DeDupe.jsm, ActorConstants.jsm and Actions.jsm to ES modules and update imports. r=Mardak 
Depends on D165820

Differential Revision: https://phabricator.services.mozilla.com/D165821
 2023-01-05 09:58:30 +00:00
Mark Banner
df47c60747 Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D165002
 2022-12-23 12:37:07 +00:00
Mark Banner
5dad366a3e Bug 1803911 - Automatically replace Cu.reportError with console.error (newtab), and manually fix tests. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D163770
 2022-12-08 16:21:28 +00:00
Iulian Moraru
e4cb785520 Backed out 3 changesets (bug 1801092) for causing newtab failures. 
Backed out changeset 9153de956154
Backed out changeset 9df9c279c28d (bug 1801092)
Backed out changeset 7323c7444941 (bug 1801092)
 2022-11-30 00:28:42 +02:00
Otto Länd
dbb211d8a1 No bug: apply code formatting via Lando 
# ignore-this-changeset
 2022-11-29 21:46:36 +00:00
Chris H-C
a741773afc Bug 1802207 - Wait to send component_init-reason "newtab" ping until newtab has been categorized r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D162906
 2022-11-24 17:59:21 +00:00
Cristian Tuns
77cb29f0f8 Backed out changeset 4a504fa8d156 (bug 1802207) for causing bc failures CLOSED TREE 2022-11-24 10:46:53 -05:00
Chris H-C
7ff970f21b Bug 1802207 - Wait to send component_init-reason "newtab" ping until newtab has been categorized r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D162906
 2022-11-24 15:22:49 +00:00
Cristian Tuns
d8e86b5e68 Backed out changeset 9c4f4de3d68c (bug 1802207) for causing lint failures on TelemetryFeed.test.js CLOSED TREE 2022-11-24 10:14:59 -05:00
Chris H-C
b88e45d4e4 Bug 1802207 - Wait to send component_init-reason "newtab" ping until newtab has been categorized r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D162906
 2022-11-24 14:52:30 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Chris H-C
e004fe0137 Bug 1786612 - Also send 'newtab' pings at component init r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D156123
 2022-09-07 17:28:36 +00:00
Chris H-C
03ec4b9f67 Bug 1786612 - Instrument Pocket interactions with events r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D155756
 2022-09-07 17:28:36 +00:00
Chris H-C
589fc52a3e Bug 1786612 - Add topsites and top stories prefs to 'newtab' ping r=nanj,thecount 
Also include pocket logged in status, which (because it's not a pref) is
sampled over time.

Also also, include the search field pref.

Differential Revision: https://phabricator.services.mozilla.com/D155755
 2022-09-07 17:28:35 +00:00
scott
87bfee2269 Bug 1779636 - Pocket newtab login state to events pings r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D152121
 2022-07-29 20:46:40 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE 
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
 2022-07-20 14:57:48 +03:00
Mark Banner
f399fc3c21 Bug 1780074 - Migrate browser/components/newtab to ESM. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D152113
 2022-07-20 10:36:52 +00:00
Nick Alexander
6e9303448d Bug 1775128 - Add toast_notification message template for displaying (native) toast notifications. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D150073
 2022-07-20 02:58:42 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D150893
 2022-07-11 12:41:50 +00:00
Chris H-C
ed9b7fb559 Bug 1766887 - Call it newtab_visit_id instead of newtab_session_id for data collection r=Standard8 
This better reflects the concept at the level data analysis is performed.
Each newtab can then be considered a "visit" in the way that web analytics
consider page visits.

Doesn't change the id's contents from being the internal newtab session id.
But names have power.

Differential Revision: https://phabricator.services.mozilla.com/D149445
 2022-06-17 20:21:51 +00:00
Chris H-C
dbda5399ca Bug 1766887 - Gate 'newtab' ping submission behind Nimbus feature variable r=TravisLong 
Differential Revision: https://phabricator.services.mozilla.com/D146847
 2022-06-17 20:21:50 +00:00
Chris H-C
69a594ce29 Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter 
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
 2022-06-17 20:21:49 +00:00
Cristian Tuns
b967cfd2bb Backed out 8 changesets (bug 1766887) for causing mochitest failures on browser_newtab_ping.js CLOSED TREE 
Backed out changeset a6b01c1e8823 (bug 1766887)
Backed out changeset 1ef2dd2b779e (bug 1766887)
Backed out changeset f248baea014a (bug 1766887)
Backed out changeset 3f3066906403 (bug 1766887)
Backed out changeset 3ad63b0fa7b8 (bug 1766887)
Backed out changeset 06a0a6ef295a (bug 1766887)
Backed out changeset abe659b175cb (bug 1766887)
Backed out changeset f90e9e70f6d4 (bug 1766887)
 2022-06-17 10:49:00 -04:00
Chris H-C
c1a96b3dcd Bug 1766887 - Call it newtab_visit_id instead of newtab_session_id for data collection r=Standard8 
This better reflects the concept at the level data analysis is performed.
Each newtab can then be considered a "visit" in the way that web analytics
consider page visits.

Doesn't change the id's contents from being the internal newtab session id.
But names have power.

Differential Revision: https://phabricator.services.mozilla.com/D149445
 2022-06-17 13:47:06 +00:00