Commit Graph

367 Commits

Author SHA1 Message Date
Miriam Onuoha
d49918a212 Bug 1739420 - Re-added styles in _Search.scss. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D130454
2021-11-08 17:32:39 +00:00
Scott
6f90c65607 Bug 1729949 - Removing old Pocket newtab components for list and hero cards. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D129441
2021-10-26 21:43:28 +00:00
Geoff Lankow
f044ee051e Bug 1698112 - Stop referencing browser files from toolkit, and prevent it happening again with a test. r=preferences-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D128974
2021-10-21 21:54:52 +00:00
secret.okra
cd6779c2c3 Bug 1733574 - Increase visibility of shortcut image field for dark theme. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D128767
2021-10-20 14:26:39 +00:00
Scott
4b13dd6aa5 Bug 1733675 - Fixes some nits in Pocket newtab experiment. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D127338
2021-10-04 20:39:08 +00:00
Harry Twyford
f6c835067b Bug 1733646 - Use secondary background color in newtab context menus. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D127293
2021-10-01 20:37:05 +00:00
Scott
bae6836889 Bug 1730017 - Adding save to Pocket button to newtab Pocket cards on hover. r=fluent-reviewers,flod,gvn
Differential Revision: https://phabricator.services.mozilla.com/D126748
2021-09-29 20:20:32 +00:00
Scott
b1ecb29b6d Bug 1730018 - New Pocket footer section on newtab r=gvn,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D126268
2021-09-23 22:08:37 +00:00
Scott
d88d5f1009 Bug 1729946 - Adding Pocket newtab load more button. r=fluent-reviewers,gvn,flod
Differential Revision: https://phabricator.services.mozilla.com/D125631
2021-09-23 02:48:38 +00:00
Harry Twyford
bd18b6c4d2 Bug 1727319 - Part 2 - Remove intermediary variables in _theme.scss. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D125608
2021-09-16 21:50:29 +00:00
Harry Twyford
fb98c10513 Bug 1727319 - Assign set of colors from bug 1727317 to the existing new tab CSS variables. r=Mardak
While this is mainly a refactoring patch, a few visible effects are expected:
- Proton Primary teal is now used correctly in dark mode. I confirmed with UX that we want this.
- Various minor elements now may use slightly different colors than before. Things like hover states and borders are now functions of the main colors on the page rather than their own hardcoded colors. While one might be able to spot differences in a side-by-side comparison, the general idea is to capture the same "feeling".

Differential Revision: https://phabricator.services.mozilla.com/D125607
2021-09-16 21:50:29 +00:00
Harry Twyford
2c68cf2971 Bug 1727317 - Define set of color variables to use in newtab. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D125606
2021-09-16 21:50:29 +00:00
Scott
79862bace3 Bug 1717682 - Pref and implementation for compact 4 card row layout for Pocket newtab. r=fluent-reviewers,gvn,flod
Differential Revision: https://phabricator.services.mozilla.com/D125307
2021-09-15 23:47:41 +00:00
Harry Twyford
9ffc6060d1 Bug 1730560 - Fix newtab customize checkbox color. r=Mardak
This patch also renames --customize-menu-primary-action-text to --customize-menu-slider-fill, since that's the only place its used.

Differential Revision: https://phabricator.services.mozilla.com/D125461
2021-09-13 21:24:37 +00:00
Harry Twyford
75f4dc3868 Bug 1727321 - Part 4 - Stop using color variables elsewhere in newtab. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D124401
2021-09-08 22:06:27 +00:00
Harry Twyford
1cbd7abe67 Bug 1727321 - Part 3 - Stop using color variables in box-shadows. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D124399
2021-09-08 22:06:27 +00:00
Harry Twyford
a327978c95 Bug 1727321 - Part 2 - Stop using color variables in buttons. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D124398
2021-09-08 22:06:26 +00:00
Harry Twyford
913233dfed Bug 1727321 - Part 1 - Stop using color variables in links. r=thecount
The purpose of this stack of patches is to stop using color variables directly in newtab CSS in favour of the semantic variables defined in _theme.scss. That way, we can later refactor _theme.scss to use theme variables instead of hardcoded colors.

There's a lot of dead CSS/components in new tab. This stack of patches refactors dead code as well, mostly because it's not clear what is dead and what is not. I tried to keep things generally looking the same on visible surfaces, but there are some minor style differences in dead components and in asrouter devtools. I spoke to Mardak on Slack and he confirmed it would be okay to slightly change the look of dead components. Scott, I tagged you for review since you know what is dead and what is not.

Differential Revision: https://phabricator.services.mozilla.com/D124397
2021-09-08 22:06:26 +00:00
Harry Twyford
ff0ec1287a Bug 1726432 - Part 4 - Remove unused variables. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D123387
2021-09-08 22:06:26 +00:00
Harry Twyford
b421d1a2ae Bug 1726432 - Part 3 - Consolidate variables with their '-nte' equivalents. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D123386
2021-09-08 22:06:25 +00:00
Harry Twyford
edebf41522 Bug 1726432 - Part 2 - Consolidate newtab-background-secondary variable. r=amy
This is the variable we will eventually replace with ntp_secondary or equivalent.

Differential Revision: https://phabricator.services.mozilla.com/D123385
2021-09-08 22:06:25 +00:00
Harry Twyford
89b1a551a1 Bug 1726432 - Part 1 - Remove newtab-experience class. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D123384
2021-09-08 22:06:24 +00:00
Harry Twyford
48fbf1d8f5 Bug 1710937 - Part 6 - Remove code related to showing fallback screenshots in Top Sites. r=amy
I confirmed with Julian Gaibler that we don't want to show screenshots as fallbacks in Top Sites. We still want to support custom icons and screenshots in the "Recent activity" section, both of which are unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D123253
2021-09-08 22:06:24 +00:00
Harry Twyford
caf54ef43c Bug 1710937 - Part 4 - Remove SectionMenus and section header icons. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D123251
2021-09-08 22:06:23 +00:00
Harry Twyford
b62fce7b38 Bug 1710937 - Part 1 - Remove newNewTabExperienceEnabled pref and associated code. r=amy,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D123248
2021-09-08 22:06:22 +00:00
Scott
5156ff3a3b Bug 1722739 - Newtab Pocket privacy link hover underline fix r=amy
Differential Revision: https://phabricator.services.mozilla.com/D121124
2021-07-29 19:04:17 +00:00
amy churchwell
dc203ba0ea Bug 1719727 - Change "Personalize" on New Tab to gear icon. r=prathiksha,fluent-reviewers,Gijs,thecount
Differential Revision: https://phabricator.services.mozilla.com/D119657
2021-07-15 19:36:50 +00:00
Sam Foster
8548ab2296 Bug 1700124 - de-duplicate add (+) icons r=thecount,harry,desktop-theme-reviewers
* Rename toolkit's add.svg to plus.svg, use it for the zoom-in buttons and about:newtab's add icon

Differential Revision: https://phabricator.services.mozilla.com/D118627
2021-07-08 18:52:40 +00:00
Sam Foster
ddf71985d6 Bug 1708502 - De-dupe about:newtab icons. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D118863
2021-07-07 17:08:28 +00:00
Scott
77aeb945fd Bug 1719352 - Some newtab css changes to generated css files. r=emcminn,amy
Differential Revision: https://phabricator.services.mozilla.com/D119228
2021-07-06 23:38:42 +00:00
Butkovits Atila
f98b22464a Backed out changeset 2e42adcd4838 (bug 1719352) for causing failures on browser_parsable_css.js. CLOSED TREE 2021-07-07 01:33:57 +03:00
Scott
d6dc09aba4 Bug 1719352 - Some newtab css changes to generated css files. r=amy,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D119228
2021-07-06 21:10:43 +00:00
Sam Foster
d1ed3d9417 Bug 1699586 - De-duplicate default up arrow icons, rename as arrow-up.svg r=harry,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117577
2021-06-25 00:03:22 +00:00
Sam Foster
d3fd7ac161 Bug 1699586 - De-duplicate default down arrow icons, rename as arrow-down.svg. r=harry,desktop-theme-reviewers,Itiel,extension-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D117576
2021-06-25 00:03:21 +00:00
Sam Foster
3919d43c5c Bug 1699586 - De-duplicate small right arrow icons, rename as arrow-right-12.svg r=harry,desktop-theme-reviewers,thecount,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117575
2021-06-25 00:03:21 +00:00
Sam Foster
0d288d54bf Bug 1699586 - De-duplicate small left arrow icons, rename as arrow-left-12.svg. r=harry,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117574
2021-06-25 00:03:21 +00:00
Sam Foster
efe71d1203 Bug 1699586 - De-duplicate small down arrow icons, rename as arrow-down-12.svg. r=harry,preferences-reviewers,desktop-theme-reviewers,thecount,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117571
2021-06-25 00:03:20 +00:00
Dorel Luca
6df8d65dc2 Backed out 6 changesets (bug 1699586) for Browser-chrome failures in browser/base/content/test/performance/browser_startup_images.js. CLOSED TREE
Backed out changeset 8d42246a3ee8 (bug 1699586)
Backed out changeset e492a3c410b1 (bug 1699586)
Backed out changeset 621c35b393a2 (bug 1699586)
Backed out changeset 91f70d7ff2b1 (bug 1699586)
Backed out changeset 25a77358d2bc (bug 1699586)
Backed out changeset 1d3c1fe20fe9 (bug 1699586)
2021-06-24 02:03:18 +03:00
Sam Foster
16cf4d685b Bug 1699586 - De-duplicate default up arrow icons, rename as arrow-up.svg r=harry,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117577
2021-06-23 18:49:43 +00:00
Sam Foster
04400d2227 Bug 1699586 - De-duplicate default down arrow icons, rename as arrow-down.svg. r=harry,desktop-theme-reviewers,Itiel,extension-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D117576
2021-06-23 18:49:42 +00:00
Sam Foster
fb30f9c4cb Bug 1699586 - De-duplicate small right arrow icons, rename as arrow-right-12.svg r=harry,desktop-theme-reviewers,thecount,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117575
2021-06-23 18:49:42 +00:00
Sam Foster
8e25760022 Bug 1699586 - De-duplicate small left arrow icons, rename as arrow-left-12.svg. r=harry,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117574
2021-06-23 18:49:41 +00:00
Sam Foster
c30a72bcf7 Bug 1699586 - De-duplicate small down arrow icons, rename as arrow-down-12.svg. r=harry,preferences-reviewers,desktop-theme-reviewers,thecount,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117571
2021-06-23 18:49:41 +00:00
Brindusan Cristian
8f94d76427 Backed out 6 changesets (bug 1699586) for causing bc failures in browser_ext_tabs_hide.js.
CLOSED TREE

Backed out changeset aeeaa1d05965 (bug 1699586)
Backed out changeset 2b0292c56e66 (bug 1699586)
Backed out changeset b23c2cdf6055 (bug 1699586)
Backed out changeset 4c4d46cb250d (bug 1699586)
Backed out changeset bd33ea428223 (bug 1699586)
Backed out changeset faedaeb2a10f (bug 1699586)
2021-06-23 03:12:24 +03:00
Sam Foster
ca56b936f2 Bug 1699586 - De-duplicate default up arrow icons, rename as arrow-up.svg r=harry,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117577
2021-06-22 22:32:34 +00:00
Sam Foster
2415391b24 Bug 1699586 - De-duplicate default down arrow icons, rename as arrow-down.svg. r=harry,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117576
2021-06-22 22:32:34 +00:00
Sam Foster
8bddc7b3a2 Bug 1699586 - De-duplicate small right arrow icons, rename as arrow-right-12.svg r=harry,desktop-theme-reviewers,thecount,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117575
2021-06-22 22:32:34 +00:00
Sam Foster
826ae560ca Bug 1699586 - De-duplicate small left arrow icons, rename as arrow-left-12.svg. r=harry,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117574
2021-06-22 22:32:33 +00:00
Sam Foster
cfe7f2a60c Bug 1699586 - De-duplicate small down arrow icons, rename as arrow-down-12.svg. r=harry,preferences-reviewers,desktop-theme-reviewers,thecount,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D117571
2021-06-22 22:32:33 +00:00
amy churchwell
48c4395f02 Bug 1712215, 1712221 - Update drop shadows. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D116048
2021-06-22 17:35:55 +00:00