corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1298 Commits

Author SHA1 Message Date
Emily McMinn
47d4b9ac59 Bug 1846342 - Add supplemental info_text to shopping sidebar template r=desktop-theme-reviewers,pdahiya,aminomancer,dao 
Differential Revision: https://phabricator.services.mozilla.com/D185074
 2023-08-08 15:07:44 +00:00
Shane Hughes
314cb7abca Bug 1846803 - Final adjustments to feature callout surveys. r=jprickett 
1. Allow messages to set `browser.newtab.feature-tour`
2. Prevent individual element transitions in feature callouts
3. Change how multi-select item actions are processed so that, when
   clicking the primary button, its action is performed _as well as_ the
   action of the selected item.
4. Remove some built-in styles that can be set by experiment recipe
5. Allow messages to override the tour pref for newtab and pdfjs

Differential Revision: https://phabricator.services.mozilla.com/D185201
 2023-08-02 22:40:58 +00:00
Emily McMinn
88ac7a8667 Bug 1846344 - Update headline to show part of text as bold r=fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D185087
 2023-08-02 20:02:20 +00:00
Jason Prickett
e22da7ce69 Bug 1846557 - Fix cta-link additional button styles for feature callout r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D185057
 2023-08-01 16:53:31 +00:00
Yoen Zhang
09ab9d0425 Bug 1845388 - Update Experimenter Link to Messaging surfaces used in source doc. r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184624
 2023-07-31 19:50:17 +00:00
Hanna Jones
24dbfb7665 Bug 1826829 - remove --in-content-link-color-* references from aboutwelcome CSS r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer 
I could be missing something here since I'm not super familiar with this code, but it seems like we pull in `in-content/common.css` in `aboutwelcome.html` so we should have access to the token values.

Depends on D182258

Differential Revision: https://phabricator.services.mozilla.com/D182259
 2023-07-31 15:54:51 +00:00
Jason Prickett
b8dea0fc38 Bug 1846108 - Add styles for feature callout survey confirmation screen r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184876
 2023-07-29 03:42:06 +00:00
hanna alemu
032131cd81 Bug 1838288 - Create Feature Callout layout to support smaller image r=omc-reviewers,aminomancer,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D184859
 2023-07-28 23:43:05 +00:00
Shane Hughes
0f4e587520 Bug 1845862 - Support primary buttons in Feature Callout. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D184788
 2023-07-28 20:51:17 +00:00
Punam Dahiya
398c181b1a Bug 1839764 - Create Opt-in Messaging Surface r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D183176
 2023-07-28 20:07:03 +00:00
Jason Prickett
f43226a1f2 Bug 1845421 - Add ability to disable primary button until multiselect option is selected r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184670
 2023-07-27 18:39:29 +00:00
Jason Prickett
fb566fae67 Bug 1844215 - Add styling for cta link and multiselect to feature callout for use in newtab survey r=aminomancer,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184400
 2023-07-27 07:52:18 +00:00
negin
50e8112aa6 Bug 1843098 - Hide secondary section on responsive mode through pref r=omc-reviewers,emcminn 
Solution covers repositioning embedded migration wizard on full-width resolution by about 40px and removing the secondary section for =<800px. Removing secondary section can also be implemented for other screens with new pref `"hide_secondary_section".`

Open to feedback on this solution, I simplified from the original solution (useEffect checking for screen size) as the use case for this is only for responsive mode so we're able to handle this in the css.

See [slack discussion](https://mozilla.slack.com/archives/C03QN51QE6N/p1689695895033649) on why we decided to hide the secondary section for responsive mode for the embedded migration wizard - for a quick summary there is not enough screen real estate and reducing the spacing between the checkboxes impacts accessibility.

{F5120728}

{F5120726}

{F5120795}

{F5120793}

Differential Revision: https://phabricator.services.mozilla.com/D184394
 2023-07-26 17:41:02 +00:00
Emily McMinn
eb39cc9a65 Bug 1840517 - Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D182128
 2023-07-24 18:59:03 +00:00
Jason Prickett
d444ae7d62 Bug 1844212 - Implement ability to hide steps indicator in about welcome r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184346
 2023-07-24 07:28:48 +00:00
Emily McMinn
6f4e6300be Bug 1796699 - Allow for a configurable alt-tag on the about:welcome/Spotlight logo element r=omc-reviewers,aminomancer 
Allows a localized alt tag to be added to the logo element (for ex. in Spotlights where the logo is replaced by an image.)

Implemented similarly to the alt-tag for the onboarding illustrations; localization requires a `string_id` with an associated `.aria-label` prop.

Differential Revision: https://phabricator.services.mozilla.com/D184139
 2023-07-20 20:10:11 +00:00
Yoen Zhang
bd6f90155a Bug 1831211 - Add more detailed documentation for FxMS templates, overall message structure r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178895
 2023-07-18 19:30:07 +00:00
Shane Hughes
dc77a4b351 Bug 1835950 - Make images in Spotlight modals load lazily. r=omc-reviewers,dmose 
Make the main Spotlight image always lazy load, and make other
Spotlight/about:welcome images lazy load if the configured src is an
http or https URL. This is to fix a bug where slow image loading due to
network issues could cause Spotlight modals to hang while blocking
interaction with the rest of the browser.

Differential Revision: https://phabricator.services.mozilla.com/D180483
 2023-07-18 00:52:33 +00:00
Nick Alexander
bd3b0949b0 Bug 1805514 - Part 1: Support launch_action in Windows native toast notifications. r=barret 
`launch_action` is both top-level (when the toast is clicked) and
per-action (when a button is clicked).

Differential Revision: https://phabricator.services.mozilla.com/D182312
 2023-07-15 02:34:05 +00:00
Narcis Beleuzu
b3557244ea Backed out changeset 949ab6d791cd (bug 1840517) for bc failure on browser_aboutwelcome_multistage_mr.js 2023-07-14 01:37:54 +03:00
Emily McMinn
c4e12e1095 Bug 1840517 - Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D182128
 2023-07-13 21:30:07 +00:00
Iulian Moraru
f191451a5a Backed out changeset 1ae88f81ac4a (bug 1840517) for causing newtab failures. CLOSED TREE 2023-07-12 23:56:57 +03:00
Emily McMinn
824a92e3ed Bug 1840517 - Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D182128
 2023-07-12 18:44:29 +00:00
Norisz Fay
59da20dd58 Bug 1842869 - Fix lint failure on MultiSelect.jsx, FeatureCalloutBroker.sys.mjs CLOSED TREE 2023-07-11 23:54:53 +03:00
Mark Banner
2eda629a6d Bug 1842869 - Simplify and fix newtab's ESLint configuration. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D183285
 2023-07-11 20:29:19 +00:00
Shane Hughes
a9e75d53ce Bug 1825069 - Refactor AboutWelcome MultiSelect component to support sentiment collection. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D182275
 2023-07-11 17:55:56 +00:00
Mike Conley
f2f2869242 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao 
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
 2023-07-10 18:31:19 +00:00
Cristina Horotan
90490ed96b Backed out 2 changesets (bug 1823489) for causing bc failures at browser_multistage_spotlight.js 
Backed out changeset 684648252672 (bug 1823489)
Backed out changeset 15437d29bacc (bug 1823489)
 2023-07-10 17:47:20 +03:00
Mike Conley
55bee439b7 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao 
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
 2023-07-10 13:34:04 +00:00
Stanca Serban
ecb95f5427 Backed out 2 changesets (bug 1823489) for causing multiple bc failures. 
Backed out changeset da128472125a (bug 1823489)
Backed out changeset dd5996a4e7d2 (bug 1823489)
 2023-07-08 21:11:49 +03:00
Mike Conley
3bccb141ec Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao 
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
 2023-07-08 16:18:01 +00:00
Cristina Horotan
326373b54e Backed out changeset c22d4f75d4fe (bug 1831211) for causing generate failure 2023-07-08 01:36:33 +03:00
Yoen Zhang
165b403e56 Bug 1831211 - Add more detailed documentation for FxMS templates, overall message structure r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178895
 2023-07-07 22:07:18 +00:00
Noemi Erli
043702d68b Backed out 2 changesets (bug 1823489) for causing failures in test_panel_list_min_width_from_anchor.html 
Backed out changeset abe4ae7a4c01 (bug 1823489)
Backed out changeset ccb73c7c777a (bug 1823489)
 2023-07-07 19:05:56 +03:00
Mike Conley
1d3fdc07d8 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao 
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
 2023-07-07 15:19:49 +00:00
scottdowne
8789495725 Bug 1840681 - Pocket newtab fallback to publisher if we don't have a source prop. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D182388
 2023-06-29 16:20:24 +00:00
negin
87e6259495 Bug 1834368 - Update styles for links in about:welcome/spotlight r=omc-reviewers,desktop-theme-reviewers,aminomancer,hanna_a 
Differential Revision: https://phabricator.services.mozilla.com/D179241
 2023-06-28 19:55:43 +00:00
negin
b882e48890 Bug 1837051 - Add Embedded Migration Wizard support for spotlight dialog r=omc-reviewers,pdahiya,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D180713
 2023-06-23 19:23:51 +00:00
Mike Conley
e8864ee16f Bug 1838926 - Add ASRouter targeting for whether or not the user has ever used the migration wizard to import passwords from a CSV file. r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D181287
 2023-06-23 14:14:26 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Emily McMinn
b7ca5d8e41 Bug 1838904 - Update split template to handle appstore buttons & qr code r=omc-reviewers,aminomancer,pdahiya 
Updating the template to allow for these two treatments for the 116 experiment:
https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-H1-2023?type=design&node-id=2337-52398&t=Y1N9vfuftoee2MJ3-4

Differential Revision: https://phabricator.services.mozilla.com/D181303
 2023-06-19 16:49:25 +00:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Iulian Moraru
7725c61610 Backed out changeset 11d0cb525f1d (bug 1835212) for causing bc failures on browser_feature_callout.js. CLOSED TREE 2023-06-13 00:34:23 +03:00
hanna alemu
6890b0f07f Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D179839
 2023-06-12 20:24:08 +00:00
negin
2640a6b2b8 Bug 1836083 - Fixes Embedded Migration Wizard import and Done button should render correct on shorter responsive layout r=desktop-theme-reviewers,dao,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D180336
 2023-06-12 16:41:53 +00:00
Cristina Horotan
00b07ba633 Backed out changeset a79a0225de72 (bug 1835212) for causing bc failures at browser_feature_callout.js on a CLOSED TREE 2023-06-09 01:31:13 +03:00
hanna alemu
bdfd7be5bc Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D179839
 2023-06-08 19:33:29 +00:00
Shane Hughes
075092d296 Bug 1832715 - Allow multistage spotlight OPEN_URL actions to include UTM params. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D177848
 2023-06-08 19:20:07 +00:00
Shane Hughes
99653f2ab9 Bug 1835028 - Change newtab stylelint problem severity from warning to error. r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179906
 2023-06-05 12:58:01 +00:00