Commit Graph

69 Commits

Author SHA1 Message Date
Shane Hughes
dc77a4b351 Bug 1835950 - Make images in Spotlight modals load lazily. r=omc-reviewers,dmose
Make the main Spotlight image always lazy load, and make other
Spotlight/about:welcome images lazy load if the configured src is an
http or https URL. This is to fix a bug where slow image loading due to
network issues could cause Spotlight modals to hang while blocking
interaction with the rest of the browser.

Differential Revision: https://phabricator.services.mozilla.com/D180483
2023-07-18 00:52:33 +00:00
Mike Conley
143026f39c Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod
Significant portions of this were written by Shane Hughes <shughes@mozilla.com> -
specifically the parts that move the Firefox Account sign-in flow for tabs into
a SpecialMessageAction, and making AboutWelcomeUtils.handleUserAction return
a Promise.

Differential Revision: https://phabricator.services.mozilla.com/D176453
2023-04-28 15:38:24 +00:00
Noemi Erli
b2042001fc Backed out 2 changesets (bug 1830178, bug 1829426) for causing failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE
Backed out changeset 917f6a2ef432 (bug 1830178)
Backed out changeset 47704fa0c047 (bug 1829426)
2023-04-28 08:19:22 +03:00
Mike Conley
a0043ccde6 Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod
Significant portions of this were written by Shane Hughes <shughes@mozilla.com> -
specifically the parts that move the Firefox Account sign-in flow for tabs into
a SpecialMessageAction, and making AboutWelcomeUtils.handleUserAction return
a Promise.

Differential Revision: https://phabricator.services.mozilla.com/D176453
2023-04-28 03:17:28 +00:00
Shane Hughes
ca232ede40 Bug 1813716 - Encapsulate aboutwelcome container and make its ID more unique. r=omc-reviewers,fxview-reviewers,sfoster,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D172493
2023-03-29 21:51:09 +00:00
Meg Viar
04e1d3b419 Bug 1806425 - Make value of source in Feature Callout and page in its telementry more consistent r=jprickett,aminomancer
Unify the values of "source" and "page" as used in FeatureCallout.sys.mjs:
- Explicitly pass in a value for "page" when instantiating a Feature Callout and use this for the value of "page" when sending Feature Callout telemetry and as the "source" when making calls to `sendTriggerMessage`. This avoids the risk of including non-about: page URLs or PDF file extensions in our telemetry.
- Set the value of "page" in an HTML data attribute that can be accessed for use in about:welcome telemetry for Spotlight and Feature Callouts.
- Update references to the page value previously used as the page/source for telemetry from `about:firefoxview` Feature Callouts from "firefoxview"  to "about:firefoxview"
- Pass the token "chrome" when creating a callout from the browser chrome and update references to the source in PDF.js messages' targeting
- Update the page value expected in automated tests as needed

Differential Revision: https://phabricator.services.mozilla.com/D165910
2023-01-20 16:53:30 +00:00
Shane Hughes
db26095c40 Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D163531
2022-12-01 16:42:18 +00:00
Emily McMinn
e8b3e6267b Bug 1781091 - Update RTAMO to match MR1 designs r=mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D161482
2022-11-17 17:13:35 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D161942
2022-11-13 21:02:41 +00:00
Shane Hughes
16d1998b3f Bug 1783070 - Use safe navigators for About Welcome window functions. r=mviar
Update About Welcome's invocations of window functions to use optional
chaining to avoid errors when they are undefined. Then, the surfaces
that load the About Welcome bundle will no longer need to define those
references as empty functions.

Differential Revision: https://phabricator.services.mozilla.com/D155011
2022-08-26 21:43:54 +00:00
Cristian Tuns
fcb7f84123 Backed out changeset ef1b76817c3b (bug 1783070) for causing node failures CLOSED TREE 2022-08-18 20:43:05 -04:00
Shane Hughes
f6c241fc50 Bug 1783070 - Use safe navigators for About Welcome window functions. r=mviar
Update About Welcome's invocations of window functions to use optional
chaining to avoid errors when they are undefined. Then, the surfaces
that load the About Welcome bundle will no longer need to define those
references as empty functions.

Differential Revision: https://phabricator.services.mozilla.com/D155011
2022-08-19 00:06:40 +00:00
Meg Viar
0ae81533c1 Bug 1779430 - For Feature Callout telemetry, set 'page' value to current page URL r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D152761
2022-07-27 17:01:02 +00:00
Meg Viar
3cfd9ed1aa Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143645
2022-04-27 15:12:41 +00:00
Norisz Fay
9250bc1d10 Backed out changeset 392ddb43da5b (bug 1764626) for causing bc failures on browser_multistage_spotlight_telemetry.js CLOSED TREE 2022-04-26 23:30:45 +03:00
Meg Viar
de6da2f0b5 Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143645
2022-04-26 19:11:27 +00:00
Meg Viar
19b16d1f64 Bug 1764070 - Differentiate between auto advance and user click when sending Spotlight/AboutWelcome event telemetry r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143767
2022-04-19 22:43:15 +00:00
Meg Viar
e3ec61e716 Bug 1762471 - For AboutWelcome screens, use screen index rather than setting screen order explicitly in the config r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142860
2022-04-11 14:53:38 +00:00
Dan Mosedale
0db7b287ce Bug 1762285 - Update about:welcome for Fx 100 Thank You, r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142736
2022-04-02 02:31:14 +00:00
Meg Viar
a818b7875f Bug 1741923 - Add/update template to show large photograph/background image r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D139064
2022-03-05 02:19:58 +00:00
Iulian Moraru
b63a919c5a Backed out changeset 1f27d80f3ad1 (bug 1741923) for causing multiple mochitest failures. CLOSED TREE 2022-03-05 03:59:31 +02:00
Meg Viar
deddf67e0c Bug 1741923 - Add/update template to show large photograph/background image r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D139064
2022-03-05 00:28:30 +00:00
Csoregi Natalia
eb26fa9098 Backed out changeset b9007c68e8ff (bug 1741923) for causing multiple failures e.g.browser_parsable_css.js. CLOSED TREE 2022-03-05 00:42:05 +02:00
Meg Viar
9aec3475b1 Bug 1741923 - Add/update template to show large photograph/background image r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D139064
2022-03-04 21:46:16 +00:00
Ed Lee
44942cfc9a Bug 1752935 - Reuse welcome bundle from Spotlight for multistage template r=pdahiya,andreio
Detect about:welcome template usage and move modal shadow styling to content. Remove 93-backwards-compatible logoImageURL and update schema. Only basic functionality for initial testing.

Differential Revision: https://phabricator.services.mozilla.com/D138866
2022-02-16 19:05:22 +00:00
Meg Viar
bccd410d4b Bug 1752936 - Allow setting more types of backdrops behind screens r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D138045
2022-02-15 15:03:03 +00:00
Meg Viar
396af297fc Bug 1752829 - Make decorative noodles and logo style configurable in AboutWelcome r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D137452
2022-02-14 21:39:59 +00:00
Cosmin Sabou
5a63cfb671 Backed out changeset c75cbdfcdde8 (bug 1752829) for causing bcc failures on browser_aboutwelcome_rtamo.js. 2022-02-13 19:14:25 +02:00
Meg Viar
0b723cf950 Bug 1752829 - Make decorative noodles and logo style configurable in AboutWelcome r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D137452
2022-02-13 16:18:19 +00:00
Emily McMinn
5e3abb1aac Bug 1726426 - Update the RTAMO page to render through MultistageAboutWelcome and match Proton style r=pdahiya,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D133679
2022-01-13 17:05:02 +00:00
Punam Dahiya
19d97ff4a9 Bug 1720758 - Remove browser.aboutwelcome.protonDesign pref and pre-MR1 multistage onboarding r=Mardak
Cleanup pre-MR1 new user onboarding experience  by
 - removing browser.aboutwelcome.protonDesign pref
 - removing pre-MR1 multistage screen
 - removing pre-MR1 AboutWelcomeDefault content
 - fix respective tests

Differential Revision: https://phabricator.services.mozilla.com/D120038
2021-07-22 16:57:32 +00:00
Csoregi Natalia
26e41dfbdb Backed out changeset c2cb820e5a69 (bug 1720758) for causing failures on browser_aboutwelcome_multistage_default.js. CLOSED TREE 2021-07-22 10:03:54 +03:00
Punam Dahiya
d83c14f45e Bug 1720758 - Remove browser.aboutwelcome.protonDesign pref and pre-MR1 multistage onboarding r=Mardak
Cleanup pre-MR1 new user onboarding experience  by
 - removing browser.aboutwelcome.protonDesign pref
 - removing pre-MR1 multistage screen
 - removing pre-MR1 AboutWelcomeDefault content
 - fix respective tests

Differential Revision: https://phabricator.services.mozilla.com/D120038
2021-07-22 05:18:06 +00:00
Andrei Oprea
db4652a3f6 Bug 1694257 - Add ability for targeted defaults for AboutWelcome r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D106418
2021-03-16 17:49:41 +00:00
emcminn
3ca2a35e0a Bug 1689304 - Update theme screen CTA string r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D106822
2021-03-03 18:02:55 +00:00
emcminn
70833f08e4 Bug 1691145 - Make Set Default first page of default onboarding r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D104880
2021-02-17 21:17:52 +00:00
Brindusan Cristian
6157be4778 Backed out changeset cbcab4d7cb3e (bug 1691145) for bc failures in browser_aboutwelcome_multistage.js. CLOSED TREE 2021-02-17 22:08:11 +02:00
emcminn
3b3ede3416 Bug 1691145 - Make Set Default first page of default onboarding r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D104880
2021-02-17 19:29:57 +00:00
emcminn
60cb332de2 Bug 1678728 - Add helptext component to replace 'disclaimer' in about:welcome template r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D98678
2020-12-17 21:15:26 +00:00
emcminn
2a500f9899 Bug 1668429 - New RTAMO UI r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D93668
2020-10-16 19:03:48 +00:00
Punam Dahiya
f385b7bea7 Bug 1659169 - RTAMO custom onboarding r=fluent-reviewers,Mardak,flod
Differential Revision: https://phabricator.services.mozilla.com/D91667
2020-10-09 02:57:40 +00:00
emcminn
6b01123779 Bug 1657618 - Add site titles under "import sites" tiles r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D86602
2020-09-16 17:54:21 +00:00
emcminn
a730fb228b Bug 1661744 - Remove hover state from topsites tiles on the import screen of about:welcome r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D88631
2020-09-02 00:30:18 +00:00
emcminn
34bfb7f337 Bug 1660259 - Correct nav aria-label, & label and description for theme buttons; improve button contrast. r=Jamie,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D87802
2020-08-27 14:21:04 +00:00
Dan Mosedale
f14a9fad10 Bug 1643776 - Add Alpenglow theme, r=dmose,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D86058
2020-08-21 17:20:07 +00:00
Razvan Maries
3748d2b321 Backed out changeset 2f4bf8bab6cf (bug 1643776) for causing bug 1660323. CLOSED TREE 2020-08-21 04:34:24 +03:00
Dan Mosedale
fc5fca3570 Bug 1643776 - Add Alpenglow theme, r=dmose,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D86058
2020-08-21 00:43:03 +00:00
Razvan Maries
c6be7eea6f Backed out changeset 2a1fa73b1a63 (bug 1643776) for perma failures on browser_all_files_referenced.js. CLOSED TREE 2020-08-21 01:02:18 +03:00
Dan Mosedale
2c6910f146 Bug 1643776 - Add Alpenglow theme r=dmose,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D86058
2020-08-20 21:04:57 +00:00
Razvan Maries
1ba54818c3 Backed out changeset 6ffb6196daf7 (bug 1643776) for perma failures on browser_all_files_referenced.js. CLOSED TREE 2020-08-20 22:26:31 +03:00