Commit Graph

70 Commits

Author SHA1 Message Date
Mark Banner
5151ae0708 Bug 1824591 - Convert toolkit/components/promiseworker to ES modules. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D179202
2023-05-28 07:58:37 +00:00
Mike Conley
f82c3815b6 Bug 1824094 - Don't read from the about:home startup cache if the last session will be recovered. r=Gijs
We were choosing not to read from the cache if the user has configured the browser
to restore the last session, but there's also the case where the last session might
be restored regardless - for example, to recover from a parent-process crash, after
an update applies, or if using the browser restart shortcut for developers. If any
foreground tab in that restored session loaded about:newtab, that'd result in the
about:newtab (and about:home) dynamic state being generated and being more up-to-date
than the cache.

The next time that about:home loaded (for example, when opening a new window), the
cache would be out of date and potentially conflict with what was in the state object
that came down from the parent.

This patch makes it so that if about:newtab is loaded before the about:home cache
gets to be used, then the cache is disqualified from use for that startup.

Differential Revision: https://phabricator.services.mozilla.com/D173782
2023-04-03 15:21:23 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D172850
2023-03-30 20:51:58 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
f399fc3c21 Bug 1780074 - Migrate browser/components/newtab to ESM. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D152113
2022-07-20 10:36:52 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Barret Rennie
8e45c83906 Bug 1776475 - Stop using NimbusFeature.isEnabled for abouthomecache r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150688
2022-07-10 15:15:18 +00:00
Barret Rennie
d6c5f2aa39 Bug 1776471 - Stop using NimbusFeature.isEnabled for aboutwelcome r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D150685
2022-07-09 16:19:46 +00:00
Tooru Fujisawa
ff679ae78e Bug 1772100 - Part 10: Use plain object for lazy getter in browser/components/newtab/. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D148020
2022-06-06 22:46:23 +00:00
Kate Hudson
8b01a6e8b3 Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-13 14:35:15 +00:00
Alexandru Michis
3545735fad Backed out changeset 92b9d5110599 (bug 1728843) for causing bc failures in browser_urlbar_telemetry_quicksuggest.js
CLOSED TREE
2021-09-09 04:23:16 +03:00
Kate Hudson
b2443171ec Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
Depends on D123763

Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-09 00:20:56 +00:00
Marian-Vasile Laza
05790a73b8 Backed out changeset 47b9c109e74c (bug 1728843) for causing bc failures on browser_urlbar_telemetry_quicksuggest.js. CLOSED TREE 2021-09-07 18:45:09 +03:00
Kate Hudson
baec809c24 Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
Depends on D123763

Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-07 13:49:51 +00:00
Andrei Oprea
292d8d2133 Bug 1723758 - Ensure all Nimbus features explicitly call method to send exposure r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D123422
2021-09-03 13:04:51 +00:00
Kate Hudson
43cfa21ed4 Bug 1714595 - Allow about:home startup cache to be toggled via Nimbus. r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D116853
2021-06-14 14:48:00 +00:00
Andrei Oprea
5fd4c4ba70 Bug 1699701 - Convert all usages of ExperimentFeature to singleton API r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D110284
2021-04-09 14:13:13 +00:00
Sebastian Hengst
cba2b35987 Backed out changeset d402c8657d3f (bug 1699701) for failing newtab's activity-stream:AboutPreferences Feed and more. CLOSED TREE 2021-04-09 15:35:48 +02:00
Andrei Oprea
ebb65f340a Bug 1699701 - Convert all usages of ExperimentFeature to singleton API r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D110284
2021-04-09 12:49:00 +00:00
Andrei Oprea
868d7139b1 Bug 1698556 - Exposure event is not sent when opening about:welcome r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D108480
2021-03-16 17:07:33 +00:00
Kate Hudson
93df0e828b Bug 1692230 - Move nimbus code to its own directory r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D105567
2021-02-20 02:51:12 +00:00
Kate Hudson
17c048556f Bug 1672202 - Add Feature API with default values r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D104056
2021-02-06 01:24:06 +00:00
Mihai Alexandru Michis
c9b07638fb Backed out changeset 110829513605 (bug 1672202) for causing bc failures in browser_autocomplete_import.js
CLOSED TREE
2021-02-06 01:00:32 +02:00
Kate Hudson
e203806f0d Bug 1672202 - Add Feature API with default values r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D104056
2021-02-05 21:00:32 +00:00
Mike Conley
a8fd698aaf Bug 1673716 - Ensure the about:home startup cache can only be used by one BrowsingContext. r=Gijs
It is theoretically possible for two BrowsingContexts to be loading about:home
at the same time during startup (for example, if the user passed in a series
of URLs to open via the command-line, including multiple about:home's).

This patch ensures that only one of those BrowsingContexts (the first to load)
gets to consume the cached streams.

Differential Revision: https://phabricator.services.mozilla.com/D97518
2020-11-20 16:27:29 +00:00
Mike Conley
84f955187a Bug 1647757 - Terminate the about:home startup cache worker when experiencing memory-pressure. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D94391
2020-10-21 22:44:50 +00:00
emcminn
2c621724d5 Bug 1659152 - Use ExperimentAPI to check enabled property of experiment branches r=k88hudson,andreio
Differential Revision: https://phabricator.services.mozilla.com/D89973
2020-09-17 17:41:51 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Mike Conley
c1fe2bff2b Bug 1622263 - Add Telemetry for about:home startup cache. r=Gijs,data-review=mmccorquodale
Differential Revision: https://phabricator.services.mozilla.com/D81189
2020-07-03 19:28:56 +00:00
Narcis Beleuzu
cc2be3eebb Backed out 2 changesets (bug 1622263) for bc failures on browser_locale_change.js . CLOSED TREE
Backed out changeset ebcad04b8151 (bug 1622263)
Backed out changeset e8290c6bfdaa (bug 1622263)
2020-07-03 03:36:48 +03:00
Mike Conley
1cdb3ea4af Bug 1622263 - Add Telemetry for about:home startup cache. r=Gijs,data-review=mmccorquodale
Differential Revision: https://phabricator.services.mozilla.com/D81189
2020-07-02 22:46:30 +00:00
Mike Conley
35dccff44e Bug 1622088 - Part 2: Add some mochitest-browser tests for the about:home startup cache. r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D71793
2020-06-16 17:18:14 +00:00
Dorel Luca
ea03151a5a Backed out 3 changesets (bug 1622088) for XPCshell and Browser-chrome failurs on browser/abouthomecache/browser_process_crash.js. CLOSED TREE
Backed out changeset 238fa307504a (bug 1622088)
Backed out changeset ceaa7857baea (bug 1622088)
Backed out changeset 9c75ae56f50e (bug 1622088)
2020-06-08 20:17:42 +03:00
Mike Conley
40c426a4d7 Bug 1622088 - Part 2: Add some mochitest-browser tests for the about:home startup cache. r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D71793
2020-06-08 15:56:25 +00:00
Csoregi Natalia
6a40275777 Backed out 3 changesets (bug 1622088) for sanitizer failures on RootingAPI.h. CLOSED TREE
Backed out changeset 43477ef52982 (bug 1622088)
Backed out changeset 35c3d2b322fa (bug 1622088)
Backed out changeset 77f71cbc61ec (bug 1622088)
2020-05-06 01:32:41 +03:00
Mike Conley
c6df08ee4c Bug 1622088 - Part 2: Add some mochitest-browser tests for the about:home startup cache. r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D71793
2020-05-05 21:03:39 +00:00
Mike Conley
13b01448c4 Bug 1631595 - Make it possible to write to the AboutHomeStartupCache periodically and on shutdown. r=Gijs
This also re-orients the cache a little bit so that cache writing is
initialized in the parent process rather than the content process.

Differential Revision: https://phabricator.services.mozilla.com/D71669
2020-04-29 16:00:40 +00:00
Mike Conley
bc68cf7c0b Bug 1631611 - Use a JSWindowActorChild to load about:newtab scripts from the ScriptPreloader rather than an observer. r=pdahiya
This shifts the responsibility for ensuring that an about:home, about:welcome
or about:newtab page is where we inject the scripts to the JSWindowActor system,
rather than using the observer service on document creation and checking the
URL.

Differential Revision: https://phabricator.services.mozilla.com/D71773
2020-04-22 21:33:12 +00:00
Mike Conley
5853171528 Bug 1614502 - Add a mechanism that can generate an about:home document for a startup cache. r=Gijs,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D68094
2020-04-17 15:31:39 +00:00
Mike Conley
6b21d37b1a Bug 1614502 - Expose utility functions for rendering Activity Stream. r=Mardak
These will be used by a later patch inside of a ChromeWorker using
ReactDOMServer.

Differential Revision: https://phabricator.services.mozilla.com/D68093
2020-04-17 15:31:11 +00:00
Mike Conley
a551ab5356 Bug 1621032 - Add a mechanism for reading a static about:home from the HTTP cache at startup. r=Gijs,k88hudson
This mechanism is preffed off for now.

Differential Revision: https://phabricator.services.mozilla.com/D66079
2020-04-07 18:54:32 +00:00
Mike Conley
6bb04a8198 Bug 1625997 - Remove unnecessary unload event listener from AboutNewTabChildService. r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D68826
2020-04-02 13:53:08 +00:00
Mike Conley
527cf6e02a Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 03:10:29 +00:00
Dorel Luca
e6edb45133 Backed out changeset 9160f18bc24e (bug 1619992) for XPCshell failures in newtab/test/xpcshell/test_AboutNewTab.js 2020-03-11 04:20:31 +02:00
Mike Conley
f431383314 Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 01:25:31 +00:00
Mike Conley
65f0c27c0e Bug 1617983 - Re-enable separate privileged about content process for about:home, about:newtab, about:welcome on Nightly. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D64376
2020-03-09 18:37:58 +00:00