Commit Graph

405 Commits

Author SHA1 Message Date
Sandor Molnar
2899c1f4da Backed out changeset b463b9cd8aef (bug 1846036) for causing failures in toolkit/components/passwordmgr/test/mochitest/test_prompt.html CLOSED TREE 2023-08-05 02:15:47 +03:00
Neil Deakin
5e36a94898 Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin

Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-04 18:36:03 +00:00
Mark Banner
544ecba3af Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Mark Banner
40de601f11 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Marco Bonardo
ac9c47ede2 Bug 1826946 - Delay frecency calculation for history batch inserts. r=daisuke
When inserting multiple URIs in history, it makes sense to delay expensive
frecency calculations to a later time. We only set recalc_frecency and the
PlacesFrecencyRecalculator will take care of it.
We keep immediately calculating frecency only when a single url is inserted,
that is the case when the user is normally browsing the Web.

Differential Revision: https://phabricator.services.mozilla.com/D179263
2023-06-05 16:13:57 +00:00
Rob Wu
f0c7c874d6 Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckoview-reviewers,Standard8,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D179890
2023-06-05 10:23:40 +00:00
Rob Wu
bad812f243 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Mark Banner
232facd440 Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
2023-06-02 20:00:35 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Marco Bonardo
ddbafa4329 Bug 1834989 - Clean up UrlbarTestUtils use. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D179056
2023-05-26 14:56:55 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
Natalia Csoregi
1b67d0b941 Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
2023-05-24 04:29:45 +03:00
Mark Banner
d1fc869252 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 19:09:29 +00:00
Noemi Erli
1f146f097e Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
2023-05-23 12:14:37 +03:00
Mark Banner
08ff6c0ad9 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 08:13:08 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Johannes J. Schmidt
0679b59e81 Bug 1824112 - switch to addLoginAsync in tests r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D175704
2023-05-10 13:52:10 +00:00
Sandor Molnar
84627283e9 Backed out 16 changesets (bug 1824112) for causing mochitest failures in toolkit/components/passwordmgr/test/mochitest/test_autocomplete_tab_between_fields.html CLOSED TREE
Backed out changeset 6830c9a5d1ce (bug 1824112)
Backed out changeset ebfc28fdb638 (bug 1824112)
Backed out changeset ae112f47fdf1 (bug 1824112)
Backed out changeset 7295fad178a2 (bug 1824112)
Backed out changeset 3074e99ee5a0 (bug 1824112)
Backed out changeset a821ff170e11 (bug 1824112)
Backed out changeset 7bfa8564a6b5 (bug 1824112)
Backed out changeset ce59496fc86f (bug 1824112)
Backed out changeset e3f3d730e9fa (bug 1824112)
Backed out changeset b2f3bcc9bf07 (bug 1824112)
Backed out changeset 03447a1935df (bug 1824112)
Backed out changeset fc82a197b868 (bug 1824112)
Backed out changeset 406121a380d9 (bug 1824112)
Backed out changeset 196bb8eb2cc0 (bug 1824112)
Backed out changeset 0948d06a3c2c (bug 1824112)
Backed out changeset bc994ffb1614 (bug 1824112)
2023-05-10 12:07:00 +03:00
Johannes J. Schmidt
364acf3f03 Bug 1824112 - switch to addLoginAsync in tests r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D175704
2023-05-10 07:47:25 +00:00
Noemi Erli
81fb845a46 Backed out 14 changesets (bug 1824112) for causing mochitest failures in test_autocomplete_password_generation.html CLOSED TREE
Backed out changeset baf6c4c08d47 (bug 1824112)
Backed out changeset 999f8503465f (bug 1824112)
Backed out changeset 4830f780be1e (bug 1824112)
Backed out changeset 73b00f93c2e2 (bug 1824112)
Backed out changeset a53067121b90 (bug 1824112)
Backed out changeset f5d52901dfec (bug 1824112)
Backed out changeset 8b31247f3c94 (bug 1824112)
Backed out changeset 990365a7418d (bug 1824112)
Backed out changeset c3be4f0b5337 (bug 1824112)
Backed out changeset f23b0ce08de1 (bug 1824112)
Backed out changeset 526d53b4a35f (bug 1824112)
Backed out changeset b8010f604733 (bug 1824112)
Backed out changeset 602e53d29d80 (bug 1824112)
Backed out changeset 50e0b57bd30d (bug 1824112)
2023-05-08 10:45:21 +03:00
Johannes J. Schmidt
c2ea52d5bd Bug 1824112 - switch to addLoginAsync in tests r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D175704
2023-05-08 06:51:46 +00:00
Narcis Beleuzu
81813a40f3 Backed out 12 changesets (bug 1824112) for mochitest failures on test_autocomplete_autofill_related_realms_no_dupes.html . CLOSED TREE
Backed out changeset 1b884731cc88 (bug 1824112)
Backed out changeset a5c59331e797 (bug 1824112)
Backed out changeset fec2998bed4f (bug 1824112)
Backed out changeset 3b86742b481e (bug 1824112)
Backed out changeset fdf4845c5a44 (bug 1824112)
Backed out changeset 378d2832774b (bug 1824112)
Backed out changeset f24f6a88b9a0 (bug 1824112)
Backed out changeset dd3b06a85ac8 (bug 1824112)
Backed out changeset e19d6f69fd8a (bug 1824112)
Backed out changeset e96c54b21c45 (bug 1824112)
Backed out changeset b51f68d02f4c (bug 1824112)
Backed out changeset 30aa8323efcd (bug 1824112)
2023-05-02 15:02:59 +03:00
Johannes J. Schmidt
2dccf786ac Bug 1824112 - switch to addLoginAsync in tests r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D175704
2023-05-02 09:22:07 +00:00
Sandor Molnar
8ba3c187c7 Backed out 3 changesets (bug 1824112) for causing failures related in toolkit/components/passwordmgr/<...> CLOSED TREE
Backed out changeset 54334826f02e (bug 1824112)
Backed out changeset 01a71441e86a (bug 1824112)
Backed out changeset 1d21bc78852c (bug 1824112)
2023-04-24 12:20:18 +03:00
Johannes J. Schmidt
da31c33064 Bug 1824112 - switch to addLoginAsync in tests r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D175704
2023-04-24 07:52:22 +00:00
Mathew Hodson
c060b32e7d Bug 1824906 - Update consumers to use normandy ESM. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D175026
2023-04-16 18:01:55 +00:00
Tooru Fujisawa
18d749f6ff Bug 1821308 - Part 2: Convert ctypes.jsm consumers to use ESM. r=Standard8,geckoview-reviewers,application-update-reviewers,credential-management-reviewers,sgalich,bytesized,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D173811
2023-04-11 01:25:15 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D172850
2023-03-30 20:51:58 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
2023-03-29 07:34:10 +00:00
Mark Banner
9f14e3dc03 Bug 1816934 - Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D169934
2023-02-17 19:32:06 +00:00
Cristian Tuns
b9ee007450 Backed out 6 changesets (bug 1816934, bug 1817182, bug 1817179, bug 1817183) for causing dt failures in browser_jsterm_autocomplete_null.js CLOSED TREE
Backed out changeset 17d4c013ed92 (bug 1817183)
Backed out changeset cfed8d9c23f3 (bug 1817183)
Backed out changeset 62fe2f589efe (bug 1817182)
Backed out changeset 557bd773fb85 (bug 1817179)
Backed out changeset 7f8a7865868b (bug 1816934)
Backed out changeset d6c1d4c0d2a0 (bug 1816934)
2023-02-17 10:51:33 -05:00
Mark Banner
60c0009ad6 Bug 1816934 - Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D169934
2023-02-17 09:01:43 +00:00
Dão Gottwald
b480cfa156 Bug 1810647 - Prepare for enable urlbar result menu in Nightly. r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D167004
2023-01-23 15:54:53 +00:00
Mark Banner
df47c60747 Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D165002
2022-12-23 12:37:07 +00:00
Mark Banner
11b4005c4f Bug 1791974 - Use setAsDefault* parameters where appropriate for consumers of SearchTestUtils.installSearchExtension. r=mcheang
Differential Revision: https://phabricator.services.mozilla.com/D161045
2022-11-18 14:30:27 +00:00
Mark Banner
70830f8413 Bug 1799314 - Convert consumers of testing modules to import ES modules direct (extensions). r=extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D161905
2022-11-17 12:00:27 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
William Durand
b31856e2ae Bug 1797050 - Part 8 - Add test coverage for the deprecated manifest.json key "applications". r=rpl
Depends on D160248

Differential Revision: https://phabricator.services.mozilla.com/D160726
2022-11-04 19:09:02 +00:00
William Durand
12a393c465 Bug 1797050 - Part 6 - Use browser_specific_settings instead of applications in test manifests. r=rpl,perftest-reviewers,sparky
We want to encourage extension developers to use `browser_specific_settings` instead of `applications`, which will be unsupported in Manifest Version 3+. This patch makes sure test manifests in m-c won't cause any issues in the future.

Depends on D160541

Differential Revision: https://phabricator.services.mozilla.com/D160668
2022-11-03 16:23:03 +00:00
William Durand
78829ab8e2 Bug 1797050 - Part 3 - Use browser_specific_settings instead of applications in existing WebExt tests. r=rpl,geckoview-reviewers,extension-reviewers,owlish
We want to encourage extension developers to use `browser_specific_settings` instead of `applications`,
which will be unsupported in Manifest Version 3+. This patch prepares the introduction of a new warning
(that is usually converted into an error in the test environment).

Differential Revision: https://phabricator.services.mozilla.com/D160059
2022-10-28 09:53:09 +00:00
William Durand
7382b32c34 Bug 1795285 - Remove skip-if = condprof on test_ext_manifest.js. r=robwu
That was introduced in Bug 1793925 to workaround a pre-existing issue.

Differential Revision: https://phabricator.services.mozilla.com/D159663
2022-10-19 13:10:12 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
William Durand
d8658dc7dd Bug 1793925 - Warn about complex versioning formats used in manifest. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D158834
2022-10-18 08:06:08 +00:00
Butkovits Atila
b4f413e615 Backed out changeset 6f112c0942b0 (bug 1793925) for causing build bustages. CLOSED TREE 2022-10-17 16:04:08 +03:00